Partial revert of android_webview: stop using system ICU. (patchset #1 id:1 of https://codereview.chromium.org/541753002/)
Reason for revert:
We can't accept this size increase at present; revert until we've worked out what to do about it.
Original issue's description:
> android_webview: stop using system ICU.
>
> To support unbundled updates we need to stop depending on system
> libraries. Disable using the system version of ICU and instead link
> Chromium's copy.
>
> This increases binary size by ~7MB.
>
> BUG=409851
>
> Committed: https://crrev.com/48e43572c0bfef2b1434d7f330da86cc7770b592
> Cr-Commit-Position: refs/heads/master@{#293510}
BUG=409851
Review URL: https://codereview.chromium.org/570383002
Cr-Original-Commit-Position: refs/heads/master@{#295083}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96256bfea5c496aa70b1913555b1e1c7f166c426
Also update the name of the asan dynamic runtime thunk .lib since it was changed in LLVM r217673.
After this change, component ASan build should be able to report NULL derefs and other AVs the same way as the static build does.
BUG=345874
Review URL: https://codereview.chromium.org/573743002
Cr-Original-Commit-Position: refs/heads/master@{#294857}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1d8adb2349f07f2595319f4ef7389001d3e9fd8f
This is a reland of dd7edfa67 which was reverted in 80a9a88f4c for build
failures. It also includes a BoringSSL roll and build changes to avoid adding a
static initializer.
This is a much much larger change than the diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=338885
TBR=brettw
Review URL: https://codereview.chromium.org/568643003
Cr-Original-Commit-Position: refs/heads/master@{#294589}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71c13e6ac01d5cdc49ca40e8e9301d5142d85018
- Don't remove -fno-ident from gyp build (was added about 3y ago, seemingly unnecessary for current clang)
- Add -fno-slp-vectorize to GN to make builds match (both to be removed after next clang roll)
- Make usage of -Wno-reserved-user-defined-literal match (required for dbus pre-trusty)
- Add -march=x86-64 to gn cflags
- Default symbol_level based on is_debug, and turn it off by default in Release (same as gyp)
Also, fiddle with output of gyp_flag_compare.py.
R=brettw@chromium.org
BUG=335824
Review URL: https://codereview.chromium.org/562383002
Cr-Original-Commit-Position: refs/heads/master@{#294489}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 29682b848742042388ebd29c9df775f074c1414c
The last NDK roll (r10c-rc1) lost the ability of generating functional
executables. This is a temporary workaround and should go away by the
time r10c-rd3 NDK is rolled.
BUG=
Review URL: https://codereview.chromium.org/556313003
Cr-Original-Commit-Position: refs/heads/master@{#294257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df01991ea10e2d19a684e9a212a8b4390005ea64
This is a much much larger change than the diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=338885
Review URL: https://codereview.chromium.org/539163002
Cr-Original-Commit-Position: refs/heads/master@{#294233}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd7edfa679492a6feb3ef2e1630f05da82a1b31f
See tools/gyp/pylib/gyp/input.py:
"Sections mathing the regexp '_(dir|file|path)s?$' are also considered PathSections."
Standard gyp variables should not be named like this.
BUG=
Review URL: https://codereview.chromium.org/552203002
Cr-Original-Commit-Position: refs/heads/master@{#294166}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a91e86837e8af810c14543eb01851b7881ff95d8
Currently, blink's FrameLoader.cpp contains a complex, hacky function to
determine when to inform the rest of chromium that loading is complete. This
complexity is only necessary to support layout tests. This puts the requisite
logic in the layout test harness. This logic is behind a temporary flag, in
order to permit both blink and chromium to flip to the new definition of load
completion simultaneously.
BUG=
Review URL: https://codereview.chromium.org/550343002
Cr-Original-Commit-Position: refs/heads/master@{#294085}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 46789a8b27fffe9c4d55b57fd21c3aef1dca1b69
Tune global Android ARM cflags for performance.
Update cflags in gn to keep up with gyp.
BUG=407545
CQ_TRYBOTS=tryserver.chromium.linux:android_aosp,android_clang_dbg,android_dbg
Review URL: https://codereview.chromium.org/375483003
Cr-Original-Commit-Position: refs/heads/master@{#293913}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6b767135e631b94cd096c78f6622be28a4af277e
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libjpeg and instead link
Chromium's libjpeg_turbo.
This increases binary size by ~120KB.
BUG=409851
Review URL: https://codereview.chromium.org/548513002
Cr-Original-Commit-Position: refs/heads/master@{#293663}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c8c58068cdf2997d338cd0b6e3109c5f773dbe6
Switching the use_athena gyp-flag only affects the code inside //chrome. So move
the USE_ATHENA inside //chrome so that toggling the flag doesn't cause all
targets to be rebuilt, and only code inside //chrome is rebuilt instead. This
should also prevent accidental dependence on USE_ATHENA in code outside of
//chrome.
BUG=none
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/541983002
Cr-Original-Commit-Position: refs/heads/master@{#293566}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec96ebfa63de8e17aaf9ec496a5c70c0e085edb7
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of ICU and instead link
Chromium's copy.
This increases binary size by ~7MB.
BUG=409851
Review URL: https://codereview.chromium.org/541753002
Cr-Original-Commit-Position: refs/heads/master@{#293510}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 48e43572c0bfef2b1434d7f330da86cc7770b592
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libexpat and instead link
Chromium's copy, and stop removing the expat sources from the checkout.
This increases binary size by ~64KB.
Also remove an obsolete comment about using the system version of
sqlite; this was never implemented and now will not be.
BUG=409851
Review URL: https://codereview.chromium.org/534603002
Cr-Original-Commit-Position: refs/heads/master@{#293115}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eac62b75ce57c1689a48fadd4229c1346509a170
There are more work needs to be finished, but this should at least allow us to implement login UI
* Added chrome version of ExtensionsDelegate and AppActivity
* introduce use_athena gyp flag
* disabled features/code path that does not work yet on athena. Filed bugs to keep track of them.
BUG=397167
R=mukai@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/514293003
Cr-Original-Commit-Position: refs/heads/master@{#293023}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 963c8527b331983a8f8ccb7d11aec2a50a6fcf77
The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.
Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).
Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions.
This CL deletes the .saves files and turns mac_strip_release on for ASan
builds.
BUG=148383, 242503, 170739, 166857
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/517803004
Cr-Original-Commit-Position: refs/heads/master@{#292872}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5750a97fd179642548e6add77aafc1cdb0eec7e8
This reverts commit f1dc118635a18587a35b3d6f5092878467c261dd.
Reverting due to inconsistent behavior across toolchains, and lack of
clarity on whether armv7s is actually necessary.
BUG=407295,408027
R=rohitrao@chromium.org
Review URL: https://codereview.chromium.org/507423005
Cr-Original-Commit-Position: refs/heads/master@{#292624}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c31daaf4d36113ca2602d1887566a1ad5214a03
It seems that the cons are fairly weak and the benefits might be worth it.
This flag breaks WebView builds.
BUG=None
Review URL: https://codereview.chromium.org/502743002
Cr-Original-Commit-Position: refs/heads/master@{#292458}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23668752ea266ca59e788510fc9e4baaf0397895
The android webview build now uses clang when building for host; update
the gyp variables appropriately to make sure we use reasonable compiler
flags.
BUG=377684
Review URL: https://codereview.chromium.org/516723004
Cr-Original-Commit-Position: refs/heads/master@{#292418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed51a58fb7366557e5dc3b874aa9821d8c5d5343
Add missing variables (android_ndk_*) for building Chromium for MIPS64.
In addition to this, set default mips_arch_variant-s for different MIPS
platforms.
BUG=400684
Review URL: https://codereview.chromium.org/494713002
Cr-Original-Commit-Position: refs/heads/master@{#292148}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8a5da7455b57b2399e4a69e8100c098d9870052
The mp2t mimetype is now supported when the mpeg2 TS stream parser is enabled.
This change is required since isTypeSupported involves
that CanPlayType for the same mime type is at least maybe.
This condition is now enforced at Blink level.
BUG=None
Review URL: https://codereview.chromium.org/478043005
Cr-Original-Commit-Position: refs/heads/master@{#292073}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6c976378bd6485a520f0806e82126b25047d1c9
App Store rules require shipping armv7s with arm64, so this is required
for the "both" configuration.
Also adds it to the 32-bit configuration so that local testing will
better match actual builds, but we can revisit if that turns out to be
onerous in practice.
BUG=407295
Review URL: https://codereview.chromium.org/489713003
Cr-Original-Commit-Position: refs/heads/master@{#291930}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f1dc118635a18587a35b3d6f5092878467c261dd
Reason for revert:
Tentatively reverting because it made the sizes bot grumpy (http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=52715)
Original issue's description:
> linux: Always use (64bit) gold for linking, even on 32bit.
>
> All 32bit bots now have 64bit kernels and can run 64bit gold. So always use
> that. We already require running 64bit binaries for clang, and the official
> bots already used to do this for gold. This makes linking on 32bit bots faster,
> and simplifies our configurations.
>
> BUG=396333
> TBR=brettw
>
> Committed: c7864673b1TBR=thestig@chromium.org,brettw@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396333
Review URL: https://codereview.chromium.org/482173003
Cr-Original-Commit-Position: refs/heads/master@{#291905}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 277720168a1fd1bd3147912fc81c88f6dc0f1c69
All 32bit bots now have 64bit kernels and can run 64bit gold. So always use
that. We already require running 64bit binaries for clang, and the official
bots already used to do this for gold. This makes linking on 32bit bots faster,
and simplifies our configurations.
BUG=396333
TBR=brettw
Review URL: https://codereview.chromium.org/503873004
Cr-Original-Commit-Position: refs/heads/master@{#291904}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7cd5e7a3a82ebad8bf53e1236229d1094f8dafc6
Adds support for Arm64 to 'sandbox/'. This can be used
by future CLs to provide Arm64 policy for Chrome.
BUG=355125
TEST=sandbox_linux_unittests
Review URL: https://codereview.chromium.org/487143003
Cr-Original-Commit-Position: refs/heads/master@{#291631}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6f6b730e646a11e6f6a3c1c5f54e052aa07584a
The address of a reference, or the 'this' pointer, are always non-NULL
in well-defined C/C++ programs, and Clang warns about comparing them to NULL,
because the comparisons may be optimized away.
However, it can still be useful to do such comparisons in Debug builds.
For example, Skia does a lot of SkASSERT(&a), where a is a reference
parameter.
BUG=404271
Review URL: https://codereview.chromium.org/479293002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@290361 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
primiano
gunsch
torne
scottmg
timurrrr
davidben
joleksy
japhet
bolian
hjd
fdegans
vitalybuka
Nico Weber
Sadrul Habib Chowdhury
Hans Wennborg
oshima
treib
glider
Stuart Morgan
mlamouri
petarj
damienv
noms
leecam
glider@chromium.org
thakis@chromium.org
hans@chromium.org
sbc@chromium.org
gunsch@chromium.org