f16e4eb9ffbf Implement SleepNanoseconds() on Windows
b953388b9553 Add SystemSnapshotLinux
ad1b86535c6a Roll mini_chromium to 068fe690218f
20ed4146d377 Use StringPiece for key and value in SimpleStringDictionary
interface
Bug: 758724
Change-Id: I0ef3d1a95dd2b2475a11256891beca32ab593fc5
Reviewed-on: https://chromium-review.googlesource.com/652669
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500022}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 97fba6506881970e6c7b0578a9cee9ef977321fe
This reverts commit 03ac069ca8de6a9b92572fadd73f79f794f129ab.
Reason for reland: Reworked support .aars to work with downstream
Speeds up "gn gen" by about 600ms on my machine.
NOTRY=true (all passed except net_unittests, which is globally broken atm)
TBR=bshe@chromium.org
Bug: 748851, 759903
Change-Id: I639aeb64ef2f531589e8c04535d48a54e413fe15
Reviewed-on: https://chromium-review.googlesource.com/641371
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498216}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf7f522954566498f01a4809932319b720e57338
Speeds up "gn gen" by about 600ms on my machine.
BUG=748851
Change-Id: I2a4208728eddc49bab040459e9b93552d0a9cc55
Reviewed-on: https://chromium-review.googlesource.com/609147
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5302e35e0230a5661f081732b621241cfa00c4bf
Missing deps weren't causing any problems, but correctness is required
for a later change. Deps found via maven pom.xml files.
Bug: 695304
Change-Id: Ic0ea9d652db8fa417bd8bc410ff139f061ee56df
Reviewed-on: https://chromium-review.googlesource.com/611725
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494271}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c364075d22c97468f204d35ce066c52d268744f4
b42854dfe134 Fix Doxygen after 8c802aace407
bf52da0f1bc1 posix: Fix Semaphore::TimedWait wait time
d2d10d1dc8f3 posix: Use std::trunc() from <cmath> instead of trunc()
7819ecbed662 posix: Use trunc() from <math.h> instead of std::trunc()
f37b382687c0 linux/android: Reenable util test, and enable snapshot test
a8493c9b3148 android: Fix FloatContext::NativeFpxregs for x86 with
unified headers
376cddee9eea doc: Update for NDK r15b
6823f6783082 Limit alignas to 64
3d6f7bcf90f5 Enable x86 optimizations for zlib
13e8672410d8 Update mini_chromium to ee67585e3115
1c87c92932d0 linux: Add ProcessMemoryRange to restrict memory reads to a
range
4224be41d7d1 linux: Add ElfImageReader to read ELF images via
ProcessMemory
a79791969d03 linux: Add MemoryMap::FindFileMmapStart
041a50d75c4c linux: Add DebugRendezvous to read dynamic linker data
structures
6ab73e0ad8ac linux: #include appropriate headers for ElfImageReader
5536baff1392 linux: Use PTRACE_GET_THREAD_AREA for x86
ThreadInfo.GetThreadArea
6b5f139d88ce linux: Add ProcessReader
7be6b8ea1ded Add functions to convert native x86 contexts to Crashpad
CPUContexts
bde35ca918ba Add MemorySnapshotLinux
37f20f7b1400 Add ThreadSnapshotLinux
9299d409ab0a linux: Refactor reading start time from the stat file
90e4649f0dfa linux: Sort alphabetically in util .gyp files
01b347732e0e linux: Collect CPU times in ProcStatReader and use in
ProcessReader
281be63d0074 Standardize on static constexpr for arrays when possible
7e6a0145b17b mac handler: Record the number of open files in the handler
process
6dac7ecdf58e Use constexpr at function scope
8f0636288a0e Use constexpr at namespace scope
b653f8615321 Fix Windows build after 8f0636288a0e
a06ca92083f5 Switch CQ to use the new swarmbucket (LUCI) builders
3a5837c77379 #include "build/build_config.h" where necessary
c332e7ffdab6 Fix Doxygen usage in util/misc/lexing.h
1d443b822364 Revert "Switch CQ to use the new swarmbucket (LUCI)
builders"
c9319008b609 Disable the win x86 tests in the CQ until they are swarmed
43a1e46a31f5 Tweak the README wording
7f038ebbd2df #include "build/build_config.h" where necessary
Change-Id: Ib6fe73caf333ecda8f1311ca212dae41affa534d
Reviewed-on: https://chromium-review.googlesource.com/592694
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490857}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9b9fe1cfc5ae9e3cc39361e6e3ed0e928391d8e
To be used in testing system APK removal and replacement.
Bug: 728404
Change-Id: I7e1dc884098f6639eef93a4534e3254fc5f7516a
Reviewed-on: https://chromium-review.googlesource.com/530102
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#482331}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3fa4315be4d2fb7769629ac3af9ced0e5a39537e
d3e4f09742d6 linux: Collect fxsave instead of fsave in ThreadInfo
8c802aace407 Add ReinterpretBytes which does a checked, variable size
bit cast
c4f6ca3c6ac5 mac: Provide a larger thread state buffer for AVX-512 on
10.13
Bug: 733387, crashpad:30, crashpad:185, crashpad:190
Change-Id: Ib4c1ab4c64c7e8697daca7695b81caa426e25b48
Reviewed-on: https://chromium-review.googlesource.com/541517
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480842}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2d809772b79618f5504d642bd6100bd226402ce
Reason for revert:
downstream breakage fixed by adding another mock target downstream
Original issue's description:
> Revert of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2888283002/ )
>
> Reason for revert:
> broke downstream
>
> Original issue's description:
> > Add a mock vision-common GMS client target
> >
> > Upcoming GMS versions will split the vision client into vision and
> > vision-common. In order to roll downstream, we must add an upstream
> > dependency on vision-common. But upstream is not yet ready to roll, so
> > we add a mock vision-common target to temporarily satisfy the new
> > dependency in upstream builds.
> >
> > BUG=706943
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2888283002
> > Cr-Commit-Position: refs/heads/master@{#473268}
> > Committed: 420cf37ad0
>
> TBR=agrieve@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=706943
>
> Review-Url: https://codereview.chromium.org/2893093002
> Cr-Commit-Position: refs/heads/master@{#473302}
> Committed: 9010e14d8fTBR=agrieve@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706943
Review-Url: https://codereview.chromium.org/2892953003
Cr-Original-Commit-Position: refs/heads/master@{#473377}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eaf7cc9d2e262724f33be38d880fcb7eaa97100d
Reason for revert:
broke downstream
Original issue's description:
> Add a mock vision-common GMS client target
>
> Upcoming GMS versions will split the vision client into vision and
> vision-common. In order to roll downstream, we must add an upstream
> dependency on vision-common. But upstream is not yet ready to roll, so
> we add a mock vision-common target to temporarily satisfy the new
> dependency in upstream builds.
>
> BUG=706943
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2888283002
> Cr-Commit-Position: refs/heads/master@{#473268}
> Committed: 420cf37ad0TBR=agrieve@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706943
Review-Url: https://codereview.chromium.org/2893093002
Cr-Original-Commit-Position: refs/heads/master@{#473302}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9010e14d8fc816219fe22ca57b63a9d1eefef45b
Upcoming GMS versions will split the vision client into vision and
vision-common. In order to roll downstream, we must add an upstream
dependency on vision-common. But upstream is not yet ready to roll, so
we add a mock vision-common target to temporarily satisfy the new
dependency in upstream builds.
BUG=706943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2888283002
Cr-Original-Commit-Position: refs/heads/master@{#473268}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 420cf37ad0ddf1c54203a4fdffb68af920503b0e
Enable tombstones for swarming bots. Previously if a test case is
crashed on swarming bots, no tombstones will be resolved, and even if
they are attempted to be resolved, they will fail because of the lack of
tool chains.
In this cl, we are enabling tombstones for swarming bots and we are also
adding tool chains to the dependency.
BUG=631213
Review-Url: https://codereview.chromium.org/2883633003
Cr-Original-Commit-Position: refs/heads/master@{#472615}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fc66094f89df0ecca2a3378296304a9c7e66bbff
The stability file naming code is needed both to know which file to
record to and to know which file to collect on crash (note that for the
postmortem case we simply glob files).
Note: changing the file naming is fine wrt live code as the only
current consumption of stability files is via glob on the postmortem
path.
BUG=718437
Review-Url: https://codereview.chromium.org/2860863003
Cr-Original-Commit-Position: refs/heads/master@{#469733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 531ed20b52b93b78c30a73e37ccf968238c25d84
This is a (less ambitious) re-land of http://crrev.com/2852613002 which
was reverted due to content_browsertests crashes on ChromeOS. That CL is
a re-land of http://crrev.com/2779193002 which was reverted due to build
errors on Mac.
Instead of rolling Google Test to 1.8.0, this CL uses the last commit
before a breaking change was introduced. Details about the breakage are
in https://crbug.com/630705#c27 and https://crbug.com/630705#c28. It is
expected that rolling Google Test from there to the next usable version
will be much less disruptive.
GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.
The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.
* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
been populated with headers that forward into the appropriate locations of
third_party/googletest
* testing/BUILD.gn has been populated with the targets
//testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
depend on the appropriate //third_party/googletest targets.
All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.
BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init
TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
TBR=rkc, dpranke
Review-Url: https://codereview.chromium.org/2856383002
Cr-Original-Commit-Position: refs/heads/master@{#469551}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 52e27a3d242ac0bbcbdc00683f6489ed4d8e9b3f
2815dbdf8e05 linux: Add CheckedLinuxAddressRange and make
CheckedAddressRanges copyable
fd8e2de0c502 win: MSVS 2017 (15)/C++ 14.1/C 19.10 compatibility
4036e2c9d92c linux: Add MemoryMap to collect information about mapped
memory regions
f31459b266a4 Update GYP to ffd524cefaad for MSVS 2017 (15)/C++ 14.1/C
19.10 support
44e32fe1233d Tweak InitializationState tests that rely on undefined
behavior
ed8e637817b1 linux: Fill a test file with zeroes instead of garbage in
MemoryMapTest
984749479f56 Introduce FromPointerCast<>(), with defined sign/zero-
extension behavior
15103742e06e Use FromPointerCast<>() in many places where it makes sense
f03c7b2d8f52 mac: Trigger a real SIGSYS on 32-bit x86 during tests
8af3203d811c Add LoggingReadEntireFile for reading a file into a string
51779ce63956 linux: Make MemoryMap retry when duplicates are detected
abbeffead98e Fix file descriptor/handle leak in LoggingReadEntireFile()
dc60e106f332 linux: Make fewer (but still a lot of) regions in
MemoryMap’s test
d9ca2ad21f31 Give group project-crashpad-tryjob-access access to the
commit queue
1969a5d7587b Document who has access to the try server and commit queue
7d56fd238606 Rely on winsock2.h for timeval
Review-Url: https://codereview.chromium.org/2858023002
Cr-Original-Commit-Position: refs/heads/master@{#469099}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 02b3b5d5330ff2a727412976de882206f7635401
Reason for revert:
Seems to have caused all content_browsertests on ChromiumOS to crash.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25582
I'll run the revert through trybots so that it doesn't break anything else.
Original issue's description:
> Roll googletest to 1.8.0.
>
> This is a re-land of http://crrev.com/2779193002 which was reverted due to
> build errors on Mac.
>
> GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
> googletest repository. In order to cope with this, the googletest
> repository is now sourced at third_party/googletest.
>
> The file/directory layout of Google Test is not yet considered stable.
> To minimize disruption while Google Test stabilizes, Chromium code will
> be insulated from third_party/googletest.
>
> * testing/gtest/include/gtest/ and testing/gmock/include/gmock have
> been populated with headers that forward into the appropriate locations of
> third_party/googletest
>
> * testing/BUILD.gn has been populated with the targets
> //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
> depend on the appropriate //third_party/googletest targets.
>
> All Chromium code should keep depending on the targets and headers
> in testing/{gtest,gmock} for now.
>
> BUG=630705
> TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
> TBR=rkc,dpranke,agl
>
> Review-Url: https://codereview.chromium.org/2852613002
> Cr-Commit-Position: refs/heads/master@{#468860}
> Committed: dbcef9bdc1TBR=dpranke@chromium.org,thakis@chromium.org,rkc@chromium.org,agl@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630705
Review-Url: https://codereview.chromium.org/2856963003
Cr-Original-Commit-Position: refs/heads/master@{#468934}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a289707ca3726217915fb7cac34dcdeeaba1e3cc
This is a re-land of http://crrev.com/2779193002 which was reverted due to
build errors on Mac.
GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.
The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.
* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
been populated with headers that forward into the appropriate locations of
third_party/googletest
* testing/BUILD.gn has been populated with the targets
//testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
depend on the appropriate //third_party/googletest targets.
All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.
BUG=630705
TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
TBR=rkc,dpranke,agl
Review-Url: https://codereview.chromium.org/2852613002
Cr-Original-Commit-Position: refs/heads/master@{#468860}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dbcef9bdc1edd32d62c6de0bd382cdc78ce385da
We had been looking in lib.stripped for the library when symbolizing
debuggerd traces. The libraries in lib.stripped are not the ones with
packed relocations, though, so the resulting symbolization was wrong.
This CL generates a wrapper script around the stack symbolization
script that points to the correct library to use for symbolization.
It also contains a few tests that intentionally crash in various ways.
These are all disabled by default and should only ever be run manually
for testing out instrumentation test crash tooling.
BUG=712265
Review-Url: https://codereview.chromium.org/2840193003
Cr-Original-Commit-Position: refs/heads/master@{#468206}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 276cc56b7c04cc3a28ec6315feb00f056ea8327b
Reason for revert:
Findit(https://goo.gl/kROfz5) identified CL at revision 467833 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1MzlmYTExMjNhMTllNjQ5OWY1ODU4MmRhNTVjYTVhZjlkZjk0YTQM
Original issue's description:
> Roll googletest to 1.8.0.
>
> GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
> googletest repository. In order to cope with this, the googletest
> repository is now sourced at third_party/googletest.
>
> The file/directory layout of Google Test is not yet considered stable.
> To minimize disruption while Google Test stabilizes, Chromium code will
> be insulated from third_party/googletest.
>
> * testing/gtest/include/gtest/ and testing/gmock/include/gmock have
> been populated with headers that forward into the appropriate locations of
> third_party/googletest
>
> * testing/BUILD.gn has been populated with the targets
> //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
> depend on the appropriate //third_party/googletest targets.
>
> All Chromium code should keep depending on the targets and headers
> in testing/{gtest,gmock} for now.
>
> BUG=630705
> TBR=rkc
>
> Review-Url: https://codereview.chromium.org/2779193002
> Cr-Commit-Position: refs/heads/master@{#467833}
> Committed: b539fa1123TBR=thakis@chromium.org,dpranke@chromium.org,agl@chromium.org,rkc@chromium.org,skobes@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630705
Review-Url: https://codereview.chromium.org/2847043002
Cr-Original-Commit-Position: refs/heads/master@{#467852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed7b62615d138c4d629540bab4a2757da5551134
GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.
The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.
* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
been populated with headers that forward into the appropriate locations of
third_party/googletest
* testing/BUILD.gn has been populated with the targets
//testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
depend on the appropriate //third_party/googletest targets.
All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.
BUG=630705
TBR=rkc
Review-Url: https://codereview.chromium.org/2779193002
Cr-Original-Commit-Position: refs/heads/master@{#467833}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b539fa1123a19e6499f58582da55ca5af9df94a4
bc7c6e235d64 mac: Prevent the same report from being uploaded multiple
times
5d07d81458dc Fix Doxygen warnings after 30385d4e4772
2ec34e32c2f4 linux: Support 4.10 format for empty Groups: lines in
/proc/pid/status
8297b19a5e85 Don’t attempt to do periodic tasks in a secondary
crashpad_handler
c64fd3f9b4d5 Update mini_chromium to dc3d480305b2
ddcc74f08f4f mac: Tolerate dead names for reply ports in the exception
handler server
b8aaa2290530 mac handler: Record a file-limits annotation (temporarily)
BUG=crashpad:30,crashpad:143,crashpad:167,crashpad:180
Review-Url: https://codereview.chromium.org/2825103002
Cr-Original-Commit-Position: refs/heads/master@{#465308}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 22d1fa7cd581238076db274a3932ae45a9966cd5
46f403377367 posix: Add ScopedDIR for managing open directories
ab9c03f8827b win: Promote WinMultiProcessWithTempDir to test/win for
reuse
9c6d190b9570 linux: Add ScopedPtraceAttach to manage ptrace attachments
fd9f952393ea Fix crashpad_util_test build with GCC after 4b450c813795
e142aa87d663 linux: Fix crashpad_util_test ScopedPtraceAttach.* with the
Yama LSM
a5d81370beda linux: Use pread64() instead of pread() in ProcessMemory
30385d4e4772 handler: Add user extensibility stream call-out
79425e4d9737 win: Free an old buffer before attempting to allocate a
resized one
1f28a123a4c9 designdoc: Add description of user data sources
BUG=crashpad:167,crashpad:30
Review-Url: https://codereview.chromium.org/2814043003
Cr-Original-Commit-Position: refs/heads/master@{#464059}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcba287825394261983a99443cb1be450de1083c
9104d53d1c60 Fix thread startup in snapshot reader test
542a91e20e39 Fix the race causing flaky CrashpadClient tests
270490ff79df win: Be more careful about child process exit codes
6c8a3f700738 win: Use a semaphore for synchronization in
ProcessSnapshotTest
f14eda221fe7 win: Be more careful about exit codes in end_to_end_test.py
449dfc4b5dc1 Remove BUG_LINE_FORMAT from codereview.settings
d6837b2b869f mac: Fix SystemSnapshotMacTest.TimeZone on macOS 10.12.4
96dc950eaf26 posix: Add ScopedMmap for managing memory-mapped regions
3127026a95c1 Convert generate_doxygen.sh to generate_doxygen.py
1a6ae8ce0ba8 posix: Don’t accumulate zombies in ProcessInfo.Forked
test
aa2bc55777b9 posix: Allow ScopedMmap::ResetAddrLen() to deal with
overlap
385fe6615f11 posix: DCHECK for (addr + len) overflow in
ScopedMmap::ResetAddrLen()
c39e4dc9769e mac: Remove obsolete comment about
mach_msg_header_t::msgh_reserved
46883516231e “Promote” test::Paths::Executable() to
Paths::Executable()
fa8ef92dc7f1 linux: Add ProcessMemory which reads another process'
memory
4b450c813795 test: Use (actual, [un]expected) in gtest
{ASSERT,EXPECT}_{EQ,NE}
76a67a37b1d0 Add the --monitor-self argument to crashpad_handler
45305395ad87 win: Determine length of unloaded module names
8f07f7481ab4 handler: Add --monitor-self-annotations
b4095401639e handler: Reuse existing annotations SimpleStringDictionary
BUG=crashpad:30,crashpad:143
Review-Url: https://codereview.chromium.org/2804713002
Cr-Original-Commit-Position: refs/heads/master@{#462093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4d005995302373474923a31d642c8f49071a0ce
Adding support to use Robolectric's play-services shadow
classes. Removing a custom shadow class we had in Chromium
now that the same shadow is available in Robolectric.
BUG=693660
Review-Url: https://codereview.chromium.org/2760743002
Cr-Original-Commit-Position: refs/heads/master@{#460906}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 476fddc51fb5cf133f2ce351c6805e65f4cbc4dd
3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
(compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision
BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
Review-Url: https://codereview.chromium.org/2773813002
Cr-Original-Commit-Position: refs/heads/master@{#459244}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a53e839bbe97b3936efad635e8feed3551cf545
This adds a basic navigation bar fixed to the bottom of the
BottomSheet. Changing BottomSheet content will be done in a
follow up CL(s).
BUG=699598
Review-Url: https://codereview.chromium.org/2738843003
Cr-Original-Commit-Position: refs/heads/master@{#456833}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4a2aaa37f0366b0a4673fa57867cda86f65118c9
ded751da3ddc doc: Update Doxyfile to 1.8.13
1dcd45ab751c win: Pass a query component, if present, to an HTTP server
c73aebc7dafa Download clang-format and gn tools for Linux build hosts
from DEPS hooks
58aac1bd87ce Set FD_CLOEXEC on file descriptors obtained from open() and
fopen()
bf2c5155d28f Add Signals, utilities for signal handling
60be5a66a050 net: Provide better HTTP User-Agent strings
9660a1b66e6e win: Fix build after 60be5a66a050
77c1c29253de package.h: Update copyright year to 2017
ae8fe2d1f523 Add CQ configuration to Crashpad
622e8dd1b5de Specify gerrit, as it's mandatory to specify either or both
of gerrit/rietveld
440b7e237446 Additional setup required for Gerrit projects
f848952e059b Support MINIDUMP_MISC_INFO_5 defined in Windows 10
6128f38e28eb Don't delete persistent histogram file on normal exit
BUG=696721
Review-Url: https://codereview.chromium.org/2729643005
Cr-Original-Commit-Position: refs/heads/master@{#454678}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f4adeaac49556e68664aac66b2f2fb95d7fddf0e
1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
Review-Url: https://codereview.chromium.org/2710663006
Review-Url: https://codereview.chromium.org/2710663006
Cr-Original-Commit-Position: refs/heads/master@{#452510}
Committed: c4d7eaed0f
Cr-Original-Original-Commit-Position: refs/heads/master@{#452387}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d0b0e164df66904125ecdcf3473212a1d97a11ce
1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
Review-Url: https://codereview.chromium.org/2710663006
Cr-Original-Commit-Position: refs/heads/master@{#452387}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c4d7eaed0fcac839f1fd4f2a763bcb1ee52fd227
After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b,
crashpad_handler would fail to start in a component build with this error:
dyld: Library not loaded: @rpath/libbase.dylib
Referenced from:
/Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium
Framework.framework/Helpers/crashpad_handler
Reason: image not found
BUG=693721,662466
R=mark@chromium.org
Review-Url: https://codereview.chromium.org/2704763002
Cr-Original-Commit-Position: refs/heads/master@{#451441}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 91bfdf3e5fd8b4403f1a346552c0ad991c52913d
This CL also updates the icon size and alignment.
It uses android.support.v7.widget.GridLayout since principle of weight is needed.
BUG=684665
Review-Url: https://codereview.chromium.org/2654233003
Cr-Original-Commit-Position: refs/heads/master@{#447393}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 76cd3bbdad924d4bee7264e8efb9d6f8e360e4d7
Some non-Android Java libraries (in particular, Emma) expect their
resources to be packed into JARs and accessible via methods of Class or
ClassLoader. This way is supported on Android as well, such resources
must be packed into the final APK to be usable.
This CL generalizes a way Emma resources are packed into the APK.
Instead of having a special case in apkbuilder.py a notion of java
resources JAR is added. Any prebuilt JAR can specify that it also
contains resources. Then apkbuilder.py will get a list of all such JARs
via buildconfig file and pack all resources into an APK.
Patched & rebased from:
https://codereview.chromium.org/2212443002/
Review-Url: https://codereview.chromium.org/2632283002
Cr-Original-Commit-Position: refs/heads/master@{#443944}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e46930f3962ed463e08191285a80d66b265c2bb
0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
(Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
__has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction
Updated build/secondary GN files to match .gyp changes.
BUG=656800
R=mark@chromium.org
Review-Url: https://codereview.chromium.org/2555353002
Cr-Original-Commit-Position: refs/heads/master@{#437376}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e585bac3b48a1fd12eb7a85ad3d94d823306117f
Sigurdur Asgeirsson
Andrew Grieve
Eric Stevenson
Ingemar Ådahl
Mark Mentovai
Mike Bjorge
Sergey Ulanov
John Budorick
paulmiller
hzl
manzagop
pwnall
lpromero
msramek
findit-for-me
dgn
sandv
mikecase
twellington
tzik
ymzhang
peter
rsesek
erikchen
gogerald
ajuma
scottmg