This CL contains fixes required to ensure that the presubmit
upload script does not fail after the Pylint update to 1.5.
More specifically:
- The pylintrc is modified to add wrong-order-position to
the list of disabled warnings, since many of the scripts
under build/android require sophisticated import logic
due to the use of third_party/catapult/devil/
- Otherwise, scripts are locally updated by either changing
the source code, or adding local pylint comments to disable
a specific warning.
Without this CL, no Android-specific CL can pass the presubmit
test on Gerrit :-/
BUG=NONE
R=jbudorick@chromium.org, agrieve@chromium.org, vapier@chromium.org
Change-Id: I4812c76bf1b86918d56c230574c741c3c1328c5d
Reviewed-on: https://chromium-review.googlesource.com/1148339
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577510}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 66f9dbec18c8eb8e9be2641cfe81b2cae7928fff
The default depot_tools pylintrc disables some checks that we can
reasonably enable in build/android/. This CL does so.
BUG=
Review URL: https://codereview.chromium.org/1315743004
Cr-Original-Commit-Position: refs/heads/master@{#347720}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58b4d3677418a2360c23e118199f5cf8992d4178
David 'Digit' Turner
jbudorick