Revert these two CLs to have monochrome working again on ToT.
Revert "Move PathUtils to use ContextUtils."
commit 7200e9f34aa2e9006d8ea5540035de744b13d27d.
Revert "Reland of Move language pak files to assets."
commit 67101cd0338a409d80689b9c9c875c95ccde7957.
BUG=653771,644377, 529604
TBR==agrieve@chromium.org,tedchoc@chromium.org,slan@chromium.org,xunjieli@chromium.org,torne@chromium.org,nyquist@chromium.org,wnwen@chromium.org, michaelbai@chomium.org, estevenson@chromium.org
Review-Url: https://codereview.chromium.org/2406093002
Cr-Original-Commit-Position: refs/heads/master@{#424345}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5cb262f964b4a158be02b5497462e2e8d170a59b
Reason for revert:
Breaking monochrome (chrome not booting up)
BUG=652984, 653771
Original issue's description:
> Store only locale paks rather than all assets within BuildConfig.java
>
> This works around Monochrome having diffferent BuildConfig.java for
> 32/64 bit.
>
> BUG=652984
>
> Committed: https://crrev.com/4e09dacc10a8a359785c6f49d75653ce7cfd00ec
> Cr-Commit-Position: refs/heads/master@{#423587}
TBR=tedchoc@chromium.org,michaelbai@chromium.org,agrieve@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652984
Review-Url: https://codereview.chromium.org/2404043002
Cr-Original-Commit-Position: refs/heads/master@{#424304}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 01fbbca601e78b594cebe62b8eb804ca7d6ff0aa
As part of making the Android Blimp APK compatible with the
//blimp/client/public APIs, this first CL moves the session code into
//blimp/client/app. This includes the GN-targets to ensure that they are
easily identifiable as belonging to the app directory.
This moves the APK-target itself, which means that the testing bots
needed to be updated with the new path to the target. In addition, the
lint suppressions needed to be updated with a new path.
The //blimp/client:blimp_unittests_java_deps (moved from //blimp), still
needs to be referred to directly by //blimp/BUILD.gn, because adding it
as a deps to //blimp/client:unit_tests on the Android platform does not
make the Java classes end up in the unit test APK. Other than this, the
rest of the targets have now been moved to //blimp/client and
//blimp/client/app.
Some targets have been renamed since they now reside in the app
directory.
Lastly, since the visibility parts of //blimp/client/core is cleaned up,
a bug was also filed for removing the visibility for internal core
targets for the engine browser tests.
BUG=651964, 653789
Review-Url: https://codereview.chromium.org/2387813002
Cr-Original-Commit-Position: refs/heads/master@{#423825}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ce09cbb95446995ca12230ccf86b3467d0259f1
clang-format wraps long lines, so java_cpp_enum.py should also
handle multi-line enum entries.
Also changed the HeaderParser to ignore empty comments.
BUG=652018
Review-Url: https://codereview.chromium.org/2396533002
Cr-Original-Commit-Position: refs/heads/master@{#422863}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9066edf6a2199aa3390cc55e89a93f858b50761b
Reverted by:
https://codereview.chromium.org/2369683002/
Reason for reland:
I've reworked it so that:
1. The list of pak files to extract are not set on start-up, but rather lazy initialized
2. This is done by putting the list of locale assets right in base's BuildConfig.java
3. Downstream parts have been upstreams so that this won't require a 2-sided patch
Language pak files were moved to res/raw when split apks was being implemented.
Moving them to assets with a java constant keeping track of pak file locations
will improve lookup time and save some space (no more xml files and
resources.arsc).
Other notables:
- .pak filenames no longer mangled. No more .lpak. no more hyphens to _s
- Ensures that monochrome doesn't extract files by extracting only when
files are compressed.
BUG=529604
Review-Url: https://codereview.chromium.org/2371843002
Cr-Original-Commit-Position: refs/heads/master@{#422836}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67101cd0338a409d80689b9c9c875c95ccde7957
This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.
BUG=623989
Review-Url: https://codereview.chromium.org/2364233003
Cr-Original-Commit-Position: refs/heads/master@{#422649}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8d53345794d41eb28671c65157fa3c0df093ba99
Removes annotations of "GYP version" from GN targets.
Removes shell.exe.manifest which was used only by the GYP build.
TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2373683003
Cr-Original-Commit-Position: refs/heads/master@{#421335}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cde1af7bd0ccf5b051bd3bac47290e15d8a0ef29
This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.
BUG=623989
Review-Url: https://codereview.chromium.org/2362753005
Cr-Original-Commit-Position: refs/heads/master@{#420871}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0922fe51e2ce01ab7dc1644d81bb15801a41286a
This cuts down the sub-project count from 390->280. But Android Studio
still runs out of memory (at least with default max heap settings).
BUG=620034
Review-Url: https://codereview.chromium.org/2364063002
Cr-Original-Commit-Position: refs/heads/master@{#420681}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a823415411eacefa5b91ad24fc8bf24bd28c9cc
Language pak files were moved to res/raw when split apks was being implemented.
Moving them to assets with a java constant keeping track of pak file locations
will improve lookup time and save some space (no more xml files and
resources.arsc).
BUG=529604
Review-Url: https://codereview.chromium.org/2345143002
Cr-Original-Commit-Position: refs/heads/master@{#420641}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34ae27889dd8c8ffd5f5ca8c7bc10c17e57c12e2
Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.
BUG=635567
Review-Url: https://codereview.chromium.org/2327833002
Cr-Original-Commit-Position: refs/heads/master@{#420619}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 69affba419bbaf5d66355d0526e1bf6830e60288
A Espresso dependency (Dagger) throws an InvalidPackage lint error
for a javax.inject reference. Further details are in the bug.
BUG=648419
Review-Url: https://codereview.chromium.org/2350313004
Cr-Original-Commit-Position: refs/heads/master@{#420494}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bdb3c2f97403a31e40dceb42dc8d4744a9cb2b45
While --all does what it says, Android Studio was not happy trying to
import the swath of generated projects. The flag will be available only
for the adventurous :).
BUG=620034
NOTRY=true
Review-Url: https://codereview.chromium.org/2362613002
Cr-Original-Commit-Position: refs/heads/master@{#420426}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e244c1ae9cd6729b0f89f33075aac99f71a678bf
This appeases Android Studio 2.2. Without this, it prompts to update
every time you regenerate the gradle files.
BUG=620034
Review-Url: https://codereview.chromium.org/2359593002
Cr-Original-Commit-Position: refs/heads/master@{#420224}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0c28e4fe67ab2412620634d1dff48bfd49934aeb
This just adds a shortcut for test_apk --> test_apk__apk. We should
still look at adding "better" instrumentation test support later.
This also changes the default target to chrome_public_apk_test
BUG=620034
TBR=jbudorick
Review-Url: https://codereview.chromium.org/2355113002
Cr-Original-Commit-Position: refs/heads/master@{#420223}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8daac2fedb75dc72c918817171f8eb34395ad3aa
The $ was sometimes causing Android Studio to show warnings that the
names were interpreted as variables. / and : are not allowed at all.
BUG=620034
TBR=jbudorick
Review-Url: https://codereview.chromium.org/2354073002
Cr-Original-Commit-Position: refs/heads/master@{#420222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41ced7c64711c5332daa33ec8ba95e2ff44c6599
Reason for revert:
A couple of tests are failing on non-cq bots.
Original issue's description:
> Enable media browsertests on Android
>
> These have been disabled for a long time. Now that the unified media
> pipeline is enabled, they should be much more reliable.
>
> BUG=582293
>
> Committed: https://crrev.com/e95b5033607824ec2a3441fed4faecd1e7b7b067
> Cr-Commit-Position: refs/heads/master@{#419912}
TBR=dalecurtis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582293
Review-Url: https://codereview.chromium.org/2356383002
Cr-Original-Commit-Position: refs/heads/master@{#420135}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0585358850c2a0b4258b82d1e8da7c858c2320f1
Commit d4d66d4d ("Reland #2: Move side-loaded test data /sdcard ->
/sdcard/gtestdata") introduced a regression in
LocalDeviceInstrumentationTestRun.substitute_device_root() when it's
passed a list: the posixpath.join() call ends up receiving a generator
instead of multiple arguments.
This means the call will return a generator instead of 'foo/bar/baz',
which is not what's intended.
R=jbudorick@chromium.org
Review-Url: https://codereview.chromium.org/2360693002
Cr-Original-Commit-Position: refs/heads/master@{#420101}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 37ac2516dde8b3fb2647880c406961a9cf052c65
These have been disabled for a long time. Now that the unified media
pipeline is enabled, they should be much more reliable.
BUG=582293
Review-Url: https://codereview.chromium.org/2346963004
Cr-Original-Commit-Position: refs/heads/master@{#419912}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e95b5033607824ec2a3441fed4faecd1e7b7b067
* Move them to a new file: media_color_browsertest.cc which is not
compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident).
* Minor renames/comment clean up.
BUG=582293
Review-Url: https://codereview.chromium.org/2345073002
Cr-Original-Commit-Position: refs/heads/master@{#419829}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a46402f563caaf17237ed9b575dfbc3d47e537de
Ninja complains with:
expected depfile 'foo.d' to mention 'bar', got 'baz'
Running ninja twice now reports "no work to do" again.
This change required updating all calls to build_utils.WriteDepFile() so
that the output is passed in. While doing this, I also made the helper
add in GetPythonDependencies() by default.
build/android/gyp/ant.py I just deleted rather than updating since it's
GYP-only.
BUG=646165
Review-Url: https://codereview.chromium.org/2336173003
Cr-Original-Commit-Position: refs/heads/master@{#418455}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4eb18a55cde4daf2ef43330d0304ec73ef546f96
aea37326ac..9004380757
$ git log aea37326a..900438075 --date=short --no-merges --format='%ad %ae %s'
2016-09-12 benjhayden Stop computing summary statistic ScalarNumerics in ValueSet.
2016-09-12 nednguyen Make cloud_storage_global_lock a python module & import it in py_utils.cloud_storage
2016-09-12 benjhayden Prevent re-entering value-set-table.updateContents_.
2016-09-12 rnephew [BattOr] Add logging to battor subprocess polling.
2016-09-12 washingtonp Enable some profile_chrome unit tests on Trybots, specifically the ones that will currently run without error.
BUG=645720,645106
TBR=catapult-sheriff@chromium.org
NOTRY=true (net_unittests is flaky: crbug.com/646215)
Review-Url: https://codereview.chromium.org/2331333002
Cr-Original-Commit-Position: refs/heads/master@{#418154}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a80bccf5aa929e36d526180dc5b51abe03b9d2d4
da6d44e4a2..c0b988891f
$ git log da6d44e4a..c0b988891 --date=short --no-merges --format='%ad %ae %s'
2016-09-09 erikchen Add a new cpu time TBMv2 system health metric.
2016-09-09 nednguyen Update the lock operation in cloud_storage with better implementation using py_utils.lock
2016-09-09 rnephew [BattOr] Kill BattOr shell if there is a problem with communicating during clock sync.
BUG=640312,637904,645106,645720
TBR=catapult-sheriff@chromium.org, jbudorick@chromium.org
Review-Url: https://codereview.chromium.org/2326063004
Cr-Original-Commit-Position: refs/heads/master@{#417833}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c4b1e75d9334ca63343d5e44768c246d796c8386
Reason for revert:
Broke v8 roller
Original issue's description:
> Make secondary abi work for component build
>
> Add secondary_abi_shared_libraries to pack all the secondary abi
> shared libraries into APK.
>
> BUG=622855
>
> Committed: https://crrev.com/3ac692c2e67e8030a30e4ebcd12240352944f898
> Cr-Commit-Position: refs/heads/master@{#417441}
TBR=machenbach@chromium.org,michaelbai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622855
Review-Url: https://codereview.chromium.org/2327063002
Cr-Original-Commit-Position: refs/heads/master@{#417580}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 43c48e4e358edc63ab8f032d2e94f59c177776c7
* Fail if it finds a non-trivial AndroidManifest.xml
* Fail if it finds any .so files
* Fail if it finds any assets
* Support proguard.txt
This also tweaks the naming of the sub-jar targets to give them better
target names (which show up in .jar names).
TBR=bshe
BUG=640836
Review-Url: https://codereview.chromium.org/2309643002
Cr-Original-Commit-Position: refs/heads/master@{#417160}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8dbd4fb5770dc164dfa20845f839d49c154b0e9c
In Android N, Chrome can no longer read /data/local/chrome-command-line
due to SELinux (https://crbug.com/593720). Hence command line arguments
are read from /data/local/tmp/chrome-command-line instead on userdebug
or eng builds.
This patch makes adb_chrome_public_command_line write the same arguments
to both the old and the new location, so it works with both old and new
builds of Chrome.
BUG=593720
Review-Url: https://codereview.chromium.org/2294973003
Cr-Original-Commit-Position: refs/heads/master@{#416523}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f1b179cce6d03443a0e2252a4bedcb49061099d3
Having it as '' caused it to resolve to CWD when unset due to
type=os.path.realpath. Then, perf_test_instance.py tried to write to CWD
as a file.
Also removes third_party/appurify-python from .gitignore
in order to appease test_runner.pydeps presubmit.
TBR=rnephew
BUG=609365
Review-Url: https://codereview.chromium.org/2306263002
Cr-Original-Commit-Position: refs/heads/master@{#416466}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 144057ca2c57f655112212ba1efbf90c9ab26b93
pwnall
lukasza
sgurun
nyquist
agrieve
jbudorick
estevenson
stip
brettw
khushalsagar
jayker
watk
raphael.kubo.da.costa
nednguyen
rnephew
machenbach
michaelbai
johnme