Contrary to previous attempt at:
68c6f2ce16
RenderFrameMessageFilter is on the IO thread, and is a BrowserAssociatedInterface, so will maintain the ordering of the resource request and the zoom level request. See also https://codereview.chromium.org/2167513003.
BUG=609607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2211713002
Cr-Original-Commit-Position: refs/heads/master@{#410417}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d4423d511f18f4b0d2e94cf17bf6043bee449c55
One some Android versions, enabling airport mode is not enough to switch
off NFC on the devices. Running "svc nfc disable", available on M and later,
allows to ensure that NFC always remains off.
BUG=634937
Review-Url: https://codereview.chromium.org/2223013002
Cr-Original-Commit-Position: refs/heads/master@{#410345}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 154947a15a35d3b9b9818bd895f950c0a12ad306
This enables us to run all ProGuard uninhibited by tests, since Proguard will
now consider both the tests and the tested code while performing its
optimizations. This is opposed to running ProGuard on the tested java,
keeping stuff around for the tests, which would then use the tested code as
a library.
This turns on optimizations and removes test code from the shipped apk, saving
us ~550kb in .dex size, and ~70kb memory per process.
BUG=620323,625704,626710
Review-Url: https://codereview.chromium.org/2182303002
Cr-Original-Commit-Position: refs/heads/master@{#410056}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d50624e2e5a9d9fe13596d83e73385c9c44069e9
This CL modifies java_cpp_enum.py to preserve comments on the
enums in the generated Java file.
The comments are useful for developers who usually read the
JavaDoc and not the C++ files.
BUG=634092
Review-Url: https://codereview.chromium.org/2210633002
Cr-Original-Commit-Position: refs/heads/master@{#410047}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ea986397d77dc45b5b272ad68d00cc6063ee6987
Before the parser only recognize native crash, but not process crash. In
this cl, process crash will be marked as 'CRASHED' instead of 'UNKNOWN'.
BUG=
Review-Url: https://codereview.chromium.org/2207303002
Cr-Original-Commit-Position: refs/heads/master@{#409934}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 419b412379e5db6d32858f31f22d1b1ebc6ab2da
1. Historically the OnNoMemory suicide on malloc/new failure was not
enabled on Android. This seems to be due to the fact that
set_new_handler was not avilable on Android back in the days of
pre-libcxx. See crbug.com/317791 .
2. After the libcxx switch, however, the combination of operator new
throwing bad_alloc and chrome building with -fno-exception made
operator new (but not malloc) inadvertently suicidal, by virtue of
ending up calling the default exception handler.
See crbug.com/633313#c28 .
3. crrev.com/1883093005 (first seen in M52) introduced a shim layer
wrapping malloc and operator new, which was intending, among the
various things, to make malloc / new finally secure on Android.
This good intend, however, failed to materialize because the
set_new_handler call in memory_linux.cc was still #ifdef-ed out
on Android. Similarly the memory_unittests.cc were excluded on
Android for the same reason (Android was deemed to not possibly
be secure since 1.).
In summary here's what went wrong:
- When we switched to libcxx, nobody realized that we could have
finally taken advantage of set_new_handler.
- When I enabled the android shim I didn't realize about the
missing set_new_handler call. I was assuming that the memory
tests would have screamed red if I did something wrong, but I
didn't realize that they were disabled on Android.
This CL fixes all this, enabling set_new_handler on Android and
enabling the tests.
Note also that this CL is just about inducing a hard crash on malloc failure.
This does not change the situation about disallowing large allocations
(>2GB) that might cause int signed/unsigned bugs
(see crbug.com/169327). As things stand today, Android never had that
check and still doesn't yet after this CL.
BUG=633966,317791
TEST=base_unittests --gtest_filter=OutOfMemory*
Review-Url: https://codereview.chromium.org/2201363002
Cr-Original-Commit-Position: refs/heads/master@{#409531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 227dbd3dc564004471f146ef655fad35c52704c3
The instrumentation_test_apk template can't use the isolate generation
logic if it stays in //testing/test.gni as doing so would introduce a
circular dependency. Android appears to be the only user of the
isolate generation logic anyway.
BUG=633333
Review-Url: https://codereview.chromium.org/2204823002
Cr-Original-Commit-Position: refs/heads/master@{#409429}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f5e2b6ac5cf0356d4e3fa25d65a6d1dcf4aaa2ad
Reason for revert:
This breaks compile step on official.desktop.continuous for all OS trunk.
crbug.com/633775
Original issue's description:
> [Sync] Merge sync_unit_tests into components_unit_tests, take 2.
>
> This change was previously landed and reverted because some bot configs
> in the build repo needed to be updated first.
>
> BUG=626114
> TBR=dpranke,jam,slan
>
> Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d
> Cr-Commit-Position: refs/heads/master@{#409060}
>
> patch from issue 2186733002 at patchset 60001 (http://crrev.com/2186733002#ps60001)
>
> Committed: https://crrev.com/9131f18a585a66ad327af8089d3fb80c10388948
> Cr-Commit-Position: refs/heads/master@{#409356}
TBR=dpranke@chromium.org,jam@chromium.org,slan@chromium.org,maxbogue@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626114,633775
Review-Url: https://codereview.chromium.org/2201273002
Cr-Original-Commit-Position: refs/heads/master@{#409386}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 523ee7dd9be18c54a45ca4ff499d57e1cac4495c
There are a few spots in the Android templates that assume appending
__build_config to a given target label will result in the label for a
write_build_config action. When toolchains exist in a label, appending
like this doesn't work. E.g.: :some_label(//toolchain)__build_config
Previously, we added a GN assert to enforce default toolchain, but that
was too strict, as it made it so no other targets that are defined in
the same BUILD.gn file could use a non-default toolchain.
This change make the error a build-time error rather than a gn gen
error.
BUG=629371
Review-Url: https://codereview.chromium.org/2161063003
Cr-Original-Commit-Position: refs/heads/master@{#408576}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 83bcd862038586061feea4b390ac524ab0a9a358
There are a bunch of subfolder reorganizations going along with this:
- engine/ -> engine_impl/
- sessions/ -> sessions_impl/
- util/ -> base/
- internal_api/public/base/ -> base/
- internal_api/public/sessions/ -> sessions/
- internal_api/public/engine/ -> engine/
- internal_api/public/events/ -> engine/events/
- internal_api/public/util/ -> base/
- internal_api/public/ -> core/
- internal_api/ -> core_impl/
This change was generated using the following script:
http://pastebin.com/vVAkRCkh
Because this patch is so large, some review was done in split CLs:
Manual changes: http://crrev.com/2155763002
Sync internal changes: http://crrev.com/2156693002
Sync external changes: http://crrev.com/2148293004
This is a minimal change to support file movement; it doesn't do
anything like merging sync_unit_tests into component_unit_tests,
which will be done in a followup.
The gyp files are not sorted because they're all going to be removed
very soon anyways.
BUG=626114
R=jam@chromium.org, zea@chromium.org
TBR=jam
Review URL: https://codereview.chromium.org/2130453004 .
Cr-Original-Commit-Position: refs/heads/master@{#408497}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fef332d69faf129b64689e30304061322ca9bcad
We have so many resources that onResourcesLoaded is exceeding the 64KB limit
Java has on methods. This CL splits onResourcesLoaded based on resource type,
eg: onResourcesLoadedAnim, onResourcesLoadedDrawable, onResourcesLoadedString.
BUG=629768
Review-Url: https://codereview.chromium.org/2163993002
Cr-Original-Commit-Position: refs/heads/master@{#407864}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2c63be44901ccd5fe3af5323ca494959d497628a
ports.ResetTestServerPortAllocation is called in two locations, once in a
multithreaded context in which it's holding the lock file and once in a
singlethreaded context in which it isn't. It currently nukes the lock file,
which is fine in a singlethreaded context but can cause duplicate port
allocation in a multithreaded context. This CL will allow that function
to stop nuking the lock file in a subsequent CL to fix that issue.
BUG=631018
Review-Url: https://codereview.chromium.org/2176183004
Cr-Original-Commit-Position: refs/heads/master@{#407791}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fdec47a6f1b4e7db662796344a115a72b6c0805f
Extremely long running tests can cause timeouts due to lack of output. This
adds a heartbeat message to stop that while tests are still running.
BUG=615157, 630640
Review-Url: https://codereview.chromium.org/2182563002
Cr-Original-Commit-Position: refs/heads/master@{#407576}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e8555d3785393f8bf04579226a9e39f4e574c599
We were tracking size-within-apk, and size-within-apk+extracted size,
but it's also useful to track uncompressed size for things like the
native library & dex file.
BUG=none
Review-Url: https://codereview.chromium.org/2172303002
Cr-Original-Commit-Position: refs/heads/master@{#407550}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8b895f66dfce62d1e1c9517e04d3183690c4a07d
Adding this to support building Robolectric 3.0 in Chromium.
Robolectric has several .properties files and several native
libraries that would be best to include in some of the
Robolectric jars.
BUG=
Review-Url: https://codereview.chromium.org/2044223005
Cr-Original-Commit-Position: refs/heads/master@{#406871}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5f2924f3f0b3c5070c8c192174e7680573ffb12c
Chrome has been using Jar and resources from support library for years.
In Q1 2016, Android team stops shipping jars/res for support libray.
Instead, AAR is promoted, which is a zip that wraps jars and resources.
This CL introduces a utility python script that processes an AAR file.
In GN gen time, it lists all files in the AAR, yet it does not extract
it. Actual unpacking is postponed until compilation.
Two other things to notice:
1. In the old jar we depended on, support-v13 contains support-v4 and
support-annotations. After converting to AAR, these two libraries are no
longer part of support-v13. Thus this change needs to be reflected.
2. In the new AAR format, support-v4 now contains two jars instead of
one. All public classes are in classes.jar, and all hidden classes are
in libs/internal_impl-$VERSION.jar.
This work is not possible without bajones@'s pioneering work in
https://chromiumcodereview.appspot.com/2069273002/
BUG=611171
Review-Url: https://codereview.chromium.org/2156453002
Cr-Original-Commit-Position: refs/heads/master@{#406603}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c84b9756d482be2561734a19138b41ca630f2701
We are already using GN-written list of java sources as an input for
javac and emma_instrumentation actions instead of passing all files via
command line. This CL switches lint action to use the same file. While
it isn't needed for Android Studio support which is the original reason
this source list was added, passing sources as list improves consistency
and avoids hitting a command-line limit imposed by OS (which is large
but still reachable even on Linux).
BUG=none
Review-Url: https://codereview.chromium.org/2159173002
Cr-Original-Commit-Position: refs/heads/master@{#406271}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b54d076261882c53f0dd9c9e1707debe0feafb2a
Ran into this when trying to add support for android_aar() template.
The existing logic did not play nice with the filtering done by
_FilterUnwantedDepsPaths.
It now just resolves groups at the same time as _FilterUnwantedDepsPaths
so that no other logic within the file should need to know about them.
BUG=611171
Review-Url: https://codereview.chromium.org/2141153002
Cr-Original-Commit-Position: refs/heads/master@{#405536}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 29078463073171cf034c7c5e8e9fdd18d5022fec
This supports Java auto-completion, but probably not many
more advanced features since it doesn't include resources,
assets, etc.
It also likely doesn't work for test apks yet (haven't tried it).
Usage:
build/android/generate_gradle.py \
--output-directory out/Default \
--target //chrome/android:chrome_public_apk \
--project-dir my-project-dir
BUG=620034
Review-Url: https://codereview.chromium.org/2130933002
Cr-Original-Commit-Position: refs/heads/master@{#405431}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0fa1a09f4f5418b05248c48e995ce7434970e6cc
All clients have transitioned to using the respective devil modules
directly, so these are no longer needed.
BUG=617761
Review-Url: https://codereview.chromium.org/2139133004
Cr-Original-Commit-Position: refs/heads/master@{#405260}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ea1df286ee67565024cd4ee017804e317445043
Currently, the test runner only takes action on SIGTERM on test execution
threads and only stops at the end of a test shard. In some cases, this isn't
fast enough. This CL makes the main thread drop test execution.
This CL also tweaks the handling of test results to better handle UNKNOWNs.
BUG=
Review-Url: https://codereview.chromium.org/2134523002
Cr-Original-Commit-Position: refs/heads/master@{#404507}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6c04fde85a18fc3bc8498f9735b984beaf8209c7
All suites now use isolate files that are either generated from gn
data / data_deps or checked in to chromium.
BUG=
Review-Url: https://codereview.chromium.org/2131083003
Cr-Original-Commit-Position: refs/heads/master@{#404488}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e17088df1d6f3cab29c0c817d7f71def8a84841e
Reason for revert:
Breaks ninja noticing when .java files change.
Original issue's description:
> Make Android .build_configs aware of prebuilts and java sources
>
> This information will be necessary for generating gradle projects for
> Android Studio.
>
> BUG=620034
>
> Committed: https://crrev.com/2bb3a690dc221b8a5dac4c4d99055e69ffe712b8
> Cr-Commit-Position: refs/heads/master@{#403822}
TBR=wnwen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620034
Review-Url: https://codereview.chromium.org/2126003002
Cr-Original-Commit-Position: refs/heads/master@{#403939}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 333d257e513ae47c7f4d09895079a6dc6822ec62
The existing assumption in the code (that the existense of package name
within android_resource() rules determines whether they should be
linted) turned out to be false.
The new logic does not look at package names, but instead collects all
reference resources, and then excludes any of them that were already
linted by another android_library().
BUG=621774
Review-Url: https://codereview.chromium.org/2113943002
Cr-Original-Commit-Position: refs/heads/master@{#403687}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a12be529fb88039cc3090a83c4fbaaf04e13b144
We were using GN's ordering of libraries, but GN isn't actually
providing them in dependency order. This change adds a TODO to add this
feature to GN, and in the meantime uses readelf to determine library
dependency order (as we used to do).
BUG=624791
Review-Url: https://codereview.chromium.org/2111233002
Cr-Original-Commit-Position: refs/heads/master@{#403257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb7accc611d326aaee424a64ab974e3c04abe918
Reason for revert:
breaks downstream rollers' gn gen
Original issue's description:
> Reland of Have build_config targets depend only on other build_config targets
>
> Reason for revert:
> Added missing dep for andriod_assets. Testing clean builds.
>
> TBR=brettw
> BUG=620034
>
> Committed: https://crrev.com/3df1aa821cb0298158b788bb37087460a19e52ea
> Cr-Commit-Position: refs/heads/master@{#403054}
TBR=brettw@chromium.org,petewil@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620034
Review-Url: https://codereview.chromium.org/2115543002
Cr-Original-Commit-Position: refs/heads/master@{#403140}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4cd3b19c9551a8f70842f732f289de3640b038ab
Reason for revert:
Sheriff: reverting on suspicion of breaking the android build.
It looks like the apk packaging step fails when a required component is not found. This change looked like a likely culprit since it changes the naming conventions, and the problem was file not found.
Link to failed build here:
https://build.chromium.org/p/chromium/builders/Android/builds/58342
Relevant section of build logs here:
FAILED: gen/android_webview/system_webview_apk__create_incremental__package.d gen/android_webview/system_webview_apk/system_webview_apk.apk_intermediates_incremental.unfinished.apk
python ../../build/android/gyp/apkbuilder.py --depfile gen/android_webview/system_webview_apk__create_incremental__package.d --resource-apk=gen/android_webview/system_webview_apk/system_webview_apk.apk_intermediates_incremental.ap_ --output-apk=gen/android_webview/system_webview_apk/system_webview_apk.apk_intermediates_incremental.unfinished.apk --assets=@FileArg\(gen/android_webview/system_webview_apk.build_config:assets\) --uncompressed-assets=@FileArg\(gen/android_webview/system_webview_apk.build_config:uncompressed_assets\) --dex-file=gen/build/android/incremental_install/bootstrap.dex --android-abi=armeabi-v7a --native-lib-placeholders=\[\"libfix.crbug.384638.so\"\]
Traceback (most recent call last):
File "../../build/android/gyp/apkbuilder.py", line 311, in <module>
main(sys.argv[1:])
File "../../build/android/gyp/apkbuilder.py", line 307, in main
depfile_deps=depfile_deps)
File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 527, in CallAndWriteDepfileIfStale
pass_changes=True)
File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 63, in CallAndRecordIfStale
new_metadata.AddFile(path, _Md5ForPath(path))
File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 381, in _Md5ForPath
_UpdateMd5ForFile(md5, path)
File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 362, in _UpdateMd5ForFile
with open(path, 'rb') as infile:
IOError: [Errno 2] No such file or directory: u'snapshot_blob.bin'
[34308/48394] ACTION //android_webview/test:android_webview_apk__create_incremental__package(//build/toolchain/android:arm)
FAILED: gen/android_webview/test/android_webview_apk__create_incremental__package.d gen/android_webview/test/android_webview_apk/android_webview_apk.apk_intermediates_incremental.unfinished.apk
python ../../build/android/gyp/apkbuilder.py --depfile gen/android_webview/test/android_webview_apk__create_incremental__package.d --resource-apk=gen/android_webview/test/android_webview_apk/android_webview_apk.apk_intermediates_incremental.ap_ --output-apk=gen/android_webview/test/android_webview_apk/android_webview_apk.apk_intermediates_incremental.unfinished.apk --assets=@FileArg\(gen/android_webview/test/android_webview_apk.build_config:assets\) --uncompressed-assets=@FileArg\(gen/android_webview/test/android_webview_apk.build_config:uncompressed_assets\) --dex-file=gen/build/android/incremental_install/bootstrap.dex --android-abi=armeabi-v7a --native-lib-placeholders=\[\"libfix.crbug.384638.so\"\]
Traceback (most recent call last):
File "../../build/android/gyp/apkbuilder.py", line 311, in <module>
main(sys.argv[1:])
File "../../build/android/gyp/apkbuilder.py", line 307, in main
depfile_deps=depfile_deps)
File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 527, in CallAndWriteDepfileIfStale
pass_changes=True)
File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 63, in CallAndRecordIfStale
new_metadata.AddFile(path, _Md5ForPath(path))
File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 381, in _Md5ForPath
_UpdateMd5ForFile(md5, path)
File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py", line 362, in _UpdateMd5ForFile
with open(path, 'rb') as infile:
IOError: [Errno 2] No such file or directory: u'snapshot_blob.bin'
Original issue's description:
> Have build_config targets depend only on other build_config targets
>
> This works by having android target names follow a naming convention.
> If a target name matches, then it is assumed to have a .build_config file.
> gn gen will raise an error if it doesn't. Likewise, if a target name
> does not match the filters, but does create a .build_config file, gn gen
> will fail on an assert.
>
> This change adds a bunch of naming-convention exceptions, which will
> be addressed in subsequent commits.
>
> Finally, why make this change? This allows all .build_config targets to be
> generated in just a few seconds, which will allow fast generation of
> build.gradle files for Android Studio integration.
>
> BUG=620034
>
> Committed: https://crrev.com/1029ca88161324eff7a62b1e2eecc84d5acf0f6c
> Cr-Commit-Position: refs/heads/master@{#402934}
TBR=brettw@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620034
Review-Url: https://codereview.chromium.org/2110943002
Cr-Original-Commit-Position: refs/heads/master@{#402949}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70586184529bdc819367bcdcb4dbaf41d8325559
This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.
This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.
Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.
BUG=620034
Review-Url: https://codereview.chromium.org/2095913003
Cr-Original-Commit-Position: refs/heads/master@{#402934}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1029ca88161324eff7a62b1e2eecc84d5acf0f6c
Many of the paths are within /tmp. To address those, this change adds
relevant parent directories or path to originating .zip file in order
to provide context.
BUG=621769
Review-Url: https://codereview.chromium.org/2102373002
Cr-Original-Commit-Position: refs/heads/master@{#402802}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3f9e0b4e45f6ae6a8822fa46f87b80c36f8c6339
Makes the PDF plug-in accessible on all supported platforms by building an
accessibility tree for the PDF content and grafting it on as a subtree of
the accessibility tree for the embedding page.
It exposes all of the text of the PDF, including full support for computing
the bounding box of any arbitrary text range. Using heuristics, automatically
groups the text runs into paragraphs and marks some of them as headings if
their font size is larger than the average for the page.
I wrote a browser test for this, to be reviewed in a follow-up changelist.
Currently the coordinates don't update if the user zooms. I want to fix that
by using a transformation matrix after this change lands -
http://crrev.com/2047873002 - but scrolling works fine.
Future work might include incremental loading and support for links and maybe
even fill-in forms.
Depends on:
http://crrev.com/1953053002http://crrev.com/2058453002http://crrev.com/2050973003http://crrev.com/2055903002
BUG=54724
Review-Url: https://codereview.chromium.org/2055953002
Cr-Original-Commit-Position: refs/heads/master@{#402122}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8e6fe4d789f430554f47df5085fa04a6808221c7
Without --extra-packages, we now use the same code-path
to generate the current R.java as well as dependent R.java files.
Previously, we were combing aapt's R.java with our own template.
Our custom template no longer generating assignments for non-array
styleable fields within onResourcesLoaded() (matches aapt's behaviour)
Reason for reland:
Fixed GYP issue & verified all webrtc targets compile.
TBR=jbudorick
BUG=none
Review-Url: https://codereview.chromium.org/2096763002
Cr-Original-Commit-Position: refs/heads/master@{#401653}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca0837dc170bd670dd5dc818bedaee40ad39b2c1
Reason for revert:
Relanded the wrong patchset! Missing code for excluding styleable.
Original issue's description:
> Reland #2 Refactor process_resources.py to use aapt's --extra-packages
>
> Without --extra-packages, we now use the same code-path
> to generate the current R.java as well as dependent R.java files.
> Previously, we were combing aapt's R.java with our own template.
>
> Our custom template no longer generating assignments for non-array
> styleable fields within onResourcesLoaded() (matches aapt's behaviour)
>
> Reason for reland:
> Fixed GYP issue & verified all webrtc targets compile.
>
> TBR=jbudorick
> BUG=none
>
> Committed: https://crrev.com/f3c8dfe0190ad701a9339436ff1d7f3b1e556e7d
> Cr-Commit-Position: refs/heads/master@{#401624}
TBR=jbudorick@chromium.org,phoglund@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2097583002
Cr-Original-Commit-Position: refs/heads/master@{#401637}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1459934bc93f7668b3b6b73d3fe4b739a909181c
Without --extra-packages, we now use the same code-path
to generate the current R.java as well as dependent R.java files.
Previously, we were combing aapt's R.java with our own template.
Our custom template no longer generating assignments for non-array
styleable fields within onResourcesLoaded() (matches aapt's behaviour)
Reason for reland:
Fixed GYP issue & verified all webrtc targets compile.
TBR=jbudorick
BUG=none
Review-Url: https://codereview.chromium.org/2096693002
Cr-Original-Commit-Position: refs/heads/master@{#401624}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3c8dfe0190ad701a9339436ff1d7f3b1e556e7d
Reason for revert:
Broke webrtc GYP rules.
Original issue's description:
> Reland: Refactor process_resources.py to use aapt's --extra-packages
>
> Reason for Reland:
> - No longer generating assignments for non-array styleable fields within
> onResourcesLoaded() (matches aapt's behaviour)
>
> We actually never pass --include-all-resources, so this is just
> refactoring dead code. I think it's an improvement though,
> as the new comments explain more of why things work the way they do.
>
> TBR=agrieve
> BUG=none
>
> Committed: https://crrev.com/c04a207f591c1cae455fee6c9c7d8b0dbca20abe
> Cr-Commit-Position: refs/heads/master@{#401355}
TBR=jbudorick@chromium.org,phoglund@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2090303003
Cr-Original-Commit-Position: refs/heads/master@{#401595}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 932350f8583c875a222df3c3b7d9913418a2fe54
Reason for revert:
broke
Original issue's description:
> Roll internal Google Play Services (Chromium part)
>
> BUG=613768
>
> TBR=jbudorick@chromium.org,agrieve@chromium.org,mariakhomenko@chromium.org
> NOTRY=true
>
> (skipping trybots because previous, identical patch
> passed CQ, and because this is needed to fix the tree)
>
> Committed: https://crrev.com/c3199997a359e45fee3526111b4a5d25d8e6ea1b
> Cr-Commit-Position: refs/heads/master@{#401419}
TBR=jbudorick@chromium.org,agrieve@chromium.org,mariakhomenko@chromium.org,sgurun@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=613768
Review-Url: https://codereview.chromium.org/2095473002
Cr-Original-Commit-Position: refs/heads/master@{#401454}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ad7108b358c2707f0bd42e60cceb73f97830860
This is in place of readelf / write_ordered_libaries.py.
Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.
BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2082453003
Cr-Original-Commit-Position: refs/heads/master@{#401398}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 48bd27ea3fd3b86e352d6a7a8e4e70b0c711ae78
Reason for Reland:
- No longer generating assignments for non-array styleable fields within
onResourcesLoaded() (matches aapt's behaviour)
We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.
TBR=agrieve
BUG=none
Review-Url: https://codereview.chromium.org/2083383003
Cr-Original-Commit-Position: refs/heads/master@{#401355}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c04a207f591c1cae455fee6c9c7d8b0dbca20abe
Reason for revert:
Broke internal android bots
https://crbug.com/622212
Original issue's description:
> Refactor process_resources.py to use aapt's --extra-packages
>
> We actually never pass --include-all-resources, so this is just
> refactoring dead code. I think it's an improvement though,
> as the new comments explain more of why things work the way they do.
>
> BUG=none
>
> Committed: https://crrev.com/9882d61c25bbebe84e82a7d559cae6f0807a4775
> Cr-Commit-Position: refs/heads/master@{#401165}
TBR=smaier@chromium.org,wnwen@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2090543002
Cr-Original-Commit-Position: refs/heads/master@{#401240}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1483bad27eb01f8f4980be7adf55fc96de0fda5d
javac.py uses a regex to strip the parts after the base filename, e.g.
Foo.class or Foo$Bar.class should produce Foo. However, it fails to
strip .class from file names without a $. This corrects the regex.
BUG=619752
Review-Url: https://codereview.chromium.org/2079673002
Cr-Original-Commit-Position: refs/heads/master@{#401177}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14af73781b9d5372e205b01356004015c2b005ec
We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.
BUG=none
Review-Url: https://codereview.chromium.org/2081473002
Cr-Original-Commit-Position: refs/heads/master@{#401165}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9882d61c25bbebe84e82a7d559cae6f0807a4775
proguard.py filters out the newly added entry, so this change is
entirely a no-op. Makes the code a bit more understandable imo.
BUG=none
Review-Url: https://codereview.chromium.org/2083683002
Cr-Original-Commit-Position: refs/heads/master@{#400772}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c34096a861aad0076fd89975ba97143e8b46135d
Reason for revert:
downstream part broke
Original issue's description:
> Roll internal Google Play Services (Chromium part)
>
> BUG=613768
>
> Committed: https://crrev.com/27d98c86363d66c877e8ca29c1d34e3578eaa179
> Cr-Commit-Position: refs/heads/master@{#400736}
TBR=agrieve@chromium.org,mariakhomenko@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=613768
Review-Url: https://codereview.chromium.org/2085723002
Cr-Original-Commit-Position: refs/heads/master@{#400754}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ddd5ccd700c4859e47282fce3e87e3e590b7b2a
Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.
This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.
Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.
Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.
BUG=595810
Review-Url: https://codereview.chromium.org/2062633002
Cr-Original-Commit-Position: refs/heads/master@{#400727}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 18749bd362a7a8b7f4c1185c838d724dea5fad85
Reason for revert:
CL wasn't responsible for the v8 breakage
Original issue's description:
> Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #4 id:60001 of https://codereview.chromium.org/2039363002/ )
>
> Reason for revert:
> Possibly breaking v8 perf bots.
>
> Original issue's description:
> > [Android] Ensure perf test runner does not create shards for blacklisted devices.
> >
> > BUG=617559
> >
> > Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
> > Cr-Commit-Position: refs/heads/master@{#398197}
>
> TBR=jbudorick@chromium.org,perezju@chromium.org,mikecase@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=617559
>
> Committed: https://crrev.com/c89b1748ad3fee34318dd63b32e881a7361743ce
> Cr-Commit-Position: refs/heads/master@{#399460}
TBR=jbudorick@chromium.org,mikecase@chromium.org,rnephew@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617559
Review-Url: https://codereview.chromium.org/2084493003
Cr-Original-Commit-Position: refs/heads/master@{#400659}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e0ce69beeada5f4918d278c5cf8afe10165e84ce
Replace previous hand-rolled shell commands with more robust
alternatives from device_utils.
In particular "install_metadata", which used to be just the
output of "ls -l" on the device, is now a list of dictionaries
with stat file data for each installed package on the device.
BUG=552376
Review-Url: https://codereview.chromium.org/2069113002
Cr-Original-Commit-Position: refs/heads/master@{#400123}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 40cb86544a3c7f5fc2cca51dc181624b2995eed8
While contents of python dependencies doesn't affect contents of a depfile it
definitely affects the output: typical usage of CallAndWriteDepfileIfStale only
regenerates script's output if md5 sum changes, in a helper function. If content
of the python file (like lint.py) isn't used to generate md5 then it leads to
weird results: do a full build, change lint.py to always throw exception in
_OnStaleMd5, re-run build, but nothing happens, _OnStaleMd5 isn't called.
BUG=619329
Review-Url: https://codereview.chromium.org/2061573002
Cr-Original-Commit-Position: refs/heads/master@{#400012}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3218d50d461833795d64c71f8b4c0517e58a8b50
See bug, apparently it's "an up-to-date thing" but "thing is up to date".
The bug is only about grd files, but I went through `git grep -l up-to-date`
while I was at it.
BUG=344535
TBR=IPC owner
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2059143002
Cr-Original-Commit-Position: refs/heads/master@{#399698}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3e861deabe8e47db274ed779acc1a3b80837e16d
Reason for revert:
Possibly breaking v8 perf bots.
Original issue's description:
> [Android] Ensure perf test runner does not create shards for blacklisted devices.
>
> BUG=617559
>
> Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
> Cr-Commit-Position: refs/heads/master@{#398197}
TBR=jbudorick@chromium.org,perezju@chromium.org,mikecase@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617559
Review-Url: https://codereview.chromium.org/2059253002
Cr-Original-Commit-Position: refs/heads/master@{#399460}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c89b1748ad3fee34318dd63b32e881a7361743ce
Reason for revert:
Speculative revert as it seems to be crashing the host_info step on all Android bots.
BUG=619342
Original issue's description:
> [Android] Use devil for status and recovery in bb_device_status_check.
>
> BUG=619045
>
> Committed: https://crrev.com/391365fc50704855ec9eeb91c53cbe0d47d229e9
> Cr-Commit-Position: refs/heads/master@{#399350}
TBR=rnephew@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619045
Review-Url: https://codereview.chromium.org/2063563002
Cr-Original-Commit-Position: refs/heads/master@{#399379}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 411b1fdaa505528a049701676bc801803cd91bff
Fixing provision devices script failing if timeout is not manually
set and one of the devices is unresponsive.
BUG=619088
Review-Url: https://codereview.chromium.org/2059863002
Cr-Original-Commit-Position: refs/heads/master@{#399270}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39419395ebe93d10dde4107415decb81ae851eb4
Executable tests return a nonzero exit code on test failure, which is
fine from the test runner's perspective.
BUG=pdfium:415
Review-Url: https://codereview.chromium.org/2050473007
Cr-Original-Commit-Position: refs/heads/master@{#399026}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9c97682478b816179cd0ac920e202a7b83a0f241
Migrate some previous uses of the (now deprecated) Ls method, and
instances of hand rolled shell 'ls' commands to the new available
methods.
Also a bit of cleanup on RunShellCommand uses.
BUG=552376
Review-Url: https://codereview.chromium.org/2045833004
Cr-Original-Commit-Position: refs/heads/master@{#398907}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5ad37228088780af64b5a8a5d8f2ece618f4ae3e
Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.
Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.
TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org
BUG=607169,617213,616155
Review-Url: https://codereview.chromium.org/2043803003
Cr-Original-Commit-Position: refs/heads/master@{#398601}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d4d66d4d0353020ddf9f1423d08cf39ed911c329
Reason for revert:
Breaking quota-related tests in content_browsertests
https://crbug.com/617213
Original issue's description:
> Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root
>
> Reason for reland:
> Updated webview tests that broke (WebViewLayoutTest.java)
>
> And use delete_device_stale=True when pushing. This will prevent tests
> mistakenly passing when they depend on stale data files from a previous test.
>
> TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
> BUG=607169
>
> Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> Cr-Commit-Position: refs/heads/master@{#396479}
TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=607169,617213,616155
Review-Url: https://codereview.chromium.org/2044523003
Cr-Original-Commit-Position: refs/heads/master@{#398137}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55ff9438e11da5a78a6ba5d100cebfcfdbc07deb
Robolectric uses javac annotation processors when building. This
means it will need to pass some "-processor RobolectricProcessor" to
javac as well as some "-Akey=value" args
Additionally, since this processor is run by javac, Robolectric can't
be compiled using the interface.jars. This is why I am adding an
enable_interface_jars_javac option for GN.
Finally, Robolectric uses the Java services functionality. I will
need to add some configs to the META-INF/services/ dir in the
Robolectric jars for this to work correctly. This is the purpose
of the --provider-configurations option I am adding.
BUG=
Review-Url: https://codereview.chromium.org/2014983003
Cr-Original-Commit-Position: refs/heads/master@{#397262}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14569c856b4cd3a362f89a3b913f744b9a210732
Reason for reland:
Updated webview tests that broke (WebViewLayoutTest.java)
And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.
TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org
BUG=607169
Review-Url: https://codereview.chromium.org/2018663002
Cr-Original-Commit-Position: refs/heads/master@{#396479}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2524a0db714a44fbce723e00f6ed914e6d143cb6
ANGLE Android tests use native OpenGL ES rendering,
and require NativeActivity to provide the rendering surface.
Existing tests should keep using Activity,
as they don't implement ANativeActivity_onCreate().
BUG=angleproject:1362
TEST=Compile angle_end2end_tests
Review-Url: https://codereview.chromium.org/1975153003
Cr-Original-Commit-Position: refs/heads/master@{#396361}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 389d9e445c27af560f0d370a2f9f3c69b0dd812d
And use delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.
BUG=607169
Review-Url: https://codereview.chromium.org/1926793002
Cr-Original-Commit-Position: refs/heads/master@{#396169}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0fe567512193cc8fbfcfd006ff1d504bd6346290
--coverage-dir option for junit tests should take directory name, not file name.
With the change, we are able to run the command like this:
'out-gn/Debug/bin/run_clank_junit_tests --coverage-dir /tmp/coverage/junit'.
Then clank_junit_test.ec will be created in the junit directory.
BUG=
Review-Url: https://codereview.chromium.org/2003213002
Cr-Original-Commit-Position: refs/heads/master@{#395936}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9b5e71a566772a1a80d3e670ed584f60bce71df
Reason for revert:
Async request for zoom level doesn't work in all cases https://crbug.com/614348https://crbug.com/613979.
I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful.
Original issue's description:
> Add FrameHost mojo service
>
> Adds new frame-level service with one initial method to handle host zoom
> level.
>
> This moves zoom level supply from async_resource_handler.cc to being a
> request made when render_frame_impl handles a willSendRequest.
>
> The goal of this change is to remove the dependency of
> content/browser/loader on the rest of content/browser in particular
> here, removing the use of c/b/host_zoom_map_impl.h in
> content/browser/loader/async_resource_handler.cc.
>
> BUG=598073,609607
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911
> Cr-Commit-Position: refs/heads/master@{#394547}
TBR=dcheng@chromium.org,ben@chromium.org,jam@chromium.org,nasko@chromium.org,wjmaclean@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=598073,609607,614348,613979
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2007203002
Cr-Original-Commit-Position: refs/heads/master@{#395761}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b
--screenshot option was broken for instrumentation tests. In this cl,
the option is enabled. With argument --screenshot, the device will take
a screenshot whenever an instrumentation test fails.
BUG=613405
Review-Url: https://codereview.chromium.org/1998383002
Cr-Original-Commit-Position: refs/heads/master@{#395662}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 35d5e3dd14ae616db29806f3052b400f2de1945a
I killed an ongoing build and a zip file got corrupted. Then all
subsequent builds were failing, but I didn't know where.
This adds/clears up the message IMO.
Previous output:
File "/...../src/build/android/gyp/util/build_utils.py", line 228, in
ExtractAll
with zipfile.ZipFile(zip_path) as z:
File "/usr/lib/python2.7/zipfile.py", line 770, in __init__
self._RealGetContents()
File "/usr/lib/python2.7/zipfile.py", line 811, in _RealGetContents
raise BadZipfile, "File is not a zip file"
zipfile.BadZipfile: File is not a zip file
New output:
File "../../build/android/gyp/javac.py", line 90, in
_ExtractClassFiles
build_utils.ExtractAll(jar_path, path=dest_dir,
predicate=extract_predicate)
File "/...../src/build/android/gyp/util/build_utils.py", line 229, in
ExtractAll
raise Exception('Invalid zip file: %s' % zip_path)
Exception: Invalid zip file: gen/base/base_java__compile_java.javac.jar
BUG=
Review-Url: https://codereview.chromium.org/2001353002
Cr-Original-Commit-Position: refs/heads/master@{#395545}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e8198a4d058fb88e7d4314587a0f0e8992a31c15
Fixed coverage dir option for instrumentation tests, so that we should
be able to pull run time coverage data from devices to bot.
BUG=608072
Review-Url: https://codereview.chromium.org/1964183003
Cr-Original-Commit-Position: refs/heads/master@{#395419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 111b5841249ab4c8e14ed1b0af2328d5e739a140
Reason for revert:
breaks downstream
Original issue's description:
> Added the --screenshot option.
>
> --screenshot option was broken for instrumentation tests. In this cl,
> the option is enabled. With argument --screenshot, the device will take
> a screenshot whenever an instrumentation test fails.
>
> BUG=611538
>
> Committed: https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c
> Cr-Commit-Position: refs/heads/master@{#394843}
TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=611538
Review-Url: https://codereview.chromium.org/1998903002
Cr-Original-Commit-Position: refs/heads/master@{#394956}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd
--screenshot option was broken for instrumentation tests. In this cl,
the option is enabled. With argument --screenshot, the device will take
a screenshot whenever an instrumentation test fails.
BUG=611538
Review-Url: https://codereview.chromium.org/1981043004
Cr-Original-Commit-Position: refs/heads/master@{#394843}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 09891bc02742f34a11a6d8ffd8993066f6c1b62c
Replace checks for Build.VERSION.CODENAME.equals("N") wieth
Build.VERSION.CODENAMES.equals("N") || Build.VERSION.SDK_INT > Build.VERSION_CODES.M.
Eventually we will want the check to be just for SDK_INT, but for M51 we'll
use the ||.
BUG=586703
Review-Url: https://codereview.chromium.org/1989203003
Cr-Original-Commit-Position: refs/heads/master@{#394615}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96a31a443985b11f125797d32f837eff42f2efb3
Adds new frame-level service with one initial method to handle host zoom
level.
This moves zoom level supply from async_resource_handler.cc to being a
request made when render_frame_impl handles a willSendRequest.
The goal of this change is to remove the dependency of
content/browser/loader on the rest of content/browser in particular
here, removing the use of c/b/host_zoom_map_impl.h in
content/browser/loader/async_resource_handler.cc.
BUG=598073,609607
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1964273002
Cr-Original-Commit-Position: refs/heads/master@{#394547}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 68c6f2ce16d9807b5cb82679099c82c40f39e911
scottmg
perezju
jbudorick
estevenson
smaier
xunjieli
hzl
maxbogue
asvitkine
primiano
kozyatinskiy
mmenke
stip
mathp
rnephew
peconn
agrieve
mikecase
ianwen
pkotwicz
mlopatkin
bpastene
skobes
benwells
petewil
yolandyan
paulmiller
dmazzoni
thakis
sammc
fmeawad
ynovikov
tedchoc
twellington