Rather than globally defining NO_HEAPCHECKER and then checking
that in build_config.h, let builds that opt in to heap checking
directly set USE_HEAPCHECKER.
Result should be equivalent builds but less stuff in the build
files.
Review URL: http://codereview.chromium.org/9146022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This replaces the aura_show_about_flag_window_mode and
chromeos_legacy_power_button GYP flags with
--aura-force-compact-window-mode and
--aura-legacy-power-button command-line switches. There is
concern that using compile-time flags to control these
features will greatly increase the workload on the Chrome OS
builders; we apparently currently share Chrome binaries
across all Chrome OS boards with the same architecture.
BUG=109209,109052,chrome-os-partner:7570
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9264025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118522 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change toggles the build_webkit_exes_from_webkit_gyp file to 0,
so that we try to build DumpRenderTree and webkit_unit_tests from their
corresponding .gyp files (WebKitUnitTests.gyp and Tools.gyp) rather than
the old WebKit.gyp file. This breaks the circular dependencies between
the executables which depend on webkit_support, which depends on
WebKit.gyp. We now only use the 'webkit' target itself in WebKit.gyp.
R=tony@chromium.org
BUG=105826
TEST=waterfall stays green
Review URL: https://chromiumcodereview.appspot.com/8889039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118366 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
According to my testing, VS 2010 does not have problem (b) documented
at http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders,
i.e. it rebuilds the PCH file when necessary because of
e.g. preprocessor flag changes.
Since we aren't using VS 2010 for official builds, if problem (a) (out
of memory) is encountered with VS 2010 when we make the switch to
using it for official builds, we can simply turn PCH off explicitly in
the include.gypi for the official bots.
This change has no effect on VS 2008 bots or users.
BUG=110001
Review URL: http://codereview.chromium.org/9139059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@117845 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) Actually turn off ASLR for Debug build.
Despite the comments, this was not happening in reality
because the /dynamicbase linker flag overrode the
VCLinkerTool.RandomizedBaseAddress setting.
2) Make the ASLR setting configurable from outside
(target usage is for particular Dr. Memory builds).
TEST=Built googleurl_unittests and ensured its ALSR setting matched that requested, both for default and for custom via new gyp var
BUG=109767
Review URL: http://codereview.chromium.org/9169020TBR=bruening@chromium.org
Review URL: http://codereview.chromium.org/9194003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@117586 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) Actually turn off ASLR for Debug build.
Despite the comments, this was not happening in reality
because the /dynamicbase linker flag overrode the
VCLinkerTool.RandomizedBaseAddress setting.
2) Make the ASLR setting configurable from outside
(target usage is for particular Dr. Memory builds).
TEST=Built googleurl_unittests and ensured its ALSR setting matched that requested, both for default and for custom via new gyp var
BUG=109767
Review URL: http://codereview.chromium.org/9169020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@117533 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Most official Chrome OS hardware reports power button
releases correctly, but on standard x86 systems, we'll always
receive a button up event just after the button down. This
change adds a chromeos_legacy_power_button gyp flag; when
set, we lock the screen or shut down immediately when the
button is pressed instead of providing interactive
animations.
BUG=109209
TEST=added tests; also did manual testing
Review URL: http://codereview.chromium.org/9110044
git-svn-id: http://src.chromium.org/svn/trunk/src/build@116993 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fixes a regression that caused fullscreen
RenderWidgetHostViewAuras to decline the focus, resulting in
them not receiving key events.
BUG=107804
TEST=manually checked that Space and Escape now work in fullscreen YouTube videos; also added a test
Review URL: http://codereview.chromium.org/9026013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@115855 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We've been getting a bunch of extra gpu-related crashes recently, and while they don't seem to be related to swiftshader (the timing is a bit off) it's possible, so try to rule that out.
BUG=26001
TEST=
Review URL: http://codereview.chromium.org/9021039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@115534 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- "size"; optimizes for minimal code size, the default.
- "speed"; optimizes for speed over code size.
- "max"; turns on link time code generation and whole
program optimization, which is very expensive and should
be used sparingly.
Note that this change by itself lowers the optimization level to "size" for all targets. Separate changes to the V8 and WebKit repos will be needed to bring up their optimization levels to WPO.
BUG=108167
TEST=
Review URL: http://codereview.chromium.org/8983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@115187 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Register with the component updater service if it's discovered that WebGL is blacklisted. Then register the swiftshader library with the GPU data manager.
BUG=26001
TEST=Start up chrome on a blacklisted windows machine, wait a while, and open a webgl page
Review URL: http://codereview.chromium.org/8897008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@114885 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is intended to make it easier to test Breakpad crash dumping on
the buildbots. Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.
The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.
This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler(). Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().
This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files. This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.
BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
should appear in ~/Library/Application Support/Chromium/Crash Reports
Review URL: http://codereview.chromium.org/8824003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@114468 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The chromeos-chrome ebuild strips Chrome tests after the build, but it
can run significantly faster if we strip them during the build. This
changelist reduces the time it takes to build Chrome by allowing
developers to remove unnecessary debug symbols.
Performance comparison on z600 LOCAL_SOURCE build:
Before: 24m31s (257m04s user, 23m19s sys)
After: 20m55s (236m12s user, 22m10s sys)
Companion CL for updating Chrome OS to use strip_tests by default is here:
https://gerrit.chromium.org/gerrit/11517
BUG=chromium-os:22844
TEST=Build with and without debug symbols. Confirm speed difference.
Review URL: http://codereview.chromium.org/8526022TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/8659015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@111778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c