This series is to
a) Add my name to AUTHORS
I have few patches to submit to fix the chromium 64bit browser
build for ARMv8 with clang.
b) Fix FPCR access for 64bit clang compilation
Compilation fails as the MSR and MRS instructions access
the FPCR register in 32bit mode.
c) Fix Build.gn and config files
To build 64bit browser for Android with clang for ARMv8
BUG : http://crbug.com/539781
Signed-off-by: Bernhard Rosenkränzer <bero@linaro.org>
Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@linaro.org>
BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
Review-Url: https://codereview.chromium.org/1888763002
Cr-Original-Commit-Position: refs/heads/master@{#393517}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2c5ec51ea564705b02dcb6aeff6a56722cc3890f
Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.
BUG=585576
Review-Url: https://codereview.chromium.org/1952153002
Cr-Original-Commit-Position: refs/heads/master@{#392620}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd2adf0e9718ec28f46dde4c09e379c9df82065e
Some were obsolete, some I implemented in this patch. Some I left as-is if they applied to Mac or iOS.
A few items are TODOs for when transition is complete. I changed these to "TODO(GYP_GONE)"
This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1953523002
Cr-Original-Commit-Position: refs/heads/master@{#391943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9427f9e3edb7be9bd540bb35b3d3156c08c3df6
These no longer contain private sources so can be build upstream.
Lots of clean-up and unification remains but this is the first
step to building these targets upstream.
BUG=607207
Review-Url: https://codereview.chromium.org/1948503002
Cr-Original-Commit-Position: refs/heads/master@{#391501}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 561f24772cc36822699e90e7ee3842f7c301b0cb
The documentation for forward_variables_from specifies that it will give an error if the variable already exists in the target scope. But this was not implemented. Instead, the value would be silently overwritten.
This change implements the error, and fixes the times this happens in the Linux and Android builds.
Review-Url: https://codereview.chromium.org/1943583002
Cr-Original-Commit-Position: refs/heads/master@{#391136}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0785c950dce7221b10c21e911795e181076b90db
After setting emma_coverage as true, and then run JUnit testcases, code
coverage information will be stored in coverage.ec. In order to read
coverage.ec file, you will need to find the corresponding <name>.em file
in out-gn/Debug and then merge the .em and .ec file into a txt or html.
BUG=604900
Review URL: https://codereview.chromium.org/1913593002
Cr-Original-Commit-Position: refs/heads/master@{#389902}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 071f7c486154a89e15c8b796a8bd0f64573a7096
Internal Chromecast jinja_template targets need to depend on targets
which generate parameters for the template. Forward "deps" to the
underlying action in order to enforce these dependencies correctly.
BUG= b/28381705
Review URL: https://codereview.chromium.org/1922613004
Cr-Original-Commit-Position: refs/heads/master@{#389623}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e83bcc73e7f0339971d97a553f7ef29d3a95c2dc
Contains fix for ui_base_tests not having data set correctly for android.
TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,apacible@chromium.org
NOTRY=true
BUG=589318
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1916503002
Cr-Original-Commit-Position: refs/heads/master@{#389470}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e41ae190dadf81f1561c8cdfd8b308b213817210
Now uses gen.runtime rather than gen to be included by
builder/tester configurations.
TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,agrieve@chromium.org
NOTRY=true
BUG=589318
Review URL: https://codereview.chromium.org/1914573002
Cr-Original-Commit-Position: refs/heads/master@{#389148}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5d205baf70287fec693da0166aa7aa8051b5985e
Tests use write_runtime_deps to have GN write out all runtime_deps, then
use a new script "generate_isolate.py" to filter the files and create a
.isolate.
TBR=vollick
BUG=589318
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1904823003
Cr-Original-Commit-Position: refs/heads/master@{#389105}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 964da0f3923afb10a52dfe81484d7f3dcb18bad6
If we set emma_coverage as true, and do not set --filter-string in
args.gn, build will fail because --filter-string is mandatory. In this
cl, I am making --filter-string optional for emma_coverage.
BUG=
Review URL: https://codereview.chromium.org/1905523002
Cr-Original-Commit-Position: refs/heads/master@{#388413}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a18734145371ec315fb356119e63fb3c0661437
The dependency should actually be the other way around, but
for compatibility with GYP, it has to go this way.
BUG=599919
Review URL: https://codereview.chromium.org/1893063002
Cr-Original-Commit-Position: refs/heads/master@{#388126}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b355ad15304acb0a769d76bd634cb5167e62e96f
Icecc is confused by the two-argument "-target x" form, and decides to compile
everything locally. --target=x makes it happy.
Review URL: https://codereview.chromium.org/1871813003
Cr-Original-Commit-Position: refs/heads/master@{#386419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e4199397e4c6f32cf6a561e33581d59b5a7a0e9e
Lint's stderr filter actually was dropping all output of the tool
instead of just single 'Picking up _JAVA_OPTIONS' line. Fixing this
revealed a lot of internal lint errors.
Most of them were CRC errors from interface JARs, so I switched back to
use normal JARs.
Others were internal errors of InvalidPackageName check which was trying
to check Android SDK classes, because these classes were added to
classpath as a jar. It turns out that Lint treats SDK jar differently but
only if it is properly specified. The only way to tell Lint which SDK
jar to use is to create project.properties file (like in old Ant-based
build). So lint.py now accepts SDK version as a command-line argument
and creates dummy project.properties in temporary folder.
BUG=599052
Review URL: https://codereview.chromium.org/1870073002
Cr-Original-Commit-Position: refs/heads/master@{#386188}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ef5e20f9fe84651ca03fb53ed15910121cedfc0a
Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.
BUG=359249
Review URL: https://codereview.chromium.org/1865853002
Cr-Original-Commit-Position: refs/heads/master@{#385679}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 81f01675f95fdf819d374b36234765d7dcb228ab
annotations such as: @IntDef, @MainThread, etc
warnings such as: HandlerLeak, MissingSuperCall, ValidFragment
Problem was that we were not passing lint the classpath.
This change is GN-only since GYP lint warnings fail the build.
Will follow-up with a GYP change once warnings are fixed.
BUG=599052
Review URL: https://codereview.chromium.org/1847823003
Cr-Original-Commit-Position: refs/heads/master@{#385373}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eb3dd1ad7c04c091faf285aa2f78da0b7cec7a76
This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).
This change fixes the generated wrapper scripts, which didn't work.
TBR=jbudorick
BUG=589318
Review URL: https://codereview.chromium.org/1854233002
Cr-Original-Commit-Position: refs/heads/master@{#385084}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62ab0028a0165eecd60568783531d1ad3d031a26
Reason for revert:
Still breaking bots:
crbug.com/600342
Original issue's description:
> Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()
>
> Reason for revert:
> Now doesn't use obj/ directory
>
> This simplifies build rules for native tests, and allows us to get rid
> of ${target}_deps targets (once recipes are updated).
>
> This change fixes the generated wrapper scripts, which didn't work.
>
> TBR=jorgelo
> BUG=589318
>
> Committed: https://crrev.com/66605a610bce190e818ebfc73913a126c025ffb3
> Cr-Commit-Position: refs/heads/master@{#384658}
TBR=mark@chromium.org,dpranke@chromium.org,jorgelo@chromium.org,jbudorick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=589318
Review URL: https://codereview.chromium.org/1858683002
Cr-Original-Commit-Position: refs/heads/master@{#384949}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e30b022bb758a10e9ecea81d5433bd1e046ccac4
Reason for revert:
Now doesn't use obj/ directory
This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).
This change fixes the generated wrapper scripts, which didn't work.
TBR=jorgelo
BUG=589318
Review URL: https://codereview.chromium.org/1854733003
Cr-Original-Commit-Position: refs/heads/master@{#384658}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 66605a610bce190e818ebfc73913a126c025ffb3
Reason for revert:
breaks both suites on GN, e.g. https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester
Original issue's description:
> GN: Make breakpad_unittests & sandbox_linux_unittests use test()
>
> This simplifies build rules for native tests, and allows us to get rid
> of ${target}_deps targets (once recipes are updated).
>
> This change fixes the generated wrapper scripts, which didn't work.
>
> BUG=589318
>
> Committed: https://crrev.com/638c8c12c9cd5086d4ba8704852cb1167e7b4ae9
> Cr-Commit-Position: refs/heads/master@{#384348}
TBR=mark@chromium.org,dpranke@chromium.org,jorgelo@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589318
Review URL: https://codereview.chromium.org/1848033005
Cr-Original-Commit-Position: refs/heads/master@{#384571}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cb514fa85364e415c7ce4f6a8365e78a00fe7dfb
This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).
This change fixes the generated wrapper scripts, which didn't work.
BUG=589318
Review URL: https://codereview.chromium.org/1841193002
Cr-Original-Commit-Position: refs/heads/master@{#384348}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 638c8c12c9cd5086d4ba8704852cb1167e7b4ae9
These files are used by QuicTestServer & PkpTest. They're currently handled
as a special case in //build/android/pylib/instrumentation/setup.py that I'd
like to get rid of.
BUG=
Review URL: https://codereview.chromium.org/1826313003
Cr-Original-Commit-Position: refs/heads/master@{#383232}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e18e7a6d2e1971e9b50b0ca3fe1fc9f17b264193
No longer trying to guess name of cached .bin file.
Previous commit forgot to set --cache-dir for GN.
BUG=583661,597251
Review URL: https://codereview.chromium.org/1828693002
Cr-Original-Commit-Position: refs/heads/master@{#382871}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 070509bda8b8b74d8963907bd5f79909da043c34
Reason for revert:
Breaks on Android 64bit unpublished builders
BUG=597251
Original issue's description:
> Android: Run lint using a cache in the output directory (fix-up)
>
> Previous commit forgot to set --cache-dir for GN.
>
> BUG=583661
>
> Committed: https://crrev.com/99748af41ad073389f3f38274a024a830585609c
> Cr-Commit-Position: refs/heads/master@{#382699}
TBR=jbudorick@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583661
Review URL: https://codereview.chromium.org/1829683002
Cr-Original-Commit-Position: refs/heads/master@{#382838}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62cc80409b326670a7faafb3db806451fa6cc812
The system linker in Android M and later unpacks packed relocations
directly. This means that we can unconditionally enable relocation
packing for any APK that is explicitly designed to only run on such
Android releases, irrespective of whether or not the chromium or
other customized linker is used.
Invoker indicates this by setting requires_sdk_api_level_23 to true.
BUG=579610
Review URL: https://codereview.chromium.org/1801893003
Cr-Original-Commit-Position: refs/heads/master@{#381246}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 18d74636c85eb974ef00883f54cb06381ea123f6
khasim.mohammed
agrieve
jbudorick
brettw
yfriedman
hzl
slan
apacible
michaelbai
tsniatowski
mlopatkin
mikecase
aberent
mnaganov