Граф коммитов

2393 Коммитов

Автор SHA1 Сообщение Дата
sgk@google.com 208bd6d9b4 Finish release (opt) builds on Windows, including the parallel
build\*.scons structure (mirroring build\*.vsprops files):
* Use env.ApplySConscript() instead of env.SConscript with a
  hand-crafted dictionary defining 'env'.
* Move various CPPPATH, CCFLAGS, CPPDEFINES, LIBS and LIBPATH
  definitions from build/SConscript.main and target-specific 
  *.scons files into the build\*.scons files that mirror the
  existing build\*.vsprops hierarchy.
* Use the new build\{debug,release}.scons files to update the
  windows_dbg and windows_opt construction environments.
* Mirror current support for CHROME_BUILD_TYPE and CHROMIUM_BUILD
  external environment variables.
* Remove hard-coded /TP options.
* Massage $CXXFLAGS to remove $CCFLAGS, avoiding duplication of options
  on command lines.  Handle the ripple effect in $PCHCOM by adding
  $CCFLAGS back to that command line.
* Delete hammer's default settings of {CC,LINK}FLAGS_{DEBUG,OPTIMIZED}
  so they don't pollute our construction environments.
* Update chrome config to link against v8 for opt, v8_g for dbg.
* Get rid of fragile by-hand order of using_net.scons before other
  using_*.scons files.  We're now using --start-group and --end-group
  on Linux to deal with dependency cycles in libraries.
Review URL: http://codereview.chromium.org/11478

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5741 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-20 01:12:38 +00:00
deanm@chromium.org e434344159 Don't build with exception support, we don't use exceptions.
This makes the output executable substantially smaller because it won't emit .eh_frame and .eh_frame_hdr header sections.  These were previously ~1.2mb for an opt test_shell.

Review URL: http://codereview.chromium.org/11265

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-19 08:16:31 +00:00
mmoss@google.com 40dbba5eda Add Linux lighttpd for running LayoutTests on Linux.
Updated to use system lighttpd and php-cgi. This is based on the Hardy packages and file layout. YMMV with other distros.

BUG=4281

Review URL: http://codereview.chromium.org/10653


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5633 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-18 20:56:29 +00:00
mmoss@google.com 745177d267 Add platform_utils and stub test lists for Linux.
This allows the LayoutTest harness to run on Linux. Note that the tests still
don't run properly because Linux test_shell is missing the ability to read URLs
from stdin (causing the test_shell to just sit there waiting for input). I'll
add that in another CL.

BUG=4281

Review URL: http://codereview.chromium.org/10413


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-17 20:05:05 +00:00
tony@chromium.org 963426065d Fix the mac build to add dmg_fp to the libbase.a.
Remove third_party/dmg_fp complete since nothing else depends on it.

Review URL: http://codereview.chromium.org/10963


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5525 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-15 01:40:31 +00:00
tc@google.com b53e4e50cd Move dmg_fp in scons build to compile from
base/third_party/dmg_fp and compile it into base_lib.

Review URL: http://codereview.chromium.org/10769

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5521 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-15 00:53:54 +00:00
sgk@google.com 6a98bfc462 Add a webkit.scons file in between build\SConscript.main and
webkit\SConscript, as a place for calling renamed *.scons files.
Add 'webkit' and 'chrome'  COMPONENT_PROGRAM_GROUPS and
COMPONENT_TEST_PROGRAM_GROUPS so the generated .exe files get
copied correctly into the Hammer\ build subdirectory.
Review URL: http://codereview.chromium.org/10768

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5518 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 23:29:55 +00:00
sgk@google.com 1e723fddbe More *.scons renaming:
* Rename SConscript to *.scons in the following directories:
  third_party\{bspatch,bsdiff,lzma_dsk}
  chrome\installer\{setup,mini_installer,util}
* Split mini_installer and installer_unittests into separate *.scons files.
* Add using_bspatch.scons and using_lzma_sdk.scons "properties" files,
  modifying other *.scons files to use them as appropriate.
Review URL: http://codereview.chromium.org/10952

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5515 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 23:00:46 +00:00
scherkus@chromium.org 472df4f13a Recommit of media project files due to a mistake in media_unittest.vcproj
that worked in Visual Studio but broke on IncrediBuild.  Also updated to
include dmg_fp dependency.

Trying ONE MORE TIME because I think gcl breaks with "A +" files (I used "svn merge -c REV ." to un-rollback my change).

Original: http://codereview.chromium.org/10683
Rollback: http://codereview.chromium.org/10908
Review URL: http://codereview.chromium.org/10733

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5490 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 19:10:21 +00:00
sgk@google.com b02e098041 Fixes for Visual Studio solution + project file generation:
* Fix the grit tool so it works with Repository() directories (and
  tap gspencer to upstream the changes).
* Fix the evaluation of $PRE_EVALUATE_DIRS, which was interfering
  with sucking up the source files for listing in the .vcproj files.
* Set AlwaysBuild() on the project files so they're always
  evaluated for up-to-dateness when 'all_solutions' is the target.
Review URL: http://codereview.chromium.org/10725

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5440 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 02:26:30 +00:00
evanm@google.com ccf7d6e9b0 Allow optimized builds on Linux.
Review URL: http://codereview.chromium.org/10857


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5406 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 23:44:51 +00:00
agl@chromium.org ed6355cf7d * Revert "Checking in the media project files (layout based on net/base libraries)."
This reverts commit fdeb8575309055ad23803b376659c236099348ac.

Review URL: http://codereview.chromium.org/10908


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5392 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 22:23:46 +00:00
scherkus@chromium.org 1b34e0fc01 Checking in the media project files (layout based on net/base libraries).
Added a dummy media.cc file in order to produce media.lib so there are no
linker errors when building media_unittests.exe.  Currently chrome_dll
does NOT depend on media so it will not be linked in, which is OK for now :)
Review URL: http://codereview.chromium.org/10683

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5389 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 22:10:12 +00:00
agl@chromium.org 6755331f09 Add extra pass throughs for enforge.
Add march flag to builds. Our system compilers are assuming > i386 already, but
not all gcc installations will do this. Without an march flag, gcc assumes only
a 386 and then some atomic operations are compiled to undefined references
which break linking.

Review URL: http://codereview.chromium.org/10689


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5363 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 20:11:17 +00:00
tony@chromium.org 610050b47d fix mac build
need to include dmg_fp config settings in debug and release

tbr=playmobil

Review URL: http://codereview.chromium.org/10665


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5325 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 00:00:46 +00:00
evanm@google.com f5d343a0ce Allow chromium to be built with some system libs by introducing
a variable called SYSTEM_LIBS, consisting of a comma-separated
list of system libraries. So far, bzip2, libpng, libjpeg,
libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized.

BUG=4321

Review URL: http://codereview.chromium.org/10626
Patch from Fabien Tassin <fta@sofaraway.org>.


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5320 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 23:23:52 +00:00
tc@google.com d24eb6296a Make unit_tests pass with pt_BR.UTF-8 locale.
BUG=3675

Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>
original issue: http://codereview.chromium.org/9509

Review URL: http://codereview.chromium.org/11002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5319 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 23:19:30 +00:00
tc@google.com a0708c6f6d add distcc_dir to the list of pass through vars
Review URL: http://codereview.chromium.org/10658


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5316 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 23:01:48 +00:00
evanm@google.com ca912ea7d7 chmod +x install-build-deps.sh
R=deanm


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 20:54:10 +00:00
deanm@chromium.org 4259cc4667 Build v8 in debug mode, we build everything else in debug.
Review URL: http://codereview.chromium.org/10636

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5274 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 19:31:08 +00:00
evanm@google.com c4a6002a10 Some changes necessary to build an optimized binary on Linux.
Two other speedup changes that I'm not including:
 root_env = Environment(
     tools = ['component_setup'],
+    RPATH=[],

And
 linux_env.Tool('target_platform_linux')
-linux_env.Tool('target_debug')
+linux_env.Tool('target_optimized')

Review URL: http://codereview.chromium.org/10292


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5193 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-11 19:12:07 +00:00
paulg@google.com 89a99172b2 Replace 7z with ar.
Review URL: http://codereview.chromium.org/10299

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5191 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-11 19:02:12 +00:00
dkegel@google.com ee579a8fe9 Serialize links on Linux. Should fix http://code.google.com/p/chromium/issues/detail?id=3805
Review URL: http://codereview.chromium.org/9463

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-10 22:32:01 +00:00
mark@chromium.org 29ca6d3298 Reduce build verbosity after r5042
git-svn-id: http://src.chromium.org/svn/trunk/src/build@5068 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-08 14:38:11 +00:00
bradnelson@chromium.org 3a1113cb9a Adding in new solution builder pattern.
Review URL: http://codereview.chromium.org/10231

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5047 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-08 00:12:34 +00:00
mark@chromium.org 9e48815ff4 Dramatically improve the link time in release mode. Today's MC Hammer Xcode
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-07 23:55:47 +00:00
sgk@google.com 03bb2a400b Set cpus=1 on systems where we don't (yet) know how to deduce
the number of CPUs.  This at least allows the build to function
on unknown systems.

Remove a now-unnecessary addition of $V8_DIR to LIBPATH.  The
v8 libraries now get installed in $LIBS_DIR like everyone else.
Review URL: http://codereview.chromium.org/10208

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5007 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-07 19:32:43 +00:00
tc@google.com a8fd3d2cfe A more friendly build error on linux
when packages are not found by pkg-config.

Review URL: http://codereview.chromium.org/9618


git-svn-id: http://src.chromium.org/svn/trunk/src/build@4856 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-06 01:36:34 +00:00
sgk@google.com fcdca53949 Make better (and more efficient) use of Hammer functionality
in base, net and sandbox:
* Remove by-hand Install() and Alias() calls.
* Set $COMPONENT_PROGRAM_GROUPS and $COMPONENT_TEST_PROGRAM_GROUPS
  (with in each foo\foo.scons file) so executables get added
  automatically to the appropriate Alias.
* Set $TESTS_DIR and $STAGING_DIR so executables get linked
  directly in their final resting place ($TARGET_ROOT).
Review URL: http://codereview.chromium.org/9188

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4805 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 19:48:25 +00:00
brettw@google.com 6da170243d Unrollback the Scons changes, they weren't the cause of the problem.
Review URL: http://codereview.chromium.org/9184

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4783 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 17:27:18 +00:00
brettw@google.com 8fad7b7ebb Rollback r4734 to see if it fixes the crashing I experience when starting chrome, as well as the 1MB regression in chrome.dll size.
Review URL: http://codereview.chromium.org/8226

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 16:43:50 +00:00
bradnelson@chromium.org 9f09494542 Adding better project generation (source and build targets).
Adding fix to targets_msvs to work with chrome hammer.bat in depot_tools.


Review URL: http://codereview.chromium.org/9149

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4734 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 02:37:37 +00:00
bradnelson@chromium.org a8cac93cc2 Take Hammer out of the default target list.
Review URL: http://codereview.chromium.org/9142

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4673 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-04 21:59:37 +00:00
bradnelson@chromium.org eb99a0eae3 Adding visual studio solution files.
Sandbox is currently having a problem with this so it is disabled.
Fixed a few stray items.

Review URL: http://codereview.chromium.org/9259

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4525 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-04 00:32:42 +00:00
dkegel@google.com b64dcd7209 Add tlslite
git-svn-id: http://src.chromium.org/svn/trunk/src/build@4522 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-04 00:13:15 +00:00
mark@chromium.org cf1e70e599 Build database files on the Mac (r4486). Sets HEADER_SEARCH_PATHS and adds
needed files in third_party/WebKit/WebCore/platform/sql and
third_party/WebKit/WebCore/storage to webkit.xcodeproj.  Makes
TestShell.xcodeproj depend on libsqlite.
Review URL: http://codereview.chromium.org/9055

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4494 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-03 21:43:08 +00:00
dkegel@google.com 9441d47d18 Happy on hardy 64 bit now.
git-svn-id: http://src.chromium.org/svn/trunk/src/build@4477 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-03 19:47:36 +00:00
sgk@google.com c4d78eb08e Refactor building unit_tests with SCons for the new structure:
* Rename SConscript.unit_tests to test/unit/unit_tests.scons.
* Add a new chrome/chrome.scons "master" for building everything
  chrome.  Have it just load the existing SConscript file, and
  the new test/unit/unit_tests.scons file.  We'll move things from
  SConscript (or elsewhere) into chrome.scons as they get convertd.
* Change build/SConscript.main to load chrome/chrome.scons.
* Add new using_libjpeg.scons, using_libxml.scons, and using_libxslt.scons
  "properties" files.
* Convert test/unit/unit_tests.scons to use the available using_*.scons files.
* Combine settings that were scattered throught test/unit/unit_tests.scons
  to make it a little more readable.
* Add $CHROME_DIR/ to the beginning of the file listed in
  test/unit/unit_tests.scons, since they're now being interpreted
  from a SConscript file down two directory levels.
Review URL: http://codereview.chromium.org/9005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4448 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-03 06:27:57 +00:00
dkegel@google.com 3f71b814a4 A simple script to install whatever is needed to build chromium.
Initially, it only supports the Ubuntu 8.04 flavor of Linux, but 
we should expand that as time goes on.



git-svn-id: http://src.chromium.org/svn/trunk/src/build@4330 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-31 21:45:30 +00:00
agl@chromium.org 971f166380 Get fonts to render in a somewhat recognisable form on Linux.
Review URL: http://codereview.chromium.org/8936


git-svn-id: http://src.chromium.org/svn/trunk/src/build@4325 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-31 21:27:18 +00:00
bradnelson@chromium.org 17c9d2a6d0 Fixing use of built_component from SConstructs.
Review URL: http://codereview.chromium.org/8724

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4189 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-29 23:28:05 +00:00
bradnelson@google.com 1d7e0a0f81 Adding in BuildComponents to allow things like Defer and publishing.
Review URL: http://codereview.chromium.org/8666

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4153 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-29 19:17:42 +00:00
sgk@google.com 81784b61b1 Re-apply 4099, v8 build dir change (after manual buildbot cleaning).
Review URL: http://codereview.chromium.org/8688

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4108 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 23:48:10 +00:00
sgk@google.com 57457c0379 Revert r4099.
Review URL: http://codereview.chromium.org/8685

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4100 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 22:37:54 +00:00
sgk@google.com 9cf3b0d159 build/SConscript.v8 update, plus fixes:
* Use SCons -C to invoke the v8 build from our own build directory,
  using the -Y option to pull all source files from the v8 source
  directory, to avoid building things under src/v8.
* Make sure the build directory exists before we invoke the subsidiary
  SCons that will chdir there.
* Build libv8_snapshot.a in the obj/v8 directory, not src/build.
* Remove the svn:ignore property from src/build (specifically libv8snapshot.a).
* Correct the $LIBS_DIR location of libv8.a.
* Use the actual file names involved instead of local Python variables.
* Don't forcibly add our targets to other component's Aliases.
Review URL: http://codereview.chromium.org/8851

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4099 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 22:22:47 +00:00
bradnelson@google.com 5e4ad44655 Fixing clobber which was broken by r4051.
Review URL: http://codereview.chromium.org/8842

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4082 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 19:48:24 +00:00
bradnelson@google.com 360d9b0f6e Splitting apart the environments to build in.
This will let use incrementally introduce BuildComponents in SConscript.main

Review URL: http://codereview.chromium.org/8807

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4051 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 01:44:15 +00:00
evanm@google.com f1d16e8aae Revert "Use SCons -C to invoke the v8 build from our own build directory,"
This reverts r4041.

Review URL: http://codereview.chromium.org/8822


git-svn-id: http://src.chromium.org/svn/trunk/src/build@4045 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 00:26:28 +00:00
sgk@google.com 1788802d6d Use SCons -C to invoke the v8 build from our own build directory,
using the -Y option to pull all source files from the v8 source
directory.  This requires making sure the build directory exists
before we invoke the subsidiary SCons that will chdir there.
Other clean up:
* Use the actual file names involved instead of local Python variables.
* Don't forcibly add our targets to other component's Aliases.
Review URL: http://codereview.chromium.org/8639

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4041 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-28 00:11:18 +00:00
tc@google.com f496518795 speed up scons
I did some profiling and found that we spend a lot of
time in SCons/Subst.py resolving paths with $ vars in
them.  By pre-resolving some common $ vars, we can get
a 16% speed up of an empty build (running hammer Hammer
when everything is already built).  On my work desktop,
this is a saving from ~180s to do an empty build to
~150s to do an empty build.

I found which symbols to pre-resolve by gathering stats
on what symbols were resolved during a single run.
Originally, these were the top 10 calls to
StringSubber.substitute:

  91466 /src/gclient-git/src/chrome
  89457 $MAIN_DIR/Hammer
  89457 $DESTINATION_ROOT
  89447 $TARGET_ROOT/obj
  65514 $OBJ_ROOT/webkit
  18169 $OBJ_ROOT/third_party
   8991 -I/src/gclient-git/src/webkit/pending
   5700 $THIRD_PARTY_DIR/WebKit
   4488 -I/src/gclient-git/src/webkit/port/platform/network
   4488 -I/src/gclient-git/src/webkit/port/platform

Afterwards, the top 10 calls were:
  65514 /src/gclient-git/src/chrome/Hammer/obj/webkit
  23933 /src/gclient-git/src/chrome/Hammer/obj
  18169 $OBJ_ROOT/third_party
   8991 -I/src/gclient-git/src/webkit/pending
   5700 $THIRD_PARTY_DIR/WebKit
   4488 -I/src/gclient-git/src/webkit/port/platform/network
   4488 -I/src/gclient-git/src/webkit/port/platform
   3813 $OBJ_ROOT/skia
   3498 $THIRD_PARTY_DIR/icu38
   3456 $THIRD_PARTY_WEBKIT_DIR/JavaScriptCore

Adding these rules cuts the total number of calls to
StringSubber.substitute from 1001817 to 665933.

Review URL: http://codereview.chromium.org/8608


git-svn-id: http://src.chromium.org/svn/trunk/src/build@4010 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-10-27 18:21:49 +00:00