r220846 was not the root cause of the failure.
> Revert 220846 "Make landmines.py take an extra script via an env..."
>
> It broke telemetry_unittests.
> http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/8782/steps/telemetry_unittests/logs/stdio
>
> E:\b\depot_tools\python_bin\python_slave.exe src\tools\telemetry\run_tests --browser=release_x64
> No adb found in $PATH, fallback to checked in binary.
> Traceback (most recent call last):
> File "src\tools\telemetry\run_tests", line 8, in <module>
> from telemetry.unittest import gtest_testrunner
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\__init__.py", line 12, in <module>
> from telemetry.core.browser_options import BrowserFinderOptions
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_options.py", line 12, in <module>
> from telemetry.core import browser_finder
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_finder.py", line 9, in <module>
> from telemetry.core.backends.chrome import android_browser_finder
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_finder.py", line 17, in <module>
> from telemetry.core.backends.chrome import android_browser_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_backend.py", line 15, in <module>
> from telemetry.core.backends.chrome import chrome_browser_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\chrome_browser_backend.py", line 19, in <module>
> from telemetry.core.backends.chrome import extension_dict_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\extension_dict_backend.py", line 9, in <module>
> from telemetry.core.backends.chrome import inspector_backend
> File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\inspector_backend.py", line 19, in <module>
> from telemetry.core.jsheap import model
> ImportError: No module named jsheap
>
> > Make landmines.py take an extra script via an env var.
> >
> > The extra Python script to run can be specified via env var
> > EXTRA_LANDMINES_SCRIPT.
> >
> > BUG=223636
> >
> > Review URL: https://chromiumcodereview.appspot.com/23604016
>
> TBR=sivachandra@chromium.org
>
> Review URL: https://codereview.chromium.org/23533016TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/23532029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@220870 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It broke telemetry_unittests.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/8782/steps/telemetry_unittests/logs/stdio
E:\b\depot_tools\python_bin\python_slave.exe src\tools\telemetry\run_tests --browser=release_x64
No adb found in $PATH, fallback to checked in binary.
Traceback (most recent call last):
File "src\tools\telemetry\run_tests", line 8, in <module>
from telemetry.unittest import gtest_testrunner
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\__init__.py", line 12, in <module>
from telemetry.core.browser_options import BrowserFinderOptions
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_options.py", line 12, in <module>
from telemetry.core import browser_finder
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\browser_finder.py", line 9, in <module>
from telemetry.core.backends.chrome import android_browser_finder
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_finder.py", line 17, in <module>
from telemetry.core.backends.chrome import android_browser_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\android_browser_backend.py", line 15, in <module>
from telemetry.core.backends.chrome import chrome_browser_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\chrome_browser_backend.py", line 19, in <module>
from telemetry.core.backends.chrome import extension_dict_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\extension_dict_backend.py", line 9, in <module>
from telemetry.core.backends.chrome import inspector_backend
File "E:\b\build\slave\Win_7_Tests_x64__3_\build\src\tools\telemetry\telemetry\core\backends\chrome\inspector_backend.py", line 19, in <module>
from telemetry.core.jsheap import model
ImportError: No module named jsheap
> Make landmines.py take an extra script via an env var.
>
> The extra Python script to run can be specified via env var
> EXTRA_LANDMINES_SCRIPT.
>
> BUG=223636
>
> Review URL: https://chromiumcodereview.appspot.com/23604016TBR=sivachandra@chromium.org
Review URL: https://codereview.chromium.org/23533016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@220853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When using components, the CDM and adapter cannot be within the Chrome bundle.
Since the adapter is built with Chrome, the CDM cannot be within its bundle.
As a result, the adapter no longer needs to be a bundle.
The chrome_paths.cc code allows testing with the non-component path.
BUG=180260
R=xhwang@chromium.org
Review URL: https://codereview.chromium.org/14743002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@198211 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change is to fix resource-related issues with the current approach.
We can't include resources in the test_java target to share them between
the shell and test apks, so we need one apk to contain the shell and run
tests against.
To achieve this we apply the same trick as testshell does and build the
test code against the .jar created as a side-effect of building the shell
apk target.
This change completely removes the test_apk target.
BUG=None
TEST=AndroidWebViewTests
TBR=bulach@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12609013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190404 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It looks like this made win extract_build fail.
Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.
This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts.
The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/
I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.
R=cmp,maruel@chromium.org
BUG=121897
Review URL: https://chromiumcodereview.appspot.com/11175016TBR=iannucci@chromium.org
Review URL: https://codereview.chromium.org/11293111
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166105 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.
This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts.
The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/
I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.
R=cmp,maruel@chromium.org
BUG=121897
Review URL: https://chromiumcodereview.appspot.com/11175016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166085 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
thakis@chromium.org
tkent@chromium.org
sivachandra@chromium.org
cbiesinger@chromium.org
robliao@chromium.org
iannucci@chromium.org
ddorwin@chromium.org
justincohen@google.com
sbaig1@bloomberg.net
dtrainor@chromium.org
mkosiba@chromium.org
ilevy@chromium.org
scottmg@chromium.org
vandebo@chromium.org