Граф коммитов

53 Коммитов

Автор SHA1 Сообщение Дата
miu 5acfa65c84 [RELAND] Fixit: Factor out common base::Time* math operator overloads.
This relands https://codereview.chromium.org/1122443004 with a landmine
to clobber the iOS builds.  This is necessary because Xcode's logic for
determining that base/time/time.h changed is faulty and is preventing
modules dependent on it from being rebuilt.

Revert history: https://codereview.chromium.org/1125283003

BUG=467417,485435
TBR=stuartmorgan@chromium.org

Review URL: https://codereview.chromium.org/1131923005

Cr-Original-Commit-Position: refs/heads/master@{#329060}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad576e7a77b87bfd0ed09b46cf9fdfacd342672b
2015-05-10 00:15:55 +00:00
thakis 4ea6676322 Add a note that landmines should not be used in general.
BUG=none

Review URL: https://codereview.chromium.org/1009603006

Cr-Original-Commit-Position: refs/heads/master@{#321824}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 37066a5a215e8c8e85958e7b1c7756b201b17c5c
2015-03-23 18:58:21 +00:00
ncbray bf313b31f5 Roll NaCl toolchain change.
This CL causes gclient runhooks to unpack the NaCl toolchain to
//native_client/toolchain.  It also causes GYP to use the toolchain from that
location rather than unpacking it into the output directory during the build.

This CL adds a landmine to reclaim ~1 GB of disk space.  Landmines are normally
used for correctness issues, in this case it is being used because an additional
1 GB of disk usage could cause random bots to fail.

BUG=456902

Review URL: https://codereview.chromium.org/921243002

Cr-Original-Commit-Position: refs/heads/master@{#316880}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4453c50a5dd04a86aa1c5e164b4760f14cac115d
2015-02-18 20:11:41 +00:00
ianwen 40f2a91bb7 Upstream Enhanced Bookmark Model (2nd Land)
This is the data layer of enhanced bookmark. There is no reason why
this class should live in private repository.

BUG=428832
Previously landed in:
https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261
Reverted in: https://crrev.com/f40cb64710a333da6d554e98dfcc432cd6cf8f1f

Review URL: https://codereview.chromium.org/923653002

Cr-Original-Commit-Position: refs/heads/master@{#316085}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec62d8d37848b12309994f10bf8457ae4fcabb8e
2015-02-12 23:37:16 +00:00
alexclarke 311deddb35 Revert of Upstream Enhanced Bookmark Model (patchset #6 id:100001 of https://codereview.chromium.org/899403002/)
Reason for revert:
This is blocking downstream and people are complaining.  I tried to land the downstream fix but there was a compile problem.

Sorry, hope you can fix the problems and re-land.

Original issue's description:
> Upstream Enhanced Bookmark Model
>
> This is the data layout of enhanced bookmark. There is no reason why
> this class should live in private repository.
>
> BUG=428832
>
> Committed: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261
> Cr-Commit-Position: refs/heads/master@{#315939}

TBR=kkimlabs@chromium.org,newt@chromium.org,cjhopman@chromium.org,ianwen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428832

Review URL: https://codereview.chromium.org/920043003

Cr-Original-Commit-Position: refs/heads/master@{#315976}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f40cb64710a333da6d554e98dfcc432cd6cf8f1f
2015-02-12 14:53:06 +00:00
ianwen 53844cf3ce Upstream Enhanced Bookmark Model
This is the data layout of enhanced bookmark. There is no reason why
this class should live in private repository.

BUG=428832

Review URL: https://codereview.chromium.org/899403002

Cr-Original-Commit-Position: refs/heads/master@{#315939}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 691b64f43fc0a69752344e5edbbc4d8f406cf261
2015-02-12 06:34:36 +00:00
blundell b54e20e9ee Move //mojo/{public, edk} underneath //third_party
This CL move //mojo/public and //mojo/edk to live in the following locations:
- //third_party/mojo/src/mojo/public
- //third_party/mojo/src/mojo/edk

It moves the related gypfiles from //mojo to //third_party/mojo and updates
them as necessary to account for the file moves. It also updates clients of the
mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK
and EDK build systems are maintained in the Mojo repo and designed to be
flexible wrt the location of the SDK/EDK in a client repo, so no changes are
needed.

This CL does not update include paths to the code being moved to limit the
number of moving parts, instead relying on the include_dirs that the SDK and
EDK targets supply to their direct dependents to ensure that include paths
continue to resolve correctly.

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/814543006

Cr-Original-Commit-Position: refs/heads/master@{#312129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70fb54767b472a5edfb859e489beeeec7abdb0e4
2015-01-19 17:19:27 +00:00
amistry 511aa4d1f0 Revert of Reverting due to Android builders breakage. Subsequent fixes did not fix. (patchset #1 id:1 of https://codereview.chromium.org/843913006/)
Reason for revert:
Didn't fix the Android builders.

Original issue's description:
> Reverting due to Android builders breakage. Subsequent fixes did not fix.
>
> Revert "Use SuppressFBWarnings to suppress findbugs warnings"
>
> This reverts commit 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138.
>
> Revert "Temporarily add a workaround for findbugs."
>
> This reverts commit 790b64ba7f5343b6b99c97e8deaa635e1e9422d0.
>
> Revert "Temporarily remove some findbugs "known bugs""
>
> This reverts commit 5a1c59272e7fd23116bcec8b952474e62bdcf7d3.
>
> NOTRY=true
> TBR=cjhopman@chromium.org
>
> Committed: https://crrev.com/710d2f69b76e7b997307a7096e31029857e8c7fb
> Cr-Commit-Position: refs/heads/master@{#311630}

TBR=cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/827123006

Cr-Original-Commit-Position: refs/heads/master@{#311640}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ed4075728f265ed930531b4ba97c937068d921a
2015-01-15 07:10:54 +00:00
amistry 72eca2b361 Reverting due to Android builders breakage. Subsequent fixes did not fix.
Revert "Use SuppressFBWarnings to suppress findbugs warnings"

This reverts commit 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138.

Revert "Temporarily add a workaround for findbugs."

This reverts commit 790b64ba7f5343b6b99c97e8deaa635e1e9422d0.

Revert "Temporarily remove some findbugs "known bugs""

This reverts commit 5a1c59272e7fd23116bcec8b952474e62bdcf7d3.

NOTRY=true
TBR=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/843913006

Cr-Original-Commit-Position: refs/heads/master@{#311630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 710d2f69b76e7b997307a7096e31029857e8c7fb
2015-01-15 05:50:53 +00:00
cjhopman b5e3b05b75 Use SuppressFBWarnings to suppress findbugs warnings
This has several benefits:
Makes the warning obvious at the place of the problem
Makes suppressing the warnings the same as suppressing compiler and lint warnings
Makes supporting findbugs as part of the build easier

TBR=rmcilroy, mef, boliu

BUG=431826

Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
Cr-Commit-Position: refs/heads/master@{#311402}

Review URL: https://codereview.chromium.org/793203002

Cr-Original-Commit-Position: refs/heads/master@{#311596}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138
2015-01-15 01:01:10 +00:00
Daniel Cheng 3091c5e4e3 Add a landmine to clobber broken GN bots.
GN bots are having trouble picking up the changes to the resouce ID
range, which was changed in https://codereview.chromium.org/734243003/.

BUG=444902
R=eroman@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/821303002

Cr-Original-Commit-Position: refs/heads/master@{#309588}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1a85aee41655ad2c016ffe22320f0b1d9571e15
2014-12-23 22:55:19 +00:00
dcheng 2ab691ac21 Out of line CallbackBase's copy and assignment operators.
This saved nearly 300KiB on a release build of Chrome.

BUG=436357

Review URL: https://codereview.chromium.org/760513002

Cr-Original-Commit-Position: refs/heads/master@{#305784}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f883604e3ea3a0b9881dc5eb1e933fb66d914003
2014-11-26 05:05:21 +00:00
scottmg 8b665c00f2 Update to VS2013 Update 4, and Windows SDK 8.1
- Disable 4996 (deprecated functions in 8.1, these don't help us because we have to run on old OSs anyway)
- Simplify Bluetooth LE header hacks (these headers are buggy in 8.0 and 8.1 SDKs, but less buggy in 8.1)
- Revert attempt to centralize toolchain hashes as it didn't work well, and made it hard to roll anyway (see 400830).
- Instead of basing C4702 (unreachable code) on Pro vs. Express, check whether it's actually disabled in the xtree header
- Remove automatic calling of Express toolchain setup script. It hasn't worked well since post VS2013 RTM because of being distributed as .msp files, and the new Community edition is relatively easy to install so can subsume that usage (that being the motivation for the 4702 change above)
- goma package for u4 is pushed
- ANGLE is switched to load d3dcompiler_47 and build against 8.1 sdk, roll included here.

Xrefs:
- https://codereview.chromium.org/719343004/
- https://chromium-review.googlesource.com/#/c/229616/
- b2/18365241
- https://codereview.chromium.org/733563003/
- https://codereview.chromium.org/732673002/
- https://codereview.chromium.org/729453004/
- https://chromereviews.googleplex.com/120597013/

BUG=311488,432748,400830

Review URL: https://codereview.chromium.org/720033003

Cr-Original-Commit-Position: refs/heads/master@{#304329}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6675a5f1f55e66b1d6625af6225d44f5d9b0f3d
2014-11-15 01:38:14 +00:00
petrcermak 9504305385 Add support to base::Timer for custom task runners.
This patch adds a public method
SetTaskRunner(scoped_refptr<SingleThreadTaskRunner>) to base::Timer
which changes the task runner used by the timer
(ThreadTaskRunnerHandler::Get() by default).

This change will enable scheduling timers on the queues of the
Blink scheduler (see https://codereview.chromium.org/637303003/).
Most importantly, we plan to apply this to the shared timer in
blink::Platform.

BUG=

Review URL: https://codereview.chromium.org/637983003

Cr-Original-Commit-Position: refs/heads/master@{#302947}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7652da6d5cbd7e5b82b340e638ebe80aafeacf6e
2014-11-06 02:18:21 +00:00
petrcermak 529efed80f Fix ninja "multiple rules" warning.
BUG=427526

Review URL: https://codereview.chromium.org/680923002

Cr-Original-Commit-Position: refs/heads/master@{#302064}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 297afd0505b111fe9ea65620fca6de4b2f16f234
2014-10-30 10:22:48 +00:00
fdegans 67078467e8 Reland Roll android_tools and breakpad to the latest.
Compared to the previous CL, this picks up in breakpad:
Fix breakpad on mips and x86_64 for the NDK r10c update.

Original issue's description:
> Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/)
>
> Reason for revert:
> Downstream x64 and mips bots didn't like it.
>
> Original issue's description:
> > Roll android_tools and breakpad to the latest.
> >
> > This picks up in android_tools:
> > Updated SDK build tools to 21.0.1 and removed old versions.
> > Upgrade NDK to r10c.
> >
> > And in breakpad:
> > Update breakpad to support Android NDK r10c
> > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
> > Refactor .so name detection logic in minidump/linux_dumper.
> > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
> > Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
> > Remove workaround for Linux credential-passing bug.
> >
> > TBR=brettw, danakj
> > NOTRY=true
> > BUG=424680, 425077, 358831
> >
> > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b
> > Cr-Commit-Position: refs/heads/master@{#300671}
>
> TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=424680, 425077, 358831
>
> Committed: https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068
> Cr-Commit-Position: refs/heads/master@{#300688}

TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,ppi@chromium.org
BUG=424680, 425077, 358831

Review URL: https://codereview.chromium.org/676483002

Cr-Original-Commit-Position: refs/heads/master@{#301087}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27660a3c6e308e9293745697433747e0a4fafae0
2014-10-24 13:00:37 +00:00
mkosiba c43826dafd Final step of the java_cpp_template -> java_cpp_enum migration.
This CL migrates the remaining gyp/gn rules away from the
java_cpp_template rule.

BUG=405532

Review URL: https://codereview.chromium.org/659493003

Cr-Original-Commit-Position: refs/heads/master@{#300881}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dfdc7fb2bcde7ea4a9458967fdc5f7fa15abb3fa
2014-10-23 13:56:31 +00:00
ppi 5e474c8d62 Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/)
Reason for revert:
Downstream x64 and mips bots didn't like it.

Original issue's description:
> Roll android_tools and breakpad to the latest.
>
> This picks up in android_tools:
> Updated SDK build tools to 21.0.1 and removed old versions.
> Upgrade NDK to r10c.
>
> And in breakpad:
> Update breakpad to support Android NDK r10c
> Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
> Refactor .so name detection logic in minidump/linux_dumper.
> The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
> Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
> Remove workaround for Linux credential-passing bug.
>
> TBR=brettw, danakj
> NOTRY=true
> BUG=424680, 425077, 358831
>
> Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b
> Cr-Commit-Position: refs/heads/master@{#300671}

TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424680, 425077, 358831

Review URL: https://codereview.chromium.org/676453002

Cr-Original-Commit-Position: refs/heads/master@{#300688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068
2014-10-22 16:41:32 +00:00
fdegans e0463104af Roll android_tools and breakpad to the latest.
This picks up in android_tools:
Updated SDK build tools to 21.0.1 and removed old versions.
Upgrade NDK to r10c.

And in breakpad:
Update breakpad to support Android NDK r10c
Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
Refactor .so name detection logic in minidump/linux_dumper.
The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
Remove workaround for Linux credential-passing bug.

TBR=brettw, danakj
NOTRY=true
BUG=424680, 425077, 358831

Review URL: https://codereview.chromium.org/671633003

Cr-Original-Commit-Position: refs/heads/master@{#300671}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 79bd5f12620f81dd241984d925b87a888e1dc37b
2014-10-22 12:58:41 +00:00
skyostil 0718303cc9 Revert of Revert of Use the new java_cpp_enum rule in content. (patchset #1 id:1 of https://codereview.chromium.org/625543002/)
Reason for revert:
Oops, wasn't supposed to revert this after all.

Original issue's description:
> Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
>
> Reason for revert:
> Fails to compile on several bots:
>
> https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
>
> First error:
> FAILED: cd ../../clank/native/framework; python <snip ...>
> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
> import org.chromium.content.common.TopControlsState;
>                                   ^
>   symbol:   class TopControlsState
>   location: package org.chromium.content.common
>
> Original issue's description:
> > Use the new java_cpp_enum rule in content.
> >
> > This moves most of the generated Java enums under content/ to use the
> > java_cpp_enum rule removing the need for keeping the enums in
> > separate list files and the need for the .template files.
> >
> > BUG=405532, 351558
> >
> > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> > Cr-Commit-Position: refs/heads/master@{#297789}
>
> TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405532, 351558
>
> Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef
> Cr-Commit-Position: refs/heads/master@{#297793}

TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558

Review URL: https://codereview.chromium.org/617103007

Cr-Original-Commit-Position: refs/heads/master@{#297794}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4db84b031042bf4f99720372f657ff53e4503a16
2014-10-02 10:09:12 +00:00
perezju 83a0fcba76 Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
Reason for revert:
Fails to compile on several bots:

https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio

First error:
FAILED: cd ../../clank/native/framework; python <snip ...>
../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
import org.chromium.content.common.TopControlsState;
                                  ^
  symbol:   class TopControlsState
  location: package org.chromium.content.common

Original issue's description:
> Use the new java_cpp_enum rule in content.
>
> This moves most of the generated Java enums under content/ to use the
> java_cpp_enum rule removing the need for keeping the enums in
> separate list files and the need for the .template files.
>
> BUG=405532, 351558
>
> Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> Cr-Commit-Position: refs/heads/master@{#297789}

TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558

Review URL: https://codereview.chromium.org/625543002

Cr-Original-Commit-Position: refs/heads/master@{#297793}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 949b6e5050c7a2ee2a894799db19ec325ba911ef
2014-10-02 10:06:08 +00:00
mkosiba d5bb547252 Use the new java_cpp_enum rule in content.
This moves most of the generated Java enums under content/ to use the
java_cpp_enum rule removing the need for keeping the enums in
separate list files and the need for the .template files.

BUG=405532, 351558

Review URL: https://codereview.chromium.org/615893003

Cr-Original-Commit-Position: refs/heads/master@{#297789}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
2014-10-02 09:07:09 +00:00
mkosiba cc5e7c3fbe Use the new java_cpp_enum rule in net.
This moves most of the generated Java enums under net/ to use the
java_cpp_enum rule removing the need for keeping the enums in
separate list files and the need for the .template files.

BUG=405532

Review URL: https://codereview.chromium.org/599493004

Cr-Original-Commit-Position: refs/heads/master@{#297420}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f6ebbf6b7c4a6d0626979198cfca64cb92cb2833
2014-09-30 14:42:55 +00:00
qsr c4c4c53c81 mojo: Fix java generator
Fix issue with method with empty response.
Fix issue with local variable shadowing user parameters.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/607933002

Cr-Original-Commit-Position: refs/heads/master@{#297176}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f187aa3de7e2f5b7ab759594e7b3c4e3c4083de
2014-09-29 15:24:41 +00:00
Nico Weber b33954ba35 Add a landmine for crbug.com/408192
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/529183004

Cr-Original-Commit-Position: refs/heads/master@{#293024}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f49a7ad853db11ffb232ad8649a46b2ae047b53
2014-09-02 23:44:39 +00:00
qsr d4a833477b mojo: generate Proxies and Stubs for java bindings.
This CL allows to generate Stub and Proxy of mojo service in java. This
allows to call interfaces method through message pipes.

Committed: b2ef91ee4a

Review URL: https://codereview.chromium.org/411913002

Cr-Original-Commit-Position: refs/heads/master@{#292154}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 063e1e3acae7473399f5064c66296de55b0ac04b
2014-08-27 15:19:23 +00:00
scottmg@chromium.org fcfdc9de53 Revert 289650 "Roll buildtools, this updates VS2013 Pro to Update 3"
gfx_unittests fails on x64_rel.

Unclear why tryjob was successful, perhaps different hardware between tryjob and waterfall.

> Roll buildtools, this updates VS2013 Pro to Update 3
> 
> TBR=iannucci@chromium.org
> NOTRY=true
> BUG=402543
> 
> Review URL: https://codereview.chromium.org/458353003

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/477013002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-15 00:07:27 +00:00
scottmg@chromium.org e76e0b2763 Roll buildtools, this updates VS2013 Pro to Update 3
TBR=iannucci@chromium.org
NOTRY=true
BUG=402543

Review URL: https://codereview.chromium.org/458353003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289650 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-14 18:48:18 +00:00
scottmg@chromium.org f55feb4fa0 Make landmines work on local builds too
Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.

landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.

Reland with fix for ios, and for clean pull.

R=iannucci@chromium.org
BUG=400011

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099

Review URL: https://codereview.chromium.org/457003004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289546 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-14 14:03:30 +00:00
iannucci@chromium.org 41f3a62575 Revert of Make landmines work on local builds too (patchset #3 of https://codereview.chromium.org/457003004/)
Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):


Traceback (most recent call last):
  File "src/build/landmines.py", line 132, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 119, in main
    gyp_environment.SetEnvironment()
  File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
    with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'

Original issue's description:
> Make landmines work on local builds too
> 
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
> 
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
> 
> R=iannucci@chromium.org
> BUG=400011
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099

TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011

Review URL: https://codereview.chromium.org/469623002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289158 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-13 02:07:35 +00:00
scottmg@chromium.org d95769ca0c Make landmines work on local builds too
Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.

landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.

R=iannucci@chromium.org
BUG=400011

Review URL: https://codereview.chromium.org/457003004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289099 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-12 22:52:11 +00:00
cjhopman@chromium.org 27654960d9 Update lint and findbugs to use jars instead of class files
Now that this is done, we don't need to leave the class files laying
around anymore. So don't.

Review URL: https://codereview.chromium.org/458653002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288971 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-12 15:10:38 +00:00
eseidel@chromium.org 9c89e2d8ce Add a landmine to fix builders after blink_resources.grd changed
I will send a PSA to chromium-dev shortly explaining the issue.

BUG=338338, 400860
NOTRY=true

Review URL: https://codereview.chromium.org/441133002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287640 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-05 23:21:53 +00:00
thakis@chromium.org b1ff80bd0d Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors.
BUG=338338
NOTRY=true

Review URL: https://codereview.chromium.org/439503005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287102 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-08-01 22:08:49 +00:00
rmcilroy@chromium.org b8444e5e36 Roll Breakpad from 1345 to 1351.
This pulls in the following CLs:
 - r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
 - r1347 Stringify minidump stream_type constants in minidump_dump output
 - r1348 Ensure C:/Dumps/ exists in crash_generation_app
 - r1349 Change some ELF utils to return the length as a size_t
 - r1350 Add frame pointer recovery to the AMD64 Stackwalker.
 - r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

BUG=394841,393903

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284101

R=mark@chromium.org

Review URL: https://codereview.chromium.org/400203002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-07-18 17:14:37 +00:00
bradnelson@google.com 348cbbfb66 Adding a landmine to clobber due to NDEBUG nacl change.
BUG=391093
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/363083004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@281106 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-07-02 23:11:11 +00:00
qsr@chromium.org f95e57547d Generate java bindings for structs.
This CL introduces bindings for struct. It only generates fields and not
serialization/deserialization methods.

R=rmcilroy@chromium.org, viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279677

Review URL: https://codereview.chromium.org/306893010

git-svn-id: http://src.chromium.org/svn/trunk/src/build@279707 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-25 13:28:50 +00:00
pastarmovj@google.com 6f28c6224e Revert 279677 "Generate java bindings for structs."
Broke the Linux x64 build http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/66839/steps/compile/logs/stdio
> Generate java bindings for structs.
> 
> This CL introduces bindings for struct. It only generates fields and not
> serialization/deserialization methods.
> 
> R=rmcilroy@chromium.org, viettrungluu@chromium.org
> 
> Review URL: https://codereview.chromium.org/306893010

TBR=qsr@chromium.org

Review URL: https://codereview.chromium.org/354833003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@279688 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-25 12:36:59 +00:00
qsr@chromium.org aecbd8dd3d Generate java bindings for structs.
This CL introduces bindings for struct. It only generates fields and not
serialization/deserialization methods.

R=rmcilroy@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/306893010

git-svn-id: http://src.chromium.org/svn/trunk/src/build@279677 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-25 11:52:30 +00:00
boliu@chromium.org 074756f7a7 aw: Use HashMap instead of ArrayMap
ArrayMap is only available in API 19, and not all chromium
infrastructure are on API 19 yet.

BUG=387760
NOTRY=true

Review URL: https://codereview.chromium.org/350703003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@279215 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-23 22:59:13 +00:00
nbarth@chromium.org 8795e5b881 Add landmine due to generated file move in Blink r175513
Blink generated file move requires a clobber to avoid using stale
generated files.

This should have been included in the Blink roll, but we
didn't realize this was needed, so we failed to advise the
gardener (sorry!):
Blink roll 175512:175568
https://codereview.chromium.org/317183002/

See discussion at:
https://code.google.com/p/chromium/issues/detail?id=381111#c4

BUG=381111
TBR=dcheng
TBR=peter

Review URL: https://codereview.chromium.org/316343003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@275406 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-06 11:25:13 +00:00
machenbach@chromium.org e2a8888be1 Update V8 to version 3.27.19.2 (merged r21666).
Please reply to the V8 sheriff mvstanton@chromium.org in case of problems.

R=jochen@chromium.org, mvstanton@chromium.org
TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/316853002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@274820 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-04 14:26:03 +00:00
bratell@opera.com 9c86f68130 Graphical version of the run_binary_size_analysis tool.
The binary_size tool suit includes tools that are useful when trying
to reduce binary size of a program, and chromium related programs
in particular.

This commit (mostly written by andrewhayden@chromium.org for 
Android but ported to generic Linux by bratell@opera.com) adds 
a graphical HTML based output for run_binary_size_analysis.py.
In the generated web page it is possible to dynamically and 
graphically browse the binary and each part of the source tree 
is given a size that reflects its contribution to the binary size.

The run_binary_size_analysis tool is run on compiled binaries 
with symbols and uses nm and addr2line to map parts of the
binary to source code. Since addr2line is slow the operation to map 
binary symbols to source files takes a while but the output is 
well worth it when shrinking programs. See its usage information
for details about how to run it.

This commit also includes the tool explain_binary_size_delta.py 
(textual output) which can be used to understand why a binary 
changed size and in what way. See its usage information for 
details about how to run it.

There are many further improvements possible to to do on these tools.
Search the bug database for Label:Tools-BinarySize for suggestions.

BUG=339059
R=primiano@chromium.org,andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/258633003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@272255 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-22 18:49:40 +00:00
scottmg@chromium.org fec8ddd435 Revert 271737 "Revert 271721 "VS2013 Update 2""
https://src.chromium.org/viewvc/chrome?view=rev&revision=271919 fixes the
compiler crash, http://src.chromium.org/viewvc/chrome?view=rev&revision=271780
fixes the bug in landmines that didn't allow the initial land/revert to
go smoothly.

Should be A-OK this time.

> Revert 271721 "VS2013 Update 2"
> 
> static_library build ICEing on some builders on mini_installer.
> 
> > VS2013 Update 2
> > 
> > As discussed in the linked bug, the toolchain2013.py script in
> > depot_tools is no longer workable (because the update for Update 2 is
> > supplied as a .msp that must be applied against a system-installed
> > VS2013).
> > 
> > As such, the Express hash here is not updated.
> > 
> > The hash zip referenced here was built as follows:
> > - Install VS2013 Update 2 on a clean VM
> > - Copy DIA SDK\, VC\
> > - Copy DLLs from VC\redist to sys32\ and sys64\
> > - Copy win8sdk unchanged from previous .zip.
> > - Delete various unused arm\ subdirectories
> > - Delete the IDE-only Snippets, etc. subdirectories in VC\
> > - Patch VC\include\xtree to disable warning 4702 per request in
> >   http://crbug.com/346399 .
> > 
> > A followup change will be to write a script that does these steps
> > semi-automatically, hopefully for Express too, though there is the
> > added complication of the WDK/ATL/MFC hacking required there. In
> > particular, this script will not be useful for a dev to actually run
> > as part of runhooks, but will be a bit useful for deployment/
> > documentation of the above process.
> > 
> > In the interim there are no extremely-pressing reasons for Express
> > users to update to Update2 that I'm aware of, so they get non-Update2
> > for now.
> > 
> > R=iannucci@chromium.org
> > BUG=372451,346399,371847,339215,350639
> > 
> > Review URL: https://codereview.chromium.org/284663003
> 
> TBR=scottmg@chromium.org
> 
> Review URL: https://codereview.chromium.org/297753002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/295093004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@271921 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-21 17:10:43 +00:00
scottmg@chromium.org 9c86e7e0cd Revert 271721 "VS2013 Update 2"
static_library build ICEing on some builders on mini_installer.

> VS2013 Update 2
> 
> As discussed in the linked bug, the toolchain2013.py script in
> depot_tools is no longer workable (because the update for Update 2 is
> supplied as a .msp that must be applied against a system-installed
> VS2013).
> 
> As such, the Express hash here is not updated.
> 
> The hash zip referenced here was built as follows:
> - Install VS2013 Update 2 on a clean VM
> - Copy DIA SDK\, VC\
> - Copy DLLs from VC\redist to sys32\ and sys64\
> - Copy win8sdk unchanged from previous .zip.
> - Delete various unused arm\ subdirectories
> - Delete the IDE-only Snippets, etc. subdirectories in VC\
> - Patch VC\include\xtree to disable warning 4702 per request in
>   http://crbug.com/346399 .
> 
> A followup change will be to write a script that does these steps
> semi-automatically, hopefully for Express too, though there is the
> added complication of the WDK/ATL/MFC hacking required there. In
> particular, this script will not be useful for a dev to actually run
> as part of runhooks, but will be a bit useful for deployment/
> documentation of the above process.
> 
> In the interim there are no extremely-pressing reasons for Express
> users to update to Update2 that I'm aware of, so they get non-Update2
> for now.
> 
> R=iannucci@chromium.org
> BUG=372451,346399,371847,339215,350639
> 
> Review URL: https://codereview.chromium.org/284663003

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/297753002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@271737 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-20 20:13:56 +00:00
scottmg@chromium.org bcba7faa6f VS2013 Update 2
As discussed in the linked bug, the toolchain2013.py script in
depot_tools is no longer workable (because the update for Update 2 is
supplied as a .msp that must be applied against a system-installed
VS2013).

As such, the Express hash here is not updated.

The hash zip referenced here was built as follows:
- Install VS2013 Update 2 on a clean VM
- Copy DIA SDK\, VC\
- Copy DLLs from VC\redist to sys32\ and sys64\
- Copy win8sdk unchanged from previous .zip.
- Delete various unused arm\ subdirectories
- Delete the IDE-only Snippets, etc. subdirectories in VC\
- Patch VC\include\xtree to disable warning 4702 per request in
  http://crbug.com/346399 .

A followup change will be to write a script that does these steps
semi-automatically, hopefully for Express too, though there is the
added complication of the WDK/ATL/MFC hacking required there. In
particular, this script will not be useful for a dev to actually run
as part of runhooks, but will be a bit useful for deployment/
documentation of the above process.

In the interim there are no extremely-pressing reasons for Express
users to update to Update2 that I'm aware of, so they get non-Update2
for now.

R=iannucci@chromium.org
BUG=372451,346399,371847,339215,350639

Review URL: https://codereview.chromium.org/284663003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@271721 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-20 19:15:33 +00:00
dtrainor@chromium.org 6aaa01cf7a Refactor ActivityStatus to not store current
- Refactor ActivityStatus to expose application level visibility over activity visbility.
- Add a listener for the visibility of the Application (are any Activities visible?)

BUG=341231
NOTRY=true

Review URL: https://codereview.chromium.org/159173002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@252679 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-02-21 23:04:08 +00:00
jochen@chromium.org 0b0decd1e7 Add a landmine to get rid of obselete test netscape plugins
BUG=331302
R=marja@chromium.org

Review URL: https://codereview.chromium.org/163073002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@251034 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-02-13 15:53:08 +00:00
scottmg@chromium.org 7aef8e0121 Move landmines into gyp_chromium
This ensures that the environment that's passed to gyp is the one that
landmines.py uses to determine when to set landmines.

Also, fix '2013e' not being detected as a 2013 switch.

BUG=309197, 323300
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/153073004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@249242 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-02-06 02:44:55 +00:00
scottmg@chromium.org efd029243e Fix get_landmines builder()
This meant the script wasn't doing anything on most branches of the ifs.

Is it going to cause problems to fix this? I guess basically everything
will clobber.

R=iannucci@chromium.org, sivachandra@chromium.org

Review URL: https://codereview.chromium.org/142093003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@245776 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-18 16:21:14 +00:00