This CL causes gclient runhooks to unpack the NaCl toolchain to
//native_client/toolchain. It also causes GYP to use the toolchain from that
location rather than unpacking it into the output directory during the build.
This CL adds a landmine to reclaim ~1 GB of disk space. Landmines are normally
used for correctness issues, in this case it is being used because an additional
1 GB of disk usage could cause random bots to fail.
BUG=456902
Review URL: https://codereview.chromium.org/921243002
Cr-Original-Commit-Position: refs/heads/master@{#316880}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4453c50a5dd04a86aa1c5e164b4760f14cac115d
Reason for revert:
This is blocking downstream and people are complaining. I tried to land the downstream fix but there was a compile problem.
Sorry, hope you can fix the problems and re-land.
Original issue's description:
> Upstream Enhanced Bookmark Model
>
> This is the data layout of enhanced bookmark. There is no reason why
> this class should live in private repository.
>
> BUG=428832
>
> Committed: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261
> Cr-Commit-Position: refs/heads/master@{#315939}
TBR=kkimlabs@chromium.org,newt@chromium.org,cjhopman@chromium.org,ianwen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428832
Review URL: https://codereview.chromium.org/920043003
Cr-Original-Commit-Position: refs/heads/master@{#315976}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f40cb64710a333da6d554e98dfcc432cd6cf8f1f
This is the data layout of enhanced bookmark. There is no reason why
this class should live in private repository.
BUG=428832
Review URL: https://codereview.chromium.org/899403002
Cr-Original-Commit-Position: refs/heads/master@{#315939}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 691b64f43fc0a69752344e5edbbc4d8f406cf261
This CL move //mojo/public and //mojo/edk to live in the following locations:
- //third_party/mojo/src/mojo/public
- //third_party/mojo/src/mojo/edk
It moves the related gypfiles from //mojo to //third_party/mojo and updates
them as necessary to account for the file moves. It also updates clients of the
mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK
and EDK build systems are maintained in the Mojo repo and designed to be
flexible wrt the location of the SDK/EDK in a client repo, so no changes are
needed.
This CL does not update include paths to the code being moved to limit the
number of moving parts, instead relying on the include_dirs that the SDK and
EDK targets supply to their direct dependents to ensure that include paths
continue to resolve correctly.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/814543006
Cr-Original-Commit-Position: refs/heads/master@{#312129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70fb54767b472a5edfb859e489beeeec7abdb0e4
This has several benefits:
Makes the warning obvious at the place of the problem
Makes suppressing the warnings the same as suppressing compiler and lint warnings
Makes supporting findbugs as part of the build easier
TBR=rmcilroy, mef, boliu
BUG=431826
Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
Cr-Commit-Position: refs/heads/master@{#311402}
Review URL: https://codereview.chromium.org/793203002
Cr-Original-Commit-Position: refs/heads/master@{#311596}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138
- Disable 4996 (deprecated functions in 8.1, these don't help us because we have to run on old OSs anyway)
- Simplify Bluetooth LE header hacks (these headers are buggy in 8.0 and 8.1 SDKs, but less buggy in 8.1)
- Revert attempt to centralize toolchain hashes as it didn't work well, and made it hard to roll anyway (see 400830).
- Instead of basing C4702 (unreachable code) on Pro vs. Express, check whether it's actually disabled in the xtree header
- Remove automatic calling of Express toolchain setup script. It hasn't worked well since post VS2013 RTM because of being distributed as .msp files, and the new Community edition is relatively easy to install so can subsume that usage (that being the motivation for the 4702 change above)
- goma package for u4 is pushed
- ANGLE is switched to load d3dcompiler_47 and build against 8.1 sdk, roll included here.
Xrefs:
- https://codereview.chromium.org/719343004/
- https://chromium-review.googlesource.com/#/c/229616/
- b2/18365241
- https://codereview.chromium.org/733563003/
- https://codereview.chromium.org/732673002/
- https://codereview.chromium.org/729453004/
- https://chromereviews.googleplex.com/120597013/
BUG=311488,432748,400830
Review URL: https://codereview.chromium.org/720033003
Cr-Original-Commit-Position: refs/heads/master@{#304329}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6675a5f1f55e66b1d6625af6225d44f5d9b0f3d
This patch adds a public method
SetTaskRunner(scoped_refptr<SingleThreadTaskRunner>) to base::Timer
which changes the task runner used by the timer
(ThreadTaskRunnerHandler::Get() by default).
This change will enable scheduling timers on the queues of the
Blink scheduler (see https://codereview.chromium.org/637303003/).
Most importantly, we plan to apply this to the shared timer in
blink::Platform.
BUG=
Review URL: https://codereview.chromium.org/637983003
Cr-Original-Commit-Position: refs/heads/master@{#302947}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7652da6d5cbd7e5b82b340e638ebe80aafeacf6e
Compared to the previous CL, this picks up in breakpad:
Fix breakpad on mips and x86_64 for the NDK r10c update.
Original issue's description:
> Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/)
>
> Reason for revert:
> Downstream x64 and mips bots didn't like it.
>
> Original issue's description:
> > Roll android_tools and breakpad to the latest.
> >
> > This picks up in android_tools:
> > Updated SDK build tools to 21.0.1 and removed old versions.
> > Upgrade NDK to r10c.
> >
> > And in breakpad:
> > Update breakpad to support Android NDK r10c
> > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
> > Refactor .so name detection logic in minidump/linux_dumper.
> > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
> > Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
> > Remove workaround for Linux credential-passing bug.
> >
> > TBR=brettw, danakj
> > NOTRY=true
> > BUG=424680, 425077, 358831
> >
> > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b
> > Cr-Commit-Position: refs/heads/master@{#300671}
>
> TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=424680, 425077, 358831
>
> Committed: https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068
> Cr-Commit-Position: refs/heads/master@{#300688}
TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,ppi@chromium.org
BUG=424680, 425077, 358831
Review URL: https://codereview.chromium.org/676483002
Cr-Original-Commit-Position: refs/heads/master@{#301087}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27660a3c6e308e9293745697433747e0a4fafae0
Reason for revert:
Downstream x64 and mips bots didn't like it.
Original issue's description:
> Roll android_tools and breakpad to the latest.
>
> This picks up in android_tools:
> Updated SDK build tools to 21.0.1 and removed old versions.
> Upgrade NDK to r10c.
>
> And in breakpad:
> Update breakpad to support Android NDK r10c
> Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
> Refactor .so name detection logic in minidump/linux_dumper.
> The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
> Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
> Remove workaround for Linux credential-passing bug.
>
> TBR=brettw, danakj
> NOTRY=true
> BUG=424680, 425077, 358831
>
> Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b
> Cr-Commit-Position: refs/heads/master@{#300671}
TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424680, 425077, 358831
Review URL: https://codereview.chromium.org/676453002
Cr-Original-Commit-Position: refs/heads/master@{#300688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068
This picks up in android_tools:
Updated SDK build tools to 21.0.1 and removed old versions.
Upgrade NDK to r10c.
And in breakpad:
Update breakpad to support Android NDK r10c
Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
Refactor .so name detection logic in minidump/linux_dumper.
The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
Remove workaround for Linux credential-passing bug.
TBR=brettw, danakj
NOTRY=true
BUG=424680, 425077, 358831
Review URL: https://codereview.chromium.org/671633003
Cr-Original-Commit-Position: refs/heads/master@{#300671}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 79bd5f12620f81dd241984d925b87a888e1dc37b
Reason for revert:
Oops, wasn't supposed to revert this after all.
Original issue's description:
> Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
>
> Reason for revert:
> Fails to compile on several bots:
>
> https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
>
> First error:
> FAILED: cd ../../clank/native/framework; python <snip ...>
> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
> import org.chromium.content.common.TopControlsState;
> ^
> symbol: class TopControlsState
> location: package org.chromium.content.common
>
> Original issue's description:
> > Use the new java_cpp_enum rule in content.
> >
> > This moves most of the generated Java enums under content/ to use the
> > java_cpp_enum rule removing the need for keeping the enums in
> > separate list files and the need for the .template files.
> >
> > BUG=405532, 351558
> >
> > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> > Cr-Commit-Position: refs/heads/master@{#297789}
>
> TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405532, 351558
>
> Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef
> Cr-Commit-Position: refs/heads/master@{#297793}
TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558
Review URL: https://codereview.chromium.org/617103007
Cr-Original-Commit-Position: refs/heads/master@{#297794}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4db84b031042bf4f99720372f657ff53e4503a16
Reason for revert:
Fails to compile on several bots:
https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
First error:
FAILED: cd ../../clank/native/framework; python <snip ...>
../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
import org.chromium.content.common.TopControlsState;
^
symbol: class TopControlsState
location: package org.chromium.content.common
Original issue's description:
> Use the new java_cpp_enum rule in content.
>
> This moves most of the generated Java enums under content/ to use the
> java_cpp_enum rule removing the need for keeping the enums in
> separate list files and the need for the .template files.
>
> BUG=405532, 351558
>
> Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> Cr-Commit-Position: refs/heads/master@{#297789}
TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558
Review URL: https://codereview.chromium.org/625543002
Cr-Original-Commit-Position: refs/heads/master@{#297793}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 949b6e5050c7a2ee2a894799db19ec325ba911ef
This moves most of the generated Java enums under content/ to use the
java_cpp_enum rule removing the need for keeping the enums in
separate list files and the need for the .template files.
BUG=405532, 351558
Review URL: https://codereview.chromium.org/615893003
Cr-Original-Commit-Position: refs/heads/master@{#297789}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
This moves most of the generated Java enums under net/ to use the
java_cpp_enum rule removing the need for keeping the enums in
separate list files and the need for the .template files.
BUG=405532
Review URL: https://codereview.chromium.org/599493004
Cr-Original-Commit-Position: refs/heads/master@{#297420}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f6ebbf6b7c4a6d0626979198cfca64cb92cb2833
Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):
Traceback (most recent call last):
File "src/build/landmines.py", line 132, in <module>
sys.exit(main())
File "src/build/landmines.py", line 119, in main
gyp_environment.SetEnvironment()
File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'
Original issue's description:
> Make landmines work on local builds too
>
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
>
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
>
> R=iannucci@chromium.org
> BUG=400011
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011
Review URL: https://codereview.chromium.org/469623002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289158 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.
landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.
R=iannucci@chromium.org
BUG=400011
Review URL: https://codereview.chromium.org/457003004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289099 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This pulls in the following CLs:
- r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
- r1347 Stringify minidump stream_type constants in minidump_dump output
- r1348 Ensure C:/Dumps/ exists in crash_generation_app
- r1349 Change some ELF utils to return the length as a size_t
- r1350 Add frame pointer recovery to the AMD64 Stackwalker.
- r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.
BUG=394841,393903
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284101R=mark@chromium.org
Review URL: https://codereview.chromium.org/400203002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The binary_size tool suit includes tools that are useful when trying
to reduce binary size of a program, and chromium related programs
in particular.
This commit (mostly written by andrewhayden@chromium.org for
Android but ported to generic Linux by bratell@opera.com) adds
a graphical HTML based output for run_binary_size_analysis.py.
In the generated web page it is possible to dynamically and
graphically browse the binary and each part of the source tree
is given a size that reflects its contribution to the binary size.
The run_binary_size_analysis tool is run on compiled binaries
with symbols and uses nm and addr2line to map parts of the
binary to source code. Since addr2line is slow the operation to map
binary symbols to source files takes a while but the output is
well worth it when shrinking programs. See its usage information
for details about how to run it.
This commit also includes the tool explain_binary_size_delta.py
(textual output) which can be used to understand why a binary
changed size and in what way. See its usage information for
details about how to run it.
There are many further improvements possible to to do on these tools.
Search the bug database for Label:Tools-BinarySize for suggestions.
BUG=339059
R=primiano@chromium.org,andrewhayden@chromium.org
Review URL: https://codereview.chromium.org/258633003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272255 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
https://src.chromium.org/viewvc/chrome?view=rev&revision=271919 fixes the
compiler crash, http://src.chromium.org/viewvc/chrome?view=rev&revision=271780
fixes the bug in landmines that didn't allow the initial land/revert to
go smoothly.
Should be A-OK this time.
> Revert 271721 "VS2013 Update 2"
>
> static_library build ICEing on some builders on mini_installer.
>
> > VS2013 Update 2
> >
> > As discussed in the linked bug, the toolchain2013.py script in
> > depot_tools is no longer workable (because the update for Update 2 is
> > supplied as a .msp that must be applied against a system-installed
> > VS2013).
> >
> > As such, the Express hash here is not updated.
> >
> > The hash zip referenced here was built as follows:
> > - Install VS2013 Update 2 on a clean VM
> > - Copy DIA SDK\, VC\
> > - Copy DLLs from VC\redist to sys32\ and sys64\
> > - Copy win8sdk unchanged from previous .zip.
> > - Delete various unused arm\ subdirectories
> > - Delete the IDE-only Snippets, etc. subdirectories in VC\
> > - Patch VC\include\xtree to disable warning 4702 per request in
> > http://crbug.com/346399 .
> >
> > A followup change will be to write a script that does these steps
> > semi-automatically, hopefully for Express too, though there is the
> > added complication of the WDK/ATL/MFC hacking required there. In
> > particular, this script will not be useful for a dev to actually run
> > as part of runhooks, but will be a bit useful for deployment/
> > documentation of the above process.
> >
> > In the interim there are no extremely-pressing reasons for Express
> > users to update to Update2 that I'm aware of, so they get non-Update2
> > for now.
> >
> > R=iannucci@chromium.org
> > BUG=372451,346399,371847,339215,350639
> >
> > Review URL: https://codereview.chromium.org/284663003
>
> TBR=scottmg@chromium.org
>
> Review URL: https://codereview.chromium.org/297753002TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/295093004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271921 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
static_library build ICEing on some builders on mini_installer.
> VS2013 Update 2
>
> As discussed in the linked bug, the toolchain2013.py script in
> depot_tools is no longer workable (because the update for Update 2 is
> supplied as a .msp that must be applied against a system-installed
> VS2013).
>
> As such, the Express hash here is not updated.
>
> The hash zip referenced here was built as follows:
> - Install VS2013 Update 2 on a clean VM
> - Copy DIA SDK\, VC\
> - Copy DLLs from VC\redist to sys32\ and sys64\
> - Copy win8sdk unchanged from previous .zip.
> - Delete various unused arm\ subdirectories
> - Delete the IDE-only Snippets, etc. subdirectories in VC\
> - Patch VC\include\xtree to disable warning 4702 per request in
> http://crbug.com/346399 .
>
> A followup change will be to write a script that does these steps
> semi-automatically, hopefully for Express too, though there is the
> added complication of the WDK/ATL/MFC hacking required there. In
> particular, this script will not be useful for a dev to actually run
> as part of runhooks, but will be a bit useful for deployment/
> documentation of the above process.
>
> In the interim there are no extremely-pressing reasons for Express
> users to update to Update2 that I'm aware of, so they get non-Update2
> for now.
>
> R=iannucci@chromium.org
> BUG=372451,346399,371847,339215,350639
>
> Review URL: https://codereview.chromium.org/284663003TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/297753002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271737 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
As discussed in the linked bug, the toolchain2013.py script in
depot_tools is no longer workable (because the update for Update 2 is
supplied as a .msp that must be applied against a system-installed
VS2013).
As such, the Express hash here is not updated.
The hash zip referenced here was built as follows:
- Install VS2013 Update 2 on a clean VM
- Copy DIA SDK\, VC\
- Copy DLLs from VC\redist to sys32\ and sys64\
- Copy win8sdk unchanged from previous .zip.
- Delete various unused arm\ subdirectories
- Delete the IDE-only Snippets, etc. subdirectories in VC\
- Patch VC\include\xtree to disable warning 4702 per request in
http://crbug.com/346399 .
A followup change will be to write a script that does these steps
semi-automatically, hopefully for Express too, though there is the
added complication of the WDK/ATL/MFC hacking required there. In
particular, this script will not be useful for a dev to actually run
as part of runhooks, but will be a bit useful for deployment/
documentation of the above process.
In the interim there are no extremely-pressing reasons for Express
users to update to Update2 that I'm aware of, so they get non-Update2
for now.
R=iannucci@chromium.org
BUG=372451,346399,371847,339215,350639
Review URL: https://codereview.chromium.org/284663003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271721 4ff67af0-8c30-449e-8e8b-ad334ec8d88c