7599696007
Fix +x on Windows-only binary after 92d69f7733
...
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/948923002
Cr-Original-Commit-Position: refs/heads/master@{#317659}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a75f28fac6c844bd77d593990fcd19d81d65731
2015-02-23 21:53:20 +00:00
f7c6ccd43b
Add dbghelp.dll that works on XP, and include in base.isolate
...
This fixes the hang that caused the addition of the early out in
stack_trace_win.cc.
Removing that in turn fixes symbolization of stack traces on XP bots.
R=cpu@chromium.org
BUG=460506
Review URL: https://codereview.chromium.org/943933005
Cr-Original-Commit-Position: refs/heads/master@{#317651}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92d69f7733f4028cf8b3d5b4b97a31173e687594
2015-02-23 21:15:53 +00:00
ca257503a2
Cleanup: Remove unused Windows script.
...
Now that Visual Studio 2013 is the supported toolchain, this may not be
necessary and used by anyone anymore.
BUG=None
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/940123006
Cr-Original-Commit-Position: refs/heads/master@{#317514}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 52b006bfeea47592dce7ab8ff97867e98ac39143
2015-02-21 16:58:08 +00:00
ad8ddf9c0a
Update the path to the ASan/Win MD runtime now that we're using clang 3.7.0
...
BUG=448789,345874
TBR=hans@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/879863003
Cr-Original-Commit-Position: refs/heads/master@{#313267}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00d64bc73bfa9d5ffcb086cc8cbae39513391067
2015-01-27 13:27:57 +00:00
40c9d08ba5
Win/Clang: the ASan run-time DLL has moved
...
BUG=345874
NOTRY=true
Review URL: https://codereview.chromium.org/746423005
Cr-Original-Commit-Position: refs/heads/master@{#306888}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c5a784437a72c5a881751bac2aa682eaf9d89784
2014-12-04 21:01:36 +00:00
b95cd38a1f
Add supportedOS GUID for Windows 10
...
R=grt@chromium.org
BUG=420629
Review URL: https://codereview.chromium.org/627003004
Cr-Original-Commit-Position: refs/heads/master@{#298339}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c5b4ba478cb54f9bd07edb34bb965c1aac246b36
2014-10-07 02:50:13 +00:00
d720857baf
Add GYP dependencies for the ASan RTL in the component build mode
...
BUG=345874
NOTRY=true
Review URL: https://codereview.chromium.org/517383003
Cr-Original-Commit-Position: refs/heads/master@{#292655}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e2f3e261755cdc688ac0e0492655695e7e6f73d
2014-08-29 16:55:09 +00:00
9a722f07f6
Remove ftol workaround since we're rolled to Update2
...
We were previously linking in this .obj file which patched the broken
ftol that was causing floating point stack overflows. This is fixed
in VS2013 Update2 and so is no longer required.
https://connect.microsoft.com/VisualStudio/feedback/details/808199
R=cpu@chromium.org
BUG=348525
Review URL: https://codereview.chromium.org/318153002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275581 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-07 01:27:15 +00:00
b16d1a815e
Add ftol workaround for VS2013
...
The .obj was taken from
https://connect.microsoft.com/VisualStudio/feedback/details/808199
offered as a workaround by Microsoft. This fixes the floating point
stack going unbalanced.
This is fixed in Update 2, and can be removed once that's rolled
out.
R=cpu@chromium.org , jam@chromium.org
BUG=348525
Review URL: https://codereview.chromium.org/186333002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@254792 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-03-04 19:01:12 +00:00
79cf8a5b17
Add --no-logo to reorder-imports.py.
...
Note, depends on https://codereview.appspot.com/57170049/ landing and Syzygy DEPS rolling to take effect.
BUG=335802
TEST=Silent builds again!
Review URL: https://codereview.chromium.org/148933005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250388 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-02-11 14:04:59 +00:00
20d33f5870
Call SwapImports on x64 builds too.
...
BUG=335173
Review URL: https://codereview.chromium.org/149023008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@249859 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-02-08 00:08:18 +00:00
c31efe5bdc
Remove build references to third_party/cygwin
...
There's test running dependencies in blink and buildbot,
so the directory/DEPS can't be removed right now. For the
time being, remove the build related entries.
R=maruel@chromium.org , thakis@chromium.org
BUG=123026
TEST=remove from DEPS and .DEPS.git, delete HKCU\Software\Cygnus Solutions\... and build successfully.
Review URL: https://codereview.chromium.org/149063008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248802 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-02-04 23:00:37 +00:00
f9239b2372
Delete some msvs_cygwin_shell:0
...
This is the default, so these are no-ops.
TBR=thakis@chromium.org
BUG=123026
Review URL: https://codereview.chromium.org/141693007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247039 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-25 00:45:40 +00:00
5c48a8f64b
Temporary fix for telemetry builds
...
Until we get the swapimport tool up and running on x64 builds of Windows.
BUG=335945,336025
Review URL: https://codereview.chromium.org/137643003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245928 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-20 18:10:44 +00:00
6d78c04067
1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
...
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197
Review URL: https://codereview.chromium.org/109483003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245312 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-16 20:58:27 +00:00
756f62a98b
Revert of Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe ( https://codereview.chromium.org/109483003/ )
...
Reason for revert:
Tests failing on Win x64 bots.
Original issue's description:
> 1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
> 2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197
TBR=robertshield@chromium.org ,siggi@chromium.org,csharp@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/132613004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245214 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-16 17:01:35 +00:00
e7ce66710d
1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds)
...
2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048
Review URL: https://codereview.chromium.org/109483003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245197 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-16 15:46:33 +00:00
3c0353800c
Embed compatibility manifest into all *.exe files
...
This CL introduces an automated and centralized way to embed
compatibility manifest into all *.exe files. With this CL,
a potential risk of behavioural inconsistency between
production binaries and unit test binaries is resolved by
enforcing the same compatibility context.
This CL uses 'target_conditions' feature of gyp to inject
manifest settings into each executable target. One tricky
part is that some executables such as setup.exe and
mini_installer.exe require external manifest file instead of
embedded one when component build is enabled.
See http://crbug.com/127233 for this.
You can override the gyp variable
'win_exe_compatibility_manifest' locally for a given
executable target to embed a custom compatibility manifest.
BUG=260692
Review URL: https://chromiumcodereview.appspot.com/19275010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@214427 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-30 20:24:30 +00:00
abfac8ed9a
Quench build spew.
...
R=scottmg@chromium.org
BUG=225195
Review URL: https://chromiumcodereview.appspot.com/13472015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191978 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-04-03 04:17:16 +00:00
4b8c3409bd
Check in a custom-built import library for user32 exports up to Windows XP SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library.
...
Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll".
Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll".
R=cpu@chromium.org
BUG=176040
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191173
Review URL: https://chromiumcodereview.appspot.com/12295040
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191418 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-29 19:17:58 +00:00
8ec6524c6d
Revert 191173 "Check in a custom-built import library for user32..."
...
> Check in a custom-built import library for user32 exports up to Windows XP SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library.
> Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll".
> Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll".
>
> R=cpu@chromium.org
> BUG=176040
>
>
> Review URL: https://chromiumcodereview.appspot.com/12295040
TBR=siggi@chromium.org
Review URL: https://codereview.chromium.org/13208002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191179 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-28 18:38:06 +00:00
495d67c8c4
Check in a custom-built import library for user32 exports up to Windows XP SP2/SP3, which is used by chrome.dll in preference to the Platform SDK's user32.lib import library.
...
Custom build an import library for Chrome's post-WinXP imports, that binds to a fictional "user32-delay.dll".
Implement and test a delay load hook that diverts dynamic loading of any dll "foo-delay.dll" to "foo.dll".
R=cpu@chromium.org
BUG=176040
Review URL: https://chromiumcodereview.appspot.com/12295040
git-svn-id: http://src.chromium.org/svn/trunk/src/build@191173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-28 17:51:09 +00:00
8f187fd9ee
Separate CL to check in import library binary from https://codereview.chromium.org/12295040/ as it has to be manually committed.
...
BUG=176040
Review URL: https://codereview.chromium.org/12939020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190721 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-26 18:35:19 +00:00
ff50d0dcb5
Set svn:executable bit on scripts that are executable.
...
R=mark@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10165021
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133399 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-04-23 03:24:12 +00:00
84f7015a80
Remove unused cygwin build step
...
All references have now been removed.
BUG=111731
Review URL: http://codereview.chromium.org/9317020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@120350 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-02-03 18:07:49 +00:00
d0dbcedb9a
Was previously testing wrong condition: 'win' in platform is true for "dar'win'" too.
...
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9159050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@119766 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-01-30 23:32:35 +00:00
301b5065de
run cygwin mount setup in runhooks, and remove some references to it
...
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9223028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@119708 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-01-30 19:35:17 +00:00
eb420fbc2a
Add install-build-deps.py to patch msbuild for vs2010
...
(patch discussed in bug and on connect page)
BUG=97534
Review URL: https://chromiumcodereview.appspot.com/9265019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118381 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-01-19 23:00:06 +00:00
c9ee63aad7
Remove the comments setting emands and vim tab width and expansion variables.
...
These were added in r28089 (http://codereview.chromium.org/256059 ) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@92046 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-07-11 20:22:46 +00:00
4bf37fdb76
Exclude ChromeOS directories and files from mac win linux.
...
Extension of this change, applied more liberally:
http://src.chromium.org/viewvc/chrome/trunk/src/build/linux/chrome_linux.croc?r1=44710&r2=46647
Review URL: http://codereview.chromium.org/3540002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@61430 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-10-04 22:56:50 +00:00
34ca68beb9
TTF: Don't include v8 in the coverage results. Also moves common rules to common.croc.
...
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2022007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@47071 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-05-12 21:10:56 +00:00
8db3187032
Measure coverage for NaCl code
...
Review URL: http://codereview.chromium.org/1618027
git-svn-id: http://src.chromium.org/svn/trunk/src/build@44710 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-04-15 22:01:47 +00:00
8863f541c7
Remove the grd clobber script on Windows.
...
Now that we have more and more proper grd dependencies in place,
this script may just do more harm than good by causing spurious rebuilds.
Additionally, it horked the build today.
TEST=none
BUG=17706
Review URL: http://codereview.chromium.org/1019007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@41947 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-03-18 12:40:52 +00:00
a31dd79166
Add browser_tests to coverage (note recent mac fixes).
...
Add platform-specific coverage capability.
Add courgette to windows coverage.
BUG=none
TEST=make sure coverage bots work (continue to have ~36% coverage).
Review URL: http://codereview.chromium.org/545107
git-svn-id: http://src.chromium.org/svn/trunk/src/build@36502 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-01-19 00:37:39 +00:00
7930aa5773
Add windows croc file
...
Review URL: http://codereview.chromium.org/460033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@33653 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-12-03 02:17:11 +00:00
19ba4b483e
Add comments setting emacs and vim tab width and expansion variables.
...
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@28089 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-10-06 03:02:38 +00:00
650f43b727
The buildbots compile into src/build/{Debug,Release} but this script
...
assumes that the build output is in src/chrome/{Debug,Release}. Update
the clobber script to look in both places.
Review URL: http://codereview.chromium.org/255015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@27580 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-30 00:53:38 +00:00
348eca2172
Force inclusion of build/common.gypi for all chromium gyp files.
...
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@26302 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-15 23:52:14 +00:00
3bbad9bbbb
Cosmetic fixes to clobber_generated_headers.py:
...
Only try to remove a generated header file if it exists.
Only report "Clobbered" if we actually removed something.
Print the actual system error if the removal fails.
Print the error message on stderr, not stdout.
Normalize the header file path name.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164173
git-svn-id: http://src.chromium.org/svn/trunk/src/build@23736 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-08-19 20:41:13 +00:00
555667afe6
Fix the expected path logic in clobber_generated_headers.py
...
TEST=If it doesn't break the tree, it's perfect.
http://crbug.com/17706
Review URL: http://codereview.chromium.org/164096
git-svn-id: http://src.chromium.org/svn/trunk/src/build@22978 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-08-11 00:02:00 +00:00
f40bb0cfec
Re-enable the grit hook, and make it more solid in case of failures.
...
I was unable to reproduce the failures from the bots on my machine.
If they appear again, the build will not break, ane we will get full info.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159866
git-svn-id: http://src.chromium.org/svn/trunk/src/build@22480 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-08-05 15:24:53 +00:00
534b61d558
Fix infinite loop in grit headers clobbering script.
...
It turns out that on Windows the path-splitting function will always preserve the drive part (c:\).
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159827
git-svn-id: http://src.chromium.org/svn/trunk/src/build@22344 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-08-03 23:24:31 +00:00
2f5382a860
Add hook to clobber header files generated by grit on Windows.
...
This workarounds build problem with IncrediBuild.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159803
git-svn-id: http://src.chromium.org/svn/trunk/src/build@22325 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-08-03 21:58:41 +00:00
4d8e00ace8
Pulling in new gyp version.
...
Working around change in msvs_cygwin_shell added for nacl.
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/155393
git-svn-id: http://src.chromium.org/svn/trunk/src/build@20449 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-07-11 01:02:08 +00:00
035e6f4fe7
Switching cygwin setup_mount project to use bare command line.
...
Otherwise you're assuming you have cygwin in order to set it up.
Review URL: http://codereview.chromium.org/113505
git-svn-id: http://src.chromium.org/svn/trunk/src/build@16246 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-05-16 22:17:56 +00:00
e29d54f9d9
Add a 'cygwin' target to execute setup_mount.bat explicitly as a
...
dependency of targets that need it (that is, any target with
'rules' or 'actions').
Review URL: http://codereview.chromium.org/115154
git-svn-id: http://src.chromium.org/svn/trunk/src/build@15774 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-05-11 20:01:24 +00:00
Scott Graham
tfarina
timurrrr
hans
scottmg@chromium.org
robertshield@chromium.org
caitkp@chromium.org
Yukawa@chromium.org
siggi@chromium.org
rlarocque@chromium.org
maruel@chromium.org
scottmg@google.com
tony@chromium.org
jrg@chromium.org
jhawkins@chromium.org
gregoryd@google.com
phajdan.jr@chromium.org
sgk@google.com
yaar@chromium.org
bradnelson@chromium.org