This reverts commit 9cd170f05955bc31ed7ee43c24f01383d8cb2da8.
Reason for revert: Likely broke the compilation on ToTLinux (dbg): https://ci.chromium.org/p/chromium/builders/ci/ToTLinux%20%28dbg%29/11140
Original change's description:
> Implement DWARF Fission support in Chrome Android.
>
> - This is a fixed version of
> https://chromium-review.googlesource.com/c/chromium/src/+/1975081,
> which was reverted because it caused a build failure for ChromeOS.
> - Build failure in ChromeOS is now fixed by checking for target_os in
> Fission-related build configs.
> - Modify some compiler build definitions to allow symbol_level=2 with
> Chrome Android 32bit, and to make the build respect use_debug_fission in
> those cases.
> - Modify "link" and "solink" tools in Android toolchain so that DWP
> files can be generated for builds with use_debug_fission.
> - Modify partitioned_shared_library template/script so that DWP files
> can be generated for partitioned libs when use_debug_fission is set.
> - Assert that ThinLTO and Fission aren't enabled at once for Android
> build, since this will cause Fission stuff to silently fail.
>
> Change-Id: Ia55bd893cfb73b418544e1029f57f41d5308f154
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995743
> Commit-Queue: Nelson Billing <nbilling@google.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734777}
TBR=thakis@chromium.org,agrieve@chromium.org,scottmg@chromium.org,nbilling@google.com
Bug: 1045333
Change-Id: Ibf3724a3c5c4b8b349a3fd87b2f13e376bd726b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017353
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#734853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14b686f408617c9953d665171f550ea0a9fb06b7
- This is a fixed version of
https://chromium-review.googlesource.com/c/chromium/src/+/1975081,
which was reverted because it caused a build failure for ChromeOS.
- Build failure in ChromeOS is now fixed by checking for target_os in
Fission-related build configs.
- Modify some compiler build definitions to allow symbol_level=2 with
Chrome Android 32bit, and to make the build respect use_debug_fission in
those cases.
- Modify "link" and "solink" tools in Android toolchain so that DWP
files can be generated for builds with use_debug_fission.
- Modify partitioned_shared_library template/script so that DWP files
can be generated for partitioned libs when use_debug_fission is set.
- Assert that ThinLTO and Fission aren't enabled at once for Android
build, since this will cause Fission stuff to silently fail.
Change-Id: Ia55bd893cfb73b418544e1029f57f41d5308f154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995743
Commit-Queue: Nelson Billing <nbilling@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#734777}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9cd170f05955bc31ed7ee43c24f01383d8cb2da8
This reverts commit de763ddc3a3d7e9cdd667f9620b406ca5138cd66.
Reason for revert: Causing consistent build failures on https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel See crbug.com/1040636 for more info.
Original change's description:
> Implement DWARF Fission support in Chrome Android.
>
> - Modify some compiler build definitions to allow symbol_level=2 with
> Chrome Android 32bit, and to make the build respect use_debug_fission in
> those cases.
> - Modify "link" and "solink" tools in Android toolchain so that DWP
> files can be generated for builds with use_debug_fission.
> - Modify partitioned_shared_library template/script so that DWP files
> can be generated for partitioned libs when use_debug_fission is set.
>
> Change-Id: I85b755302976d9675ef00c5a79f5184ecc8dbd4b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975081
> Commit-Queue: Nelson Billing <nbilling@google.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729858}
TBR=thakis@chromium.org,agrieve@chromium.org,scottmg@chromium.org,nbilling@google.com
Change-Id: I3f3e446ba7ce07034301663af4d2cf0b5cd95982
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993901
Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#729884}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3ad8642063d2d9b9c4ed3462d95de529f32c7564
- Modify some compiler build definitions to allow symbol_level=2 with
Chrome Android 32bit, and to make the build respect use_debug_fission in
those cases.
- Modify "link" and "solink" tools in Android toolchain so that DWP
files can be generated for builds with use_debug_fission.
- Modify partitioned_shared_library template/script so that DWP files
can be generated for partitioned libs when use_debug_fission is set.
Change-Id: I85b755302976d9675ef00c5a79f5184ecc8dbd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975081
Commit-Queue: Nelson Billing <nbilling@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#729858}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de763ddc3a3d7e9cdd667f9620b406ca5138cd66
A typo in the introduction of this (currently unused) tooling caused the
VR library to blow up when opened (it was actually a copy of the main
library instead of a partition).
Bug: 921663
Change-Id: I80264954bd42d50e0df49513ffd94d8b8547e281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602157
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#658131}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dcbf30138aa44accaa54b021ec141c9bd5387c27
This change builds on the prototype posted by pcc@, here:
http://crrev.com/c/1521283
The partitioned_shared_library GN template may be used in place of
shared_library to create a set of libraries linked simultaneously. This
will be leveraged in later changes to split code into Android dynamic
feature modules. The current change adds the GN template for the set of
partitions, along with the Python wrapper script invoked by GN.
Bug: 921663
Change-Id: I805d598b03ae15bd4ceeb8e915526ed8b15af4cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568772
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#654117}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b06acce01851078c171e97d7480b8b719e7f6d9
Martin Šrámek
Nelson Billing
sebsg
Christopher Grant