jyquinn
2695bccd4a
Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (patchset #1 id:1 of https://codereview.chromium.org/2344243002/ )
...
Reason for revert:
Breaks iOS build with failure:
FAILED: gen/linked_src/third_party/objective_c/google_toolbox_for_mac
python ../../build/symlink.py --update-target-mtimes -f ../../../../../../third_party/google_toolbox_for_mac/src gen/linked_src/third_party/objective_c/google_toolbox_for_mac
Traceback (most recent call last):
File "../../build/symlink.py", line 65, in <module>
sys.exit(Main(sys.argv))
File "../../build/symlink.py", line 56, in Main
os.utime(s, None)
OSError: [Errno 2] No such file or directory: '../../../../../../third_party/google_toolbox_for_mac/src'
Original issue's description:
> Add work-around to symlink.gni to avoid "not up-to-date" ninja errors
>
> Ninja bug: https://github.com/ninja-build/ninja/issues/1186
>
> BUG=646165
>
> Committed: https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa
> Cr-Commit-Position: refs/heads/master@{#419751}
TBR=dpranke@chromium.org ,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=646165
Review-Url: https://codereview.chromium.org/2356973002
Cr-Original-Commit-Position: refs/heads/master@{#419871}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65f3a42b24088c3a96de9becbe96c4a0094ca843
2016-09-20 22:16:30 +00:00
agrieve
c7bae1174e
Add work-around to symlink.gni to avoid "not up-to-date" ninja errors
...
Ninja bug: https://github.com/ninja-build/ninja/issues/1186
BUG=646165
Review-Url: https://codereview.chromium.org/2344243002
Cr-Original-Commit-Position: refs/heads/master@{#419751}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 80f464d5151c3eec102604faf5fa36d9369b64aa
2016-09-20 14:15:27 +00:00
bpastene
e766152188
Expand the ~ character in link_names of symlink.py
...
BUG=565452
Review URL: https://codereview.chromium.org/1811933007
Cr-Original-Commit-Position: refs/heads/master@{#382321}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a516b28437b3f5f483b2dc9e7f175ca94bdd1223
2016-03-21 17:54:51 +00:00
bpastene
1ca07908a0
dont symlink if it's already correctly linked
...
BUG=565452
Review URL: https://codereview.chromium.org/1632073002
Cr-Original-Commit-Position: refs/heads/master@{#371380}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e1758d341770bb9b009483f6de721a1d6f97fcb3
2016-01-26 00:33:20 +00:00
agrieve
b27bcf3840
GN (android): Fix md5sum_bin_host not working for component builds
...
This affected all test_runner.py invokations.
BUG=510442
Review URL: https://codereview.chromium.org/1233313003
Cr-Original-Commit-Position: refs/heads/master@{#338898}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6cc97ff4e7c37054de5931e2ce07fb469766d204
2015-07-15 20:13:54 +00:00
eseidel
b78630700f
Teach build/symlink.py --force to delete directories.
...
Otherwise os.remove just fails saying it can't delete a directory.
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1222573002
Cr-Original-Commit-Position: refs/heads/master@{#337083}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: add100b7cd19ae6caad54ac6c6ed9766b7f1f70b
2015-07-01 19:10:18 +00:00
mostynb@opera.com
b9819b1385
Skip argv[0] when processing command line options in symlink.py
...
The problem fixed by this patch is that this script always creates a link
to itself in the target location. That behavior was probably not intended
and caused problems when running this script several times with the same
target folder. Each run of this script would create one expected link and
one link to the script itself. Meaning that the need to use --force the
second time was needed to overwrite the "self-link" from the first run.
Even with --force there were issues if this script was run in parallel
since there can be a race condition in overwriting the "self-link".
Review URL: https://chromiumcodereview.appspot.com/16096006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@202661 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-05-28 21:49:11 +00:00
phajdan.jr@chromium.org
5740174015
Make use_system_mesa switch work: make symlinks
...
for nacl untrusted build.
BUG=161389
Review URL: https://codereview.chromium.org/11862016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@178028 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-01-22 17:57:14 +00:00