The CL https://codereview.chromium.org/1771173002/ introduced a
cycle in gyp files, which is not allowed on iOS:
Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp
This cycle is not actually real on iOS, as it is under a OS!=iOS condition,
It was detected because, when building the mac tools,
gyp_chromium was invoked with OS=iOS.
This OS configuration was internally discarded when actually building
(because of the --ignore-environment flag that was passed), but
was still triggering the check for circular gyp dependencies.
TBR=thakis
Review URL: https://codereview.chromium.org/1797283002
Cr-Original-Commit-Position: refs/heads/master@{#381248}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a5430a08444415e4a7bd3cf15675136bf89eec31
Clear the default value in build/common.gypi and remove overrides in
.gyp files. Leave support for whitelisting in grit_action.gypi as it
is still used downstream and on android.
BUG=548645
Review URL: https://codereview.chromium.org/1489403004
Cr-Original-Commit-Position: refs/heads/master@{#364078}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 32aa7b67dadee74d6e89bd93682354cced97e06c
Put iOS chrome://flags & chrome://ui-alternatives resources and
strings to components/flags_ui so that they live close to the
corresponding shared resources.
BUG=554966
Review URL: https://codereview.chromium.org/1500533002
Cr-Original-Commit-Position: refs/heads/master@{#363527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: da218471f007776d7ed87b7c99341b56949fdd05
Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)
BUG=134849
Review URL: https://codereview.chromium.org/1395073002
Cr-Original-Commit-Position: refs/heads/master@{#362997}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 07c5e062f2ea6ef0e3b5844f1a11ecb4df4d41f6
Move the strings IDS_FLAGS_ENHANCED_BOOKMARKS_{NAME,DESCRIPTION} to
//components/strings so that they can be shared with iOS.
BUG=551954
Review URL: https://codereview.chromium.org/1475293003
Cr-Original-Commit-Position: refs/heads/master@{#361908}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed25e27ac2c6bbcabc7a7908f802a8e74b5ee11c
Replace it with the equivalent ManagePasswordsUIController::NavigateToExternalPasswordManager.
Note: This CL does not remove IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE yet, because it is also used in other pieces of the password manager UI. We need to double-check if it is OK to merge that with chrome::kPasswordManagerAccountDashboardURL, or whether it just should be made a separate constant. Using localisation to get the hl= URL parameter is very likely an overkill, see #0 in http://crbug.com/548259.
R=vasilii@chromium.org
BUG=548259
Review URL: https://codereview.chromium.org/1467993002
Cr-Original-Commit-Position: refs/heads/master@{#361304}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1bff66d12e811993940e7dd01074768c30e0cd5b
Move FeatureEntry structure definition to components/flags_ui so that
it can be shared with iOS and move the helper macros to a secondary
header file for the same reason.
Move IDS_GENERIC_EXPERIMENT_CHOICE_* strings to flags_ui.grdp.
BUG=551954
Review URL: https://codereview.chromium.org/1415953005
Cr-Original-Commit-Position: refs/heads/master@{#359927}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 246c564da980b3dbbd0a062688ec65539b4b2c35
This CL componentizes strings used by ProfileSyncService in anticipation of
componentizing that class for integration on iOS.
BUG=512825
TBR=jochen
Review URL: https://codereview.chromium.org/1405383006
Cr-Original-Commit-Position: refs/heads/master@{#358292}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aa263a8c1ca63baf4ce1ad5521987162d2d46bec
Remove from build/ios/grit_whitelist.txt all resources that are
not needed.
Synchronize with downstream version of the file.
BUG=None
Review URL: https://codereview.chromium.org/1395153002
Cr-Original-Commit-Position: refs/heads/master@{#357542}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a8b75a6d21f35fc1b99578036114a998b50fc760
These files are moved in order to be shared on iOS.
- moved the resources to //components/version_ui/resources
- moved the strings to //components
- Merged version_info strings into version_ui strings.
- Renamed IDX_ABOUT_VERSION_* to IDX_VERSION_UI_*.
- moved the constants to //components/version_ui/version_ui_constants
TBR=jochen
Review URL: https://codereview.chromium.org/1332353003
Cr-Original-Commit-Position: refs/heads/master@{#354477}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fd959bad4fe04f3050651ad0cc36be4e948f0b3c
Currently if save prompt was triggered via Credential Management API,
the cancel button says "No Thanks" and do not blacklist the site.
After this patch the button will say "Never" and id user presses the
button, it will blacklist the site.
BUG=528980
Review URL: https://codereview.chromium.org/1402463004
Cr-Original-Commit-Position: refs/heads/master@{#354001}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fbacd4a393a056fe76e4cb1accf13ecfc03858d
Setting the flag loads an empty page at chrome://md-policy.
This is the scaffold for further development on the new Material
Design policy page without influencing the old one.
BUG=134849
Review URL: https://codereview.chromium.org/1321713004
Cr-Original-Commit-Position: refs/heads/master@{#352800}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c9018a4fe33078586afd9a0d3568f6fb15d44335
Stop using whitelisting for resources from components on the rationale
that it causes confusion for the developers and most of those resources
are used on iOS.
Stop support for whitelisting for resources when using gn as meta-build
system on the rationale that the migration will happen after Chrome on
iOS is unforked at which point whitelisting will not be used with gyp
either.
Update build/ios/grit_whitelist.txt to:
1. remove all resources from //components,
2. remove all resources that no longer exists,
3. add all resources used downstream (i.e. unfork the file).
TEST=Checked that clobber build compiled and all tests passed on both
the upstream and downstream tree with this CL.
BUG=429756
Review URL: https://codereview.chromium.org/1350453004
Cr-Original-Commit-Position: refs/heads/master@{#350526}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 502be01eec9af4fa82ce8abe4f6470735288b5e4
A screen reader should verbalise "settings" instead of "autofill
settings three dots" when the user taps the gear icon on the keyboard
accessory.
BUG=428087
Review URL: https://codereview.chromium.org/1357243003
Cr-Original-Commit-Position: refs/heads/master@{#350040}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7647c0a5f887011a4976a936326a46b956623e61
These are the possible sources for a policy:
Cloud - Policy values received from the cloud.
Platform - Local configured policies.
Enterprise Default - Defaults for policies in enterprise environments
on Chrome OS. Can be overridden.
Enterprise Override - Policies enforced in enterprise environments on
Chrome OS. Can NOT be overridden.
The source of a policy is determined when it's first set. For cloud
policies, this would be the decoding of the protocol buffers.
Platform policies are usually set by loading platform-specific local
configurations like entries in the Windows registry.
Enterprise defaults are automatically set if the device is active in
an enterprise environment.
Enterprise override policies are set within the code to enforce
specific behaviors (like ash tray visibility). They cannot be
overridden.
BUG=506123
TBR=jam@chromium.org
Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe
Cr-Commit-Position: refs/heads/master@{#349654}
Committed: https://crrev.com/2c4ce2a1988fdde3456e49112eba6c7855ca4528
Cr-Commit-Position: refs/heads/master@{#349749}
Review URL: https://codereview.chromium.org/1304843004
Cr-Original-Commit-Position: refs/heads/master@{#349927}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 64834b71e60e7861a80f68f80d5cde8a56107084
Reason for revert:
Fix google chrome compile. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/4220/steps/compile/logs/stdio
../../chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:1235:23:error:
too few arguments to function call, expected 6, have 5
NULL);
^
../../components/policy/core/common/policy_map.h:66:3: note: 'Set' declared here
void Set(const std::string& policy,
^
Original issue's description:
> Add source column to chrome://policy showing the origins of policies.
>
> These are the possible sources for a policy:
> Cloud - Policy values received from the cloud.
> Platform - Local configured policies.
> Enterprise Default - Defaults for policies in enterprise environments
> on Chrome OS. Can be overridden.
> Enterprise Override - Policies enforced in enterprise environments on
> Chrome OS. Can NOT be overridden.
>
> The source of a policy is determined when it's first set. For cloud
> policies, this would be the decoding of the protocol buffers.
> Platform policies are usually set by loading platform-specific local
> configurations like entries in the Windows registry.
> Enterprise defaults are automatically set if the device is active in
> an enterprise environment.
> Enterprise override policies are set within the code to enforce
> specific behaviors (like ash tray visibility). They cannot be
> overridden.
>
> BUG=506123
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe
> Cr-Commit-Position: refs/heads/master@{#349654}
>
> Committed: https://crrev.com/2c4ce2a1988fdde3456e49112eba6c7855ca4528
> Cr-Commit-Position: refs/heads/master@{#349749}
TBR=tnagel@chromium.org,bartfab@chromium.org,dbeam@chromium.org,jam@chromium.org,fhorschig@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=506123
Review URL: https://codereview.chromium.org/1350913006
Cr-Original-Commit-Position: refs/heads/master@{#349774}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8778b84c83b210d60046b538e9d16cfc1f534cd
These are the possible sources for a policy:
Cloud - Policy values received from the cloud.
Platform - Local configured policies.
Enterprise Default - Defaults for policies in enterprise environments
on Chrome OS. Can be overridden.
Enterprise Override - Policies enforced in enterprise environments on
Chrome OS. Can NOT be overridden.
The source of a policy is determined when it's first set. For cloud
policies, this would be the decoding of the protocol buffers.
Platform policies are usually set by loading platform-specific local
configurations like entries in the Windows registry.
Enterprise defaults are automatically set if the device is active in
an enterprise environment.
Enterprise override policies are set within the code to enforce
specific behaviors (like ash tray visibility). They cannot be
overridden.
BUG=506123
TBR=jam@chromium.org
Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe
Cr-Commit-Position: refs/heads/master@{#349654}
Review URL: https://codereview.chromium.org/1304843004
Cr-Original-Commit-Position: refs/heads/master@{#349749}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2c4ce2a1988fdde3456e49112eba6c7855ca4528
These are moved in order to be shared on iOS.
resource_ids are updated as follows:
generated_resources.grd: -100
components_strings.grd : +70
components_chromium_strings.grd: +10
components_resources.grd: +20
Review URL: https://codereview.chromium.org/1339803003
Cr-Original-Commit-Position: refs/heads/master@{#348949}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e89640c464a7e40c00f9b40852ee88e94fa04101
Following are the performance numbers for apprtc.appspot.com test
(no loopback) on Peppy.
With cpu governer = performance,
SW HW
latency(ms) 7.3 5.2
total CPU(%) 21.6 12.9
power (mWh/s) 2.2 2.2
With default cpu governer = ondemand,
SW HW
latency(ms) 10.3 5.5
total CPU(%) 27.4 22.1
power (mWh/s) 2.22 2.21
BUG=426381
TEST=test apprtc on squawks.
Review URL: https://codereview.chromium.org/1260923002
Cr-Original-Commit-Position: refs/heads/master@{#341072}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5ab150809ca86515cf4fa3fedd2696f71dfb51f
We no longer use it in any layout tests (recently removed the deferred
per-tile-painting tests). No reason to keep this around.
BUG=413479
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1179653004
Cr-Original-Commit-Position: refs/heads/master@{#334003}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 16275d4cfd5bc6c96414d2cba629acbd6efaa3fc
This change removes the 'view original' link and replaces it with
a button that currently navigates to the original article but will
eventually slide the view out of focus.
The feedback form and close button now span the full width of a page
while content is limited to 800px wide.
BUG=428533
Review URL: https://codereview.chromium.org/1160113004
Cr-Original-Commit-Position: refs/heads/master@{#333759}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ae0286c350696ba16a8119af2af4aee2f06859e9
Let them map to the default ERR_SSL_PROTOCOL_ERROR. It was added, along with a
custom error message, in https://crrev.com/51258. The
enforcement was then removed in https://codereview.chromium.org/6792032, but
the error code and custom message remained. Prune them; the error is now
unreachable but for some codepaths in NSS (server originally supported RI and
renego without it) and the custom error message is now innaccurate.
BUG=none
Review URL: https://codereview.chromium.org/1151833004
Cr-Original-Commit-Position: refs/heads/master@{#332125}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a38456c11f5f6031e6710e958f7838e978ee05d
This change allows content to be shown on the page prior to the
distillation of the first page of an article having completed.
The template HTML and the loading animation will show while the
distillation completes.
BUG=
Review URL: https://codereview.chromium.org/1130703003
Cr-Original-Commit-Position: refs/heads/master@{#331852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: efe2ac1d3e1650a1cec652566542ac492eafedb3
You can now delete things by long pressing suggestions in the dropdown (assuming it's the right kind of suggestion).
BUG=486153
Review URL: https://codereview.chromium.org/1134793004
Cr-Original-Commit-Position: refs/heads/master@{#330413}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c806c71f4a9e704d40b14df026a6ebfa0c2fcac1
This upstreams the bulk of the code necessary to support WebUI in the
iOS web layer. Much of this is forked off of the content/ versions,
which can't be used on iOS.
BUG=464810
Review URL: https://codereview.chromium.org/1110213002
Cr-Original-Commit-Position: refs/heads/master@{#327441}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f0e19f918f0d1e183d2ee35fdaca3b191e36c19b
and associated field trial and delete unused strings.
While at it, rename
IDS_OMNIBOX_EMPTY_HINT_WITH_DEFAULT_SEARCH_PROVIDER
to
IDS_SEARCH_BOX_EMPTY_HINT_WITH_DEFAULT_SEARCH_PROVIDER
TBR=kmadhusu
(for trivial rename change in chrome/browser/search/...)
BUG=447809
Review URL: https://codereview.chromium.org/1104513003
Cr-Original-Commit-Position: refs/heads/master@{#326932}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c9f46539657b1006216a026a1b5b7a6b52857f3a
Chrome trail-blazed using ICU plural format support in 2008~9. Due to the lack of support for plural in our translation pipeline, Chrome decided to use 6 strings (for each plural category) for each logical string and builds ICU's plural message pattern at run-time.
Now that we can utilize the translation pipeline that supports ICU syntax directly (as are Android and other Google products), we'd better switch to directly using ICU syntax.
That way, adding a new string requiring a plural formatting is made much simpler. And if necessary, we can add a gender support easily.
BUG=471827
TEST=ui_base_unit_tests --gtest_filter=*Format*
Review URL: https://codereview.chromium.org/1049513002
Cr-Original-Commit-Position: refs/heads/master@{#324517}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3a6c36bbd58de11de968cea7c271d5516d320dce
This change adds a HTML/CSS version of the YES/NO feedback form that
appears at the bottom of a distilled page. This form is either at
the bottom of the page or at the bottom of the distilled article
depending on which is larger.
This change depends on:
https://codereview.chromium.org/1015463004/
BUG=
Review URL: https://codereview.chromium.org/1049043003
Cr-Original-Commit-Position: refs/heads/master@{#323582}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87f0c35db730f3351b2da0858f4b93b5a58da33c
droger
stuartmorgan
sdefresne
fhorschig
vabr
blundell
mathp
estade
melandory
rouslan
dgrogan
felt
newt
tommi
dbeam
henryhsu
palmer
jdonnelly
kcwu
danakj
mdjones
davidben
mpearson
anujk.sharma
pbond
jshin
cjhopman