f64ef73d8bba Update project status docs for Windows
74c3eb8d0f3e doc: Fix links with plus signs in rendered output
71f6724239bf Disable end-to-end test of extra memory range removal
12536e06e526 Replace base/template_util.h stuff with C++11 type_traits
1fe622550d87 win: Check that UseHandler() has been called in
DumpAndCrash()
0d4438b2a547 win: Don't add zero-sized memory ranges to dump
96dba6713abf Make VS2015 build work
dbfcb5d03211 win: Cap indirect memory gathering
6a6a0c27ed0c win: Support dumping another process by causing it to crash
b6089da2bfab Roll mini_chromium to 783fdf3ccc1c
cf452d9a8608 Fix Mac after dbfcb5d03
a4649789a52f Roll mini_chromium to 0a9dc1c4feea
d6d726a0eb83 Update to use base/bit_cast.h to follow to follow
https://codereview.chromium.org/399313006
a02ba240062a Convert from scoped_ptr to std::unique_ptr
00d458adaf38 Roll mini_chromium to 964ee49aa24e
BUG=crashpad:104,crashpad:103,crashpad:98
Review URL: https://codereview.chromium.org/1921833002
Cr-Original-Commit-Position: refs/heads/master@{#389578}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9e3bcaa124626a0e2f1781fbb8c4a390930fc894
Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.
BUG=585585
Review URL: https://codereview.chromium.org/1915273002
Cr-Original-Commit-Position: refs/heads/master@{#389576}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d73e44f7177fe1dbb6e868120b985a6c9fb8a30
Compact Language Detector (CLD) v2 has been the only version used by Chromium
for several months. A PSA announcing deprecation was sent in September 2015, see
the bug for more details.
This change should be a no-op for all platforms, since all platforms are already
migrated to CLD v2.
BUG=605688
Review URL: https://codereview.chromium.org/1920853002
Cr-Original-Commit-Position: refs/heads/master@{#389544}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: edab266c2b432d1200dc1de23fc5424dcd8d3b23
Several targets require a build-time dependency on a framework bundle, but not a
link-time one. This can be if the target is only using the framework for its
resources or if it dlopen()s it at run-time.
framework_bundle now adds another target (target_name+link) that can be used if
something wants a link-time dependency on the framework bundle. By default, only
a build-time dependency is created.
BUG=297668
R=sdefresne@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/1910133002
Cr-Original-Commit-Position: refs/heads/master@{#389528}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 152572b1ae44de42b011c667c1d8bf317810851e
This showed up as a bottleneck for gn gen on Android. Refactoring these
out improves gn gen time (avg of 3 trails on my machine) from 2151->1984
BUG=none
Review URL: https://codereview.chromium.org/1909273002
Cr-Original-Commit-Position: refs/heads/master@{#389484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95ba4446355ffd95eca68d3c3ba7fc3c2e364b6d
Reason for revert:
Downstream iOS CLs aren't ready for this yet. Reverting for now.
Original issue's description:
> Add Archive step for iOS builds.
>
> Future xctest support will set the test's bundle_loader to Chromium and look
> for Chromium internals. Setting `-fvisibility=hidden` during compile and
> stripping after linking makes graybox testing from xctest impossible.
>
> Instead, add a new 'Archive' configuration -- the same as what Xcode does --
> where visibility is set to hidden and stripping is done after linking, but skip
> those steps on the remaining configurations.
>
> This CL should land concurrently with an official bot script change to compile
> `ninja -C out/Release-iphoneos ; ninja -C out/Archive-iphoneos chrome`
> and to pull official binaries from out/Archive-iphoneos instead of
> Release-iphoneos.
>
> BUG=
> TBR=thakis@chromium.org
>
> Committed: https://crrev.com/aeaf816fe1be6ef1fc9f71a205bcc21e9625964f
> Cr-Commit-Position: refs/heads/master@{#389404}
TBR=sdefresne@chromium.org,baxley@chromium.org,rohitrao@chromium.org,smut@google.com,mark@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1919903002
Cr-Original-Commit-Position: refs/heads/master@{#389479}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b649ffbfb9492874a09804ca9d5b67bdc7967938
Contains fix for ui_base_tests not having data set correctly for android.
TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,apacible@chromium.org
NOTRY=true
BUG=589318
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1916503002
Cr-Original-Commit-Position: refs/heads/master@{#389470}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e41ae190dadf81f1561c8cdfd8b308b213817210
The tip-of-tree Clang bots rely on an environment variable
called LLVM_FORCE_HEAD_REVISION to be set in order to know
to fetch the tip-of-tree Clang and use its version in the compile
time defines, rather than the checked-in version.
We don't want GN to use or depend on environment variables,
so this patch modifies the clang update script to also look at
a new command line arg, and adds a GN arg called 'llvm_force_head_revision' to cause the same effect.
However, we need to keep the env var around for `gclient runhooks`
and to keep the existing bots (and devs) working while on GYP,
and, perhaps more importantly, adding a new GYP_DEFINE that
does what we need to build/common.gypi is proving intractable,
so we hack MB to rewrite what the GYP_DEFINE would be if life
made sense back into the env var.
BUG=481692, 582737
R=thakis@chromium.org, brettw@chromium.org
Review URL: https://codereview.chromium.org/1908293002
Cr-Original-Commit-Position: refs/heads/master@{#389408}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 909bad6afa7124f67c4890f3c1bc244179141978
Future xctest support will set the test's bundle_loader to Chromium and look
for Chromium internals. Setting `-fvisibility=hidden` during compile and
stripping after linking makes graybox testing from xctest impossible.
Instead, add a new 'Archive' configuration -- the same as what Xcode does --
where visibility is set to hidden and stripping is done after linking, but skip
those steps on the remaining configurations.
This CL should land concurrently with an official bot script change to compile
`ninja -C out/Release-iphoneos ; ninja -C out/Archive-iphoneos chrome`
and to pull official binaries from out/Archive-iphoneos instead of
Release-iphoneos.
BUG=
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1907053003
Cr-Original-Commit-Position: refs/heads/master@{#389404}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aeaf816fe1be6ef1fc9f71a205bcc21e9625964f
Many executables are missing embedded manifest files when built with gn,
and remoting_desktop is missing the OS compatibility information. This
change cleans up most of these problems.
BUG=602505
Review URL: https://codereview.chromium.org/1906193002
Cr-Original-Commit-Position: refs/heads/master@{#389306}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3eee0c968569c726bd8ca26c0a70b929b87f1427
Reason for revert:
rnk might have fixed this upstream, let's give it a try :-)
Original issue's description:
> clang/win: Disable precompiled headers.
>
> The protobuf3 roll triggered a compiler crash in the pch codepath.
>
> BUG=605570
> R=hans@chromium.org
>
> Committed: https://crrev.com/589ef6b6a9d60b21d6c78b92887de1b9d04b7e0f
> Cr-Commit-Position: refs/heads/master@{#388887}
TBR=hans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605570
Review URL: https://codereview.chromium.org/1914673002
Cr-Original-Commit-Position: refs/heads/master@{#389213}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8b6d787f07401e9c72a5858a00a396981bbc018d
Now uses gen.runtime rather than gen to be included by
builder/tester configurations.
TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,agrieve@chromium.org
NOTRY=true
BUG=589318
Review URL: https://codereview.chromium.org/1914573002
Cr-Original-Commit-Position: refs/heads/master@{#389148}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5d205baf70287fec693da0166aa7aa8051b5985e
http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit
that cause build failures when using Xcode version of clang (loading clang
plugin fails).
http://crrev.com/1910843002 tried to disable mojo_public_bindings_unittests
only, but the build present the same breakage after the latest roll. Disable
all mojo targets until the dependency on third_party/WebKit is fixed.
BUG=605508
Review URL: https://codereview.chromium.org/1915493003
Cr-Original-Commit-Position: refs/heads/master@{#389129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b582bd87eef350aed20c52eb552bf5e101e01b58
This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.
BUG=431177
Review URL: https://codereview.chromium.org/1902593003
Cr-Original-Commit-Position: refs/heads/master@{#389111}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4806ea270d3151fddb36117261fbebb28ecbb2c4
Tests use write_runtime_deps to have GN write out all runtime_deps, then
use a new script "generate_isolate.py" to filter the files and create a
.isolate.
TBR=vollick
BUG=589318
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1904823003
Cr-Original-Commit-Position: refs/heads/master@{#389105}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 964da0f3923afb10a52dfe81484d7f3dcb18bad6
http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit
that cause build failures when using Xcode version of clang (loading clang
plugin fails).
As mojo is currently not used on iOS, remove the dependency temporarily
by not building mojo/mojo_edk_tests.gyp:mojo_public_bindings_unittests.
BUG=605508
Review URL: https://codereview.chromium.org/1910843002
Cr-Original-Commit-Position: refs/heads/master@{#389080}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: babe70a9fc6770f67a4ce287c995d2bbcdaf0430
Reason for revert:
speculatively reverting: issues with linking on the gpu bots again: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/8079
Original issue's description:
> Implement arflags in the GN build.
>
> This flag was recently added in GN. This patch hooks it up to the toolchains
> and moves some flags to use it that previously had to be hardcoded on the
> tool command itself.
>
> Remove concurrent_links variable from gcc_toolchain which was unused.
>
> BUG=598599
> Reland of http://crrev.com/1896163003 with fix.
TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598599
Review URL: https://codereview.chromium.org/1910393002
Cr-Original-Commit-Position: refs/heads/master@{#389000}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ce39e29422675764e94de94458ce3bb22fe53d3
This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.
Remove concurrent_links variable from gcc_toolchain which was unused.
BUG=598599
Reland of http://crrev.com/1896163003 with fix.
Review URL: https://codereview.chromium.org/1909163002
Cr-Original-Commit-Position: refs/heads/master@{#388971}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 920a09e4e58f92bf1ece1fcf1f31ec44185a4959
We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.
BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1902463002
Cr-Original-Commit-Position: refs/heads/master@{#388829}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 540b8c11b0418e42e79fa27b84ac4f3c0f7770fa
CSSValuePool was used to be static instance on main thread
only. But OffscreenCanvas in a worker requires to access
the CSS value caches in a non-main thread. This patch uses
the ThreadSpecific persistent handles to create static
CSSValuePool instances per thread when needed, and the
cleanup code is handled in ThreadState::cleanup() added by
patch https://codereview.chromium.org/1881933005.
As a result, WebKit unit tests (which does not use the
ThreadState::cleanup() as the worker thread) need to be
modified so that false positive leak errors will not be
reported.
In addition, an indirect memory leak "__strdup
/build/eglibc-3GlaMS/eglibc-2.19/string/strdup.c" is
generated in webkit unit tests; but after printing out the
full error stack trace, we observe that it eventually
originates from libfontconfig, a third_party library that
has leaks and has already been suppressed in
leak_suppression.cc. But the default stack trace is too
short on suppress this indirect memory leak; so we added
one more leak suppression underneath the libfontconfig.
BUG=599659
Review URL: https://codereview.chromium.org/1870503002
Cr-Original-Commit-Position: refs/heads/master@{#388815}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1174eb6ddb160985b51d1d45321e24c493aa7f83
Reason for revert:
This added the new test to some FYI bots (but nowhere else?) and claimed that the binary can run on swarming but it doesn't add a _run target or an isolate file to actually run it on swarming. As a consequence, the FYI bots this added the test to that still use gyp now all fail their "isolate tests" step. Example: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4976
Original issue's description:
> Introduce components/display_compositor
>
> We would like to share BufferQueue, GLHelper and later other parts
> of content/browser/compositor in Mus. This CL introduces a new
> display_compositor component and moves BufferQueue, GLHelper and
> friends to components/display_compositor.
>
> BUG=601867
> TBR=ben@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> NOTRY=true
> NOTREECHECKS=true
TBR=ben@chromium.org,piman@chromium.org,sky@chromium.org,xhwang@chromium.org,tkent@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601867
Review URL: https://codereview.chromium.org/1904773004
Cr-Original-Commit-Position: refs/heads/master@{#388760}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b844a929a8e624c6391d5efab8aea49bb883874
We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.
BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1902463002
Cr-Original-Commit-Position: refs/heads/master@{#388662}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec03489356fa45add604aaca28f277a0c9f83dee
Reason for revert:
Broke Windows x64 build.
c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/20984/steps/compile/logs/stdio
Original issue's description:
> Introduce components/display_compositor
>
> We would like to share BufferQueue, GLHelper and later other parts
> of content/browser/compositor in Mus. This CL introduces a new
> display_compositor component and moves BufferQueue, GLHelper and
> friends to components/display_compositor.
>
> BUG=601867
> TBR=ben@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=piman@chromium.org,sky@chromium.org,xhwang@chromium.org,ben@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601867
Review URL: https://codereview.chromium.org/1905863002
Cr-Original-Commit-Position: refs/heads/master@{#388661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 442ab50b0b4a5ca8d8b634d6b79dea960918f1f0
Reason for revert:
variety of compile failures on Android bots that have been switched to GN, see https://codereview.chromium.org/1896163003/#msg18
Original issue's description:
> Implement arflags in the GN build.
>
> This flag was recently added in GN. This patch hooks it up to the toolchains
> and moves some flags to use it that previously had to be hardcoded on the
> tool command itself.
>
> Remove concurrent_links variable from gcc_toolchain which was unused.
>
> BUG=598599
TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598599
Review URL: https://codereview.chromium.org/1903363003
Cr-Original-Commit-Position: refs/heads/master@{#388646}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0d539e12630324a0ab446b19cacf765761cf9684
We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.
BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1902463002
Cr-Original-Commit-Position: refs/heads/master@{#388641}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ea767b706b88fbeb77655c2193d593dfef54660a
This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.
Remove concurrent_links variable from gcc_toolchain which was unused.
BUG=598599
Review URL: https://codereview.chromium.org/1896163003
Cr-Original-Commit-Position: refs/heads/master@{#388554}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c33bfab4e4dc2702bc6ccc36038defd850837bd2
If we set emma_coverage as true, and do not set --filter-string in
args.gn, build will fail because --filter-string is mandatory. In this
cl, I am making --filter-string optional for emma_coverage.
BUG=
Review URL: https://codereview.chromium.org/1905523002
Cr-Original-Commit-Position: refs/heads/master@{#388413}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a18734145371ec315fb356119e63fb3c0661437
GN build of Google Test including Chromium's extensions which make it
impossible to reuse the GN build definition outside of Chromium without
pulling the entire src/testing. We provide a way to exclude these
extensions from the build.
Review URL: https://codereview.chromium.org/1901313002
Cr-Original-Commit-Position: refs/heads/master@{#388400}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ccff0d0ca88dc927380c9d0d4315af5faeee626d
stip
scottmg
hzl
andrewhayden
rsesek
agrieve
justincohen
dpranke
antz
jbudorick
brucedawson
thakis
apacible
sdefresne
krasin
brettw
fsamuel
xlai
schenney
hashimoto
tkent
friedman
xyzzyz
svaldez
bpastene
ljagielski
phosek