Граф коммитов

7 Коммитов

Автор SHA1 Сообщение Дата
mark@chromium.org b3400c94ed Circular relationships between .gyp files should be errors. Make them errors,
but currently only on the Mac.

These relationships should be errors on all platforms, but some currently
exist on non-Mac platforms.  See http://crbug.com/35878.  Because the Mac is
the only platform where a circular dependency between .gyp files is known to
cause tangible problems, the portions of Chromium's .gyp files that are used
by Macs have been fixed to remove these relationships, and the check is left
enabled on the Mac to ensure that no new ones are created.

BUG=35308
TEST=none
Review URL: http://codereview.chromium.org/600151

git-svn-id: http://src.chromium.org/svn/trunk/src/build@39128 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-02-16 20:14:26 +00:00
yaar@chromium.org ac49c578a1 gyp_chromium automatically includes features_override.gypi
Other projects that use gyp_chromium directly depend on that.

Review URL: http://codereview.chromium.org/255078

git-svn-id: http://src.chromium.org/svn/trunk/src/build@28035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-10-05 20:48:38 +00:00
sgk@google.com 849c008d9d Create a separate function that returns the list of additional
files to be included in the build (common.gypi and */supplement.gypi).
BUG=none
TEST=successful "gclient runhooks"
Review URL: http://codereview.chromium.org/214058

git-svn-id: http://src.chromium.org/svn/trunk/src/build@26901 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-23 03:49:50 +00:00
mattm@chromium.org 5ba0f23123 Avoid gyp_chromium duplicating an include that's already in the command line.
Fixes automatic makefile regeneration from duplicating gcc flags and causing a full rebuild each time.

BUG=none
TEST=make && touch chrome/chrome.gyp && make

Review URL: http://codereview.chromium.org/207004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@26415 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-16 23:16:05 +00:00
sgk@google.com eb43828260 Refactor gyp_chromium so you don't have to execute it from the src/.. directory.
BUG=none
TEST='python src/build/gyp_chromium; cd src; python build/gyp_chromium; cd build; python gyp_chromium'
Review URL: http://codereview.chromium.org/195107

git-svn-id: http://src.chromium.org/svn/trunk/src/build@26408 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-16 22:37:47 +00:00
mark@chromium.org 727acf7f42 Make follow-up changes per r26302 review comments that were apparently not made
in r26302.  Set Subversion properties, fix the O3D GYP invocation to work
properly, fix presubmit warnings, and do some additional cleanup.
Review URL: http://codereview.chromium.org/200144

git-svn-id: http://src.chromium.org/svn/trunk/src/build@26378 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-16 19:44:02 +00:00
yaar@chromium.org 348eca2172 Force inclusion of build/common.gypi for all chromium gyp files.
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.

What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.

Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
  ./third_party/hunspell/hunspell.gyp
  ./third_party/icu/icu.gyp
  ./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
   -or-
   Delete gyp_chromium.gypi and move its content back to common.gypi

Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.

Review URL: http://codereview.chromium.org/206006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@26302 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2009-09-15 23:52:14 +00:00