This improves analyze.py so that it doesn't think that an Android header change should build/test non-Android targets.
BUG=455394
Review URL: https://codereview.chromium.org/912663002
Cr-Original-Commit-Position: refs/heads/master@{#315619}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d9c2c62b9d8cafd29b3194816092eed6bde096b5
Hopefully the move will make DesktopWindowTreeHostX11Test.Deactivate no longer
flaky. Only a single window can be active at a time. I suspect that this test
sometimes fails when run in parallel with other tests
BUG=396491
TEST=None
Review URL: https://codereview.chromium.org/414123005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@285834 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Background: I am currently trying to test NaCl in clank by setting disable_nacl=0 and enable_plugins=1 in gyp. Some of the code required to get this to work is guarded under overly-specific OS==android and similar constructs. This first CL enables a coherent build with the flags set to gyp, but does not yet turn the functionality on completely. A sampling of issues fixed:
1) std:: prefix is more strictly observed on android
2) define NACL_LINUX, etc., is needed for nacl code
3) properly guard flag-setting code
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032R=bradnelson@google.com, darin@chromium.org
Review URL: https://codereview.chromium.org/299703016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
To run the toolkit-views app launcher on Mac, it needs a new app list
service + supporting classes. It's going to look a lot like the Linux
one. This CL starts by sharing what can be shared between Windows and
Linux, in preparation for using it on Mac as well.
It does this principally by:
- Moving `app_list_shower` to `app_list_shower_views`, making it views-specific;
- Adding AppListServiceViews, which Win/Linux (and soon Mac) inherit from;
- Rearranging the delegation to eliminate some boilerplate.
Other changes:
- Removed AppList container abstract interface (now just access AppListView);
- Removed AppListFactory (now AppListShower::MakeViewForCurrentProfile());
- Moved AppListControllerDelegateLinux to AppListControllerDelegateViews;
- Most of AppListServiceLinux moves to AppListServiceViews;
- Added AppListShowerDelegate and AppListShower given virtual method
hooks to assist testability (previously AppListShower was given a NULL
service/delegate in tests);
- Positioning logic in AppListWin/AppListLinux made static/stateless;
- Removes the `on_should_dismiss_` closure (now just dismiss via the service;
- Big trim of AppListServiceWin and AppListServiceLinux - now these are
just platform-specific stuff.
BUG=365977
TEST=Just refactoring, nothing should change
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267184
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267354
Review URL: https://codereview.chromium.org/225053004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When a user has configured Chrome to run in Metro mode, all browser
windows should open in the Ash desktop, regardless of where the request
came from. This includes browser desktop shortcuts, v1 browser-hosted
apps, OAuth windows, links from packaged apps, and DevTools windows.
Currently there are many code paths that result in a browser created in
Windows Desktop mode.
Also, if a browser is created in Ash, Metro mode does not always
activate. This may cause a user to think no window was created.
This CL adds BrowserWindow::AdjustHostDesktopType(..) to represent the
current policy decision that browser windows should only open on the Ash
desktop on Windows, when Chrome is running in Metro mode.
The policy is enforced by ensuring all constructed Browser instances are
created with a verified host desktop, which will be TYPE_ASH whenever the
ash shell is instantiated on Windows.
Then, when a browser window gains focus in the Ash desktop, if the metro
viewer process is not already the foreground window, switch to Metro
mode.
BUG=315385, 315894, 319173
TEST=Have Chrome configured in Metro mode. Then:
1. Open Chrome via the Desktop mode App Launcher.
2. Open Chrome via the context menu on the Chrome icon on the Desktop
mode App Launcher.
3. Open Chrome with a profile-badged desktop shortcut (twice).
4. (in Metro Mode) open an undocked Inspector window.
5. Open a v1 hosted app (e.g. Drive) from the Desktop mode app launcher.
6. After showing the Desktop app launcher and closing it, open a v1
hosted app desktop shortcut
===> All of these should open windows in Ash, and switch to Metro mode.
Review URL: https://codereview.chromium.org/58853004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235906 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
All ozone configurations currently build DRI support, and therefore
have a dependency on the libdrm system library. This is not needed
except when ozone_platform_dri is enabled.
This allows us to drop the link to libdrm when it is not needed.
Review URL: https://codereview.chromium.org/62953003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@233671 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
And introduce a gyp variable use_ozone_evdev to allow this feature to be
removed from the build. Additionally, the --ozone-events flag is introduced
to select an EventFactoryDelegateOzone implementation to use.
If an embedder or out-of-tree EventFactoryDelegateOzone implementation
calls SetEventFactoryDelegateOzone during initialization, the flag has no
effect.
BUG=none
TEST=Build & run content_shell, ui_unittests with use_ozone=1
Review URL: https://codereview.chromium.org/28513004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229950 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* AppNonClientFrameViewAura is Ash-specific, rename to AppNonClientFrameViewAsh
* Move BrowserNonClientFrameViewAsh into chrome/browser/ui/views/frame/ with
all the other views platform-specific frames
* Add build rule to exclude _ash_browsertests for non-Ash builds
BUG=156361
TEST=compiles, browser_tests *NonClientFrameView* pass
Review URL: https://chromiumcodereview.appspot.com/11229041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@163466 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The x11 exclusion rule should not be excluding chromeos files. There is
a separate chromeos exclusion rule for that.
Also adding unit test exclusion to the chromeos rule.
BUG=chromium:134081
TEST=build w/ tests successfully
Signed-off-by: Simon Que <sque@chromium.org>
Change-Id: I2e462dcbda6ffc3636886a1f877a5554b7f6a1a9
Review URL: https://chromiumcodereview.appspot.com/10632015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@143694 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculatively reverting due to gyp update error on official bots:
KeyError: 'src/breakpad/breakpad.gyp:dump_syms#target while trying to load target src/remoting/remoting.gyp:remoting_linux_symbols#target'
This is the only patch in the regression range that touches breakpad.gyp.
---
Upstream Android native crash handling changes.
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/10037013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131600 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131404 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
jam
pkotwicz@chromium.org
sehr@chromium.org
tapted@chromium.org
erg@chromium.org
spang@chromium.org
sadrul@chromium.org
kalyan.kondapally@intel.com
jochen@chromium.org
thestig@chromium.org
davemoore@chromium.org
tbarzic@chromium.org
sreeram@chromium.org
jamescook@chromium.org
dbeam@chromium.org
stuartmorgan@chromium.org
wangxianzhu@chromium.org
sque@chromium.org
bbudge@chromium.org
bradnelson@google.com
jam@chromium.org
carlosvaldivia@google.com
erg@google.com
msw@chromium.org
oshima@chromium.org
evan@chromium.org