The toolchain directory inside depot_tools will only exist if
"set DEPOT_TOOLS_WIN_TOOLCHAIN=1" so this is currently a no-op.
It will break the "dogfood" of 'GYP_MSVS_USE_SYSTEM_TOOLCHAIN'
now renamed per above, but I think only a few people tested
that (cc'd here).
R=dpranke@chromium.org
BUG=323300, 326357
Review URL: https://codereview.chromium.org/137573002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245412 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
With this change, `gclient runhooks` creates ninja files by default on
Windows. To build, run `ninja -C out\Release chrome`. The output appears
in out\ instead of build\.
If you need to use a VS build for some reason, you can still
`set GYP_GENERATORS=msvs`. This is no longer a tested configuration.
Bots should automatically pick up the binaries in the new location (out).
If something does break, it should be safe to revert this change, and bots
should then automatically go back to picking up binaries from the old
location (build).
R=thakis@chromium.org
BUG=303291
Review URL: https://codereview.chromium.org/111183004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243782 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds arm version and some android configuration build flags.
This adds most of the logic from common.gypi to the Android GN build.
This is currently missing the crtbegin/end stuff and won't actually make real Android builds. The logic in this patch is just the initial conversion that will require testing and several more passes of fixes.
R=torne@chromium.org, torne
Review URL: https://codereview.chromium.org/121173005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243681 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes gyp_chromium pass defines defined via -D on the command line to GN.
Fixes double-escaping of strings from supplemental.gypi files.
Pass use_goma to the GN build.
Handle "use_goma" and "use_goma=1" (same for other boolean values). Previously values with no equals sign were getting converted to 'true', which doesn't match '1' which we look for.
Output goma wrappers in the GYP header for Windows toolchains.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/123463005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@243446 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This passes the official build and branding flags to the GN build. Currently, this is used to hook up the proper sysroot for compiling on Linux for official builds. The 32-bit branded build does not compile currently due to pending pkgconfig issues.
Fix a bug where assertions in the build config would not get reported properly. This was because I forgot to actually throw the error at the toplevel.
BUG=
R=piman@chromium.org
Review URL: https://codereview.chromium.org/115643002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@240918 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reproduced on a new Win7 x64 VM, and this fixed the build (at
least for the chrome target).
This doesn't address the need to copy the runtime DLLs into the
output directory so that chrome runs though, that's a separate
problem where something in chrome's gyp should be copying them
there, at least for a debug build.
TBR=mikelawther@chromium.org
BUG=326345
Review URL: https://codereview.chromium.org/111183002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239671 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Without GYP_DEFINES set, build/gyp_chromium would crash with
Generating gyp files from GN...
Traceback (most recent call last):
File "./build/gyp_chromium", line 207, in <module>
if not RunGN(supplemental_includes):
File "./build/gyp_chromium", line 147, in RunGN
gyp_vars = GetVarsStringForGN(supplemental_includes)
File "./build/gyp_chromium", line 79, in GetVarsStringForGN
items = shlex.split(env_string)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 279, in split
return list(lex)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 269, in next
token = self.get_token()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 96, in get_token
raw = self.read_token()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 124, in read_token
nextchar = self.instream.read(1)
AttributeError: 'list' object has no attribute 'read'
This was broken by r238475
BUG=321352
Review URL: https://codereview.chromium.org/103253002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238486 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of 236542 and 238454 (runs GN in GYP mode before actually running GYP), plus some additions
Move GYP_DEFINES parsing to Python for GN.
I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
Currently, GN does not produce any files used by the build, these will be added in a second step.
BUG=321352
TBR=bradnelson@google.com
Review URL: https://codereview.chromium.org/101573004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238475 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Hook up GN to the GYP build system.
>
> This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions
>
> Move GYP_DEFINES parsing to Python for GN.
>
> I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
>
> Currently, GN does not produce any files used by the build, these will be added in a second step.
>
> BUG=321352
> R=bradnelson@google.com
>
> Review URL: https://codereview.chromium.org/73623005TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/102923002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238459 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions
Move GYP_DEFINES parsing to Python for GN.
I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
Currently, GN does not produce any files used by the build, these will be added in a second step.
BUG=321352
R=bradnelson@google.com
Review URL: https://codereview.chromium.org/73623005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238454 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This cl ports the nacl wrapper to the chromium build system and adds local modifications from Chromevox to liblouis. The native library and braille tables are copied to the location in the resources output directory where chromevox can pick them up.
BUG=316353
Review URL: https://codereview.chromium.org/67283007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237638 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
With this change, `gclient runhooks` creates ninja files by default on Mac.
To build, run `ninja -C out/Release chrome`. The output appears in out/
instead of in xcodebuild/. (This doesn't happen if OS=ios, so it shouldn't
affect chrome/ios development.)
If you need to use xcode for some reason, you can
`export GYP_GENERATORS=xcode` to force xcode project generation.
If you do this, please inform me why.
Bots should automatically pick up the binaries in the new location (out).
If something does break, it should be safe to revert this change, and bots
should then automatically go back to picking up binaries from the old
location (xcodebuild).
BUG=294387
R=mark@chromium.org
Review URL: https://codereview.chromium.org/31143002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@231675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
thakis@chromium.org
brettw@chromium.org
pkasting@chromium.org
scottmg@chromium.org
nick@chromium.org
petarj@mips.com
plundblad@chromium.org
jam@chromium.org
ckocagil@chromium.org
iannucci@chromium.org
schenney@chromium.org