7b47211656
check_return_value.py should drop stderr of the command it runs.
...
Gyp will treat the command as failed if there is any stderr output.
However, we're interested in the actual return value anyways.
BUG=359096
R=mark@chromium.org
Review URL: https://codereview.chromium.org/222883002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261307 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-04-03 07:36:32 +00:00
17ac412f09
Use the system provided harfbuzz on chromeos
...
It's part of the pango library we use already, so by using it, we avoid
a link time collission.
However, if you build just the browser on linux on ubuntu 12, we don't
have such an up to date pango available, so we need to be a bit smart
about whether or not to use the system harfbuzz.
This also allows for treating linker warnings as errors on chromeos
BUG=353127
R=jshin@chromium.org , thakis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259423
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259530
Review URL: https://codereview.chromium.org/203163003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@259652 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-03-26 19:10:02 +00:00
6f636927a8
Revert of Use the system provided harfbuzz on chromeos ( https://codereview.chromium.org/203163003/ )
...
Reason for revert:
chromeos doesn't have hb-icu.h
Original issue's description:
> Use the system provided harfbuzz on chromeos
>
> It's part of the pango library we use already, so by using it, we avoid
> a link time collission.
>
> However, if you build just the browser on linux on ubuntu 12, we don't
> have such an up to date pango available, so we need to be a bit smart
> about whether or not to use the system harfbuzz.
>
> This also allows for treating linker warnings as errors on chromeos
>
> BUG=353127
> R=jshin@chromium.org , thakis@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259423
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259530
TBR=jshin@chromium.org ,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353127
Review URL: https://codereview.chromium.org/212313003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@259534 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-03-26 09:31:31 +00:00
d95f05fff1
Use the system provided harfbuzz on chromeos
...
It's part of the pango library we use already, so by using it, we avoid
a link time collission.
However, if you build just the browser on linux on ubuntu 12, we don't
have such an up to date pango available, so we need to be a bit smart
about whether or not to use the system harfbuzz.
This also allows for treating linker warnings as errors on chromeos
BUG=353127
R=jshin@chromium.org , thakis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259423
Review URL: https://codereview.chromium.org/203163003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@259530 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-03-26 08:05:28 +00:00
39d7d82d43
Revert of Use the system provided harfbuzz on chromeos ( https://codereview.chromium.org/203163003/ )
...
Reason for revert:
Revert as speculative cause for build failure.
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/17405/steps/Report/logs/stdio
Original issue's description:
> Use the system provided harfbuzz on chromeos
>
> It's part of the pango library we use already, so by using it, we avoid
> a link time collission.
>
> However, if you build just the browser on linux on ubuntu 12, we don't
> have such an up to date pango available, so we need to be a bit smart
> about whether or not to use the system harfbuzz.
>
> This also allows for treating linker warnings as errors on chromeos
>
> BUG=353127
> R=jshin@chromium.org ,thakis@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259423
TBR=jshin@chromium.org ,thakis@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353127
Review URL: https://codereview.chromium.org/211473008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@259439 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-03-26 01:49:58 +00:00
a3e651e42b
Use the system provided harfbuzz on chromeos
...
It's part of the pango library we use already, so by using it, we avoid
a link time collission.
However, if you build just the browser on linux on ubuntu 12, we don't
have such an up to date pango available, so we need to be a bit smart
about whether or not to use the system harfbuzz.
This also allows for treating linker warnings as errors on chromeos
BUG=353127
R=jshin@chromium.org ,thakis@chromium.org
Review URL: https://codereview.chromium.org/203163003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@259423 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-03-26 00:47:20 +00:00
jochen@chromium.org
erikchen@chromium.org