If too many tests are run one after another, battery temperatures can become
abnormally high. This gives the device a chance to cool down between runs.
BUG=
Review URL: https://codereview.chromium.org/1126143004
Cr-Original-Commit-Position: refs/heads/master@{#328716}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ce719b80a3358f0f930b004fde3c452d1a1c9ec
This makes it easier to write what turns out to be the most
common usage of this method: ensure that some processes
are not running, and don't care if none is found.
Also helps to distinguish an adb/device error (which should
trigger a retry), from cases where no processes to kill are found
(where the caller doesn't need/want to retry).
Clients that benefit from this flag are also updated.
BUG=475845
Review URL: https://codereview.chromium.org/1079113002
Cr-Original-Commit-Position: refs/heads/master@{#325217}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 84436c8ee6194ac0a782535b07e8643c7a768847
Switch all battery related device interaction from
DeviceUtils to BatteryUtils. Currently they reside in device
utils, which has a lot of functionality around a lot of
different device interactions. This will consolidate all
current and future power related phone interactions into one location.
BUG=472763
Review URL: https://codereview.chromium.org/1057563002
Cr-Original-Commit-Position: refs/heads/master@{#323940}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58368d3ea55f26f5eb98a76cb7985f580f23ff8c
This will allow the caller to specify an argument to adb public keys to be
written to the device (along with any existing keys already on the device)
during wiping.
BUG=
Review URL: https://codereview.chromium.org/970573002
Cr-Original-Commit-Position: refs/heads/master@{#318717}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 89f0fd6d122773f9375e0ab243f95dbb99bacd4e
Add a command-line argument for adb keys to be pushed onto
the devices being provisioned. This can be used by bots to
provide adb authentication.
BUG=
Review URL: https://codereview.chromium.org/949323003
Cr-Original-Commit-Position: refs/heads/master@{#318325}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00c5fd30f5991deab5ba034d2f9829f0609342c7
Build bot recipes have been upgraded to explicitly request the provisioning
options they need.
At this point it should be safe to remove the code that guessed the required
configuration from the bot name.
BUG=450984
Review URL: https://codereview.chromium.org/926333004
Cr-Original-Commit-Position: refs/heads/master@{#317034}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 545a9ceb6ca0810e9ee4df8990071c18c3a066d7
provision_devices.py currently relies on the builder name to determine
the desired device configuration for perf bots. To safely phase this out
this CL:
- exposes these configuration settings as command line options
- sets default values for these options based on the builder name, thus
matching the previous behaviour of the script on all bots.
- explicitly adding these options on the perf bots will also maintain the
same script behaviour, namely:
--wait-for-battery --disable-network --disable-java-debug
- after all perf-bot recipes are updated, we can remove the
builder-name-sniffing code.
In the process we also upgrade from optparse to argparse for handling
command line options.
BUG=450984
Review URL: https://codereview.chromium.org/869563002
Cr-Original-Commit-Position: refs/heads/master@{#312818}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b205693d72e37d173f7dabcefe6c02f115509f27
The reboot for the devices was added because after a wipe certain settings
require a reboot to take effect. When the device is not wiped, there is no
reason to reboot it. We need the ability to have bots that will not reboot
devices, because some devices have boot-screen prompt as a security feature.
BUG=
Review URL: https://codereview.chromium.org/737033003
Cr-Original-Commit-Position: refs/heads/master@{#304969}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e52d00fb93f6db33a1d0488b5610cebd96fda82f
The 'date -u' was not working on N5 devices. The -s option seems to work across
devices. I've tested on N4 and N5. This change implements an earlier change that
was reverted. See the change here: https://codereview.chromium.org/668013003/
The difference in this change is that it sets the time zone to UTC.
BUG=406848
Review URL: https://codereview.chromium.org/671833003
Cr-Original-Commit-Position: refs/heads/master@{#300803}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3fad747a3352fb78e4beaf51cbf839e72168a4cb
The 'date -u' was not working on N5 devices. The -s option seems to work across
devices. I've tested on N4 and N5.
BUG=406848
Review URL: https://codereview.chromium.org/668013003
Cr-Original-Commit-Position: refs/heads/master@{#300542}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e3b2f5071ae50778f07abbc84fc6a9e07e169892
This patch revises the implementation of DeviceUtils.PushChangedFiles
and changes its interface (slightly).
PushChangedFiles now:
- takes a list of (host_path, device_path) tuples, each of which are
analogous to the original parameters.
- continues to use AndroidCommands.GetFilesChanged to determine which
files need pushing
- attempts to pick the fastest method out of:
- individual file pushes
- entire directory pushes
- zip-push-unzip
BUG=400440
Review URL: https://codereview.chromium.org/646523002
Cr-Original-Commit-Position: refs/heads/master@{#299098}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b53e3ccca7fa26a51f3980f250f5527581324316
Also remove the option -w to only wipe without provisioning. This was temporary
functionality to recover from INSUFFICIENT_STORAGE on device error. With the
default wiping, this should be unnecessary. For bots that skip wiping, we can
still manually fix by manually running without --skip-wipe.
BUG=383106
TBR=craigdh@chromium.org
Review URL: https://codereview.chromium.org/334503002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@276866 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
rnephew
jbudorick
perezju
navabi
machenbach
mattm
jbudorick@chromium.org
navabi@google.com
tonyg@chromium.org
navabi@chromium.org