This changelist defines new classes and types for
accessibility in ui/accessibility. Subsequent changes will
refactor code inside content/ to inherit from AXTree and
AXNode, then we can start exposing the accessibility tree
outside of content/.
In addition, we can now use these same types in Views
accessibility and share more code.
BUG=316726
Review URL: https://codereview.chromium.org/67283004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@236733 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Unlike the extensions V8 bindings, gin is based on ObjectTemplates rather than
on evaluating script. Unlike the Blink V8 bindings, gin isn't tightly coupled to
Blink. In fact, gin's only link-time dependency is V8. We plan to use gin to build
the V8 bindings for Mojo (see https://codereview.chromium.org/59153005/ for
an example of how they will be used).
In the long term, gin could serve as a basis for both the Blink and the extension
system bindings, but we don't have any immediate plans to pursue that use of
this code.
This code is largely inspired by a lightweight bindings system designed by
Aaron Boodman.
Review URL: https://codereview.chromium.org/67763002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@234160 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Using enable_printing=0 removes all of the source files of the printing
component, but has no effect on its dependencies. It is wrong to empty out the
target inside the target. If printing is disabled, then the dependency on
printing.gyp is not needed and can be removed.
This target was causing libgcrypt to be linked even when printing was disabled.
That problem goes away with this change.
Review URL: https://codereview.chromium.org/62793002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@233563 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is the pattern we follow for projects under ui/, each top-level directory
(app_list, aura, compositor, events) have its own gyp file for its main target
(library).
BUG=299841
TEST=build/gyp_chromium, ninja -C out/Debug shell_dialogs, and other targets
still build.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/47323002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@231478 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Create new google_api/gcm directory, and add some of the initial base logic
for integrating protobufs with chrome sockets.
A SocketStream is an implementation of the ZeroCopyStream interfaces that allows
for asynchronously retrieving a message (with timeout support) which can then
be parsed by a CodedInputStream, or alternatively allows a CodedOutputStream
to write into a Chrome socket.
Once a SocketStream closes itself (which will happen on error or timeout), the
stream cannot be reused, and a new one should be created (typically with a
socket that has been reconnected). In general, the state of the socket stream
must be checked before interacting with it.
Also fixes issue in SocketTestUtil where mock Sockets aren't taking ownership
of IOBuffers that they're using (exposed by tests).
TBR=darin@chromium.org
BUG=284553
Review URL: https://codereview.chromium.org/23684017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229533 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is my second attempt to do this, the first time https://codereview.chromium.org/23460023/ has been reverted (https://codereview.chromium.org/23858006) because the new target 'copy_syzyasan_binaries' was not build, so the SyzyASan binaries were missing from the syzygy dir...
Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
- ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
R=chrisha@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25890006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229085 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Language detection is used from the renderer on most platform, but from the
browser on iOS. This CL moves it from chrome/common/ to a new "translate"
component, which allows to track and address more cleanly dependencies issues.
BUG=297777
Review URL: https://codereview.chromium.org/25531002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@227015 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This seems to be preventing things landing through the CQ due to compile warnings on mac using clang, and on win-64.
Error such as
FAILED: ninja .. ..\..\media\cast\framer\cast_message_builder_unittest.cc ...
error C2220: warning treated as error - no 'object' file generated
warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
FAILED: clang++ ... -c ../../media/cast/audio_receiver/audio_receiver.cc -o obj/media/cast/audio_receiver/cast_audio_receiver.audio_receiver.o
In file included from ../../media/cast/audio_receiver/audio_receiver.cc:5:
../../media/cast/audio_receiver/audio_receiver.h:117:55:error: no newline at end of file [-Werror,-Wnewline-eof]
#endif // MEDIA_CAST_AUDIO_RECEIVER_AUDIO_RECEIVER_H_
> Build cast_unittest
>
> Build cast targets on all bots.
>
> R=justinlin@chromium.org
>
> Review URL: https://codereview.chromium.org/25891004TBR=hclam@chromium.org
Review URL: https://codereview.chromium.org/25368003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@226960 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dmazzoni@chromium.org
sugoi@chromium.org
zmo@chromium.org
justincohen@chromium.org
jschuh@chromium.org
rileya@chromium.org
joaodasilva@chromium.org
plundblad@chromium.org
jam@chromium.org
abarth@chromium.org
sadrul@chromium.org
kkania@chromium.org
jochen@chromium.org
inferno@chromium.org
spang@chromium.org
tfarina@chromium.org
kbr@chromium.org
zea@chromium.org
glider@chromium.org
pfeldman@chromium.org
sebmarchand@chromium.org
ben@chromium.org
scottmg@chromium.org
tonyg@chromium.org
hclam@chromium.org
droger@chromium.org
tapted@chromium.org
engedy@chromium.org
acolwell@chromium.org
brettw@chromium.org