If use_concatenated_impulse_responses is set (in config.gni), then
grit needs to have it defined as well. This is needed to reference
the appropriate response files for the HRTF panner in WebAudio.
BUG=528424
TEST=webaudio panner tests pass
Review URL: https://codereview.chromium.org/1311013010
Cr-Original-Commit-Position: refs/heads/master@{#347534}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c50633b258d948b7d28f4bb7af3a787ac8b7079
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Re-land of http://crrev.com/1318823008 while preserving config ordering.
Review URL: https://codereview.chromium.org/1307223010
Cr-Original-Commit-Position: refs/heads/master@{#346964}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6dd952c77209619a445205998173fc40fb817be1
Reason for revert:
This breaks why these configs exist in the first place and seriously breaks the clang/win gn build (which is what these configs exist for).
Original issue's description:
> Un-nest configs in GN files.
>
> People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
>
> Un-nest for clarity.
>
> Committed: https://crrev.com/4af2eac8e84692d94f88504ab6e0b244b88dddcb
> Cr-Commit-Position: refs/heads/master@{#346461}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1316843006
Cr-Original-Commit-Position: refs/heads/master@{#346695}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0cb5abbf230f3c30e3499d4e787f059ed723dd3c
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Review URL: https://codereview.chromium.org/1318823008
Cr-Original-Commit-Position: refs/heads/master@{#346461}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4af2eac8e84692d94f88504ab6e0b244b88dddcb
Reason for revert:
Apparently this was incorrect.
Original issue's description:
> Move GN grit scripts out of secondary tree.
>
> These build files were in the secondary tree because I thought tools/grit was DEPSed in. However, this directory is in the Chrome tree. The DEPSed-in directory is tools/grit/grit. Moving these files to the expected place will make things more clear.
>
> Committed: https://crrev.com/82d10f697a4268dd9ae0fffd8f3dfb1fb42901e5
> Cr-Commit-Position: refs/heads/master@{#345713}
TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1311133008
Cr-Original-Commit-Position: refs/heads/master@{#345926}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 30327bc319a006e6c89a7b3cdf1fef86f05ec692
These build files were in the secondary tree because I thought tools/grit was DEPSed in. However, this directory is in the Chrome tree. The DEPSed-in directory is tools/grit/grit. Moving these files to the expected place will make things more clear.
Review URL: https://codereview.chromium.org/1317013002
Cr-Original-Commit-Position: refs/heads/master@{#345713}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 82d10f697a4268dd9ae0fffd8f3dfb1fb42901e5
There is a google_play_services_library variable that should be used
instead of hardcoding the java target.
Added another such variable for resources
BUG=521624
Review URL: https://codereview.chromium.org/1299003003
Cr-Original-Commit-Position: refs/heads/master@{#344183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6cd230bdd3ebabff123c44e01ef0384fa1ac1b2b
Specify enable_topchrome_md as a grit define, which
will be used to specify new asset IDs which
are only applicable to platforms affected by
the material design refresh in browser top chrome.
BUG=520992
TEST=none
Review URL: https://codereview.chromium.org/1299433002
Cr-Original-Commit-Position: refs/heads/master@{#343415}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 01b7e6102e67d35eb46060f05901f62955ca6e62
I've taken ad591c629a
and merged it onto Chromium ToT, with a few lint and other cleanups,
and one fix to make sure that Mac still compiled (which may have broken
iOS, haven't tested yet).
R=brettw@chromium.org, sdfresne@chromium.org
BUG=459705
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1250913002
Cr-Original-Commit-Position: refs/heads/master@{#342297}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a29462a04dabad3fc20dc922227c46b36459912
This ICU roll only renames component_mode -> is_component_build
Update other users of the component_mode string to is_component_build.
Rename the declaration to be local to BUILDCONFIG.gn (prefixed with '_').
Removes a bitrotted GN unit test around component handing (it wasn't
testing anything useful any more since we removed the built-in
component function).
Review URL: https://codereview.chromium.org/1275583002
Cr-Original-Commit-Position: refs/heads/master@{#342204}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a08763777c45ca4e7a00a846266bbfed31ef673
Compilers configuration have been moved from //build/compiler to
//build/config/compiler, update //third_party/nss when targetting
iOS.
BUG=459705
Review URL: https://codereview.chromium.org/1249053002
Cr-Original-Commit-Position: refs/heads/master@{#340057}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 768d90d3853fa121580923b0944998354c592a01
This changes libsrtp to use "RAND_bytes" for self-tests when compiled against
OpenSSL/BoringSSL (which is the default) to avoid getting a spurious warning
about "no real random source" being present.
Also the GN file now is included in libsrtp and has been updated to match the
changed GYP file (already in libsrtp) and also uses "RAND_bytes".
BUG=328475
Review URL: https://codereview.chromium.org/1226273005
Cr-Original-Commit-Position: refs/heads/master@{#339330}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4d031a0c4dfbaa0991d119ca3efcf2bbb800a15e
We want several new widgets from the design library:
1. TextInputLayout
2. NavigationView
3. AppBarLayout
This CL adds the gyp target to chrome_java and roll DEPS for the
third_party folder.
BUG=498585
Review URL: https://codereview.chromium.org/1225393002
Cr-Original-Commit-Position: refs/heads/master@{#339073}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f322e3cef1ab700bdda8518efe40b474769b94cf
This ports the chromevox build: chromevox and chromevox_tests targets to
gn. Liblouis is still missing since it requires native client which is
not enabled for Chrome OS.
BUG=None
Review URL: https://codereview.chromium.org/1145243006
Cr-Original-Commit-Position: refs/heads/master@{#338002}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70028e5c6f31604faa2a430c8afda19dad77ad46
This changes constructor initializer list ordering to match field
declaration ordering, except for gtest and breakpad, where the warning
is disabled.
BUG=505304
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1210013007
Cr-Original-Commit-Position: refs/heads/master@{#337152}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5648c8598f20bc9756a82cf90cee204db44ea269
This script will allow to verify at build time that the local
setup properly contains Google Play services at a given version.
BUG=490091
Review URL: https://codereview.chromium.org/1152203003
Cr-Original-Commit-Position: refs/heads/master@{#336350}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e17297a2f21f653f3e79544fad7ef7bc83b4f8ba
This allows the build files to live in the chromium repo but the
source to live in the freetype repo, similar to other third_party
DEPS.
Review URL: https://codereview.chromium.org/1155743013
Cr-Original-Commit-Position: refs/heads/master@{#332616}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ffe490b7c43e2f9393caf283d809c1983bbeb3e
If a grit target specifies a resource_ids file of "" (this has specific meaning
documented in the grit rule), don't set the empty string as an input to the
grit action.
The only time this comes up is in the java_strings_grd template.
Review URL: https://codereview.chromium.org/1157113003
Cr-Original-Commit-Position: refs/heads/master@{#331869}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af43f9f780b5fcca30faef007745306827d69c23
Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
json_schema_api.gni was generating wrong names, this was fixed.
mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
BUG=487897
TBR=dpranke
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Previously landed as https://codereview.chromium.org/1128163007/ the issue there should have been fixed by https://codereview.chromium.org/1148173002/ which has already been landed.
Review URL: https://codereview.chromium.org/1134753011
Cr-Original-Commit-Position: refs/heads/master@{#331625}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de262b0acc538d307f35b85f4ebf395357d1a4db
Reason for revert:
Broke Windows:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1568/steps/compile/logs/stdio
Original issue's description:
> Fix missing GN dependencies.
>
> Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
>
> json_schema_api.gni was generating wrong names, this was fixed.
>
> mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
>
> The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
>
> BUG=487897
>
> Committed: https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7
> Cr-Commit-Position: refs/heads/master@{#330636}
TBR=dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487897
Review URL: https://codereview.chromium.org/1137693006
Cr-Original-Commit-Position: refs/heads/master@{#330650}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e97185bf4853d56aadf362b0a00699375b1fac76
Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
json_schema_api.gni was generating wrong names, this was fixed.
mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
BUG=487897
Review URL: https://codereview.chromium.org/1128163007
Cr-Original-Commit-Position: refs/heads/master@{#330636}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eadea21096be21b0d74c93f5b1a0ae6a9cc057d7
The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing.
Originally landed as https://codereview.chromium.org/1120803003/TBR=scottmg@chromium.orgTBR=ddorwin@chromium.org (widevine)
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1123433002
Cr-Original-Commit-Position: refs/heads/master@{#327998}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b2364bb2c6fbb88e6a4550abeb9141bc7cb949c
Originally, <if expr="enable_media_router"> was not picked up by a .grd file. I traced that to grit_rule.gni and added a check there.
Review URL: https://codereview.chromium.org/1104443002
Cr-Original-Commit-Position: refs/heads/master@{#326598}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2be1ebd65b769821ad36e6cff2d47bda574c00bb
This matches the gn name and is less confusing with use_openssl and
use_openssl_certs both existing. The preprocessor flag will follow
in another CL. For now, the old name is still defined, but not used
within Chromium.
A follow-up CL will remove deprecated use_nss and USE_NSS #defines
together which will then cause downstream churn. Though from a grep
of known downstreams, the churn seems to be fairly minimal. The
removal is split from this CL so that, if we need to revert, the
CL to revert is small.
BUG=462040
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/1085923002
Cr-Original-Commit-Position: refs/heads/master@{#325541}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ee13e37acf707e703a380a9c1a03f0b494dd6a6
Now that android_webview_build is no longer supported, the extra level
of indirection of including cpufeatures.gypi instead of directly
depending on the cpufeatures target is not necessary. Remove the cases
in the Chromium tree. Other references appear in projects pulled in via
DEPS that will have to be fixed separately before cpufeatures.gypi can
be entirely deleted.
BUG=440793
Review URL: https://codereview.chromium.org/1045123005
Cr-Original-Commit-Position: refs/heads/master@{#324117}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9845b890dd38f0b88b0304f3bd6c437a7c6f8f8d
brettw
dpranke
rtoy
thakis
jbudorick
sherouk
dgn
tdanderson
davidben
sdefresne
sgurun
jbauch
petermayo
ianwen
tfarina
plundblad
sammc
yfriedman
bungeman
aurimas
mail
kkimlabs
henrika
gcasto
rickyz
apacible
torne