Some web sites (like apple.com or llbean.com) build forms after the page
loading. This prevent using the server side type resolution.
Add a tracker to update the autofill forms regularly.
Bug: 798675
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ieaaf502a7bff38756d90bd96e94c058977dcab7b
Reviewed-on: https://chromium-review.googlesource.com/943321
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#544331}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: faebdb6d4f0f5e6458c9092e223e53d40de12e28
For unclear reasons, the build/util/LASTCHANGE file frequently contained
the hash of a local-only commit from a working branch, and the result
was a 404 error when trying to inspect a page in devtools.
To avoid this, add a --filter regex that is passed to "git log --grep",
defaulting to '^Change-Id:'. This header is present for the main
source tree and third_party/skia/ official commits.
BUG=760304
Change-Id: I9464ba37a1197872a7ffd31b8c2f1a2a85856276
Reviewed-on: https://chromium-review.googlesource.com/949312
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541137}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b0f0d1a7402a84cda225408e7396f6454148d4d4
This CL uses SSH reverse port forwarding to dynamically connect the test
suites running on Fuchsia to the Python-based test servers running on
the controlling machine.
Also adds a logging context to the spawning server library, so that the
verbosity of its logging output can be independently adjusted.
Change-Id: I6099ccc21efdd5e2e6b994e863f8d4b3dadaaae1
Reviewed-on: https://chromium-review.googlesource.com/907633
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535911}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49c9ff7f3b4c6ae5b17d764ee0ac83a37cb118d2
On android, adb is used to forward connections from the device to the
host, but there isn't a way to reserve the source port before deciding
which destination port on the host to forward it to. Change
RemoteTestServer reserve a port for AIA & OCSP, and forward it to another
port, like it already does on Fuchsia. Unlike Fuchsia, the second adb
forwarding step is still required to forward the connection from device to
host.
Change-Id: I739543fd0036f189928b5c7ce31c4d9a520e1cf0
Reviewed-on: https://chromium-review.googlesource.com/887171
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532946}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb27199b5bbf8706ca90fc0c6a6d42c21092f686
Previous implementation was slow when you put too many items in
the negative part of gtest filter (with positive part = *).
For net_unittests we have 2 mln fnmatch.fnmatch() calls.
Using one re match() instead of repetitive fnmatch() is much faster.
This change makes it more than 1000 times faster in heavy scenarios
(0.1 sec instead of 8 min for net_unittests with 100 negative items).
R=alexandermont@chromium.org, jbudorick@chromium.org
Bug: 783187
Change-Id: I70b0487e451cfc0457a683d4e1ef5de2a8bee732
Reviewed-on: https://chromium-review.googlesource.com/758853
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525737}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: da0240761319bc610c7c4121d76659c7364b79bb
Previously OCSP was broken with RemoteTestServer because OCSP server
port wasn't proxied.
1. Updated testserver.py to accept --ocsp-proxy-port-number argument
which makes it possible to generate correct cerificate for the
proxied connection.
2. Updated chrome_test_server_spawner.py to forward oscp server port.
3. Updated RemtoeTestServer to proxy OCSP connection.
4. Enabled OCSP tests on Fuchsia where they were previously failing.
Bug: 776575, 792300
Change-Id: Iedb1f5b26fc29ad0c73e78f450cd49335a424c18
Reviewed-on: https://chromium-review.googlesource.com/810096
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522634}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ee7c8db6b554120fb28385f8759695048f1d8612
This removes the manually-updated software_rendering_list and
gpu_driver_bug_list versions, replacing them with Chromium
git commit hashes. These hashes are used to generate
permalinks, like this one:
57c9d07b41/gpu/config/software_rendering_list.json
Bug: 772177
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id23a5e05506492999a43cd173e4659095f75fe4c
Reviewed-on: https://chromium-review.googlesource.com/728950
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510568}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96bd9ef90d95efa332485195e03c63477b90bb07
Adds a script that runs resource_sizes.py on two given APKs, diffing
the results. This is being added with the intention of using it to
measure the size impact of including VR, but should be usable to
measure the impact of any build flags, etc.
Bug: 759087
Change-Id: I1db06594d3c02cc6a0d90c44343e5c25281d6f4e
Reviewed-on: https://chromium-review.googlesource.com/657460
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 20e696b8cf4c1e0c941a8bcb113e99109a2f7379
1. Added ws server type in test server spawner.
2. Fixed a bug in testserver.py which prevented it from loading certs
with relative paths (because it has to chdir to the working dir)
3. Enabled some tests on Android and Fuchsia. The two tests that are
still disabled depend on basic-auth-proxy mode in testserver, which
doesn't work with RemoteTestServer.
Bug: 441711, 731302
Change-Id: Id8346111f260ead648a98b0854669d1211fe3393
Reviewed-on: https://chromium-review.googlesource.com/656758
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500722}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c786d33ad7886c8d656ded42b68b4d0746b6881
This is a reland of d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5
Original change's description:
> Update test server spawner to run multiple test servers in parallel
>
> Previously test server spawner didn't allow running more than one test
> server. With this change it's now possible to run multiple tests that
> depend on test_server in parallel.
> 1. Updated chrome_test_launch_spawner.py to support more than one
> test server. /kill now requires a get parameter to specify which
> server should be killed. Number of concurrent test servers is
> specified by test runner which instantiates the spawner.
> 2. Updated test runners for Android and Fuchsia to pass the new
> max_servers parameter for the spawner to match test parallelism
> on these platforms (1 on Android, 4 on Fuchsia).
>
> Bug: 731302
> Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
> Reviewed-on: https://chromium-review.googlesource.com/627339
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497967}
TBR=mmenke@chromium.org
Bug: 731302
Change-Id: I153632cf1fc946f0543a55108555644993a942a5
Reviewed-on: https://chromium-review.googlesource.com/642151
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498596}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62cf685519caeaffb848879e549b0e2dac11d25c
This reverts commit d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5.
Reason for revert: Broke net_unittests on Cronet bots
Original change's description:
> Update test server spawner to run multiple test servers in parallel
>
> Previously test server spawner didn't allow running more than one test
> server. With this change it's now possible to run multiple tests that
> depend on test_server in parallel.
> 1. Updated chrome_test_launch_spawner.py to support more than one
> test server. /kill now requires a get parameter to specify which
> server should be killed. Number of concurrent test servers is
> specified by test runner which instantiates the spawner.
> 2. Updated test runners for Android and Fuchsia to pass the new
> max_servers parameter for the spawner to match test parallelism
> on these platforms (1 on Android, 4 on Fuchsia).
>
> Bug: 731302
> Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
> Reviewed-on: https://chromium-review.googlesource.com/627339
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497967}
TBR=phajdan.jr@chromium.org,mmenke@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org
Change-Id: Ia8fbe198eddd3900665b18192f9ebfd0a2f08c75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731302
Reviewed-on: https://chromium-review.googlesource.com/642150
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498212}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 690dbd0f33566dfbeba1a9b88e6911adcfb4aa34
SpawningServerRequestHandler.CleanupState() was setting test_servers to
[] instead of {}. As result test server spawner was crashing on some
bots.
TBR=jbudorick@chromium.org
Bug: 760196
Change-Id: Ib11575bca5fad0d1f128e4673e6b50f4d9e58b9b
Reviewed-on: https://chromium-review.googlesource.com/641073
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498160}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 309bd24c9dca914dfce162a336bc320cbd2e6af3
Previously test server spawner didn't allow running more than one test
server. With this change it's now possible to run multiple tests that
depend on test_server in parallel.
1. Updated chrome_test_launch_spawner.py to support more than one
test server. /kill now requires a get parameter to specify which
server should be killed. Number of concurrent test servers is
specified by test runner which instantiates the spawner.
2. Updated test runners for Android and Fuchsia to pass the new
max_servers parameter for the spawner to match test parallelism
on these platforms (1 on Android, 4 on Fuchsia).
Bug: 731302
Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
Reviewed-on: https://chromium-review.googlesource.com/627339
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497967}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5
Previously the port for testserver spawner for hardcoded in
test_runner.py. This means that tests may fail if that port is used when
the test is started. Now the port is allocated dynamically.
Bug: 731302
Change-Id: Ib22e2470cbe952aa25b1b02cf2f5c6a551ebae20
Reviewed-on: https://chromium-review.googlesource.com/627243
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496764}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 13f58d7d848ee2312dcce9ac32966e81c9b0d8cf
chrome_test_server_spawner is used by net_unittests to spawn test
server on the host. Previuously it had dependencies on Android. Moved
it to build/util/common and refactored Android dependency, so the
same code can be used when running these tests on Fuchsia bots.
Bug: 731302
Change-Id: Ie4069b6cc0f1dc98b96f62fdf6a1b692a86b3997
Reviewed-on: https://chromium-review.googlesource.com/603669
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492498}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9cd680e72a411c5a565098251d42863c43aef17f
A common solution for developers using Linux distributions were
/usr/bin/python is linked to /usr/bin/python3 is to put a python ->
python2 symlink earlier in the PATH when working with python2-only
projects. This doesn't work when shebangs bypasses any environment
configuration.
The change was generated by executing:
sed -i 's|#!/usr/bin/python|#!/usr/bin/env python|' \
$(grep -rl '#!/usr/bin/python' build)
Change-Id: I2de77532fd31a0348ec58f4d9af4b7172dc1b9ed
Reviewed-on: https://chromium-review.googlesource.com/559347
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ingemar Ådahl <ingemara@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#484266}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 504c076b196be39b9083a6cab1c9dee11a66b33e
Now that blink lives in the src repo, there's no need to generate a
separate LASTCHANGE file for it.
The LASTCHANGE line makes it into the user agent. LASTCHANGE.blink
used --git-hash-only to only have the git hash in there. Remove
that now-unused flag and use version.py's -e flag to get the same
effect for webkit_version.h
Reverts parts of https://chromiumcodereview.appspot.com/14973005/
No intended behavior change.
BUG=none
Review-Url: https://codereview.chromium.org/1982423002
Cr-Original-Commit-Position: refs/heads/master@{#465739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 69e2570d4b5e50cd708e4c467e567d810c4b2134
(Compared to https://codereview.chromium.org/2308313003/, this version
fixes chrome/installer/linux/BUILD.gn by including all required files)
There is nothing really chrome-specific in the process_version()
template, and if we stop always passing some files in chrome/ on every
invocation it is possible to generalize it and move it to build/util
instead (and fix some layering violation comments along the way).
Compared to its previous incarnation, process_version() no longer passes
LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
it easier for callers to specify their own |sources| with values that
may override those set in those 3 files.
A new wrapper, process_version_rc_template(), was introduced to cater
for callers (generally Windows ones) who need to process a .rc.version
file that requires the values from LASTCHANGE, BRANDING and VERSION. It
always passes those 3 files to process_version() before any optional
additional |sources|, and |template_file| defaults to
chrome_version.rc.version.
Since this template depends on files from //chrome, it lives in the
newly-added //chrome/process_version_rc_template.gni.
R=dpranke@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,ddorwin@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2341673003
Cr-Original-Commit-Position: refs/heads/master@{#419377}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dc683d2a5c9af8b55245ce5ab2253d0b6977ccfb
Reason for revert:
This appears to cause compile errors on
"Google Chrome Linux x64", closing the main waterfall.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/13577
FAILED: installer/version.txt
python ../../build/util/version.py --official -f ../../chrome/VERSION -f ../../chrome/app/theme/google_chrome/BRANDING -o installer/version.txt
Traceback (most recent call last):
File "../../build/util/version.py", line 170, in <module>
sys.exit(main())
File "../../build/util/version.py", line 159, in main
""" % values
KeyError: 'LASTCHANGE'
Original issue's description:
> There is nothing really chrome-specific in the process_version()
> template, and if we stop always passing some files in chrome/ on every
> invocation it is possible to generalize it and move it to build/util
> instead (and fix some layering violation comments along the way).
>
> Compared to its previous incarnation, process_version() no longer passes
> LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
> it easier for callers to specify their own |sources| with values that
> may override those set in those 3 files.
>
> A new wrapper, process_version_rc_template(), was introduced to cater
> for callers (generally Windows ones) who need to process a .rc.version
> file that requires the values from LASTCHANGE, BRANDING and VERSION. It
> always passes those 3 files to process_version() before any optional
> additional |sources|, and |template_file| defaults to
> chrome_version.rc.version.
> Since this template depends on files from //chrome, it lives in the
> newly-added //chrome/process_version_rc_template.gni.
>
> R=dpranke@chromium.org,brettw@chromium.org
>
> Committed: https://crrev.com/cf276fc41653b2830a5ec796d4db09b199754677
> Cr-Commit-Position: refs/heads/master@{#418514}
TBR=phajdan.jr@chromium.org,brettw@chromium.org,ddorwin@chromium.org,dpranke@chromium.org,xhwang@chromium.org,raphael.kubo.da.costa@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2338093003
Cr-Original-Commit-Position: refs/heads/master@{#418519}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b4efc387bb10eef38bbd8cb20a79802e508dd1ba
template, and if we stop always passing some files in chrome/ on every
invocation it is possible to generalize it and move it to build/util
instead (and fix some layering violation comments along the way).
Compared to its previous incarnation, process_version() no longer passes
LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
it easier for callers to specify their own |sources| with values that
may override those set in those 3 files.
A new wrapper, process_version_rc_template(), was introduced to cater
for callers (generally Windows ones) who need to process a .rc.version
file that requires the values from LASTCHANGE, BRANDING and VERSION. It
always passes those 3 files to process_version() before any optional
additional |sources|, and |template_file| defaults to
chrome_version.rc.version.
Since this template depends on files from //chrome, it lives in the
newly-added //chrome/process_version_rc_template.gni.
R=dpranke@chromium.org,brettw@chromium.org
Review-Url: https://codereview.chromium.org/2308313003
Cr-Original-Commit-Position: refs/heads/master@{#418514}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf276fc41653b2830a5ec796d4db09b199754677
Reason for revert:
The actual crash was in OmahaClient, which is fixed in: http://crrev.com/1856823002
Original issue's description:
> Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ )
>
> Reason for revert:
> Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830
>
> Original issue's description:
> > Propagate is_official_build to version script.
> >
> > OFFICIAL_BUILD is a special variable in the version script which
> > takes its value from the environment variable. This means that local
> > builds with is_official_build will not actually result in
> > ChromeVersionConstants.isOfficialBuild() returning true.
> >
> > This CL propagates the is_official_build truthiness to the script so
> > official builds no longer depend solely on the environment variable.
> >
> > BUG=599268
> >
> > Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> > Cr-Commit-Position: refs/heads/master@{#384340}
>
> TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=599268
>
> Committed: https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b
> Cr-Commit-Position: refs/heads/master@{#384610}
TBR=agrieve@chromium.org,thestig@chromium.org,skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599268
Review URL: https://codereview.chromium.org/1856843002
Cr-Original-Commit-Position: refs/heads/master@{#385007}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87d01a7e475b0785364328af5b22b15b28a40e66
Reason for revert:
Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830
Original issue's description:
> Propagate is_official_build to version script.
>
> OFFICIAL_BUILD is a special variable in the version script which
> takes its value from the environment variable. This means that local
> builds with is_official_build will not actually result in
> ChromeVersionConstants.isOfficialBuild() returning true.
>
> This CL propagates the is_official_build truthiness to the script so
> official builds no longer depend solely on the environment variable.
>
> BUG=599268
>
> Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> Cr-Commit-Position: refs/heads/master@{#384340}
TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=599268
Review URL: https://codereview.chromium.org/1851843002
Cr-Original-Commit-Position: refs/heads/master@{#384610}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 756e9b934bf1d706dd59ab39bed2af842b67063b
OFFICIAL_BUILD is a special variable in the version script which
takes its value from the environment variable. This means that local
builds with is_official_build will not actually result in
ChromeVersionConstants.isOfficialBuild() returning true.
This CL propagates the is_official_build truthiness to the script so
official builds no longer depend solely on the environment variable.
BUG=599268
Review URL: https://codereview.chromium.org/1838173005
Cr-Original-Commit-Position: refs/heads/master@{#384340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eab85df0275b825e428954c4030e358ce968ecd9
This is a documentation-only change.
Disabling presubmit checks, due to "noparent" settings for the following files:
components/policy/resources/policy_templates.json
content/common/font_config_ipc_linux.h
BUG=567488
NOPRESUBMIT=true
TBR=atwilson,dcheng
Review URL: https://codereview.chromium.org/1592403002
Cr-Original-Commit-Position: refs/heads/master@{#374213}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df175a8c3d1c1060f96d123a5896fdfbe4b3782d
This CL ports the remoting_me2me_host_archive target to GN and several
of its dependent targets. This is only a partial port of the target, as
the 'remoting_infoplist_strings' target hasn't been ported yet, but I'm
not actually sure if that's needed on Linux.
This CL also fixes the path to the remoting-webapp zip file.
Both of these targets were needed in order to flip the official
Linux x64 build over to GN.
BUG=512899, 530733
Review URL: https://codereview.chromium.org/1426113002
Cr-Original-Commit-Position: refs/heads/master@{#357697}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 63e164a242653dbed7932fe9213da828aa280f78
Add template to run a java command as an "script", i.e. templates
java_action/java_action_foreach similar to action/action_foreach.
Add template to compile a bunch of JavaScript to a bundle and to
compile JavaScript files with closure compile (only enable checks
that are known to work).
Fix gcdwebserver public configuration to add the dependency on libz
to libs instead of using ldflags.
Add files missing from //ui/base:test_support when building for iOS
with gn (they are present in the gyp build).
BUG=459705
Review URL: https://codereview.chromium.org/1393303003
Cr-Original-Commit-Position: refs/heads/master@{#355460}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aa7c1cf96274a0a531629f934bd9091a55439270
This will guarantee that a development build with a not yet commit HEAD
will also get a valid devtools frontend from the servers
BUG=535268
R=pfeldman@chromium.org,mnaganov@chromium.org,dpranke@chromium.org
Review URL: https://codereview.chromium.org/1361393002
Cr-Original-Commit-Position: refs/heads/master@{#350565}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb61e3682fe7301373360fa851c7cb3dea9aec1f
This generates a proper version manifest for chrome.exe and also for the version assembly.
This adds a new way to get the chrome version info programatically at GN time. Although this adds another exec_script call, it removes four such calls in remoting so there is a net speed increase.
BUG=
Review URL: https://codereview.chromium.org/1250853007
Cr-Original-Commit-Position: refs/heads/master@{#339833}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 983c0562bba1e4d93bb7ee489f56bcbd61fc55f9
Adds optional flag '--git-svn-go-deeper' to allow lastchange.py find
the last committed SVN revision in a Git-SVN repo.
This is to help access DevTools frontend on Android for Chromium developers
that have local changes to Blink.
BUG=468691
Review URL: https://codereview.chromium.org/1197483002
Cr-Original-Commit-Position: refs/heads/master@{#335156}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b73e2ea7a4e319eb2e6183090dfe6b9796d42c3b
Xiyuan Xia
Olivier Robin
Klaus Weidner
Kevin Marshall
Matt Mueller
Dmitry Trofimovich
Sergey Ulanov
Kai Ninomiya
bsheedy
Sergey Ulanov
Tarun Bansal
Ingemar Ådahl
thakis
sdy
raphael.kubo.da.costa
yutak
brettw
rsesek
wnwen
skyostil
mostynb
alexandermont
dpranke
tfarina
sdefresne
jochen
gunsch
agrieve
mnaganov