The using_new_optimization_config existed to allow a multi-sided V8 build
update that is now complete.
TBR=dpranke
Review URL: https://codereview.chromium.org/1351623003
Cr-Original-Commit-Position: refs/heads/master@{#349212}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ae96775ac803adcc2a1ce95064ea46a6b75b95bf
This also re-organizes a bit by moving all incremental install related
files into //build/android/incremental_install.
BUG=520082
Review URL: https://codereview.chromium.org/1338813003
Cr-Original-Commit-Position: refs/heads/master@{#349200}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 933f2593199c4f95678ddda884aa476ff1fe0c23
Few more changes need to go in before enabling NaCl support for MIPS,
lets have it disabled until then.
TEST=Build Chromium using GN.
BUG=130022
Review URL: https://codereview.chromium.org/1344803002
Cr-Original-Commit-Position: refs/heads/master@{#349109}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d82b297171f8a108efd23929927009d4874548cf
The zip template really isn't android-specific, let's move it to its
own .gni file which doesn't assert(is_android).
Review URL: https://codereview.chromium.org/1345733002
Cr-Original-Commit-Position: refs/heads/master@{#349016}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3dba3175c9f137742ddb10dbe9a10a5417186402
This factors the irt_* toolchain definitions using a template to reduce
copied boilerplate. It also switches the ARM build to use arm-nacl-clang
rather than arm-nacl-gcc, which matches what the GYP build does now. Many
of the compilation flags are still not at all right, but this is enough
for the build of the IRT to complete successfully.
BUG=531702
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1341143002
Cr-Original-Commit-Position: refs/heads/master@{#348781}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 916aafa6563eb600b60a683d52d0c121f2eaee92
Previously //build/config/sanitizer:deps unconditionally depended on
//third_party/instrumented_libraries:deps. This dependency is only necessary
//when compiling with a sanitizer, and in standalone other projects like nacl,
//instrumented_libraries doesn't exist.
This patch makes all contents of sanitizer:deps conditional on using a
sanitizer, which matches what the documentation explicitly says.
BUG=
Review URL: https://codereview.chromium.org/1341043005
Cr-Original-Commit-Position: refs/heads/master@{#348719}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc6f9a5b1858c70d852029f77020cabd3db879f6
This also moves the config out of the template. Otherwise this will generate an
error if there is more than one MIDL target in the same directory.
Use forward_variables_from in the MIDL template.
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1335283002
Cr-Original-Commit-Position: refs/heads/master@{#348664}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c0c67ed3859656cb869fb517527938f70ed0cc6
libevdev-cros is not needed for the host tooling, and is not availale for
the host in a chroot chromeos building environment.
BUG=527996
Review URL: https://codereview.chromium.org/1322343002
Cr-Original-Commit-Position: refs/heads/master@{#347531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 97739b5fcf32a746c38d8142bff56d0072953dbf
This CL adds support for overriding android_keystore_path,
android_keystore_name, android_keystore_password from other config
files.
It also adds documentation to these arguments and removes 'default'
from their name.
The chromium debug key is still used by default for all builds.
BUG=479253
Review URL: https://codereview.chromium.org/1311043014
Cr-Original-Commit-Position: refs/heads/master@{#347521}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fbc342116e60698aae09bf4175a30bf8ccc14704
I went through and did some flag auditing to try to get GN's official build mini_installer target as small as GYP's. It's still 512 bytes too large.
Adds the custom mini_installer flags to the "lib" target as well as the main mini_installer target. This removes some imports around exception handling.
Sync some official build flags: LTCG should go on all optimized targets in official builds, not just "optimize max" ones. Doing this on optimize max has no effect because we only set optimize_max on individual libraries that need to be fast, rather than anything that gets linked.
Convert /OPT:REF to /OPT:ICF. GYP specifies both, but ICF seems to imply REF according to MSDN.
Added some missing release mode flags "/d2Zi+", "/Zc:inline", and "/cgthreads:8", which I found missing from GN.
Removed a dependency on "setup" from mini installer, this is captured by the dependency on ":archive" (which already includes the setup dependency).
Review URL: https://codereview.chromium.org/1329833002
Cr-Original-Commit-Position: refs/heads/master@{#347447}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7cb45ce734f09f358e62fd982c8fa288673b2ab5
Android is the last remaining platform that has not yet converted to CLDv2.
Sheriffs: expect to see APK size changes in the range of [-122K, +98K] bytes.
See the bug for more information.
As on iOS, use the smallest data tables to minimize the binary size impact.
This brings language detection on Android into parity with iOS (which also uses
the smallest data tables).
BUG=528257
Review URL: https://codereview.chromium.org/1327543003
Cr-Original-Commit-Position: refs/heads/master@{#347418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a70dc32d62dc1a0e9a8885f2258fe612aeb1f06
Rebuilding chrome_java before change:
real 1m0.108s
user 7m44.609s
sys 0m27.630s
Rebuilding chrome_java after change:
real 0m57.893s
user 7m22.493s
sys 0m21.224s
BUG=527632
Review URL: https://codereview.chromium.org/1328823002
Cr-Original-Commit-Position: refs/heads/master@{#347405}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6d6c9ac82e8f06abb047501d37b95cae145a727c
As part of the un-forking of the NaCl GN build configs, we need
to be a little more careful about which NaCl toolchains are considered
to be "clang" or not and whether some of the clang-specific compiler
settings need to be applied in the NaCl contexts.
Also, remove more stray references to the old Nacl build configs.
R=brettw@chromium.org, mcgrathr@chromium.org, thakis@chromium.org
BUG=433528
Review URL: https://codereview.chromium.org/1307653008
Cr-Original-Commit-Position: refs/heads/master@{#347262}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b8c6bf7592cf6cb412f2d3f151bc29bd96ee7380
It's much faster than using javap (what we currently do):
With javap, building chrome_java:
real 1m17.162s
user 7m46.230s
sys 0m42.836s
With ijar, building chrome_java:
real 0m56.446s
user 5m38.761s
sys 0m26.006s
BUG=527632
Review URL: https://codereview.chromium.org/1323053003
Cr-Original-Commit-Position: refs/heads/master@{#347208}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 77614d453e6324c9da3e12b93b4c19800cbe09a9
I found that msan doesn't link in debug builds. It fails linking with an
obscure error. To prevent other people from having this problem, this patch
adds an assert for this case.
Review URL: https://codereview.chromium.org/1326453003
Cr-Original-Commit-Position: refs/heads/master@{#346764}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1131f71c0604dfbe6e1f2d3ef6dcb8d288c7e4f6
This adds a "use_gtk3" gyp/gn flag, along with a separate gtk2/gtk3
targets in system.gyp and //build/config/linux/gtk[23] in gn.
BUG=132847
Review URL: https://codereview.chromium.org/1293073006
Cr-Original-Commit-Position: refs/heads/master@{#346742}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b8f8f682a82bce992edb35c3030214ede236d3ba
Reason for revert:
Reason for revert was a misunderstanding of issues that another piece of code was having interacting with the Cardboard SDK. This code was not exhibiting the same problems, so restoring it while we investigate the other code's issues further.
Original issue's description:
> Revert of Android WebVR implementation, Cardboard 0.5.5 SDK (patchset #12 id:220001 of https://codereview.chromium.org/1200303002/ )
>
> Reason for revert:
> Android team found an incompatibility with the 0.5.5 Cardboard SDK and non-ARM devices. Rolling back until the Cardboard team can address that.
>
> Original issue's description:
> > Android WebVR implementation, Cardboard 0.5.5 SDK
> >
> > Previously part of https://codereview.chromium.org/829803003/
> >
> > BUG=389343
> >
> > Committed: https://crrev.com/1d9c45547709e77d599c218d76317895389db129
> > Cr-Commit-Position: refs/heads/master@{#342496}
> >
> > Committed: https://crrev.com/d9be58be03170c7c82f9c55abc2d21f0f7447c7f
> > Cr-Commit-Position: refs/heads/master@{#345356}
>
> TBR=jochen@chromium.org,jdduke@chromium.org,sievers@chromium.org,tedchoc@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=389343
>
> Committed: https://crrev.com/9763eb99753dc90ae912ebfbee3ba240c37db427
> Cr-Commit-Position: refs/heads/master@{#346669}
TBR=jochen@chromium.org,jdduke@chromium.org,sievers@chromium.org,tedchoc@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=389343
Review URL: https://codereview.chromium.org/1306883009
Cr-Original-Commit-Position: refs/heads/master@{#346716}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3fca9561b090d6e0bac68ebd6267b78cb39bbdf9
Currently only .so files are side-loaded (no .dex side-loading yet).
Does not require a rooted device.
Usage:
ninja -C out/Debug chrome_apk_incremental
out/Debug/bin/install_incremental_chrome_app_apk
BUG=520082
Review URL: https://codereview.chromium.org/1291793007
Cr-Original-Commit-Position: refs/heads/master@{#346583}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ae65db8da9a27bea569869f4b5a86de4b4857260
With this change, in the Chromium repo NaCl will now be built solely using Chromium's versions of the GN build files, rather than a mixture of chromium and NaCl files.
This will allow us to delete the NaCl versions in a subsequent NaCl-side CL and switch to pulling the chromium versions in via a DEPS entry, and thus "unfork" the build.
R=brettw@chromium.org, ncbray@chromium.org, mcgrathr@chromium.org
BUG=433528
Review URL: https://codereview.chromium.org/1312813003
Cr-Original-Commit-Position: refs/heads/master@{#346452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fa6ffe2fb9f488ddb859555f5abc29de72407a62
We should rely on GYP_DEFINE "enable_plugins" in gyp files and C++ macro
"ENABLE_PLUGINS" in source code to indicate plugins support. This removes
hard-coded assumptions that certain OS does (or does not) support plugins.
Also add GYP_DEFINE "enable_pdf" and macro "ENABLE_PDF" to indicate
built-in PDF viewer plugin support.
BUG=490433
TEST=trybot
TBR=sievers@chromium.org
Review URL: https://codereview.chromium.org/1318143002
Cr-Original-Commit-Position: refs/heads/master@{#346284}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 11e9711134d075bef1580c56f189ae5e1ab3c034
Changes the version processing templates to not implicitly include the chrome version .rc file. This was something I've been meaning to do for a while which was forced by this patch, because it wants to call version.py with no sources or template file. I also had to remove some checks that either a template file or sources were defined (I wasn't aware this was valid to do when I wrote these checks).
The above-mentioned change necessitated referencing the version template file from a number of existing calls.
The version script now explicitly sets the output file with -o. Previously this was the implicit second argument, but this didn't work if there was no template file. -o is the same and it's better to be more explicit anyway.
Added copy rules for xdg-mime related scripts which are required by the installer.
Added a meta "installer" target which links to the Linux installers. This will also be a good place to hook up the Windows installer when we write it.
BUG=525839
TBR=thestig@chromium.org (linux installer), ddorwin@chromium.org (widevine)
Review URL: https://codereview.chromium.org/1311543003
Cr-Original-Commit-Position: refs/heads/master@{#346279}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a874dccb5c0b7ccfe803a798a585351ce5efccc7
The //build/config/linux library defined a number of targets
built through the generate_library_loader target. All of these
are fairly chrome-specific, so having them defined in the
//build/config/linux file made it harder to reuse that file
in non-chrome GN builds (like native_client).
This CL moves the targets out to a new //build/linux directory
and updates the callers accordingly.
R=brettw@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1314163005
Cr-Original-Commit-Position: refs/heads/master@{#346242}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad0c1f495eca0968601ea74254b86fb91d412eb0
If errorprone finds an error in non-Chromium code the build will
fail. This shouldn't happen, so I am disabling errorprone on
non-Chromium code.
BUG=
Review URL: https://codereview.chromium.org/1314493010
Cr-Original-Commit-Position: refs/heads/master@{#345941}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb9e4863c7dd58c17fd53cd025f7f0dad17a52a5
This updates errorprone from 1.1.2 to 2.0.1. Version 2.0.1 includes
some fixes that lets errorprone work if you have java 8. I also
deleted the ChromiumErrorProneCompiler to just use the default
ErrorProneCompiler instead. Currently, the ChromiumErrorProneCompiler
doesn't override any default behavior and would need to be
changed a good bit to be compatible with 2.0.1.
BUG=517259
Review URL: https://codereview.chromium.org/1286613002
Cr-Original-Commit-Position: refs/heads/master@{#345688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 29d8817ee93db9e2ba9177a456a4992e3ad54d99
These are not depended on by the main rule, but can be built explicitly.
They are meant to be used to decrease adb install times (see bug)
BUG=520082
Review URL: https://codereview.chromium.org/1288023003
Cr-Original-Commit-Position: refs/heads/master@{#345513}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fd28ec0ae16a28fba11d0e3b72870f286b990d46
Since ChromeShell is going away, we shouldn't reference it in examples
in comments. This updates those comments to use something else as an
example.
Also, removing these references makes it easier to grep for the real
remaining uses of ChromeShell in the codebase.
BUG=510220
Review URL: https://codereview.chromium.org/1310733002
Cr-Original-Commit-Position: refs/heads/master@{#345452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 309af8fba631f827583b3c4f19acf7b3b50c6363
brettw
agrieve
Gordana.Cmiljanovic
mostynb
thakis
mcgrathr
sergeyu
dpranke
yfriedman
pcc
andrewhayden
petermayo
nyquist
erg
scheib
bajones
brucedawson
hshi
hanxi
mikecase
newt
jbudorick