Change common.gypi to pass scale_factors=2x to grit on Mac
(as a side effect, the close button on about:settings now looks
good).
Change bookmark_manager/main.html to type="chrome_html"
so that it gets the 2x image auto-treatment that's documented at
sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources
The icon in the upper left corner of about:bookmarks looks good
with this change, but the tree icons don't yet because cr/ui/tree.js
needs js code changes to make HiDPI icons work.
BUG=134372,123162
TEST=Open bookmark manager. Almost all images look good in HiDPI.
Review URL: https://chromiumcodereview.appspot.com/10662039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@144305 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
v8/build/common.gypi now uses environment variable CXX_target which is only
set in android_gyp, not set when gyp_chromium is called by gclient or automatic
makefile regeneration.
Now exports the environment variables needed by gyp generation.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10511019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@140431 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Without this CL, the gyp define release_extra_cflags is applied to both host and
target compiles. With this CL, the gyp define is only applied to the target
compiles.
BUG=v8:2157
TEST=gyp_chromium with extra flags. Made sure that the target mk files like
v8_shell.host.mk did not have the flags while v8_nosnapshot.target.mk had the
flags.
Review URL: https://chromiumcodereview.appspot.com/10456020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@139909 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Set the install name of all dylibs to @rpath.
Set the rpath of all executables to '@loader_path/.' (for normal binaries)
and '@loader_path/../../..' (for bundled binaries).
Also, Chromium Helper.app doesn't end up in out/Release but
somewhere below Chromium.app, so set its rpath to
'@loader_path/../../../../../../..' to get all the way back to
out/Release.
Also add "(allow file-read-metadata)" to the sandbox definition when
running on 10.6 or earlier when using the component build, to work
around a bug in dyld (see http://crbug.com/127465).
BUG=90078,127465
TEST=Do a components build. DYLD_LIBRARY_PATH isn't necessary at
build time, and isn't necessary when running chromium or test binaries.
Review URL: https://chromiumcodereview.appspot.com/10389047
git-svn-id: http://src.chromium.org/svn/trunk/src/build@139550 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The primary issues is specifying the right path to PRODUCT_DIR (i.e.
out/Release). The gyp generator for make specifies the absolute path but
for ninja would use a relative path. Since the gyp targets don't line
up with where the ant build files are located this causes failures such
as base's java being generated in base/android/out/Release/...
See:
https://groups.google.com/forum/#!msg/gyp-developer/K2T_9obUya0/qq78_Ut-E-AJ
for details.
A couple of other minor fixes:
- content java files are placed in out/Release/java/content to be
consisent with other packages.
- shared-libraries are now referenced by correct variables for apk-based
tests
- removed unused media/base/android/java/java.gyp (target is in
media/media.gyp)
TBR=mark@chromium.org,ben@chromium.org,rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386188
git-svn-id: http://src.chromium.org/svn/trunk/src/build@139418 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The flag was mostly redundant with the enable_touch_ui flag, the only
additional effect of turning it on was to change the behavior of
ui::GetDisplayLayout.
If we later wanted to duplicate the effect that disabling the
enable_metro flag prior to this change would have, we can simply
change the condition in common.gypi that determines whether to turn on
the enable_touch_ui flag.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10440037
git-svn-id: http://src.chromium.org/svn/trunk/src/build@139181 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The error is caused by missing '-m32' parameter when building v8 for host.
CXX(host) out/Release/obj.host/v8_base/v8/src/accessors.o
v8/src/globals.h:120:2: error: #error Target architecture arm is only supported on arm and ia32 host
v8/build/common.gypi tests if the compiler supports -m32:
'm32flag': '<!((echo | $(echo ${CXX_host:-$(which g++)}) -m32 -E - > /dev/null 2>&1) && echo -n "-m32" || true)',
but goma is confused by the environment variable GOMA_WRAPPER and exits
with an error:
GOMA_WRAPPER=<anything>: unkown GOMA_ parameter
and the gyp script thinks that the compiler doesn't support -m32.
Rename GOMA_WRAPPER to ANDROID_GOMA_WRAPPER to avoid confusing goma.
git-svn-id: http://src.chromium.org/svn/trunk/src/build@138916 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This will make the android_test bot red when apk tests fail.
The ANDROID_APK_TEST_TARGET flag is required while we transition from executable to APK tests.
- Executable tests need the DIR_CACHE override as the default path comes from the java side.
BUG=125059
Review URL: https://chromiumcodereview.appspot.com/10332230
git-svn-id: http://src.chromium.org/svn/trunk/src/build@138407 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Enable the Clang error that makes it a warning/error to derive from
base::RefCounted/RefCountedThreadSafe directly and have a public
destructor for Linux and Mac builds.
For ChromeOS builds, do not yet enable the warning, as it does not
yet build cleanly.
BUG=123295
TEST=it compiles
R=thakis
Review URL: https://chromiumcodereview.appspot.com/10414016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@138031 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This way, those of us working on the proxy switch need only add:
{
'variables': {
'build_ppapi_ipc_proxy_untrusted': '1',
},
}
to "~/.gyp/include.gypi"
...and we'll be able to build our untrusted targets without editing all.gyp. For anybody who doesn't set that flag, our ppapi_proxy_untrusted.gypi file will still be parsed, but it doesn't matter if the source files build (or even exist).
BUG=116317
TEST=
Review URL: https://chromiumcodereview.appspot.com/10399068
git-svn-id: http://src.chromium.org/svn/trunk/src/build@137751 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When enabled, this tool is built into Chrome and makes it log its routine invocations. Every time a routine is called and if it is called for the first time (per each thread), the log is updated with current time and the address of the routine. Later, such logs can be merged (across all threads), symbolized and fed into linker ('order_text_section') so it produces binary with more optimal code layout. This must make code work faster because of better CPU cache utilization.
See more technical details in tools/cygprofile/cygprofile.cc header.
Cyg prefix is taken after the callback names in gcc that we use to hook the code: __cyg_profile_func_enter and __cyg_profile_func_exit.
More info at https://sites.google.com/a/google.com/chrome-msk/dev/boot-speed-up-effort
BUG=chromium-os:20187
TEST=units, build cros with
declare -x EXTRA_BUILD_ARGS="order_profiling=1 linux_use_tcmalloc=0"
run it and check the log at /var/log/chrome/cyglog.*.
Review URL: https://chromiumcodereview.appspot.com/8770054
git-svn-id: http://src.chromium.org/svn/trunk/src/build@137391 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The problem with the current component build is that chrome.exe and setup.exe only know to look for DLLs like base.dll in the current directory (except chrome.dll for which they're hardcoded to know where to look). On an install those DLLs are in the version directory so chrome.exe and setup.exe fail to run not finding required DLLs...
To fix this we generate config files (to point in the version directory) and manifests (to list all the DLL dependencies explicitly) to be installed beside the exes.
Each DLL also has a manifest in the version directory to give it an "assemblyIdentity" (i.e. a unique name which is referred to as a dependency by each exe's manifest).
In order for external manifests to work, embedded manifests had to be disabled for component builds (otherwise Windows ignores the external one).
Since embedded manifests are disabled and the generated manifests are only generated in the archive to be extracted at install-time. This CL also adds a copy step for the usually embedded manifests to be dropped in the build directory so that chrome.exe and setup.exe are usable from there without requiring an install.
This doesn't make mini_installer.exe compatible with the component build yet (as mini_installer runs setup.exe right after extracting it and without any other DLLs/manifests beside it).
However it is now possible to use setup.exe (which takes the exact same parameters as mini_installer.exe) from the build output directory with a component build :)!!!
BUG=127233
TEST=Turn on component build with gyp config "component=shared_libary" and make sure we can install chrome with setup.exe.
Make sure we can run the installed Chrome.
Make sure we can uninstall the installed Chrome (i.e. that setup.exe in <version_dir>/Installer is able to find its DLLs).
Review URL: https://chromiumcodereview.appspot.com/9701050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@137118 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Need to propagate variable android_upstream_bringup to outer variable dict to make sure the variable can be reached by condition ['android_upstream_bringup==1' even we are in downstream tree which doesn't define android_upstream_bringup=1.
Otherwise android-gyp is going to show "NameError: name 'android_upstream_bringup' is not defined while evaluating condition 'android_upstream_bringup==1' in /usr/local/google/code/chromium-android/src/build/all_android.gyp..."
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10389062
git-svn-id: http://src.chromium.org/svn/trunk/src/build@136515 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Build media java files (we weren't).
Fix adb_install_content_shell for cases where the app was stuck.
Add upstream staging gyp var / #define.
Be more consistent about jar output files (all in lib.java).
Upstream a bunch of random files (e.g. ppapi).
Upstream a bunch of java and native code hit as part of shlib init.
Properly package jar files in content shell.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10377059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@136219 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Layer's coordinate system is now in DIP.
Added support of dynamic density switching.
Removed ENABLE_DIP gyp/macro and added runtime flag "--ui-enable-dip"
BUG=105165, 114666
TEST=enabled monitor test. added new tests to compositor_unittests
Review URL: https://chromiumcodereview.appspot.com/10221028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@135888 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently, the '-mfloat-abi=soft' is hard coded in the gyp file, but what we need is "-mfloat-abi=hard", since it is hard-coded, we no way to change it.
So this CL removed this hard-coded value, replaced it with variable arm_float_abi, which has a default value of 'soft'. Later in the ebuild file, we can easily override this value to be 'hard', thus make the build hardfp.
BUG=None
TEST=build manually in chromium
Review URL: http://codereview.chromium.org/10351018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@135388 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This follows the same pattern for theme_resources_touch_1x as we used for ui_resources_touch. I also introduced a gyp flag for enable_touch_ui at sky's suggestion.
BUG=115234
TEST=visual, run with --touch-optimized-ui and see bigger tabstrip and toolbar assets
Review URL: https://chromiumcodereview.appspot.com/10320002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@134942 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL does the following:
- add a new enable_metro build flag
- if the build flag is set then add a new metro icon resource pak to chrome
- at run time if Chrome is running in metro mode AND ENABLE_METRO is set then use the metro icon resource pak
BUG=114311
TEST=
Review URL: http://codereview.chromium.org/10082020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133843 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132760
Review URL: https://chromiumcodereview.appspot.com/10024050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133613 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
OFF by default; enable with a gyp var. E.g.
GYP_DEFINES="$GYP_DEFINES gtest_target_type=shared_library" android_gyp
Some useful commands:
adb uninstall org.chromium.native_test
adb install -r out/Release/base_unittests_apk/ChromeNativeTests-debug.apk
adb shell am start -n org.chromium.native_test/org.chromium.native_test.ChromeNativeTestActivity
For the moment, all apks can be built simultaneously but use the same
activity name. Thus you cannot have more than one installed at the
same time.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/10051021
git-svn-id: http://src.chromium.org/svn/trunk/src/build@133053 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517
Review URL: http://codereview.chromium.org/10024050TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10115031
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132804 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517
Review URL: http://codereview.chromium.org/10024050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132760 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Review URL: http://codereview.chromium.org/10024050TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10103022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132529 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently all 1x art files are repacked into chrome.pak files.
This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.
As a first step this CL does the following:
- add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
- stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
- update the Mac and Windows installer code to package the extra pak files.
Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.
BUG=114311
TEST=Ran on Windows, and Mac and Linux.
Review URL: http://codereview.chromium.org/10024050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132517 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Interesting changes in this range:
* The tooling infrastructure landed. Not observable, but it makes it easier
to write clang tools.
* Honor -fno-pic, pie support
* Better diagnostics for several c++11 features
* Cross-compiler changes that hopefully make CrOs clang builds simpler
* Many LTO fixes
Also pick up a minor change to the style plugin: Instead of ignoring
problems below out/, it now ignores them below gen/ and geni/. This
should make it work better with custom build directories.
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/10081013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132350 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
While we sort out the remaining linker errors, this at least ensures we
can add compliation of a bunch of chrome code for Android to gatekeeper.
This is motivated by having the android unit_tests compilation step
broken 4 out of 4 days this week.
BUG=117407
Review URL: http://codereview.chromium.org/10065018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132154 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When Chrome is built with -fprofile-generate in *_extra_cflags, it needs to link
against gcov. Adding -lgcov to the link line doesn't help because it occurs
before -Wl,--start-group. This flag correctly adds the required library if used
like the test case described below.
BUG=102550
TEST=GYP_DEFINES="debug_extra_cflags=-fprofile-generate libraries_for_target=-lgcov" ./build/gyp_chromium
make -j5 chrome # passes.
Review URL: http://codereview.chromium.org/10054022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@132061 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This work is useful to make sure at build time that we are not accessing prefs that are not registered.
This CL addresses the prefs registered by:
BrowserInit::RegisterUserPrefs
PinnedTabCodec::RegisterUserPrefs
PluginsUI::RegisterUserPrefs
PromoResourceService::RegisterUserPrefs
Later CL:
Browser::RegisterUserPrefs
SyncPromoUI::RegisterUserPrefs
*::RegisterPrefs
BUG=120802
TEST=Compiled and made diff-ed the link error to make sure they are the same.
Review URL: http://codereview.chromium.org/9949033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131994 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Most of the included changes are minor. After this roll, we
have what went into the 1.6 release, and gmock now supports
being build as a DLL. (I want this roll for one of the minor
changes, which makes it possible to reenable
-Wnull-dereference for clang)
Turn -Wnull-dereference back on, fix one instance where a
violation snuck in.
BUG=111806
TEST=none
TBR=tony
Review URL: https://chromiumcodereview.appspot.com/9999025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131656 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is copied from integer version, instead of using
template, to minimize conflict with m19 branch, as
using template requires updating forward declaration
of these classes in many places.
I put this behind gyp flag for now so that we can move forward without breaking non DIP build until we can get aura
working with DIP.
BUG=114664
TEST=none
Review URL: http://codereview.chromium.org/10025004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131405 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dlldata.c is a generated file name that a bunch of idl build rules output but most do not actually compile it AFAICT. This was causing some targets in isimpledom (that contain multiple idl files) to output to the same name (dlldata.c), so uniquize it based on InputName. For the one target that seems to actually build dlldata.c, override back to the original name to keep things the same (iaccessible2).
Review URL: http://codereview.chromium.org/10008061
git-svn-id: http://src.chromium.org/svn/trunk/src/build@131232 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The change adds a ENABLE_PROTECTOR_SERVICE condition to exclude
ProtectorService and related code. I have introduced protector_utils.h which
contains methods used by keyword_table.cc to sign and verify keywords.
Note: ChromeOS also excludes protector from the tests
(chrome_tests.gypi), but disables ProtectorService using a command line
switch.
BUG=117407
TEST=
Review URL: http://codereview.chromium.org/9863047
git-svn-id: http://src.chromium.org/svn/trunk/src/build@129910 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Enable one-click signin on Linux.
Build GTK version of one-click signin dialog.
BUG=120577
TEST=On Linux, with a clean profile, sign into GMail. The one-click infobar should pop up, and clicking "OK, sync" should bring up the one-click dialog.
Review URL: https://chromiumcodereview.appspot.com/9874006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@129762 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL conceptually does several things (most of them just one line).
1. Roll RLZ 105:118
106: Fix "expression result unused" warning caused by VERIFY() use.
107: rlz: Add an implementation of PingServer() that uses chrome's net stack.
108: Implement RlzValueStoreMac.
109: Move GetMachineId() to its own file. No intended behavior change.
110: Implement GetSystemTimeAsInt64() on mac.
111: Minor cleanups.
112: Don't pay a static initializer for expected_assertion_ when it's not used.
113: Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc
114: mac: Implement GetMachineId().
115: mac: Implement the locking part of ScopedRlzValueStoreLock.
116: Tweaks to make the use of chrome's net stack forceable through gyp.
117: Push RLZ_NETWORK_IMPLEMENTATION_ define to dependent targets.
118: Use base::mac::ScopedNSAutorleasePool only on mac.
2. Change rlz.cpp to use the blocking pool instead of the file thread.
3. Enable on mac.
4. Switch to chrome's network stack on windows
5. Switch RlzSendFinancialPingFunction to be an AsyncExtensionFunction
that calls SendFinancialPing on a worker thread. This is required because
extension functions run with a MessageLoop, so the MessageLoop in
SendFinancialPing in rlz would trigger an assert (and making that inner
loop nestable seems like a very bad idea). This change also removes
one instance of ScopedAllowIO and fixes a TODO.
BUG=46579
TEST=
1.) Do an official chrome build
2.) Add gratuitous logging in rlz.cc and other places and check that by default:
* The channel is reported as "stable"
* The brand code is the empty string
* This brand code counts as organic install
* RLZ exits early.
3.) Create ~/Library/Google/Google\ Chrome\ Brand.plist and add e.g. the string "BRAND" for key KSBrandID, restart chrome.
* Brand code is now "BRAND" (this depends on Chrome's Info.plist not having a KSBrandID key, which has precedence. Currently our Chromes seem to never have this key.)
* A ping is scheduled, but nothing is sent.
* Use the omnibox a little, which causes product events to be recorded.
4.) Restart chrome yet again, wait a bit.
* Logging in "SendFinancialPing()" should print:
pinging http://clients1.google.com:80/tools/pso/ping?as=chrome&brand=BRAND&pid=&hl=en&events=C1F,C1S&rep=2&rlz=C1:1C1_____enUS476,C2:1C2_____enUS476&id=0926C138C2EA77A791CB450D322D0183E5A8079300000001B5
ping completed!
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9699054
git-svn-id: http://src.chromium.org/svn/trunk/src/build@129028 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
New stuff:
* ObjC number, array, dict literals
* ASan fixes, visibility fixes (see bugs)
* (c++11: User-defined literals)
* -Wstring-plus-int
* Fix for a bug that made the last roll not work with goma
BUG=114996,112539,119119
TEST=none
Review URL: http://codereview.chromium.org/9836038
git-svn-id: http://src.chromium.org/svn/trunk/src/build@128696 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Enable one-click signin on OS X.
Build Cocoa version of one-click signin dialog.
Refactor one-click signin code to make it easier to unit test.
BUG=116685
TEST=On OSX, with a clean profile, sign into GMail. The one-click infobar should pop up, and clicking "OK, sync" should bring up the one-click dialog.
Review URL: https://chromiumcodereview.appspot.com/9753003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@128126 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch removes the need of exporting / setting
CROSS_C* variables when calling make for android.
Instead, set them at Makefile generation time so that gyp will
set the right compilers when calling android_gyp.
This also allows goma builds.
BUG=
TEST=builds for android.
Review URL: http://codereview.chromium.org/9693042
git-svn-id: http://src.chromium.org/svn/trunk/src/build@127667 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The optimizations may fail under certain conditions. This is the case in,
for example, WebKit WTF's Checked type, and causes test failures. As this
may affect more than just that code, disable it for the entirety of Chromium
when building for Android.
BUG=
TEST=TestWebKitAPI passes all tests.
Review URL: http://codereview.chromium.org/9704057
git-svn-id: http://src.chromium.org/svn/trunk/src/build@127262 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
depends on http://codereview.chromium.org/9466022/
depends on http://codereview.chromium.org/9465018/
BUG=110050
TEST=When the profile is not connected to a google account, each time the user
logs in to a google property an infobar will ask the user if he would like to
connect the profile to this account. If so, a dialog pops up with more
information, and allows the user to start or cancel. The user can also not
choose the default sync settings, in which case pressing start will bring
up the advanced sync dialog.
Review URL: http://codereview.chromium.org/9453035
git-svn-id: http://src.chromium.org/svn/trunk/src/build@124996 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change allows us to tweak these options without restarting the
build masters and submit try jobs that tweak them.
It also simplifies usage of these tools, because instead of copying and
pasting a large block of gyp variables from
tools/build/scripts/masters/factor/chromium_factory.py into GYP_DEFINES
or .gyp/include.gyp, developers can simply set build_for_tool=mytool.
My plan is to change the chromium.fyi master to use build_for_tool=*
first, and revert if those bots break. If they stay green, I'll send a
change to update chromium.memory.fyi and completely remove
ChromiumFactory.MEMORY_TOOLS_GYP_DEFINES.
I intend to remove all the otherwise unused (win_)(release|debug)_*
options that we exposed later. This change is supposed to be the
simplest thing that works.
R=maruel@chromium.org,timurrrr@chromium.org
BUG=109780
TEST=built with build_for_tool=drmemory locally
Review URL: http://codereview.chromium.org/9516005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@124323 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
nileshagrawal@chromium.org
alexeypa@chromium.org
steveblock@chromium.org
rsleevi@chromium.org
thakis@chromium.org
mihaip@chromium.org
hashimoto@chromium.org
phajdan.jr@chromium.org
peter@chromium.org
mmenke@chromium.org
eugenis@chromium.org
wangxianzhu@chromium.org
bradnelson@google.com
flackr@chromium.org
scottmg@chromium.org
asharif@chromium.org
yoshiki@chromium.org
sergeyu@chromium.org
asvitkine@chromium.org
yfriedman@chromium.org
rogerta@chromium.org
joi@chromium.org
asargent@chromium.org
arthurhsu@chromium.org
kinaba@chromium.org
yusukes@google.com
erg@chromium.org
maruel@chromium.org
jhawkins@chromium.org
dmichael@chromium.org
ben@chromium.org
glotov@google.com
shouqun.liu@intel.com
gab@chromium.org
robertshield@chromium.org
nirnimesh@chromium.org
csilv@chromium.org
kerz@chromium.org
jnd@chromium.org
yongsheng.zhu@intel.com
jrg@chromium.org
tony@chromium.org
oshima@chromium.org
gene@chromium.org
shenhan@google.com
james.wei@intel.com
jamescook@chromium.org
dpranke@chromium.org
tedchoc@chromium.org
sail@chromium.org
varunjain@chromium.org
sky@chromium.org
zmo@google.com
hbono@chromium.org
jgreenwald@chromium.org
jscholler@chromium.org
olonho@google.com
erg@google.com
scottmg@google.com
glider@chromium.org
akalin@chromium.org
viettrungluu@chromium.org
rsesek@chromium.org
rbyers@chromium.org
michaelbai@chromium.org
reveman@google.com
robert.nagy@gmail.com
bulach@chromium.org
saintlou@chromium.org
tfarina@chromium.org
timurrrr@chromium.org
epoger@google.com
thestig@chromium.org
rnk@chromium.org