This change removes all of the code referencing gyp_chromium that
isn't needed to keep the closure_compilation builder working and/or
also needed for proper functioning of the gclient hooks.
R=brettw@chromium.org, dbeam@chromium.org
BUG=570091, 632206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2355673003
Cr-Original-Commit-Position: refs/heads/master@{#420182}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0730244c01fd8639fbebd6985d06fb64dac4c9fe
Reason for revert:
broke the closure_compilation builders.
Original issue's description:
> Remove the top-level GYP files (or stub them out).
>
> GYP is now thoroughly broken, and it's safe to remove the top-level
> files, except where gyp_chromium is still needed for the hooks run
> by gclient (to pick up and process GYP_DEFINES).
>
> R=brettw@chromium.org
> BUG=
>
> Committed: https://crrev.com/6ca365af92a486150c8f01b1aca2557a6fa504f1
> Cr-Commit-Position: refs/heads/master@{#416782}
TBR=brettw@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2313393002
Cr-Original-Commit-Position: refs/heads/master@{#416962}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e86569476a1fee9666d0c4a56099525c9977c87
GYP is now thoroughly broken, and it's safe to remove the top-level
files, except where gyp_chromium is still needed for the hooks run
by gclient (to pick up and process GYP_DEFINES).
R=brettw@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2299543008
Cr-Original-Commit-Position: refs/heads/master@{#416782}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6ca365af92a486150c8f01b1aca2557a6fa504f1
This CL turns off the GYP hook by default in `gclient runhooks`.
While there are still some builders that use GYP, they do so explicitly
in a separate step (usually by calling MB), and there is no common dev
configuration where we want people to still use GYP by default, so there's
no point in still running this.
If you still wish to run GYP in runhooks, though, you can explicitly
set GYP_CHROMIUM_NO_ACTION=0 in your environment. You can also still
invoke `build/gyp_chromium` directly.
R=brettw@chromium.org
BUG=432967, 569975
Review-Url: https://codereview.chromium.org/2139013002
Cr-Original-Commit-Position: refs/heads/master@{#406312}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8efd4818c9bc8e02d76401721342e618fd33d4c2
Since the bots run gyp_chromium seperately from runhooks, the hermetic mac
toolchain environment variables need to be set in this script as well.
BUG=474373
Review-Url: https://codereview.chromium.org/1970623002
Cr-Original-Commit-Position: refs/heads/master@{#392822}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 588af0bb9a83d6441c00858ca5ae74a919706e74
Also fix last-modified-time comparison code to handle minor float
differences and thus correctly not copy identical files (for some
reason there appears to be a ~1e-07 diff between last-modified-time
of copied files...?).
BUG=603603
TEST=No more copy output from gyp_chromium when copied DLLs are already
there or gyp_rc != 0 :-)
Review URL: https://codereview.chromium.org/1890053004
Cr-Original-Commit-Position: refs/heads/master@{#387911}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 381d9f17b002b97ea4cf38a859d91fafd051c587
The grand GYP disabling is beginning ...
We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.
For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).
This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.
R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967
Review URL: https://codereview.chromium.org/1883283002
Cr-Original-Commit-Position: refs/heads/master@{#387481}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4d1f42d07135d10b5e5dc156c64cd76fde6aec79
The following two scripts allow for the update and roll of the mac
toolchain (Xcode) via DEPS instead of thru an infrastructure install
script. The upload / download nature of the script follows somewhat
what Windows does with visual studio files and what Mac already does
for clang rolls.
build/package_mac_toolchain.py takes an Xcode.app directory
and packages up what the parts the Mac build uses into a tar file
and uploads it to gs://chrome-mac-sdk/
build/mac_toolchain.py runs as part of hooks, downloads
and decompresses the mac toolchain, and points system files to this
new directory with the DEVELOPER_DIR environment variable.
Setting DEVELOPER_DIR throughout gyp-ninja requires this GYP CL:
https://codereview.chromium.org/1806733002/
BUG=474373
Review URL: https://codereview.chromium.org/1759793003
Cr-Original-Commit-Position: refs/heads/master@{#383461}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a03a3dc9196b4474e7f5c08803f076a95055b44
For historical reasons gyp_chromium.py was launcher script
for gyp_chromium and the python logic lived in the
gyp_chromium. This change moves python code into the
.py file makes the extension-free gyp_chromium a launcher
for gyp_chromium.py.
Review URL: https://codereview.chromium.org/1216863010
Cr-Original-Commit-Position: refs/heads/master@{#342887}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1eeaa328a6e7d621857c0026d0a2dd448dbf0f65
This is a workaround for multiprocessing on Windows. Importing in Python on
Windows doesn't search for imports that don't end in .py (and aren't
directories with an __init__.py). So, add this wrapper to avoid having
people change their command line to add a .py when running gyp_chromium.
R=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/11066021
git-svn-id: http://src.chromium.org/svn/trunk/src/build@160151 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dpranke
dbeam
thakis
justincohen
jbudorick
gab
bcwhite
sbc
scottmg@chromium.org
scottmg@google.com