package_exists() used to check if the output of 'apt-cache search' was nonempty
to check if a package is available for install. But it does not work in some
cases. For example, on Debian Testing, libgtk-3-0-dbg is not available, but
libgtk-3-0-dbgsym is. This package would show up in the apt-cache output and we
would incorrectly determine that libgtk-3-0-dbg was available. Additionally,
there can be more than one package that is listed.
This CL does a check for the exact package name.
BUG=785818
R=dpranke@chromium.org
Change-Id: Ic81f1c059223e3cec643e116dea26b30c9ac75f1
Reviewed-on: https://chromium-review.googlesource.com/791371
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#519415}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9c70eb73a314e3f164b0f4ad6ad9bde679f549a0
This should help to run layout tests on a more diverse set of Linux
distributions and avoid running into differences in font target file
name differences for common font packages.
We should move as much as possible of the test fonts for layout tests
from distribution packages to our own mechanism.
Modeled after a previously used approach for blimp fonts, compare
https://codereview.chromium.org/1776133002/
Bug: 772116
Change-Id: Ia1929d3d22a047d540f841741f5e9a369142e1b6
Reviewed-on: https://chromium-review.googlesource.com/725809
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#517350}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f49ef761da1fc44dd41589b1ccd32ac54791cecb
Test: Manually installed packages to make sure no conflict
This is a reland of 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
>
> This is the first step in moving from using gconf to dconf.
>
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}
Bug: 768027
Change-Id: I151d1c1e708fa763f3d2d5a4a18b44bfdbe351fd
Reviewed-on: https://chromium-review.googlesource.com/692616
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505437}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 357bdbf7f33061d9ecf3052813cced0e9da45498
Script is failing on goobuntu-trusty_desktop-stable-amd64 due to packages conflict:
The following packages have unmet dependencies:
libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed
libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed
Recommends: libdconf-doc:i386 but it is not installable
Conflicts: libdconf-dev but 0.20.0-1 is to be installed
This reverts commit 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
>
> This is the first step in moving from using gconf to dconf.
>
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}
TBR=dpranke@chromium.org,thomasanderson@chromium.org,timbrown@chromium.org
Change-Id: Icec37c78711a2016667ee7f134d5db49b918b7d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 768027
Reviewed-on: https://chromium-review.googlesource.com/692974
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505391}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3cd469287f3ce7290d3bfe3f1971aa529b6b1303
This is the first step in moving from using gconf to dconf.
Bug: 768027
Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
Reviewed-on: https://chromium-review.googlesource.com/691097
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
xdpyinfo from the package x11-utils is necessary for run-webkit-tests.
BUG=749222
R=dpranke@chromium.org
Change-Id: I4ee4d880895e56c947741debdaa2095f03efc91e
Reviewed-on: https://chromium-review.googlesource.com/601354
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492466}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d79de41d48ab8813d3793d8df5c6bafe4d77b6ab
It appears the "*" path in the case statement is never
matched due to the double-quotes (tested with bash 4.3.11 on
Trusty 14.04). Removing the quoting aligns with other case
statements in the script, and solves the problem. This bug
made https://codereview.chromium.org/2650823010 not have any
effect, which was discovered when deploying ARM 64 bots for
WebRTC.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2790453002
Cr-Original-Commit-Position: refs/heads/master@{#460733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95504aea9818ec4e593358d0373f9c41531a3b67
This CL adds the following packages to install-build-deps.sh:
libgtk-3-dev
libgtk-3-0
libgtk-3-0-dbg
libgtk-3-0:i386
In addition, it also refactors dev_list, lib_list, dbg_list, and
nacl_list so that each package is on a separate line. It was getting
ridiculous reformatting everything every time a new package was added.
BUG=695541
R=dpranke@chromium.orgCC=thestig@chromium.org,erg@chromium.org
Review-Url: https://codereview.chromium.org/2730523002
Cr-Original-Commit-Position: refs/heads/master@{#454118}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 20032a5cd3037ac303100cae6585e279d6908c23
This is needed to avoid AR errors in build/toolchain/gcc_ar_wrapper.py
during compile when building for Linux ARM64.
The size of thew new dependency is ~19MB on Linux.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2650823010
Cr-Original-Commit-Position: refs/heads/master@{#446656}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 74c7e4b3a075d01cb9f04b8c746fa8bc888ed768
This CL
- Enables jessie support in install-build-deps.sh
- Adds a note in linux_build_instructions.md about adding the
'contrib' component in sources.list.
- Fixes a bug in package_exists where if a ppa is added, a package is
installed from it, and then the ppa is removed, and the package is
removed but not purged, package_exists would still return true for
the package.
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2556133003
Cr-Original-Commit-Position: refs/heads/master@{#437198}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b4a2bcaef478f19b5a244d5102b412dea5372ecd
Previously we were installing Ubuntu language packs to just for their locales.
According to apt, these packages took up ~25Mb of space, and the packages are
not available on Debian. This CL uses locale-gen to generate the needed locales
instead.
The locales are only needed in the following tests:
fr_FR.UTF-8: TimeFormatBrowserTest.DecimalPointNotDot
da_DK.UTF-8: LocaleTestDanish.TestStart
he_IL.UTF-8: LocaleTestHebrew.TestStart
zh_TW.UTF-8: LocaleTestTraditionalChinese.TestStart
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2559463004
Cr-Original-Commit-Position: refs/heads/master@{#437136}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5ef5c3d2c48d8ae8cb9b90376649688b35ce2057
Reason for revert:
This change breaks the following bot: http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/56654
This appears to be the intended behavior of the change, although the bots should probably not break when it lands to avoid a closed tree.
Original issue's description:
> Add check_build_deps step to gclient runhooks
>
> This CL adds a build hook to ensure that any necessary build
> dependencies are installed before proceeding with the
> build. A failure would indicate install_build_deps.sh
> needs to be rerun.
>
> BUG=666937
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230
> Cr-Commit-Position: refs/heads/master@{#433603}
TBR=dpranke@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=666937
Review-Url: https://codereview.chromium.org/2521733002
Cr-Original-Commit-Position: refs/heads/master@{#433611}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ae919e5336c1d4a3a3455f82f85cdd06162d2f1
This CL adds a build hook to ensure that any necessary build
dependencies are installed before proceeding with the
build. A failure would indicate install_build_deps.sh
needs to be rerun.
BUG=666937
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2505413003
Cr-Original-Commit-Position: refs/heads/master@{#433603}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e8942c0a68a986313e2927de584a644c8d21b230
The algorithm we were using to parse the output of dpkg-query was out of date because the format changed.
This CL tries to make as little assumptions as possible about the output of dpkg-query, using the return code to determine failure instead of the output. However, we still rely on the last word of an error message being a package name, although this is only used to display which packages are missing.
BUG=666937
R=mmoss@chromium.org,dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2519523002
Cr-Original-Commit-Position: refs/heads/master@{#433327}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 73b3a441a128d14c81bed7afc981d35f0f401f1d
See bug, apparently it's "an up-to-date thing" but "thing is up to date".
The bug is only about grd files, but I went through `git grep -l up-to-date`
while I was at it.
BUG=344535
TBR=IPC owner
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2059143002
Cr-Original-Commit-Position: refs/heads/master@{#399698}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3e861deabe8e47db274ed779acc1a3b80837e16d
This relands https://codereview.chromium.org/1773233002/.
Original description:
Media Galleries Partial Deprecation: Remove image metadata & libexif.
Removing libexif is a great thing.
It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues.
BUG=542912,577272
TBR=
Review URL: https://codereview.chromium.org/1803883002
Cr-Original-Commit-Position: refs/heads/master@{#381121}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cd96b6f874573d7089bf2eb9d54ed53d7469bb56
Reason for revert:
Causes build errors on official waterfall.
https://bugs.chromium.org/p/chromium/issues/detail?id=593580
Original issue's description:
> Media Galleries Partial Deprecation: Remove image metadata & libexif.
>
> Removing libexif is a great thing.
>
> It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues.
>
> BUG=542912,577272
>
> Committed: https://crrev.com/f3890c75101ff9b07f48aed992285cc45bf5b4d5
> Cr-Commit-Position: refs/heads/master@{#380306}
TBR=phajdan.jr@chromium.org,rdevlin.cronin@chromium.org,thakis@chromium.org,tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=542912,577272
Review URL: https://codereview.chromium.org/1791623002
Cr-Original-Commit-Position: refs/heads/master@{#380852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0978e4ebde4a1c07f4e8da88cc9daa7732a63b1a
Removing libexif is a great thing.
It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues.
BUG=542912,577272
Review URL: https://codereview.chromium.org/1773233002
Cr-Original-Commit-Position: refs/heads/master@{#380306}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3890c75101ff9b07f48aed992285cc45bf5b4d5
On leading-edge Ubuntu versions there are no LTS backport packages, and
dpkg-query prints an error about nothing matching the wildcard to
stderr, which has caused at least one user to think the script didn't
install mesa correctly. The script handles this case just fine, though
(it expands to an empty array and sets mesa_variant to emptystring,
whcih is correct), so just redirect stderr to avoid this spurious error
message.
BUG=
Review URL: https://codereview.chromium.org/1721763003
Cr-Original-Commit-Position: refs/heads/master@{#377332}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 12cd9f6cf09631a18f11f123cc02e753dfcaa199
This is a documentation-only change.
Disabling presubmit checks, due to "noparent" settings for the following files:
components/policy/resources/policy_templates.json
content/common/font_config_ipc_linux.h
BUG=567488
NOPRESUBMIT=true
TBR=atwilson,dcheng
Review URL: https://codereview.chromium.org/1592403002
Cr-Original-Commit-Position: refs/heads/master@{#374213}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df175a8c3d1c1060f96d123a5896fdfbe4b3782d
Instead of hardcoding a list of which LTS variants of mesa might be
installed, just query for any package that matches the expected pattern
and if exactly one is installed, use that. If zero are installed, use
the base package. There shouldn't be more than one as these packages
conflict with each other, so just abort if that happens.
This avoids needing to extend the loop in this script every time a new
Ubuntu backport package is added.
BUG=
Review URL: https://codereview.chromium.org/1434453002
Cr-Original-Commit-Position: refs/heads/master@{#358039}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a6eb6958e85d742f70a8cc4c85a24c5efa93cee
This CL fixes a detection of 64-bit architecture when /sbin/init is
symlink. On Ubuntu 15.04, /sbin/init is symlink to /lib/systemd/systemd
and therefore the |file| command doesn't show anything except the path
it refers to.
BUG=
TEST=
R=primiano@chromium.org,sbc@chromium.org,scottmg@chromium.org
Review URL: https://codereview.chromium.org/1300613002
Cr-Original-Commit-Position: refs/heads/master@{#349373}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0a79d699ff6d87346347aa0f2d91d8e5dddd6924
"realpath" is used by several CrOS tools.
It is needed on builders that build Chromium through the CrOS toolchain.
BUG=chromium:491287
TEST=None
Review URL: https://codereview.chromium.org/1156763002
Cr-Original-Commit-Position: refs/heads/master@{#331434}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a8491d157d1613c41426e91a3ac479766dd7a31
Trusty seems to have dificulty installing gcc-arm-linux-gnueabihf
and gcc-4.8-multilib without these extra packages being listed
on the install line also.
BUG=435056
Review URL: https://codereview.chromium.org/1049833003
Cr-Original-Commit-Position: refs/heads/master@{#323281}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5d4ded25739d583663fd17569de96394f84c267
Tom Anderson
Dominik Röttsches
marcin
Tim Brown
Dmytro Golovchenko
Andrew Grieve
Tanin Na Nakorn
thomasanderson
kjellander
friedman
anthonyvd
jack
horo
thakis
j.isorce
vadimsh
krasin
ellyjones
tommycli
erikchen
torne
mostynb
halton.huo
reveman
ki.stfu
abarth
dnj
sbc