Граф коммитов

1088 Коммитов

Автор SHA1 Сообщение Дата
sivachandra@chromium.org d70217d122 [Android] Refactor buildbot tests so that they can be used downstream.
I refactored in the wrong way in r211209 (https://chromiumcodereview.appspot.com/18325030/). This CL fixes that. Note that r211209 is not broken; it is just not usable downstream.

BUG=249997
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/18202005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211454 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-12 21:05:48 +00:00
scherkus@chromium.org 432ba7d5c8 Update build/android/symbolize.py to match base/debug/stack_trace_android.cc format.
BUG=259554

Review URL: https://chromiumcodereview.appspot.com/19010004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211449 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-12 20:17:54 +00:00
scherkus@chromium.org 475ab8ba5e Remove executable bit from files checked in r211419.
TBR=jam

Review URL: https://codereview.chromium.org/18298013

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211429 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-12 18:35:14 +00:00
scherkus@chromium.org 6ea84eda52 Check in missing build/android/symbolize.py test files from r211134.
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/18755005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211419 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-12 17:38:40 +00:00
frankf@chromium.org 5b0ed2d5ac [Android] Use isolate remap instead of check.
- Instead of parsing *.isolated files, use isolate remap
to create a temporary dependency dir.
- Add an exclusion list to filter dependecies at a finer grain
than what's specified in isolate files.
- Convert base_unittests and unit_tests to use isolate. 

This adds an additional 50MB to the dependency size due
to many small directories not specified in the exclusion list.

BUG=249870

Review URL: https://chromiumcodereview.appspot.com/18233018

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211350 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-12 06:58:43 +00:00
navabi@google.com 052b0cec3f Deploy adb reconnect on disconnect daemon on WebKit (ContentShell) Android bot.
NOTRY=True
BUG=256353

Review URL: https://chromiumcodereview.appspot.com/18652008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-12 01:40:09 +00:00
simonhatch@chromium.org 2b7052817e Unset some environment vars so they can be set up via the bisect script.
BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/18991015

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211214 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 21:10:41 +00:00
sivachandra@chromium.org 83a253d9aa [Android] Refactor so that few pieces can be reused downstream.
BUG=249997
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/18325030

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211209 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 20:51:58 +00:00
pliard@chromium.org 145a27fabe Kill forwarder2 host daemon in python_test_sharder.py during setup.
This is normally done at the shard level in shard.py but python_test_sharder.py
doesn't seem to use that code.

BUG=242846

Review URL: https://chromiumcodereview.appspot.com/18915002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211206 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 20:42:29 +00:00
sivachandra@chromium.org 8748740460 [Android] Add bot id for an x86 fyi and try builders
BUG=170542
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/17746004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211202 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 20:23:40 +00:00
bulach@chromium.org 3dec338d37 Android: uses at least 3 samples for surface stats.
Follow-up on crrev.com/204593, fixes the bucket calculation.

BUG=

Review URL: https://chromiumcodereview.appspot.com/19055003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211196 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 19:59:49 +00:00
craigdh@chromium.org 75cd762559 [android] Fix suite error message.
BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/18641005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211156 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 17:55:51 +00:00
bulach@chromium.org f1d8a9af48 Android: adds stack symbolization utilities.
asan_symbolize.py is used for the logcat stacks using the special ASan format.
tombstones.py is used to manage tombstones files in devices.
symbolize.py is used for stack traces generated by base/debug/stack_trace_android.cc

BUG=234973

Review URL: https://chromiumcodereview.appspot.com/18473004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 16:17:56 +00:00
gkanwar@google.com 383770ce5d Fixes dispatch files to return exit codes in several places
BUG=170477

Review URL: https://chromiumcodereview.appspot.com/19021003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@211084 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-11 11:49:33 +00:00
frankf@chromium.org 4f9db973ff [Android] Tests now log to stdout instead of stderr.
NOTRY=True
BUG=258596

Review URL: https://chromiumcodereview.appspot.com/18612014

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210967 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-10 23:29:21 +00:00
frankf@chromium.org 060818c956 [Android] Remove deps list for obsolete test targets.
NOTRY=True
BUG=

Review URL: https://chromiumcodereview.appspot.com/18946005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210892 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-10 18:35:56 +00:00
bulach@chromium.org 0c82936bb8 Android: follow up on crrev.com/210749
Fixes python-driven tests.

BUG=170477, 258171
TBR=frankf

Review URL: https://chromiumcodereview.appspot.com/18305008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210859 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-10 16:31:52 +00:00
gkanwar@google.com b7f504a41e Updates the test runner script exit codes
The script now returns exit codes based on what occurred in the
test. Exit codes:
0 -- normal
1 -- fail/crash
88 -- warning

In addition, the scripts now handle DeviceUnresponsiveError by
returning a warning exit code overall, rather than silently moving
on.

BUG=170477, 258171

Review URL: https://chromiumcodereview.appspot.com/18323020

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210749 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-10 04:57:10 +00:00
joaodasilva@chromium.org 3dd0b1b22f Avoid forwarding the test HTTP port twice.
base_test_runner.BaseTestRunner already forwards port 8000; avoid doing that
again in instrumentation.test_runner.TestRunner again, which confuses the
forwarder.

BUG=242846

Review URL: https://chromiumcodereview.appspot.com/18854020

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210666 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 23:42:14 +00:00
bulach@chromium.org d3ea847751 SurfaceStats / Telemetry: calculate FPS in different frame buckets.
Instead of just calculating FPS over all frames returned by SurfaceFlinger,
use the last 90% and the last 50% as well.
This allow us to have a better representation and skip the "setup" stage.

BUG=256340

Review URL: https://chromiumcodereview.appspot.com/18341006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210583 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 17:04:15 +00:00
pliard@chromium.org b48bb4cd34 Reland r210268: "Improve forwarder2 setup/tear down in telemetry."
This CL kills the host_forwarder daemon before running the tests and also makes
Forwarder.Close() unmap the previously mapped ports.

BUG=242846
TBR=bulach@chromium.org

Review URL: https://codereview.chromium.org/18907002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210574 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 15:44:02 +00:00
nduca@chromium.org e94f646c94 Print adb missing warning to stderr, not stdout
R=bulach

Review URL: https://chromiumcodereview.appspot.com/18566007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210563 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 14:27:12 +00:00
kkimlabs@chromium.org 19333597df [Android] Add an gyp option to disable generating v14 resources script.
Currently, we are generating v14 layout and style resources from v17
resources by replacing Start and End attributes to Left and Right
attributes. However, it is not necessary for all cases, so make an
option to disable generate_v14_compatible_resources.py script and
only verify that there is no RTL attributes in the pre-v17 resources.

BUG=247049

Review URL: https://chromiumcodereview.appspot.com/18653002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210555 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 14:07:51 +00:00
gkanwar@google.com 0c42207094 Relands test_runner.py, updates buildbot scripts
Relands 210035 ("Creates a new test running script test_runner.py"),
and updates the buildbot scripts to point to the test_runner.py script,
so the buildbots don't get deprecated warnings.

BUG=248351

Review URL: https://chromiumcodereview.appspot.com/18514008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210538 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 09:03:26 +00:00
hellner@chromium.org 51157755a5 WebRTC: adds webrtc specific unit tests to test_runner.py and gtest_config.py for running them in a chromium workspace.
BUG=https://code.google.com/p/webrtc/issues/detail?id=1882

Review URL: https://chromiumcodereview.appspot.com/18358005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210534 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-09 08:50:41 +00:00
pliard@chromium.org 1be95894f5 Revert "Improve forwarder2 setup/tear down in telemetry."
This reverts r210268 which made some tests fail downstream.

TBR=bulach@chromium.org,mvanouwerkerk@chromium.org
BUG=210268

Review URL: https://codereview.chromium.org/18781002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210311 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-05 15:45:50 +00:00
pliard@chromium.org 982dbd5ac1 Make port unmapping errors non fatal.
In some cases port unmapping can fail. This should not be fatal nor need client
recovery code.

This can happen when multiple instances of the Forwarder class try to map/unmap
a same port. While the host_forwarder daemon supports that, the python wrapper
didn't.

R=bulach@chromium.org

Review URL: https://codereview.chromium.org/18714004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210306 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-05 14:33:32 +00:00
pliard@chromium.org c664eec31b Reland "Add --serial-id option to host_forwarder."
This relands r209945.

r242846 slightly changed the CLI <-> device daemon message sequence which made
the following check fail in case the device daemon was started but already
running on the device: device_forwarder_main.cc:10: CHECK_GT(bytes_read, 0).

This was actually caused by an unexposed long standing issue in daemon.cc.
ConnectToUnixDomainSocket() is performing a hand check to make sure that the
CLI is connecting to the forwarder daemon. While doing this hand check, rather
than only reading the expected fixed-size message, the function was reading all
the available bytes in the socket thus consuming the client data.

BUG=242846
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/18635005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210273 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-05 07:42:02 +00:00
pliard@chromium.org 749841ee04 Improve forwarder2 setup/tear down in telemetry.
This CL kills the host_forwarder daemon before running the tests and also makes
Forwarder.Close() unmap the previously mapped ports.

BUG=242846
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/18694002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210268 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-05 07:04:59 +00:00
ilevy@chromium.org 56f6e3c191 Revert 210035 "Creates a new test running script test_runner.py"
Causes android buildbots to spew deprecation warnings.

> Creates a new test running script test_runner.py
> 
> This new script serves as a unified entry point for all tests. The
> existing scripts are now just wrappers around the new script. Old
> commands should thus still work, but you can now make use of the
> new script to run various types of tests.
> 
> There are a few TODOs left:
> * Add options to run Monkey tests.
> 
> Miscellaneous notes:
> * --python_test_root is now a required flag when Python host-driven
>   tests are being run.
> 
> BUG=248351
> 
> Review URL: https://chromiumcodereview.appspot.com/15942016

TBR=gkanwar@google.com

Review URL: https://codereview.chromium.org/18732002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210251 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-05 02:29:05 +00:00
frankf@chromium.org db842742f6 [Android] Partial revert of r209283.
Generating isolated files from test runners is not thread-safe.

BUG=257133
TBR=craigdh@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/18519011

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-04 00:12:44 +00:00
gkanwar@google.com 40f6a425e6 Creates a new test running script test_runner.py
This new script serves as a unified entry point for all tests. The
existing scripts are now just wrappers around the new script. Old
commands should thus still work, but you can now make use of the
new script to run various types of tests.

There are a few TODOs left:
* Add options to run Monkey tests.

Miscellaneous notes:
* --python_test_root is now a required flag when Python host-driven
  tests are being run.

BUG=248351

Review URL: https://chromiumcodereview.appspot.com/15942016

git-svn-id: http://src.chromium.org/svn/trunk/src/build@210035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-03 20:31:43 +00:00
pliard@chromium.org 39645d8cfc Revert "Add --serial-id option to host_forwarder."
This reverts revision 209945.

TBR=peter@chromium.org
BUG=242846

Review URL: https://codereview.chromium.org/18640002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209959 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-03 11:47:24 +00:00
pliard@chromium.org 9e9405df5f Add --serial-id option to host_forwarder.
This moves the forwarder's control channel set up logic (which can be
considered as an internal implementation detail) from the Python script to the
host_forwarder binary.

This also changes the command line interface for the host_forwarder and
device_forwarder binaries.

BUG=242846
R=bulach@chromium.org, digit@chromium.org

Review URL: https://codereview.chromium.org/18354005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209945 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-03 10:21:26 +00:00
sivachandra@chromium.org 41aae7d2a7 [Android] Remove few redundent pieces added in CL 17114007
This CL removes certain redundant pieces which should have been removed in https://chromiumcodereview.appspot.com/17114007/ but were missed.

BUG=249997

Review URL: https://chromiumcodereview.appspot.com/18595002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209932 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-03 08:49:47 +00:00
pliard@chromium.org d2e41f8965 Remove unnecessary host parameter in forwarder.
While it is nice to be able to specify the destination host when setting up a
redirection, this functionality is never used.
This cleanup is needed for some upcoming changes in forwarder2.

BUG=242846

Review URL: https://chromiumcodereview.appspot.com/18522003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209756 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-02 19:50:26 +00:00
sivachandra@chromium.org 5f0b7670bf [Android] Refactor the buildbot scripts to prepare for downstream usage.
BUG=249997

Review URL: https://chromiumcodereview.appspot.com/17114007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209694 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-02 14:02:15 +00:00
bulach@chromium.org 3f285ee2a8 Android: adds an option to print all sharded steps.
This is necessary to decouple buildbots and the app repository.

BUG=

Review URL: https://chromiumcodereview.appspot.com/17616008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209681 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-02 12:14:38 +00:00
hashimoto@chromium.org a4f7f2082c Add missing executable bits for get_device_configuration.py
Resulted in buildbot failures:
http://build.chromium.org/p/chromium/builders/Linux/builds/40444

BUG=None
TEST=check_perms.py
TBR=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/18479002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209624 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-02 06:47:48 +00:00
cjhopman@chromium.org ea831049c4 [Android] Add an action to check/record attached devices
When doing a gyp_managed_install, we install APKs to the attached
device. Currently this can fail in many ways (no device attached,
multiple devices attached, device offline, device doesn't have root,
etc.). In addition, we need to detect changes to the attached device
(particularly when the device is switched, when an APK is
 uninstalled/updated).

The current approach is to check all this information in the action
interacting with the device. This means that when there is some
problem we print the same warning messages for every APK that is built,
and, in some cases, multiple times for each APK. Also, we have to run
every install/push action every build because we detect changes to the
attached device in that action.

This change creates a new build action, "get device configurations".
This action inspects the attached devices, filters out offline devices,
filters out devices without root, and then writes a configuration
file with the id+metadata for the first non-filtered device. This
configuration is then used by each of the build steps that interacts
with the device. This consolidates all the device checking to a single
place, and the build actions don't need to do any checking. In
addition, to detect changes in the attached device, we only need to run
this single action every build and the install/push actions will only
change when the device/metadata changes.

Also, with this change we can now gracefully handle the case where
multiple devices are attached (currently just write the configuration
for the first valid device and install to that one).

Review URL: https://chromiumcodereview.appspot.com/16831013

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209582 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-02 01:52:33 +00:00
aurimas@chromium.org a405188195 Remove the OWNERS that no longer work on the project.
Remove jcivelli@, and nileshagrawal@ who no longer work
on Chrome for Android.

Review URL: https://chromiumcodereview.appspot.com/18178014

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209531 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-01 23:02:18 +00:00
bulach@chromium.org 8abee74061 Android: disables DiagnosticsModelTest.RunAll
This test is timing out on android
(it eventually runs very close to the 120s timeout and passes, so it looks like the
flakyness is more about the size than the test itself).

BUG=256259
TBR=cpu@chromium.org
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/18344007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209439 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-01 15:38:37 +00:00
bulach@chromium.org ad0e02313f Android: disable content_browsertests SignalTest.
Started failing at crrev.com/209404

BUG=256238
TBR=hubbe@chromium.org
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/18326008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209433 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-01 14:47:05 +00:00
bulach@chromium.org 031e072db9 Android: disables IndexedDBBrowserTestWithCorruptLevelDB.DestroyTest.
Started failing after crrev.com/208579

BUG=256184
TBR=dgrogan@chromium.org
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/18328005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209414 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-01 11:32:18 +00:00
bulach@chromium.org 2c905384fa Android: fixes content_browsertests.
Following crrev.com/209345, a couple of files have been deleted / renamed.

TBR=fsamuel@chromium.org
BUG=
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/18332003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209410 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-01 11:15:24 +00:00
tfarina@chromium.org 3da67c9559 Reland "components/webdata: Break the dependency on chrome/test/base"
This was reverted because it broke android, because I forgot to remove
a line from build/android/pylib/gtest/test_runner.py

BUG=181277
TBR=joi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18201002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209348 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-06-29 21:15:48 +00:00
frankf@chromium.org a66bbda1c0 [Android] Enable using isolate files to get a list of data dependencies to push to the device.
Convert base_unittests to isolate.

BUG=249870

Review URL: https://chromiumcodereview.appspot.com/17267004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-06-29 13:00:45 +00:00
wangxianzhu@chromium.org 0872b7c4ef Upstream adb_profile_chrome
This is for external developers to profile official chrome build.

The default package name is changed to "com.android.chrome".

NOTRY=true
BUG=255178

Review URL: https://chromiumcodereview.appspot.com/18174005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209195 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-06-28 18:22:22 +00:00
kinuko@chromium.org 4a8e0f2aec Revert 209071 "components/webdata: Break the dependency on chrom..."
2nd try.

> components/webdata: Break the dependency on chrome/test/base
> 
> BUG=181277
> TBR=joi@chromium.org
> 
> Review URL: https://codereview.chromium.org/17788002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/18120007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209116 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-06-28 07:01:21 +00:00
kinuko@chromium.org 506a8c0595 Revert 209112 "Revert 209071 "components/webdata: Break the depe..."
Broke the tree.

> Revert 209071 "components/webdata: Break the dependency on chrom..."
> 
> speculative revert to see if it fixes the android bots.
> 
> > components/webdata: Break the dependency on chrome/test/base
> > 
> > BUG=181277
> > TBR=joi@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/17788002
> 
> TBR=tfarina@chromium.org
> 
> Review URL: https://codereview.chromium.org/18177003

TBR=sail@chromium.org

Review URL: https://codereview.chromium.org/18120006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@209115 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-06-28 06:49:06 +00:00