This breaks the Android component build.
This reverts commit 125e64a9eb6406446fb864aea9fa887521f19616.
>> [Android] Support building standalone APK in component build
>>
>> Many people's workflows assume that they can install the APK created in
>> out/Debug/apks. With the component build that APK is actually an
>> "incomplete" APK that cannot be manually installed (or rather causes
>> obscure errors when manually installed).
>>
>> This change does two things. First, it moves the "incomplete" APK
>> output to out/Debug/<package_name>/<ApkName>.apk. This should prevent
>> accidental installs of the "incomplete" APK. Second, it introduces an
>> option (create_standalone_apk) that when doing a component build, if
>> set, will merge the shared libraries into the "incomplete" APK to
>> create a standalone APK. This standalone APK will be created in
>> out/Debug/apks/.
>>
>> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207345
>>
>> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207516
BUG=
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/17291013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@207587 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Many people's workflows assume that they can install the APK created in
out/Debug/apks. With the component build that APK is actually an
"incomplete" APK that cannot be manually installed (or rather causes
obscure errors when manually installed).
This change does two things. First, it moves the "incomplete" APK
output to out/Debug/<package_name>/<ApkName>.apk. This should prevent
accidental installs of the "incomplete" APK. Second, it introduces an
option (create_standalone_apk) that when doing a component build, if
set, will merge the shared libraries into the "incomplete" APK to
create a standalone APK. This standalone APK will be created in
out/Debug/apks/.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207345
Review URL: https://chromiumcodereview.appspot.com/14843017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@207516 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Using page-repeat and pageset-repeat options in commands like
tools/perf/run_measurement --browser=release --page-repeat=2 --pageset-repeat=3 blink_perf third_party/WebKit/PerformanceTests/Parser/html-parser.html
previously let to a crash in _MeanAndStdDevFromList.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17390017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@207426 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
First, only get the device's utc offset when it is actually needed. Calculating
this offset takes about 100ms on a typical device. The build scripts assume
that creating an instance of AndroidCommands is not so expensive. Instead,
defer calculating this value until it is actually requested. There are
currently several cases where the build scripts call adb directly instead of
through android_commands just to avoid this extra cost.
Second, add a GetDescription method to get a (mostly) user-readable description
of the device.
TBR=frankf@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17088005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@207371 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Many people's workflows assume that they can install the APK created in
out/Debug/apks. With the component build that APK is actually an
"incomplete" APK that cannot be manually installed (or rather causes
obscure errors when manually installed).
This change does two things. First, it moves the "incomplete" APK
output to out/Debug/<package_name>/<ApkName>.apk. This should prevent
accidental installs of the "incomplete" APK. Second, it introduces an
option (create_standalone_apk) that when doing a component build, if
set, will merge the shared libraries into the "incomplete" APK to
create a standalone APK. This standalone APK will be created in
out/Debug/apks/.
Review URL: https://chromiumcodereview.appspot.com/14843017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@207345 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change is part of moving autofill into its eventual structure of a layered
component. autofill/components/core/ is a new directory that will hold code
that is shared by all platforms (including iOS). This CL moves autofill/
components/common/ underneath this directory; a follow-up CL will move
autofill/components/browser underneath this directory as well.
This CL additionally imposes the correct DEPS restrictions on
autofill/components/core/, with temporary allowances for the current
violating includes.
TBR=joi, thakis, benm
BUG=247015
Review URL: https://chromiumcodereview.appspot.com/16879006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@206994 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch improves the Android-specific adb_gdb debugging scripts
in several minor ways:
- It ensures that the temporary directory is always removed when
the script exits, even whe it is interrupted with Ctrl-C.
- It ensures that if --pull-libs is interrupted by a Ctrl-C,
the build.prop in /tmp/$USER-adb-gdb-libs/ is erased, forcing
a --pull-libs operation in the next invokation, instead of keeping
a portion of the libraries in a bad state.
- It adds a --su-prefix=<prefix> option, to be able to use tools
like 'su' on rooted production devices. This is useful when the
installed app is not debuggable (e.g. a release build), and there
is no way to run ADB as root.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/17103007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@206990 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a drop-down menu to the right of the search entry area on the OSX
app launcher. The menu is shown when clicked, and the button responds to
hover effects.
The menu button uses a new class, HoverImageMenuButton, which is derived
from an NSPopUpButton with minor extensions. Notably, it does not have a
dependency on browser themes, as does MenuButton from
chrome/browser/ui/cocoa. It tracks the mouse hover state and updates
the cell, which extends NSPopUpButtonCell and shows only the image in
the control frame -- no border, bezel, label, or dropdown arrow.
HoverImageMenuButtonCell supports a hover image, which behaves much like
an additional 'alternateImage' from NSButtonCell but for the hover
state, rather than the 'pressed' (or 'lit') state.
The menu shows the currently signed-in user, in a custom view as the
first item. It also (currently) shows menu options for Settings, Help, and
Feedback.
BUG=138633
TEST=Added app_list_unittests AppsSearchBoxMenuTest and
AppsSearchBoxMenuTest and tested manually to ensure the items are
launched correctly. Added ui_unittests HoverImageMenuButtonTest.*
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206237
Review URL: https://chromiumcodereview.appspot.com/15955003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@206930 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Causes memory leaks in AppKit due to some obscure codepaths.
BUG=249630
> Menu for the OSX app launcher, HoverImageMenuButton in src/ui/base/cocoa/controls.
>
> Adds a drop-down menu to the right of the search entry area on the OSX
> app launcher. The menu is shown when clicked, and the button responds to
> hover effects.
>
> The menu button uses a new class, HoverImageMenuButton, which is derived
> from an NSPopUpButton with minor extensions. Notably, it does not have a
> dependency on browser themes, as does MenuButton from
> chrome/browser/ui/cocoa. It tracks the mouse hover state and updates
> the cell, which extends NSPopUpButtonCell and shows only the image in
> the control frame -- no border, bezel, label, or dropdown arrow.
>
> HoverImageMenuButtonCell supports a hover image, which behaves much like
> an additional 'alternateImage' from NSButtonCell but for the hover
> state, rather than the 'pressed' (or 'lit') state.
>
> The menu shows the currently signed-in user, in a custom view as the
> first item. It also (currently) shows menu options for Settings, Help, and
> Feedback.
>
> BUG=138633
> TEST=Added app_list_unittests AppsSearchBoxMenuTest and
> AppsSearchBoxMenuTest and tested manually to ensure the items are
> launched correctly. Added ui_unittests HoverImageMenuButtonTest.*
>
> Review URL: https://chromiumcodereview.appspot.com/15955003TBR=tapted@chromium.org
Review URL: https://codereview.chromium.org/17059002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@206375 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a drop-down menu to the right of the search entry area on the OSX
app launcher. The menu is shown when clicked, and the button responds to
hover effects.
The menu button uses a new class, HoverImageMenuButton, which is derived
from an NSPopUpButton with minor extensions. Notably, it does not have a
dependency on browser themes, as does MenuButton from
chrome/browser/ui/cocoa. It tracks the mouse hover state and updates
the cell, which extends NSPopUpButtonCell and shows only the image in
the control frame -- no border, bezel, label, or dropdown arrow.
HoverImageMenuButtonCell supports a hover image, which behaves much like
an additional 'alternateImage' from NSButtonCell but for the hover
state, rather than the 'pressed' (or 'lit') state.
The menu shows the currently signed-in user, in a custom view as the
first item. It also (currently) shows menu options for Settings, Help, and
Feedback.
BUG=138633
TEST=Added app_list_unittests AppsSearchBoxMenuTest and
AppsSearchBoxMenuTest and tested manually to ensure the items are
launched correctly. Added ui_unittests HoverImageMenuButtonTest.*
Review URL: https://chromiumcodereview.appspot.com/15955003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@206237 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
bulach@chromium.org
navabi@google.com
skyostil@chromium.org
frankf@chromium.org
lliabraa@chromium.org
dfalcantara@chromium.org
tedchoc@chromium.org
cjhopman@chromium.org
ananta@chromium.org
skyostil@google.com
ericwilligers@chromium.org
chrisha@chromium.org
ilevy@chromium.org
avi@chromium.org
thestig@chromium.org
apatrick@chromium.org
cevans@chromium.org
blundell@chromium.org
digit@chromium.org
scherkus@chromium.org
tapted@chromium.org
apatrick@google.com
nileshagrawal@chromium.org
dmazzoni@chromium.org
jbauman@chromium.org
kbr@chromium.org
sivachandra@chromium.org
glider@chromium.org
robliao@chromium.org
jeanfrancoisg@chromium.org
earthdok@google.com
hinoka@google.com
iannucci@chromium.org