d9716610bf
clang: Let release builds use -O3, like on gcc.
...
Now that http://llvm.org/bugs/show_bug.cgi?id=10031 is fixed, this will hopefully
no longer crash clang.
BUG=84815
TEST=none
Review URL: http://codereview.chromium.org/7104062
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88425 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 22:35:54 +00:00
243bb8c2db
Turn on -Wdelete-non-virtual-dtor for chromeos as well.
...
All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
See the bug for a disussion of this change.
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/6995085
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88385 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 20:33:32 +00:00
f1b99ada66
Revert stubs that were added in r88040. We need proper interfaces around features that need to be compiled out, instead of adding stubs.
...
Review URL: http://codereview.chromium.org/7046052
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88374 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 19:06:55 +00:00
14b806ae61
Roll clang 131950:132735
...
Notable changes in the range:
* r132735 (hopefully) fixes a bug introduced in r131951 that made
gold 1.10 crash with
/usr/bin/ld: internal error in set_offset, at output.cc:4030
* r132535 fixes the crash at -O3 on mac
* r132565 adds a warning for "x + y ? a : b" to -Wparentheses
BUG=85289,84424
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7046048
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88344 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 16:40:06 +00:00
db9b046b6a
clang: Uncomment new warning flag.
...
BUG=85289
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7108018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88279 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 04:14:29 +00:00
a81bc4587d
roll clang 131935:132017
...
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88270 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 02:20:21 +00:00
898ceee92e
Disable RegisterProtocolHandler on Linux.
...
The OS-level registration isn't implemented on Linux, and so every time the
browser starts it will act as though another program has been registered to
handle the protocols it knows about and deregister them all internally.
Review URL: http://codereview.chromium.org/7024043
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88246 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-08 00:14:49 +00:00
34fe3a39a4
Adds a GYP flag for desktop notifications (enabled by default) and stub out relevant code if set to 0.
...
In chrome/browser/task_manager I moved notifications related code to their own files and allow exclusion and stubbing via GYP. Similarly I have added stubs for other parts including a chrome/browser/notifications/notification_stubs.cc which takes care of classes within that directory.
I also created some static methods in DesktopNotificationService to wrap commonly used notification related code so that we reduce the amount of stubs required.
BUG=none
TEST=existing notification tests succeed
Review URL: http://codereview.chromium.org/7053041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88040 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-06 21:24:02 +00:00
d44bb86949
Dummy change to test the workflow
...
TBR=nsylvain
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88024 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-06 20:13:46 +00:00
35e47c4666
Dummy change to test the commit workflow.
...
BUG=
TEST=
TBR=nsylvain
git-svn-id: http://src.chromium.org/svn/trunk/src/build@88008 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-06 18:34:27 +00:00
75fefa6920
Follow on to http://codereview.chromium.org/7020034/ in the touch ui case we
...
want to load the touch icons (while the converse might not be true)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6993017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87856 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-03 20:53:49 +00:00
b698f6a705
Only pass -Wl,--icf=safe to the target compiler, not the host one.
...
BUG=none
TEST=run gyp, check -Wl,--icf=safe is added to *.target.mk but not to *.host.mk
Review URL: http://codereview.chromium.org/7065051
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87840 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-03 20:05:46 +00:00
196a9c676d
Made ENABLE_TOUCH_ICON_LOADING configurable.
...
BUG=71571
TEST=Existing tests
Review URL: http://codereview.chromium.org/7020034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87720 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-02 23:08:01 +00:00
fe27d84d65
Add the /profile flag to linker options for official builds.
...
This deposits "FIXUPS" in the PDB, which grows the PDB file by 5% or so, but does otherwise not the generated binaries.
BUG=none
TESt=none
Review URL: http://codereview.chromium.org/7106002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87607 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-02 14:51:01 +00:00
d0064cabf8
Disable the ACCELERATED_2D_CANVAS build flag on mac
...
BUG=81678
TEST=none
Review URL: http://codereview.chromium.org/7102003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87482 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-01 16:11:22 +00:00
ab350838f3
Allow device policy code to be optionally included.
...
BUG=None
TEST=Existing
Review URL: http://codereview.chromium.org/7096013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87468 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-06-01 13:56:25 +00:00
f1f985388f
Update translations using strings from launchpad.net r228
...
This includes a new lang: Armenian (hy)
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7100004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87376 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-31 22:11:29 +00:00
764e03ef94
Revert 87315 - Revert 87309 - Second attempt to fix linux redux builder
...
Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error.
BUG=None
TEST=Builds with and without use_openssl=1
Review URL: http://codereview.chromium.org/7050040
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/7054041
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6962044
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87316 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-31 17:19:30 +00:00
052dc43fda
Revert 87309 - Second attempt to fix linux redux builder
...
Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error.
BUG=None
TEST=Builds with and without use_openssl=1
Review URL: http://codereview.chromium.org/7050040
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/7054041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87315 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-31 17:02:45 +00:00
c5403b209c
Second attempt to fix linux redux builder
...
Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error.
BUG=None
TEST=Builds with and without use_openssl=1
Review URL: http://codereview.chromium.org/7050040
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87309 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-31 16:09:46 +00:00
35f82980a4
Fix linux redux
...
Follow up to http://src.chromium.org/viewvc/chrome?view=rev&revision=87102 - it seems 'use_opensll!=0' is no longer supported in gyp(?)
BUG=None
TEST=build with use_openssl=1
Review URL: http://codereview.chromium.org/7096007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-31 10:50:50 +00:00
dbad736a51
mac: Fix a nesting bug in http://crrev.com/87141
...
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/7087016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87148 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-28 02:49:48 +00:00
0a44544232
mac: Use -O2 for clang release builds for now.
...
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7083014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87141 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-28 02:13:46 +00:00
ee2c506a4b
Invoke grit_info as a python module.
...
This speeds up build/gyp_chromium by 7s on my system (for a total of 10s with the other grit_info changes I landed earlier).
BUG=82230
TEST=none
Review URL: http://codereview.chromium.org/7035004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87140 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-28 02:11:24 +00:00
4fd1132da9
Add performance_ui_tests to the chromium_builder_perf target.
...
R=chase@chromium.org
Review URL: http://codereview.chromium.org/7080008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@87049 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-27 18:20:54 +00:00
ca0c321360
Switch to python2.6 as the default for pyauto on linux
...
BUG=81621
R=cmp@chromium.org
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86732
Review URL: http://codereview.chromium.org/6992077
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86985 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-27 06:54:51 +00:00
41ad2bcf70
Turn on navigator.registerProtocolHandler().
...
R=tony
Review URL: http://codereview.chromium.org/7075007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86944 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-27 01:30:47 +00:00
af1de37719
Enabling page visibility api in the chrome browser.
...
BUG=83286
TEST=None.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86569
Review URL: http://codereview.chromium.org/7036019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86881 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-26 20:04:21 +00:00
d2f4484f67
Handler settings page.
...
This change implements a settings page that allows users to manage protocol
handlers registered via navigator.registerProtocolHandler.
tony: could you review the ProtocolHandlerRegistry stuff?
estade: could you review the webui stuff?
Thanks!
TEST=Unit tests provided.
Review URL: http://codereview.chromium.org/7033018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86762 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-26 01:30:56 +00:00
c0403fa4c8
Revert 86732 - Switch to python2.6 as the default for pyauto on linux
...
BUG=81621
R=cmp@chromium.org
TEST=
Review URL: http://codereview.chromium.org/6992077
TBR=nirnimesh@google.com
Review URL: http://codereview.chromium.org/6987034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86739 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-25 23:32:49 +00:00
f5fd98b3dd
Switch to python2.6 as the default for pyauto on linux
...
BUG=81621
R=cmp@chromium.org
TEST=
Review URL: http://codereview.chromium.org/6992077
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86732 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-25 23:02:25 +00:00
bf0bd41e5a
Fix all build wrt gles2_conform_support
...
TEST=build all locally
BUG=83837
TBR=thakis@chromium.org
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86576 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-25 06:54:54 +00:00
e248371483
Revert 86569 - Enabling page visibility api in the chrome browser.
...
BUG=83286
TEST=None.
Review URL: http://codereview.chromium.org/7036019
TBR=shishir@chromium.org
Review URL: http://codereview.chromium.org/6979006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86574 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-25 06:03:03 +00:00
27e56b31a6
Enabling page visibility api in the chrome browser.
...
BUG=83286
TEST=None.
Review URL: http://codereview.chromium.org/7036019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86569 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-25 04:04:51 +00:00
d8fa8f6ce2
Enabling MHTML.
...
Enabling MHTML reading on the Chrome side now that the WebKit patch
adding support for MHTML landed in WebKit.
That is necessary for the MHTML layout tests to pass.
BUG=83804
TEST=MHTML layout tests should pass.
Review URL: http://codereview.chromium.org/7064044
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86560 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-25 02:57:41 +00:00
b2541d3a62
Prototype compositor to render views to a texture using d3d 10. This
...
is just a prototype for us to play with. There are plenty of issues to
resolve before its made real, but I wanted to check something in for
others to play with rather than keeping it all local. To get it to
compile you need to set the GYP_DEFINE to views_compositor.
BUG=none
TEST=none
R=ben@chromium.org ,apatrick@chromium.org
Review URL: http://codereview.chromium.org/7067029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86516 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-24 23:08:58 +00:00
205680def0
Resubmit CL 86306
...
TEST=ran locally
BUG=83382
Review URL: http://codereview.chromium.org/7066028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86468 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-24 19:37:35 +00:00
f7f56fea4a
Fix to make InputMethodIBus usable on every ChromeOS device (even without TouchUI)
...
Add switch "--enable-inputmethod-ibus" to enable InputMethodIBus on ChromeOS
Modify gyp files to link IBus
BUG=chromium-os:15566
TEST=manually
Review URL: http://codereview.chromium.org/7004029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86390 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-24 02:36:05 +00:00
359f769c72
Revert 86306 (failed compile on win builder) - Move OpenGL ES 2.0 conformance test support into main tree
...
This support breaks often because it is not built but the buildbots.
This CL adds it to the main tree so it will be built by the buildbots.
Not sure where to add it in all.gyp but I need to make sure it's built
TEST=opengl es 2.0 conformance tests still build
BUG=83382
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7057033
TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/7066003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86316 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-23 19:01:46 +00:00
c8b3ac7863
Move OpenGL ES 2.0 conformance test support into main tree
...
This support breaks often because it is not built but the buildbots.
This CL adds it to the main tree so it will be built by the buildbots.
Not sure where to add it in all.gyp but I need to make sure it's built
TEST=opengl es 2.0 conformance tests still build
BUG=83382
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7057033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86306 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-23 18:26:31 +00:00
324c8d74d5
test
...
Review URL: http://codereview.chromium.org/7019040
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86288 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-23 15:27:24 +00:00
f3e2f5ba38
Don't build googleurl_unittests in shlib builds.
...
BUG=82178
Review URL: http://codereview.chromium.org/7059003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86228 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-21 22:45:07 +00:00
1afa046353
Whitespace to kick bots
...
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86222 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-21 17:44:14 +00:00
3099af8f84
Linux: Add libcups2(-dev) to install-build-deps.sh.
...
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6990023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86191 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-21 01:05:22 +00:00
a094e579e9
Update translations using strings from launchpad.net r216
...
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7049015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-20 20:26:27 +00:00
3d2391391c
Linux: Update install-build-deps.sh for Natty and remove pre-Lucid support.
...
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6990006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86107 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-20 17:53:55 +00:00
7e7085afc4
Remove more library=shared_library pieces.
...
Leave in the definition of the 'library' variable until we're
certain all users are fixed, but otherwise hardcode it to
static_library.
Review URL: http://codereview.chromium.org/7051017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86026 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-20 00:53:50 +00:00
6009dfe782
Globally replace <(library) with static_library
...
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@86004 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-19 23:18:53 +00:00
abc056e626
Linux: Install the sqlite debugging package for developers.
...
BUG=82894
TEST=none
Review URL: http://codereview.chromium.org/6975038
git-svn-id: http://src.chromium.org/svn/trunk/src/build@85798 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-18 20:01:35 +00:00
b9d70721f1
Remove os_nix from gyp variables.
...
This is extra complexity we don't need.
Review URL: http://codereview.chromium.org/7037016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@85776 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-05-18 17:25:37 +00:00
thakis@chromium.org
jam@chromium.org
koz@chromium.org
satish@chromium.org
nsylvain@chromium.org
saintlou@chromium.org
piman@chromium.org
michaelbai@google.com
siggi@chromium.org
junov@chromium.org
jknotten@chromium.org
tony@chromium.org
mirandac@chromium.org
joth@chromium.org
darin@chromium.org
nirnimesh@chromium.org
shishir@chromium.org
nirnimesh@google.com
gman@chromium.org
ukai@chromium.org
jcivelli@chromium.org
sky@chromium.org
hashimoto@chromium.org
mattm@chromium.org
epoger@google.com
cmp@chromium.org
rsleevi@chromium.org
thestig@chromium.org
fta@sofaraway.org
evan@chromium.org