`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.
Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.
This CL was uploaded by git cl split.
R=tikuta@chromium.org
Bug: 1041419
Change-Id: I15bd43c6df0ba87f879e5226e4dbb1af7ba73f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998745
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#731078}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4782d7368c37ae35cf0c44456ba8307079a4d24e
This is basically an update of the work done in
https://crrev.com/c/1515682. The errors are not exactly the same but
the link phase was failing due to undefined symbols.
The problem of the original patch was that it was not adding the
required dependencies to animation/ in several parts of the tree, and
thus the buildflags.h include file was not generated on time.
This change allows us to build again with
build_animation_use_time_delta enabled again.
Bug: 737867
Change-Id: Id659b825f5177b137ab9de6a043b168836e3c570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741670
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Original-Commit-Position: refs/heads/master@{#686737}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b2acf6118c1de9d34e5284b385345fcaaecfb62
There is code in renderer/modules that isn't currently seeing the correct version of AnimationTimeDelta
third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc
blink_unittests was failing to link with precompiled headers enabled.
Bug: 737867
Change-Id: I437abd16e2d53a4ef05af8b95fdd01d2b9215a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515682
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eugene Girard <girard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#640299}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b1055ded27ad9c5ab25f6cf9ddfbcc3f6dd5e0f2
Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.
BUG=814485
TEST=covered by build
Change-Id: Ib936c2840991902fa33c040b381b8ffc98a3c532
Reviewed-on: https://chromium-review.googlesource.com/930033
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538310}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4416579b311cc64b476335b5d46ddbfa6131ed0e
With this change "gn check" no longer assumes all #include paths are
relative to the source root. Instead it searches for the includes by
checking each of the directories listed in include_dirs for the target.
A number of new issues have been discovered. The trivial ones have been
fixed, the larger and more complex ones have been reported and the related
parts of the project have been excluded from the default gn check run.
BUG=794926
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I39c17a7ac47dc024dd374c8891ce4911809195cb
Reviewed-on: https://chromium-review.googlesource.com/827014
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531334}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2f14ea14de1ea4ffe82aaa9c01425e41f3625797
Removes annotations of "GYP version" from GN targets.
Removes shell.exe.manifest which was used only by the GYP build.
TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2373683003
Cr-Original-Commit-Position: refs/heads/master@{#421335}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cde1af7bd0ccf5b051bd3bac47290e15d8a0ef29
This adds a chrome crash_service target that matches the target arch, and a *_win64 version when compiling 32-bit targets.
Previosly we had a crash_service.exe target that was actually the content_shell one with the wrong name. Various code referred to this target when some meant the chrome one, and some meant the content one. This patch fixes the naming and updates the references to use the correct one.
Fixes cross-compiling of generated buildflag headers. It was computing the output directory incorrectly.
BUG=537009
Review URL: https://codereview.chromium.org/1491363002
Cr-Original-Commit-Position: refs/heads/master@{#362826}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0d3b1dfc7ad173af97ca0f897319ab137d4cf634
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1469383005
Cr-Original-Commit-Position: refs/heads/master@{#361854}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 06c2ba3165d8b02364bf818d5028a7cb4fe48ac0
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1458653002/TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1475513006
Cr-Original-Commit-Position: refs/heads/master@{#361741}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cbc1cd295bc85219ad89326457cd7f5cf003d41c
Reason for revert:
This seems to have broken webkit builders: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/94668
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Committed: https://crrev.com/3118dde528359280fa0cb3c6fc5b6323e834c514
> Cr-Commit-Position: refs/heads/master@{#361527}
TBR=mark@chromium.org,spang@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1475883002
Cr-Original-Commit-Position: refs/heads/master@{#361541}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4496a9a4563bf34e624261f7dcc5f1180282ff86
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Review URL: https://codereview.chromium.org/1458653002
Cr-Original-Commit-Position: refs/heads/master@{#361527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3118dde528359280fa0cb3c6fc5b6323e834c514
Nico Weber
Sergio Villar Senin
Eugene Girard
Scott Violet
Marcin Simonides
brettw
raymes