The initial attempt caused flakiness (random deadlocks). It turns out that
testserver.py was inheriting undesirable file descriptors when it was spawned
(including file lock file descriptors). Closing the unnecessary file
descriptors between fork() and exec() solves the problem.
Forwarder used to be a pain to setup/tear down across all the various
harnesses.
This CL should hopefully solve these issues by hiding these
implementation details. The host daemon is now killed once the first time that
the Forwarder class is used and the daemon running on the devices is also
killed the first time a port is forwarded for a specific device.
TBR=bulach@chromium.org
BUG=242846
Review URL: https://codereview.chromium.org/20824008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@215023 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Forwarder used to be a pain to setup/tear down across all the various
harnesses.
This CL should hopefully solve these issues by hiding these
implementation details. The host daemon is now killed once the first time that
the Forwarder class is used and the daemon running on the devices is also
killed the first time a port is forwarded for a specific device.
TBR=bulach@chromium.org
BUG=242846
Review URL: https://codereview.chromium.org/19550004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@212582 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This causes flakiness on the Android debug tester bot.
> Move Python setup/tear down logic into Forwarder itself.
>
> Forwarder used to be a pain to setup/tear down across all the various
> harnesses.
> This CL should hopefully solve these issues by hiding these implementation
> details. The host daemon is now killed once the first time that the Forwarder
> class is used and the daemon running on the devices is also killed the first
> time a port is forwarded for a specific device.
>
> BUG=242846
> R=bulach@chromium.org, frankf@chromium.org
>
> Review URL: https://codereview.chromium.org/18086004TBR=pliard@chromium.org
Review URL: https://codereview.chromium.org/19576005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@212054 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Forwarder used to be a pain to setup/tear down across all the various
harnesses.
This CL should hopefully solve these issues by hiding these implementation
details. The host daemon is now killed once the first time that the Forwarder
class is used and the daemon running on the devices is also killed the first
time a port is forwarded for a specific device.
BUG=242846
R=bulach@chromium.org, frankf@chromium.org
Review URL: https://codereview.chromium.org/18086004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@212020 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Instead of parsing *.isolated files, use isolate remap
to create a temporary dependency dir.
- Add an exclusion list to filter dependecies at a finer grain
than what's specified in isolate files.
- Convert base_unittests and unit_tests to use isolate.
This adds an additional 50MB to the dependency size due
to many small directories not specified in the exclusion list.
BUG=249870
Review URL: https://chromiumcodereview.appspot.com/18233018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@211350 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is achieved by having BaseTestRunner instantiate a single Forwarder
instance and inject it into SpawningServer.
This makes the test server spawner instance use an already configured Forwarder
instance for every single unit test rather than instantiating Forwarder every
time (which also meant unnecessarily running 'adb forward' for every single
unit test).
Note that this CL also makes Forwarder thread-safe. This is due to the fact
that the test server spawner does its work on a worker thread and not to the
fact that a single Forwarder instance can be shared accross multiple shards as
one could think.
BUG=229685,239014
R=bulach@chromium.org, craigdh@chromium.org, frankf@chromium.org
Review URL: https://codereview.chromium.org/15151003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@200500 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In ASan build, device_forwarder and md5sum_bin are built with ASan
instrumentation. Due to specifics of ASan on Android, such binaries
must be prefixed with a script to run.
This change also adds more app names to the wrap property list, to
cover content_tests and test_shell.
BUG=160952
Review URL: https://chromiumcodereview.appspot.com/12211070
git-svn-id: http://src.chromium.org/svn/trunk/src/build@181309 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
jbudorick@chromium.org
craigdh@chromium.org
johnme@chromium.org
pliard@chromium.org
frankf@chromium.org
bulach@chromium.org
nileshagrawal@chromium.org
eugenis@chromium.org