Removed the switch to re-enable old VIDEO_HOLE path as the overlay
path appears to be working correctly.
BUG=469374
Review URL: https://codereview.chromium.org/1380533002
Cr-Original-Commit-Position: refs/heads/master@{#351571}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d2b919284b79346539b438641f6a3252dccb113b
Default all android builds to safe_browsing=3 mode.
This will fix the crash in chrome_public_apk when built with //clank
checkout. It'll also provide more consistency between public and private
builds since both will use safe_browsing==3. At a later
date, the public build will get support for safe browsing.
In a follow-up CL I'd like to disable the Safe Browsing settings UI
when it's not supported, assuming we can determine that before the UI
is created.
BUG=533105
Review URL: https://codereview.chromium.org/1343293004
Cr-Original-Commit-Position: refs/heads/master@{#350429}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 36a226dfc5214fa56583dc14debda373c1718c58
Removing all targets from components so i can add one at a time and check that it works correctly.
Adding components/bookmarks.
components/bookmarks is building correctly but it needs ios/web gn files that are not written yet.
BUG=459705
Review URL: https://codereview.chromium.org/1310513006
Cr-Original-Commit-Position: refs/heads/master@{#350148}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dc35ba27660f5e0a26ab4e9495efdaaf829afb10
There are several specific features needed for Chromecast builds. This
flag will be used to enable and disable these features. This flag is
the equivalent of 'embedded' and 'is_chromecast' in GYP, which mean the
same thing in practice.
BUG=516899
Bug:b/17615224
Review URL: https://codereview.chromium.org/1345013002
Cr-Original-Commit-Position: refs/heads/master@{#349961}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 77bdc2e6b89cac63abb81da88d87bd897da67f71
Few more changes need to go in before enabling NaCl support for MIPS,
lets have it disabled until then.
TEST=Build Chromium using GN.
BUG=130022
Review URL: https://codereview.chromium.org/1344803002
Cr-Original-Commit-Position: refs/heads/master@{#349109}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d82b297171f8a108efd23929927009d4874548cf
Android is the last remaining platform that has not yet converted to CLDv2.
Sheriffs: expect to see APK size changes in the range of [-122K, +98K] bytes.
See the bug for more information.
As on iOS, use the smallest data tables to minimize the binary size impact.
This brings language detection on Android into parity with iOS (which also uses
the smallest data tables).
BUG=528257
Review URL: https://codereview.chromium.org/1327543003
Cr-Original-Commit-Position: refs/heads/master@{#347418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a70dc32d62dc1a0e9a8885f2258fe612aeb1f06
Reason for revert:
Reason for revert was a misunderstanding of issues that another piece of code was having interacting with the Cardboard SDK. This code was not exhibiting the same problems, so restoring it while we investigate the other code's issues further.
Original issue's description:
> Revert of Android WebVR implementation, Cardboard 0.5.5 SDK (patchset #12 id:220001 of https://codereview.chromium.org/1200303002/ )
>
> Reason for revert:
> Android team found an incompatibility with the 0.5.5 Cardboard SDK and non-ARM devices. Rolling back until the Cardboard team can address that.
>
> Original issue's description:
> > Android WebVR implementation, Cardboard 0.5.5 SDK
> >
> > Previously part of https://codereview.chromium.org/829803003/
> >
> > BUG=389343
> >
> > Committed: https://crrev.com/1d9c45547709e77d599c218d76317895389db129
> > Cr-Commit-Position: refs/heads/master@{#342496}
> >
> > Committed: https://crrev.com/d9be58be03170c7c82f9c55abc2d21f0f7447c7f
> > Cr-Commit-Position: refs/heads/master@{#345356}
>
> TBR=jochen@chromium.org,jdduke@chromium.org,sievers@chromium.org,tedchoc@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=389343
>
> Committed: https://crrev.com/9763eb99753dc90ae912ebfbee3ba240c37db427
> Cr-Commit-Position: refs/heads/master@{#346669}
TBR=jochen@chromium.org,jdduke@chromium.org,sievers@chromium.org,tedchoc@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=389343
Review URL: https://codereview.chromium.org/1306883009
Cr-Original-Commit-Position: refs/heads/master@{#346716}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3fca9561b090d6e0bac68ebd6267b78cb39bbdf9
We should rely on GYP_DEFINE "enable_plugins" in gyp files and C++ macro
"ENABLE_PLUGINS" in source code to indicate plugins support. This removes
hard-coded assumptions that certain OS does (or does not) support plugins.
Also add GYP_DEFINE "enable_pdf" and macro "ENABLE_PDF" to indicate
built-in PDF viewer plugin support.
BUG=490433
TEST=trybot
TBR=sievers@chromium.org
Review URL: https://codereview.chromium.org/1318143002
Cr-Original-Commit-Position: refs/heads/master@{#346284}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 11e9711134d075bef1580c56f189ae5e1ab3c034
I've taken ad591c629a
and merged it onto Chromium ToT, with a few lint and other cleanups,
and one fix to make sure that Mac still compiled (which may have broken
iOS, haven't tested yet).
R=brettw@chromium.org, sdfresne@chromium.org
BUG=459705
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1250913002
Cr-Original-Commit-Position: refs/heads/master@{#342297}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a29462a04dabad3fc20dc922227c46b36459912
When set to 1, this will NOT activate the field trial test specified
in the fieldtrial_testing_config_*.json. This gives Chromium
packagers the flexibility to disable field trial testing config for
their package as we have on our Google Chrome build.
BUG=515686
Review URL: https://codereview.chromium.org/1266113002
Cr-Original-Commit-Position: refs/heads/master@{#341845}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d2e44fe0e7994b083504c249b654e20d76228e0
Chromecast builds need to explicitly set |enable_browser_cdms| to true
and |enable_pepper_cdms| to false. Rather than introduce a global
is_chromecast variable, as we have in GYP, allow |enable_pepper_cdms| to
be set in args.gn.
BUG= b/17615224
Review URL: https://codereview.chromium.org/1266693005
Cr-Original-Commit-Position: refs/heads/master@{#341776}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9bacb78d7d0a453ff5d23df7fd30b7b75cded17d
Renamed USE_PLATFORM_SPELLCHECKER preprocessor flag to
USE_BROWSER_SPELLCHECKER to more accurately reflect the fact
that the browser side contains other services such as red
underlines that will be leveraged by any spellchecker.
BUG=415302
Review URL: https://codereview.chromium.org/1263423006
Cr-Original-Commit-Position: refs/heads/master@{#341771}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 990eb97f091d9719b2061de67b7e585f6a967d8b
The header is now meant to be an interface for any
system that would like to use its own spellchecker
instead of the hunspell library.
Split the implementation into two source files, one for mac and one for android.
The android implementation is just method stubs for now.
Updated related build files and #include references.
Part 1 of a 3 part breakdown of https://codereview.chromium.org/1204293003.
The breakdown will also include some changes to the original CL.
BUG=415302
Review URL: https://codereview.chromium.org/1230933002
Cr-Original-Commit-Position: refs/heads/master@{#339195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 684453c5ecb33796629becb77b64591d939e4458
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Original-Commit-Position: refs/heads/master@{#339002}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d967d55cf7a0f78e6ace9ec681d2d082e631810b
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Original-Commit-Position: refs/heads/master@{#338040}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 311a46585ee5b77486ef42d947bc7cc7566558b1
SafeBrowsingDatabaseManager: Pure interface
TestSafeBrowsingDatabaseManager: Dummy impl for tests
LocalSafeBrowsingDatabaseManager: Existing full impl.
RemoteSafeBrowsingDatabaseManager: New for Android
Wire up the safe_browsing=3 build-mode to switch Android to
use Remote*. Move SafeBrowsingCheck into Local* and create
the Test* impl that can't accidentally call a real
implementation's methods. Adjust tests to use either Test*
or Local*.
The initial implementation of Remote* does the bookeeping
of requests, but doesn't yet make calls to Java and isn't
tested.
BUG=474608
Review URL: https://codereview.chromium.org/1110723002
Cr-Original-Commit-Position: refs/heads/master@{#329551}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2cd5eef530be7100274af882af3f5aff4d1c4be
The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing.
Originally landed as https://codereview.chromium.org/1120803003/TBR=scottmg@chromium.orgTBR=ddorwin@chromium.org (widevine)
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1123433002
Cr-Original-Commit-Position: refs/heads/master@{#327998}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b2364bb2c6fbb88e6a4550abeb9141bc7cb949c
Remove most references to android_webview_build from the build directory
now that we no longer support that build configuration. Fold conditions
into their parents where appropriate. Leave the variable itself defined
to 0 as not all uses in the tree have been removed yet.
A few references are left alone here and will be removed separately in
later changes that will be larger refactorings to eliminate other
variables.
BUG=440793
Review URL: https://codereview.chromium.org/1043913002
Cr-Original-Commit-Position: refs/heads/master@{#323013}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c6fe7a775af41cd98533e89a902b8b67044caa87
The bots still use 'cpu_arch' to set the architecture, and the build
file was keying off of build_cpu_arch to determine whether or not
to enable NaCl, so things were failing. Updating the the code to
'current_cpu' fixes the problem correctly.
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/964003002
Cr-Original-Commit-Position: refs/heads/master@{#318585}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1c35162ea310ab09b3bb72fe1bfe95232db5d1a6
I don't think any other config will work at the moment.
Note that this is also totally untested, but should at least compile :).
R=brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/954383002
Cr-Original-Commit-Position: refs/heads/master@{#318329}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ea95fb51c079912c99ff90a4579e02d802a73e9
This should get most of NaCl and the PPAPI stuff needed
for NaCl building and linking. There is more work to be
done to get some of the test binaries working (and
probably fill out parts of the NaCl SDK) and possibly
some pnacl support work remaining as well.
NaCl is still disabled by default (set enable_nacl=true
to change). Enabling nacl is still mostly untested and
likely doesn't work at all :).
R=ncbray@chromium.org, brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/877553008
Cr-Original-Commit-Position: refs/heads/master@{#318180}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6065cf751340a8a99b670357b2053ed6df12a7af
tmoniuszko
halliwell
nparker
sherouk
slan
Gordana.Cmiljanovic
dpranke
andrewhayden
bajones
hshi
mmaliszkiewicz
danduong
dylanking
avayvod
sdefresne
Nico Weber
brettw
rickyz
prashantv
mfoltz
mostynb
torne