When called from a bot, runhooks' stdin will be redirected to /dev/null. The
hack we use in update.py that redirects stdin to stderr causes a read-only
/dev/null to eventually appear as gsutil's stderr here, which causes it
to blow up for an unknown reason. To avoid this problem, open a writable
/dev/null and redirect unconditionally here.
This prevents command line users from seeing gsutil's output, but at least
the thing runs.
BUG=453195
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1246783002
Cr-Original-Commit-Position: refs/heads/master@{#339542}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 83a9be53371d0bc5a1084e2162cb28b2d073433e
Since yesterday, it works on Windows. This allows us to not
completely clobber the build from update.py each time, since the
build system tracks the dependency instead.
It should also be possible to use this from gn, so we can delete the
posix-print-revision.py script. The only problem was that the
hack we use for fixing the output in gclient runhooks didn't work.
I've adjusted that to not fail when the hack doesn't work.
BUG=483065
R=scottmg@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1127233002
Cr-Original-Commit-Position: refs/heads/master@{#328699}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cd20b07ab7edf2a7bab8e34362cebe5f92b41a27
Reason for revert:
Looks like this broke the world: http://build.chromium.org/p/chromium.fyi/console?category=win%20clang
Original issue's description:
> Use Clang's update.py --print-revision everywhere.
>
> Since yesterday, it works on Windows. This allows us to not
> completely clobber the build from update.py each time, since the
> build system tracks the dependency instead.
>
> It should also be possible to use this from gn, so we can delete the
> posix-print-revision.py script. The only problem was that the
> hack we use for fixing the output in gclient runhooks didn't work.
> I've adjusted that to not fail when the hack doesn't work.
>
> BUG=483065
>
> Committed: https://crrev.com/828bba82c5ed315cf073ad9599c0d5334a9a403d
> Cr-Commit-Position: refs/heads/master@{#328634}
TBR=scottmg@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=483065
Review URL: https://codereview.chromium.org/1131813002
Cr-Original-Commit-Position: refs/heads/master@{#328672}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 05320c6a7b8695c843c6d4de10261e7a65fafcb3
Since yesterday, it works on Windows. This allows us to not
completely clobber the build from update.py each time, since the
build system tracks the dependency instead.
It should also be possible to use this from gn, so we can delete the
posix-print-revision.py script. The only problem was that the
hack we use for fixing the output in gclient runhooks didn't work.
I've adjusted that to not fail when the hack doesn't work.
BUG=483065
Review URL: https://codereview.chromium.org/1127233002
Cr-Original-Commit-Position: refs/heads/master@{#328634}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 828bba82c5ed315cf073ad9599c0d5334a9a403d
Also blacklist /usr/{,local/}{include,lib} instead of /usr to make
things less confusing for people who check out Chrome under /usr.
The plugin is downloaded separately from the rest of the LLVM
package to avoid bloating the package with a large file that
most people don't need right now.
BUG=453195,463361
R=thakis@chromium.org,hans@chromium.org
CC=dcheng@chromium.org
Review URL: https://codereview.chromium.org/970053002
Cr-Original-Commit-Position: refs/heads/master@{#319317}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b1dea52802af355f47822b89fb68eb25fc124f55