The initial attempt caused flakiness (random deadlocks). It turns out that
testserver.py was inheriting undesirable file descriptors when it was spawned
(including file lock file descriptors). Closing the unnecessary file
descriptors between fork() and exec() solves the problem.
Forwarder used to be a pain to setup/tear down across all the various
harnesses.
This CL should hopefully solve these issues by hiding these
implementation details. The host daemon is now killed once the first time that
the Forwarder class is used and the daemon running on the devices is also
killed the first time a port is forwarded for a specific device.
TBR=bulach@chromium.org
BUG=242846
Review URL: https://codereview.chromium.org/20824008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@215023 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Forwarder used to be a pain to setup/tear down across all the various
harnesses.
This CL should hopefully solve these issues by hiding these
implementation details. The host daemon is now killed once the first time that
the Forwarder class is used and the daemon running on the devices is also
killed the first time a port is forwarded for a specific device.
TBR=bulach@chromium.org
BUG=242846
Review URL: https://codereview.chromium.org/19550004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@212582 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This causes flakiness on the Android debug tester bot.
> Move Python setup/tear down logic into Forwarder itself.
>
> Forwarder used to be a pain to setup/tear down across all the various
> harnesses.
> This CL should hopefully solve these issues by hiding these implementation
> details. The host daemon is now killed once the first time that the Forwarder
> class is used and the daemon running on the devices is also killed the first
> time a port is forwarded for a specific device.
>
> BUG=242846
> R=bulach@chromium.org, frankf@chromium.org
>
> Review URL: https://codereview.chromium.org/18086004TBR=pliard@chromium.org
Review URL: https://codereview.chromium.org/19576005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@212054 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Forwarder used to be a pain to setup/tear down across all the various
harnesses.
This CL should hopefully solve these issues by hiding these implementation
details. The host daemon is now killed once the first time that the Forwarder
class is used and the daemon running on the devices is also killed the first
time a port is forwarded for a specific device.
BUG=242846
R=bulach@chromium.org, frankf@chromium.org
Review URL: https://codereview.chromium.org/18086004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@212020 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
jbudorick
danduong
jbudorick@chromium.org
craigdh@chromium.org
johnme@chromium.org
pliard@chromium.org
skyostil@chromium.org