> Make page_cycler.py fully measure memory for each page.
>
> Telemetry makes the distinction between metrics collected for each page and for
> each page set. The fine-grained memory metrics were collected only per page set
> (although there was some histogram data collected per page).
>
> This CL makes the memory metric module systematically report the whole data per
> page (and not only per page set) so that we can measure pages independently.
> The per page set memory metric collection is now a no-op.
>
> BUG=323494
>
> Review URL: https://codereview.chromium.org/91573003TBR=pliard@chromium.org
Review URL: https://codereview.chromium.org/111773002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239791 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Telemetry makes the distinction between metrics collected for each page and for
each page set. The fine-grained memory metrics were collected only per page set
(although there was some histogram data collected per page).
This CL makes the memory metric module systematically report the whole data per
page (and not only per page set) so that we can measure pages independently.
The per page set memory metric collection is now a no-op.
BUG=323494
Review URL: https://codereview.chromium.org/91573003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239784 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This speeds up PushIfNeeded() execution times on a same instance of
AndroidCommands for repetitive files. This can be achieved by mapping host file
paths to their mtime at push time as tonyg@ pointed out although this assumes
that the device doesn't modify the files.
This is needed to make PurgeUnpinnedAshmem() reasonably fast to execute in
Telemetry. This CL decreases by 40 secs the execution time of netsim.top_10
whem memory is measured for each page (and PurgeUnpinnedAshmem() is called
before each measurement).
BUG=323494,326929
R=bulach@chromium.org, craigdh@chromium.org, tonyg@chromium.org
Review URL: https://codereview.chromium.org/97133002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239757 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The sync tests failure seems to have to do with port unmapping. Not unmapping
ports let most of the sync tests pass (only 2 failures remain for an unrelated
reason apparently).
Note that port unmapping was added to avoid exceeding the file descriptor limit
in net_unittests since each test server was listening on a different port. The
sync tests use a server always listening on a same port so unmapping the port
is not strictly needed.
BUG=313809
Review URL: https://codereview.chromium.org/106533002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239467 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Calling sys.exit() in a thread spawned by
multiprocessing.pool.ThreadPool causes an infinite hang that even SIGINT
can't fix. This is bad. Instead of calling sys.exit(), raise an
exception, crafted so that the important information (the failed
command's stdout and stderr) comes after the stacktrace and the copyable
command.
This also renames CheckCallDie() to CheckOutput() and changes it to
print stderr but not stdout by default. Suppressing stderr has hid bugs
in the past (e.g. aapt crunch failures), and hiding stdout is what we
usually want anyway.
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/106923002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239276 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
dirname outputs "." when given an empty argument, which gyp rules then
interpret as goma being available.
Remove ANDROID_GOMA_WRAPPER which is no longer used, and use GOMA_DIR
directly for android build.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/104563004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238718 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of crrev.com/62953024 which was reverted because
it broke other platforms.
Refactoring common cleanup code required by both
android_browser_finder.py and perf/setup.py and moving it into
pyblib/utils/test_environment.py.
Also, this change avoids killing twice the adb server when running
in a bot environment, where the adb restart is already invoked by
the bot steps.
BUG=268450
R=bulach@chromium.org,tonyg@chromium.org
Review URL: https://codereview.chromium.org/94683002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237815 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL modifies the build to incorporate the expected C++ library version
in the Java code. This is then checked when the library is loaded, to
make sure that the C++ and Java builds match.
This CL also implements error handling when library loads fail or the
loaded version doesn't match the expected version.
BUG=311644
Review URL: https://codereview.chromium.org/59533009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/builds/12649/steps/BuildPackages/logs/stdio
autotest-chrome-0.0.1-r3242: ERROR:root:bluetooth_RegressionClient import error: No module named telemetry.core. Skipping bluetooth_RegressionClient
autotest-chrome-0.0.1-r3242: Traceback (most recent call last):
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/bin/setup_job.py", line 72, in init_test
autotest-chrome-0.0.1-r3242: exec import_stmt + '\n' + init_stmt in locals_dict, globals_dict
autotest-chrome-0.0.1-r3242: File "<string>", line 1, in <module>
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/site_tests/bluetooth_RegressionClient/bluetooth_RegressionClient.py", line 7, in <module>
autotest-chrome-0.0.1-r3242: from autotest_lib.client.cros.bluetooth import bluetooth_semiauto_helper
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/cros/bluetooth/bluetooth_semiauto_helper.py", line 10, in <module>
autotest-chrome-0.0.1-r3242: from autotest_lib.client.cros import semiauto_framework
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/cros/semiauto_framework.py", line 9, in <module>
autotest-chrome-0.0.1-r3242: from autotest_lib.client.common_lib.cros import chrome
autotest-chrome-0.0.1-r3242: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3242/work/autotest-work/client/common_lib/cros/chrome.py", line 7, in <module>
autotest-chrome-0.0.1-r3242: from telemetry.core import browser_finder, browser_options, exceptions
autotest-chrome-0.0.1-r3242: ImportError: No module named telemetry.core
> [Telemetry] Refactor common Android test harness functions.
>
> Refactoring common cleanup code required by both
> android_browser_finder.py and perf/setup.py and moving it into
> pyblib/utils/test_environment.py.
> Also, this change avoids killing twice the adb server when running
> in a bot environment, where the adb restart is already invoked by
> the bot steps.
>
> BUG=268450
> R=bulach@chromium.org,tonyg@chromium.org
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/62953024TBR=primiano@chromium.org
Review URL: https://codereview.chromium.org/93793002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237674 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Refactoring common cleanup code required by both
android_browser_finder.py and perf/setup.py and moving it into
pyblib/utils/test_environment.py.
Also, this change avoids killing twice the adb server when running
in a bot environment, where the adb restart is already invoked by
the bot steps.
BUG=268450
R=bulach@chromium.org,tonyg@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/62953024
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237667 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) Verify that setLocalDescription fails when trying to negotiate an unsupported video codec
- Verify that setLocalDescription fails when trying to negotiate with a client that does not support encryption
BUG=303035
Review URL: https://codereview.chromium.org/47923023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235798 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Changes:
* Decouple the version of the SDK that is installed from
the version of the Android API that will be used.
* Upgrade the SDK to Android-19 while we are at it.
* Allow an "--api-level" argument to choose system images.
* Automagically download and install platform libraries for
any --api-level
BUG=
Review URL: https://codereview.chromium.org/59943011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235782 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We use the SurfaceFlinger data to compute the lengths of the frames (normalized
to vsyncs). Sometimes the data is inconsistent and we get two frames that are
less than 1 vsync apart. Filter out these frame lengths (threshold length is
currently 0.5 vsyncs) and print a warning.
BUG=318093
Review URL: https://codereview.chromium.org/71353006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@235675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
pliard@chromium.org
johnme@chromium.org
tonyg@chromium.org
bulach@chromium.org
navabi@google.com
newt@chromium.org
wjia@chromium.org
boliu@chromium.org
craigdh@chromium.org
thakis@chromium.org
skyostil@chromium.org
primiano@chromium.org
aberent@chromium.org
creis@chromium.org
frankf@chromium.org
ilevy@chromium.org
andrewhayden@chromium.org
jyasskin@chromium.org
elham@google.com
mnaganov@chromium.org
rileya@chromium.org
dominikg@chromium.org
rockot@google.com
mek@chromium.org