This adds ppapi-related targets except the tests to the GN build.
Did some minor tweaks to the .gypi ppapi lists. Some files were duplicated between the trusted and common lists which causes errors in GN (it doesn't uniquify the lists like GYP). Common is used in every place trusted is, so I just removed the duplicates from the trusted list.
Fixed some warnings in skia and tcmalloc. Added the ability to undefine NOMINMAX on Windows.
Fixed some src/ui Windows compilation issues.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/305513003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@273016 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is the GN version of build/java_cpp_template.gypi.
It defines a template that wraps an action_foreach that generates .java
files using the host C preprocessor.
The major difference in the GN version is that it takes all the
generated java files and zips them together in a single .srcjar. When
such a target is included in the srcjar_deps of a java library, the
.java files in the .srcjar will be treated much like files listed in
that libraries java_sources (particularly they will be compiled and
included in the .jar/.dex).
Depends on https://crrev.com/264773014/
BUG=359249
Review URL: https://codereview.chromium.org/264923007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272775 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a protobuf target and a template for defining protos. This handles doing host builds of protoc when cross-compiling.
The command buffer sevice wants more optimization on Android, so this patch generalizes the solution. Normally Android, like Windows, optimizes for size. This now adds support on Android for speed optimization just like Windows does. Mac & Linux always optimize for speed.
Removes the declare_args call around the gcc_version. This was parameterized to be different if is_android was set, which isn't valid because build parameters can't vary across toolchains. Since this value is derived from the environment, I just removed the declare_args call.
BUG=
R=piman@chromium.org
Review URL: https://codereview.chromium.org/289953004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271941 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Parameterize webrtc enabling.
Add use_seccomp_pbf flag
Add a webkit version target
Work on ui/base GN build, especially on Windows. This target is a mess (in GYP). This patch tries to make it make a bit more sense while fixing the errors I found.
Fix ui/gl target for non-Linux platform. A bunch of X11 stuff was not parameterized.
Add unscaled resources target
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/287343006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271724 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a meta-target "//base/allocator" that forwards to tcmallor or nothing depending on the build configuration.
Write tcmalloc target definition.
Write base unit tests prefs, and some support targets from base.gypi.
Fix a bunch of added files in the base target that were exposed by linking the unit tests.
Removes toolkit_uses_gtk which was removed from the GYP build.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/288203003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds special handling for variables that begin with underscores, which is inspired by Dart. Such variables are not imported when doing an import, which gives .gni files a way to have intermediate private variables that won't pollute the scopes of the files that include them.
This also applies to the root build config, which can have private values now.
Adds some missing unused variable checks. This was disabled because processing imports would mean all imported variables were unused, and files not using all of them would get unused variable errors. This adds the option to mark merged values on a scope as used, which is used for imported values.
BUG=341738
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/287693002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@271078 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Some minor tweaks in STL usage in GN itself to enable it to compile using the Android version of the STL. Enable this in the build (not so much because we need a GN binary on Android, but for build verification purposes).
Moved the executable_ldconfig config from the linux file to the gcc one since its shared between the Linux and Android builds. Added "-Bdynamic" and "-Wl,-z,nocopyreloc" to this on Android.
Moved some sysroot path components from sysroot.gni to android/config.gni (which sysroot uses) so it can be shared with the toolchain definitions.
Added the android_full_debug build flag. Made the "optimize off" mode of the build match the GYP build's "light optimization" on Android contingent on this flag.
Pulls out the optimize and optimize_max shared flags into one list to avoid duplication.
Adds a bunch of linker optimization flags that should be passed on non-Mac Posix platforms, and turns on dead code stripping for Mac builds.
Adds functionality to the gcc toolchain template to be able to insert strings before and after the libs. Adds a wrapper template for android toolchains that sets these accordingly to get the gross Android crtbegin/end files inserted in the right place on the linker line.
Made the android_ndk_root variable relative to the source root rather than the system root. Uses of this now rebase according to their own needs which makes some of the arguments a lot easier to follow.
Build file updates for base and libevent for Android. Implement ashmem library.
The only change on desktop linux is the addition of -Wl,--fatal-warnings to the linker line.
R=ajwong@chromium.org, cjhopman@chromium.org, scottmg@chromium.org
Review URL: https://codereview.chromium.org/275703003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previously "gn args" printed build arguments. That has now moved to "gn args <outdir> --list" along with a new --short mode that's a bit more convenient for some uses.
Now "gn args" runs your editor on the build arguments for the given output directory, and re-generates the build given those arguments. This is an easier way to manage changing build arguments for a build (previously you would have to re-type everything or edit build.ninja manually).
"gn gen" now always uses the existing arguments for the given output dir, unless "--args" is manually specified (giving the old behavior of just using those). This also allows a more convenient way for a user to recover from a borked build (sincetimes I ran into a state where something was missing that prevent ninja from even starting enough to rebuild the build).
I removed the "show" and "refresh" ninja phony rules since the new commands cover those cases.
This patch adds some additional tracing to build startup since I noticed it was missing when trying to figure out why the args command was so slow (I fixed the main reason, it was with new code I added).
Added proper escaping for printing string values and unit tests for these.
Two minor build file fixes.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/265693003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds extension detection for lower-case ".s" assembly files (used in NSPR) in addition to the existing handling of uppercase ".S" ones.
Minor fixes for build files for Mac for dependencies and files.
Proper handling of USE_NSS and addition of USE_OPENSSL_CERTS that match the GYP build.
R=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/242173002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@265064 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds a template for using the jni_generator. Creates the
base_jni_headers target and updates the base target to depend on it and
actually use the sources that required it.
Adds //third_party/android_tools:cpu_features required by one of the
base files that also required jni.
Disable a bunch of third_party targets for Android builds.
BUG=359249
Review URL: https://codereview.chromium.org/237973002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@264695 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fixes a lot of minor mistakes (mostly missing/extra files and flags) for the Mac GN build.
I separated out some clang flags into a config for extra clang warnings. Several of the third party libraries needed to remove this.
Removes the use_nss flag and uses !use_openssl. This is a result of discussion with rsleevi.
Removes extra duplicate net build file from secondary tree.
ui/gesture_events seems to be getting compiled in GN with more strict warnings than in GYP. Rather than fix this, I fixed the warning in the gesture recognizer unit test. It was returning a const copy (the const is pointless when you're copying).
This also removes a bunch of old GYP integration stuff that was left in the GN build.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/239543013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@264626 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This does the net target. I started doing some more that are commented out at the bottom, and there are a few more after that do do. The deps of these targets started to build up to an unreasonable level and this should be a good checkpoint.
Fix grit rule.
Fix SSL dependent configs
Add TLD cleanup
Add gconf and gio targets for Linux.
Add sources filtering for ChromeOS, .rc, and .mm files. Remove built-in code that removes .rc and .mm files (this wasn't quite complete so causes problems).
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/236713002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263967 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fixes enough issues so that we can compile and link some libraries, but
it is not yet a working build.
Work remaining:
- base needs JNI support ('base_jni_headers', etc.)
- we need to figure out what should link and/or be APKs to run the tests
- we need to adjust GN to only build in the host config, not the target config.
R=brettw@chromium.org, cjhopman@chromium.org
TBR=jam
BUG=360936
Review URL: https://codereview.chromium.org/227673008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263440 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This also removes some patterns from the sources assignment filter, and adds scary comments not to make it bigger. The GYP version of this is out of control so I want to set a clear policy of what is included and not.
I removed X-related stuff from the filter (there are only about 50 files around the tree) and added manual rules for the affected files.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/235983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@263394 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes the GN build of Skia compile and adds it to the GN build.
Previously, the configuration of the GN Skia tried to match the confusing array
of skia targets. This new version dispenses with that and just adds all files
(except SSE ones) to one target. I'm not even sure if it's necessary to split
out the SSE ones, but it seems nice since that target will get more complicated
when we add Arm and MIPS support.
I audited the defines again and added some to the main build config that had
been added to the GYP build recently.
This improves some operator error messages that I found confusing when I had errors in my file.
BUG=
R=djsollen@google.com, scottmg@chromium.org
Review URL: https://codereview.chromium.org/214883005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds an error check when invoking templates which caused really confusing messages if the template invocation encountered an error (because we'd continue running).
Hooks up the provider for programatically defined variables in template invocations so those can be used.
Sets the current directory in a template invocation to be that of the invoking file.
No longer define the target-related programatic variables in an import. Using these in an import will give the directory relative to the import, which is probabyl not what you want.
Fix the Windows build by adding a missing library. Add a warning not to add more to the main list (this added .lib is pretty obscure).
BUG=
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/226223006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@262524 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
brettw@chromium.org
mvanouwerkerk@chromium.org
henrika@google.com
cjhopman@chromium.org
scottmg@chromium.org
fdegans@chromium.org
derat@chromium.org
hans@chromium.org
ckocagil@chromium.org
tfarina@chromium.org
dpranke@chromium.org
mithro@mithis.com
jam@chromium.org