48e8457906
The CL https://codereview.chromium.org/1771173002/ introduced a cycle in gyp files, which is not allowed on iOS: Cycle: ui/base/ui_base.gyp -> ui/base/ime/ui_base_ime.gyp -> ui/base/ui_base.gyp This cycle is not actually real on iOS, as it is under a OS!=iOS condition, It was detected because, when building the mac tools, gyp_chromium was invoked with OS=iOS. This OS configuration was internally discarded when actually building (because of the --ignore-environment flag that was passed), but was still triggering the check for circular gyp dependencies. TBR=thakis Review URL: https://codereview.chromium.org/1797283002 Cr-Original-Commit-Position: refs/heads/master@{#381248} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: a5430a08444415e4a7bd3cf15675136bf89eec31 |
||
---|---|---|
.. | ||
OWNERS | ||
chrome_ios.croc | ||
clean_env.py | ||
coverage.gypi | ||
mac_build.gypi |