6932ee9819
This has a bunch of minor advantages: 1. It's less code 2. It's a build step less per windows_manifest 3. /manifest:embed automatically sets 1 or 2 based on /dll, so clients of windows_manifest() clients no longer need to set type 4. rc.exe is no longer required for every single binary, which helps bootstrapping of cross-building some chrome/win binaries on non-win No intended behavior change. TBR=sergeyu,grt Bug: 495204 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I13cd9103829fa535997fa7a7e5ec009dbc1b8039 Reviewed-on: https://chromium-review.googlesource.com/585109 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489729} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 132e149a98b37ee78eaf86434dbe37f22fa40d4c |
||
---|---|---|
.. | ||
syzygy | ||
BUILD.gn | ||
as_invoker.manifest | ||
chrome_win.croc | ||
common_controls.manifest | ||
compatibility.manifest | ||
copy_cdb_to_output.py | ||
merge_pgc_files.py | ||
message_compiler.gni | ||
message_compiler.py | ||
reorder-imports.py | ||
require_administrator.manifest | ||
run_pgo_profiling_benchmarks.py | ||
use_ansi_codes.py |