This commit is contained in:
Bastien Abadie 2019-07-19 17:11:05 +02:00 коммит произвёл GitHub
Родитель ca1c554c4a
Коммит bd2d9eb930
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
9 изменённых файлов: 472 добавлений и 67 удалений

8
CODE_OF_CONDUCT.md Normal file
Просмотреть файл

@ -0,0 +1,8 @@
# Community Participation Guidelines
This repository is governed by Mozilla's code of conduct and etiquette guidelines.
For more details, please read the
[Mozilla Community Participation Guidelines](https://www.mozilla.org/about/governance/policies/participation/).
## How to Report
For more information on how to report violations of the Community Participation Guidelines, please read our '[How to Report](https://www.mozilla.org/about/governance/policies/participation/reporting/)' page.

6
CONTRIBUTING.md Normal file
Просмотреть файл

@ -0,0 +1,6 @@
## Contributing
Discussions happen in #static-analyzers on irc.mozilla.org.
1. [Issues marked as `good-first-bug`](https://github.com/mozilla/code-review/labels/good-first-bug) are self-contained enough that a contributor should be able to work on them.
2. Issues are considered not assigned, until there is a PR linked to them.

373
LICENSE Normal file
Просмотреть файл

@ -0,0 +1,373 @@
Mozilla Public License Version 2.0
==================================
1. Definitions
--------------
1.1. "Contributor"
means each individual or legal entity that creates, contributes to
the creation of, or owns Covered Software.
1.2. "Contributor Version"
means the combination of the Contributions of others (if any) used
by a Contributor and that particular Contributor's Contribution.
1.3. "Contribution"
means Covered Software of a particular Contributor.
1.4. "Covered Software"
means Source Code Form to which the initial Contributor has attached
the notice in Exhibit A, the Executable Form of such Source Code
Form, and Modifications of such Source Code Form, in each case
including portions thereof.
1.5. "Incompatible With Secondary Licenses"
means
(a) that the initial Contributor has attached the notice described
in Exhibit B to the Covered Software; or
(b) that the Covered Software was made available under the terms of
version 1.1 or earlier of the License, but not also under the
terms of a Secondary License.
1.6. "Executable Form"
means any form of the work other than Source Code Form.
1.7. "Larger Work"
means a work that combines Covered Software with other material, in
a separate file or files, that is not Covered Software.
1.8. "License"
means this document.
1.9. "Licensable"
means having the right to grant, to the maximum extent possible,
whether at the time of the initial grant or subsequently, any and
all of the rights conveyed by this License.
1.10. "Modifications"
means any of the following:
(a) any file in Source Code Form that results from an addition to,
deletion from, or modification of the contents of Covered
Software; or
(b) any new file in Source Code Form that contains any Covered
Software.
1.11. "Patent Claims" of a Contributor
means any patent claim(s), including without limitation, method,
process, and apparatus claims, in any patent Licensable by such
Contributor that would be infringed, but for the grant of the
License, by the making, using, selling, offering for sale, having
made, import, or transfer of either its Contributions or its
Contributor Version.
1.12. "Secondary License"
means either the GNU General Public License, Version 2.0, the GNU
Lesser General Public License, Version 2.1, the GNU Affero General
Public License, Version 3.0, or any later versions of those
licenses.
1.13. "Source Code Form"
means the form of the work preferred for making modifications.
1.14. "You" (or "Your")
means an individual or a legal entity exercising rights under this
License. For legal entities, "You" includes any entity that
controls, is controlled by, or is under common control with You. For
purposes of this definition, "control" means (a) the power, direct
or indirect, to cause the direction or management of such entity,
whether by contract or otherwise, or (b) ownership of more than
fifty percent (50%) of the outstanding shares or beneficial
ownership of such entity.
2. License Grants and Conditions
--------------------------------
2.1. Grants
Each Contributor hereby grants You a world-wide, royalty-free,
non-exclusive license:
(a) under intellectual property rights (other than patent or trademark)
Licensable by such Contributor to use, reproduce, make available,
modify, display, perform, distribute, and otherwise exploit its
Contributions, either on an unmodified basis, with Modifications, or
as part of a Larger Work; and
(b) under Patent Claims of such Contributor to make, use, sell, offer
for sale, have made, import, and otherwise transfer either its
Contributions or its Contributor Version.
2.2. Effective Date
The licenses granted in Section 2.1 with respect to any Contribution
become effective for each Contribution on the date the Contributor first
distributes such Contribution.
2.3. Limitations on Grant Scope
The licenses granted in this Section 2 are the only rights granted under
this License. No additional rights or licenses will be implied from the
distribution or licensing of Covered Software under this License.
Notwithstanding Section 2.1(b) above, no patent license is granted by a
Contributor:
(a) for any code that a Contributor has removed from Covered Software;
or
(b) for infringements caused by: (i) Your and any other third party's
modifications of Covered Software, or (ii) the combination of its
Contributions with other software (except as part of its Contributor
Version); or
(c) under Patent Claims infringed by Covered Software in the absence of
its Contributions.
This License does not grant any rights in the trademarks, service marks,
or logos of any Contributor (except as may be necessary to comply with
the notice requirements in Section 3.4).
2.4. Subsequent Licenses
No Contributor makes additional grants as a result of Your choice to
distribute the Covered Software under a subsequent version of this
License (see Section 10.2) or under the terms of a Secondary License (if
permitted under the terms of Section 3.3).
2.5. Representation
Each Contributor represents that the Contributor believes its
Contributions are its original creation(s) or it has sufficient rights
to grant the rights to its Contributions conveyed by this License.
2.6. Fair Use
This License is not intended to limit any rights You have under
applicable copyright doctrines of fair use, fair dealing, or other
equivalents.
2.7. Conditions
Sections 3.1, 3.2, 3.3, and 3.4 are conditions of the licenses granted
in Section 2.1.
3. Responsibilities
-------------------
3.1. Distribution of Source Form
All distribution of Covered Software in Source Code Form, including any
Modifications that You create or to which You contribute, must be under
the terms of this License. You must inform recipients that the Source
Code Form of the Covered Software is governed by the terms of this
License, and how they can obtain a copy of this License. You may not
attempt to alter or restrict the recipients' rights in the Source Code
Form.
3.2. Distribution of Executable Form
If You distribute Covered Software in Executable Form then:
(a) such Covered Software must also be made available in Source Code
Form, as described in Section 3.1, and You must inform recipients of
the Executable Form how they can obtain a copy of such Source Code
Form by reasonable means in a timely manner, at a charge no more
than the cost of distribution to the recipient; and
(b) You may distribute such Executable Form under the terms of this
License, or sublicense it under different terms, provided that the
license for the Executable Form does not attempt to limit or alter
the recipients' rights in the Source Code Form under this License.
3.3. Distribution of a Larger Work
You may create and distribute a Larger Work under terms of Your choice,
provided that You also comply with the requirements of this License for
the Covered Software. If the Larger Work is a combination of Covered
Software with a work governed by one or more Secondary Licenses, and the
Covered Software is not Incompatible With Secondary Licenses, this
License permits You to additionally distribute such Covered Software
under the terms of such Secondary License(s), so that the recipient of
the Larger Work may, at their option, further distribute the Covered
Software under the terms of either this License or such Secondary
License(s).
3.4. Notices
You may not remove or alter the substance of any license notices
(including copyright notices, patent notices, disclaimers of warranty,
or limitations of liability) contained within the Source Code Form of
the Covered Software, except that You may alter any license notices to
the extent required to remedy known factual inaccuracies.
3.5. Application of Additional Terms
You may choose to offer, and to charge a fee for, warranty, support,
indemnity or liability obligations to one or more recipients of Covered
Software. However, You may do so only on Your own behalf, and not on
behalf of any Contributor. You must make it absolutely clear that any
such warranty, support, indemnity, or liability obligation is offered by
You alone, and You hereby agree to indemnify every Contributor for any
liability incurred by such Contributor as a result of warranty, support,
indemnity or liability terms You offer. You may include additional
disclaimers of warranty and limitations of liability specific to any
jurisdiction.
4. Inability to Comply Due to Statute or Regulation
---------------------------------------------------
If it is impossible for You to comply with any of the terms of this
License with respect to some or all of the Covered Software due to
statute, judicial order, or regulation then You must: (a) comply with
the terms of this License to the maximum extent possible; and (b)
describe the limitations and the code they affect. Such description must
be placed in a text file included with all distributions of the Covered
Software under this License. Except to the extent prohibited by statute
or regulation, such description must be sufficiently detailed for a
recipient of ordinary skill to be able to understand it.
5. Termination
--------------
5.1. The rights granted under this License will terminate automatically
if You fail to comply with any of its terms. However, if You become
compliant, then the rights granted under this License from a particular
Contributor are reinstated (a) provisionally, unless and until such
Contributor explicitly and finally terminates Your grants, and (b) on an
ongoing basis, if such Contributor fails to notify You of the
non-compliance by some reasonable means prior to 60 days after You have
come back into compliance. Moreover, Your grants from a particular
Contributor are reinstated on an ongoing basis if such Contributor
notifies You of the non-compliance by some reasonable means, this is the
first time You have received notice of non-compliance with this License
from such Contributor, and You become compliant prior to 30 days after
Your receipt of the notice.
5.2. If You initiate litigation against any entity by asserting a patent
infringement claim (excluding declaratory judgment actions,
counter-claims, and cross-claims) alleging that a Contributor Version
directly or indirectly infringes any patent, then the rights granted to
You by any and all Contributors for the Covered Software under Section
2.1 of this License shall terminate.
5.3. In the event of termination under Sections 5.1 or 5.2 above, all
end user license agreements (excluding distributors and resellers) which
have been validly granted by You or Your distributors under this License
prior to termination shall survive termination.
************************************************************************
* *
* 6. Disclaimer of Warranty *
* ------------------------- *
* *
* Covered Software is provided under this License on an "as is" *
* basis, without warranty of any kind, either expressed, implied, or *
* statutory, including, without limitation, warranties that the *
* Covered Software is free of defects, merchantable, fit for a *
* particular purpose or non-infringing. The entire risk as to the *
* quality and performance of the Covered Software is with You. *
* Should any Covered Software prove defective in any respect, You *
* (not any Contributor) assume the cost of any necessary servicing, *
* repair, or correction. This disclaimer of warranty constitutes an *
* essential part of this License. No use of any Covered Software is *
* authorized under this License except under this disclaimer. *
* *
************************************************************************
************************************************************************
* *
* 7. Limitation of Liability *
* -------------------------- *
* *
* Under no circumstances and under no legal theory, whether tort *
* (including negligence), contract, or otherwise, shall any *
* Contributor, or anyone who distributes Covered Software as *
* permitted above, be liable to You for any direct, indirect, *
* special, incidental, or consequential damages of any character *
* including, without limitation, damages for lost profits, loss of *
* goodwill, work stoppage, computer failure or malfunction, or any *
* and all other commercial damages or losses, even if such party *
* shall have been informed of the possibility of such damages. This *
* limitation of liability shall not apply to liability for death or *
* personal injury resulting from such party's negligence to the *
* extent applicable law prohibits such limitation. Some *
* jurisdictions do not allow the exclusion or limitation of *
* incidental or consequential damages, so this exclusion and *
* limitation may not apply to You. *
* *
************************************************************************
8. Litigation
-------------
Any litigation relating to this License may be brought only in the
courts of a jurisdiction where the defendant maintains its principal
place of business and such litigation shall be governed by laws of that
jurisdiction, without reference to its conflict-of-law provisions.
Nothing in this Section shall prevent a party's ability to bring
cross-claims or counter-claims.
9. Miscellaneous
----------------
This License represents the complete agreement concerning the subject
matter hereof. If any provision of this License is held to be
unenforceable, such provision shall be reformed only to the extent
necessary to make it enforceable. Any law or regulation which provides
that the language of a contract shall be construed against the drafter
shall not be used to construe this License against a Contributor.
10. Versions of the License
---------------------------
10.1. New Versions
Mozilla Foundation is the license steward. Except as provided in Section
10.3, no one other than the license steward has the right to modify or
publish new versions of this License. Each version will be given a
distinguishing version number.
10.2. Effect of New Versions
You may distribute the Covered Software under the terms of the version
of the License under which You originally received the Covered Software,
or under the terms of any subsequent version published by the license
steward.
10.3. Modified Versions
If you create software not governed by this License, and you want to
create a new license for such software, you may create and use a
modified version of this License if you rename the license and remove
any references to the name of the license steward (except to note that
such modified license differs from this License).
10.4. Distributing Source Code Form that is Incompatible With Secondary
Licenses
If You choose to distribute Source Code Form that is Incompatible With
Secondary Licenses under the terms of this version of the License, the
notice described in Exhibit B of this License must be attached.
Exhibit A - Source Code Form License Notice
-------------------------------------------
This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/.
If it is not possible or desirable to put the notice in a particular
file, then You may include the notice in a location (such as a LICENSE
file in a relevant directory) where a recipient would be likely to look
for such a notice.
You may add additional accurate notices of copyright ownership.
Exhibit B - "Incompatible With Secondary Licenses" Notice
---------------------------------------------------------
This Source Code Form is "Incompatible With Secondary Licenses", as
defined by the Mozilla Public License, v. 2.0.

8
README.md Normal file
Просмотреть файл

@ -0,0 +1,8 @@
# Mozilla Code Review
This project has 2 parts:
* `bot` is a Python script running as a Taskcluster task, reporting issues found in analyzer tasks,
* `frontend` is an administration frontend (in Vue.js) displaying detailed information about current analyses.
The analyzer tasks are triggered by [pulselistener](https://github.com/mozilla/release-services/tree/master/src/pulselistener), from the release-services project.

Просмотреть файл

@ -1,26 +1,63 @@
Static Analysis Bot
===================
Developer setup
---------------
The code review bot is a Python 3 application, so it should be easy to bootstrap on your computer:
```
mkvirtualenv -p /usr/bin/python3 code-review
pip install -r requirements.txt -r requirements-dev.txt
pip install -e .
```
You should now be able to run linting and unit tests:
```
flake8
pytest
```
If those tests are OK, you can run the bot locally, by specifying a Taskcluster secret with your configuration, and a task reference to analyze.
```
export TRY_TASK_ID=XXX
export TRY_TASK_GROUP_ID=XXX
code-review-bot --taskcluster-secret=path/to/secret
```
Configuration
-------------
As every other services in `mozilla-releng/services`, the code review bot is configured through the [Taskcluster secrets service](https://tools.taskcluster.net/secrets)
The code review bot is configured through the [Taskcluster secrets service](https://tools.taskcluster.net/secrets)
The following configuration variables are currently supported:
* `APP_CHANNEL` **[required]** is provided by the common configuration (staging or production)
* `REPORTERS` **[required]** lists all the reporting tools to use when a code review is completed (details below)
* `ANALYZERS` **[required]** lists all the analysis tool to run on specified revisions. These tools will produce the reported issues.
* `PHABRICATOR` **[required]** holds the credentials to make API calls on Phabricator.
* `ZERO_COVERAGE_ENABLED` is a boolean value enabling or disabling the zero coverage warning report.
* `PAPERTRAIL_HOST` is the optional Papertrail host configuration, used for logging.
* `PAPERTRAIL_PORT` is the optional Papertrail port configuration, used for logging.
* `SENTRY_DSN` is the optional Sentry full url to report runtime errors.
* `MOZDEF` is the optional MozDef log destination.
The `REPORTERS` configuration is a list of dictionaries describing which reporting tool to use at the end of the patches code review.
Supported reporting tools are emails (for admins) and Phabricator.
Each reporter configuration must contain a `reporter` key with a unique name per tool. Each tool has its own configuration requirement.
Phabricator credentials
-----------------------
They are required, and must be set like this:
```
PHABRICATOR:
url: 'https://phabricator.services.mozilla.com/api/'
api_key: api-XXXX
```
Reporter: Mail
--------------
@ -39,32 +76,10 @@ Key `reporter` is `phabricator`
Configuration:
* `url` : The Phabricator api url
* `api_key` : The Phabricator account's api key
* `analyzers` : The analyzers that will be published on Phabricator. Possible values are: mozlint, clang-tidy, clang-format, coverity, infer, coverage.
This reporter will send detailed informations about every **publishable** issue.
Analyzer: Clang Tidy
--------------------
Key is `clang-tidy`
Detect code review issues on C/C++ code
Analyzer: Clang Format
--------------------
Key is `clang-format`
Detect linting issues on C/C++ code
Analyzer: MozLint
-----------------
Key is `mozlint`
Detect linting issues on Python and Javascript code
Example configuration
---------------------
@ -73,7 +88,11 @@ Example configuration
"common": {
"APP_CHANNEL": "staging",
"PAPERTRAIL_HOST": "XXXX.papertrail.net",
"PAPERTRAIL_PORT": 12345
"PAPERTRAIL_PORT": 12345,
"PHABRICATOR": {
"url": "https://dev.phabricator.mozilla.com",
"api_key": "deadbeef123456"
}
},
"code-review-bot": {
"REPORTERS": [
@ -86,14 +105,8 @@ Example configuration
},
{
"reporter": "phabricator",
"url": "https://dev.phabricator.mozilla.com",
"api_key": "deadbeef123456"
"analyzers": ["clang-tidy", "mozlint"]
}
],
"ANALYZERS": [
"clang-tidy",
"clang-format",
"mozlint"
]
}
}

Просмотреть файл

@ -1,26 +1,28 @@
aiohttp==3.5.4
asn1crypto==0.24.0
async-timeout==3.0.1
atomicwrites==1.3.0
attrs==19.1.0
cachetools==3.1.1
certifi==2019.3.9
cffi==1.12.3
chardet==3.0.4
-e git+git@github.com:mozilla/code-review.git@83fe33a0605e13233d509b774d58b4e102155b4d#egg=code_review_bot&subdirectory=bot
datadog==0.29.0
cryptography==2.7
datadog==0.29.3
decorator==4.4.0
entrypoints==0.3
flake8==3.7.7
flake8==3.7.8
flake8-isort==2.7.0
google-api-python-client==1.7.9
google-auth==1.6.3
google-auth-httplib2==0.0.3
httplib2==0.12.3
httplib2==0.13.0
icalendar==4.0.3
idna==2.8
idna-ssl==1.1.0
importlib-metadata==0.17
importlib-metadata==0.18
isort==4.3.20
libmozdata==0.1.56
libmozdata==0.1.57
Logbook==1.4.3
mccabe==0.6.1
mohawk==1.0.0
@ -35,23 +37,25 @@ py==1.8.0
pyasn1==0.4.5
pyasn1-modules==0.2.5
pycodestyle==2.5.0
pycparser==2.19
pyflakes==2.1.1
pyOpenSSL==19.0.0
pyparsing==2.4.0
pytest==4.6.2
pytest==5.0.1
python-dateutil==2.8.0
python-hglib==2.6.1
pytz==2019.1
PyYAML==5.1
PyYAML==5.1.1
requests==2.22.0
requests-futures==0.9.9
requests-futures==1.0.0
responses==0.10.6
rsa==4.0
six==1.12.0
slugid==2.0.0
structlog==19.1.0
taskcluster==7.0.1
taskcluster==14.3.1
taskcluster-urls==11.0.0
testfixtures==6.8.2
testfixtures==6.9.0
toml==0.10.0
typing-extensions==3.7.2
uritemplate==3.0.0

Просмотреть файл

@ -17,24 +17,7 @@ force_single_line = True
default_section=FIRSTPARTY
sections=FUTURE,STDLIB,THIRDPARTY,FIRSTPARTY,LOCALFOLDER
known_first_party =
backend_common
cli_common
code_coverage_bot
code_coverage_crawler
codecoverage_backend
mapper_api
please_cli
pulselistener
shipit_api
shipit_pipeline
shipit_signoff
shipit_taskcluster
code_review_bot
tokens_api
tooltool_api
treestatus_api
uplift_backend
uplift_bot
[mypy]
# Specify the target platform details in config, so your developers are

Просмотреть файл

@ -30,11 +30,10 @@ with open('VERSION') as f:
setuptools.setup(
name='code_review_bot',
version=VERSION,
description='Listens to bugzilla entries, executes'
'some code review and reports results.',
description='Reports issues found in Mozilla code review tasks',
author='Mozilla Release Management',
author_email='release-mgmt-analysis@mozilla.com',
url='https://shipit.mozilla-releng.net',
url='https://github.com/mozilla/code-review',
tests_require=read_requirements('requirements-dev.txt'),
install_requires=read_requirements('requirements.txt'),
packages=setuptools.find_packages(),

Просмотреть файл

@ -1,2 +1,13 @@
Static Analysis Frontend
========================
Code Review Frontend
====================
This is a simple Vue.JS administration frontend, the production instance is publicly available at https://static-analysis.moz.tools/
Developer setup
---------------
```
npm install
npm run build # to build once
npm run start # to start a dev server
```