Also clear out the memory used by the async logger when it's shut down.
This relies on the fact that enabling and disabling logging is performed
on the same thread, but I think this is a reasonnable thing to do. We
could assert it though.
Some systems offer OSS v4 but do not have BSD-only functions like
strlcpy, used in cubeb_oss.c. An example is Debian GNU/kFreeBSD, that
uses a FreeBSD kernel with GNU userspace utilities, like glibc.
With this patch cubeb will be able to build on these systems thanks to
the help of libbsd, that privides most libc functions that you would
expect on BSD.
These are minor cleanups that do not affect the behaviour of the script.
In particular, I removed most `DESTINATION` arguments from `install()`,
since they are automatically deduced based on the type of file to be
installed.
In #662 I also added doxygen_add_docs and gtest_discover_tests, but they
require CMake version 3.9 and 3.10 respectively, and I think that the
advantages they provide are not worth dropping support for older versions
Following
https://github.com/mozilla/cubeb/issues/658#issuecomment-955998734, the
speex library is now handled like a normal dependency: cubeb will link
against the system version if available, and fall back to the bundled
one if not.
I've also added a BUNDLE_SPEEX option, so that you can force the use of
the bundled library if needed (e.g. creating a standalone libcubeb on a
system where libspeex is available).
I also had to move the bundled library to a separate folder. As `src` is
always added as an include path, the headers in `src/speex` would
conflict with system headers. And it also clears the relationship
between cubeb and speex. I choose the "subprojects" name to follow the
Meson convention, since CMake does not have one. A bit OT, but if you're
curious you can see their rationale here:
https://mesonbuild.com/Subprojects.html#why-must-all-subprojects-be-inside-a-single-directory
Lastly, I added cubeb_log.cpp to the list of sources of test_resampler,
as I was getting linking errors when building with BUILD_SHARED_LIBS=true
Fixes#658
This is useful to users who can't recursively clone the repo or that
simply want to build the project from the downloadable tarball (like
Linux distributions, for example)
Users can now disable the lazy loading of libraries, and use classic
linkage instead.
Previously, cubeb would link with threads only if using some backends.
This caused linking issues when no backends were active, because cubeb
wasn't linked against pthread or similar, while the library is needed by
src/cubeb_log.cpp, as it uses std::thread.
#cleanup
* ossaudio (FreeBSD currently) backend
The ossaudio backend was rewritten from the sunaudio
backend.
* Fix leaking of mixer_fd in oss_enumerate_devices
* Both input/output can be detected at the same DSP
* Update on device detection during enumeration
* Remove spurious calls to SNDCTL_CARDINFO
* Fix string allocation detection in oss_enumerate_devices
* On FreeBSD, try to open and probe the device's capability in oss_enumerate_devices
* Rewrite oss_io_routine() to implement correctly for all stream directions
* Add preferred device detection for FreeBSD
* Emits stable devid from oss_enumerate_devices on FreeBSD
* Fix SNDCTL_DSP_GETI/OSPACE calls in oss_stream_init
* Use /dev/sndstat instead on FreeBSD for oss_enumerate_devices
* Unify both play and record nfr and take the minimum value between them
* Fix allocating both input/output buffers to input/output-only streams
* Fix clipping issue
* Fix misuse of input_device and output_device in oss_stream_init
* Fix builds on Illumos
* Code refactoring on oss_enumerate_devices
* Improve oss_io_routine for the case when the stream is in both direction
* Use fragsize instead of total buffer size for number of frames
* Probe OSS audio availability in cubeb_init when backend is not specified
* Fix scan-build10 report on src/cubeb_oss.c:285
* Add __DragonFly__ pp macro testing along-side __FreeBSD__
* Move oss_init in default_init[] table right below alsa to respect POLA
* Fix use-after-free of s->mutex in oss_stream_destroy
* Fix inconsistent indentation
* Remove blocks_written from cubeb_stream
* Add LL integer suffix to make 0x80000000 more clear
* Add parsing of /dev/sndstat for hw.snd.verbose > 0 in FreeBSD
* Do device setup in the order of channels, format and speed, according to developer/callorder.html of OSS v4.x API reference
* Add proper latency_frame support for oss_stream_init
* Mark close brackets and close braces NUL in oss_sndstat_line_parse
* Search close brackets and close braces from the end of line in oss_sndstat_line_parse
* Use 32 frames for each fragments in oss_calc_frag_params
* Drop unnecessary #include <sys/sysctl.h>
* Add support for cubeb_channel_layout
* Compilation and scan-build fixes:
* Fix warnings in oss_chn_from_cubeb
* Include cubeb_mixer.h to have cubeb_channel_layout_nb_channels
* Fix potential resource leakage in input_stream_layout->layout does not
match input_stream_params->channels. (The same for
output_stream_layout)
* Classify cubeb_stream_params::layout and cubeb_stream_params::channels
mismatch as CUBEB_ERROR_INVALID_PARAMETER
* AUDIODEVICE can now override /dev/dsp
AUDIODEVICE was chosen to match the sndio backend.
* Change environment variable AUDIODEVICE to AUDIO_DEVICE in oss backend
* Change the format of cubeb_device_info's friendly_name
This avoids name collision when setting media.cubeb.output_device in
about:config of Firefox. However, I think it makes more sense on
Firefox's side to use device_id instead.
* Fix warning of a missing %d in LOG() in oss_io_routine
* Do not enable OSS compilation when SOUND_VERSION < 0x040000
* Add mutex to serialize access to cubeb_strings in cubeb_oss's cubeb_context
* Change the calculation of fragsize/nfr to match stream latency, with 2 fragments available. By HPS
* Now reuse the same thread for audiostream
* Redo the duplex logic
* Restructure the use of buffers
* Fix problems dealing with draining
* Revert "Fix problems dealing with draining"
This reverts commit 30301ba101.
* Revert "Restructure the use of buffers"
This reverts commit 9823ca889c.
* Revert "Revert "Restructure the use of buffers""
This reverts commit 10dc869b85.
* Revert "Revert "Fix problems dealing with draining""
This reverts commit 9d19b10944.
* Make sure there are at least s->nfr available before calling data_cb
* Kill a signed/unsigned comparison
* Add The FreeBSD Foundation copyright line for recent commits
* Fix race condition when restarting a stream by HPS
Originally, when stopping a stream and immediately starting the stream
again, the start call might be lost.
* Do not signal the doorbell_cv again when a stream is already stopped
This is redundant.
* Revert "Do not signal the doorbell_cv again when a stream is already stopped"
This reverts commit fbdf753fc7.
* Make state changes look more similar to pulse backend
This also allows drained/short-input stream to be resumed without
stopping it first.
* Remove a spurious s->running = false
* Initial support. Device scanning and sanity checks work.
Playback and recording does not.
* stream_init fixes. Audio test now runs, though doesn't do anything.
* Set the prinfo type to the device type we'll later be limited to.
* Playback support.
Also implement stream_get_current_device and stream_device_destroy.
* AUDIO_SETINFO properly.
* Don't poll forever when recording.
Use the recommended number of latency_frames as our BUFSIZE.
* Fix typo.
* Don't allocate devid. Required for a sanity test.
* Fix some tests
* Initial attempt to support Solaris
* stdlib.h for calloc.
* undo local change
* Should probably be using "events" here, and the state change isn't
necessary now that it's done elsewhere.
* Avoid format truncation warning.
* more illumos fixes
* Performance improvements.
It seems polling for input is not a viable strategy.
* Protect volume and frames_written with a mutex.
* Protect running with a mutex.
* Add QUAD and QUAD_LFE layouts.
* Remove dual mono layout.
It makes no sense to have a case for those as the data structure
used (a bitmask) do not allow to represent this channel layout (a
channel can only be present once). As such it was a non-functional
layout
* Fix up cubeb_pulse compilation using C++ keyword.
* Remove the concept of preferred layout.
Channel layout is derived by the content being played. The concept of
preferred layout is meaningless. Either we have a layout defined, or
we don't. There's no in-between.
So we remove it.
* Remove CHANNEL_MONO concept.
* Add cubeb_sample_size convenience method.
* Rework cubeb_mixer.
This completely replace the existing remixer which had serious limitations:
1- Had no memory bound checks
2- Could only downmix 5.1 and 7.1 to stereo.
This mixer allows to convert from any sane layout to any other and work directly on interleaved samples.
This cubeb_mixer doesn't have an API compatible with the previous one.
This commit is non-fonctional, and was split for ease of review.
* Fix remixing on mac, windows and pulse backend.
* Make cubeb_mixer creation infallible.
Rather than ignore nonsensical layouts, we attempt to play it according to the stream channels count instead. The audio data will be played as-is, dropping the extra channels or inserting silence where needed.
* User proper sample size when calculating offsets.
Should the user data be of a different type to what the AudioUnit output is set to, we would have written outside the end of our allocated buffer.
* Fix input mixing and clarify frames vs samples terminology
* If a layout is unknown or invalid, always treat it as plain stereo or mono.
Add a test file for loopback tests and add to build script. This file is
currently configured to be Windows only in build scripts, as the WASAPI backend
is currently the only backend supporting the new loopback interface.
Add a test for duplex streams using the default output device and a loopback
from the same device.
Paul Adenot
Alexandre Bouvier
Matthew Gregan
Andrea Pappacoda
nyorain
khng300
Guillaume Besson
Jan Beich
nia
Chun-Min Chang
Alex Chronopoulos
orbea
Jean-Yves Avenard
Bryce Van Dyk
KO Myung-Hun
Sam Fuller
Dan Glastonbury
Dan Glastonbury
endrift
Matthew Sitton