FIX: remove primary emails from secondary_emails attr

lib/mozilla_iam/api/person.rb

@@ -28,7 +28,15 @@ module MozillaIAM
         def process_emails
           emails = @raw[:emails]
           if emails
-            emails.select { |x| x[:verified] && !x[:primary] }.map { |x| x[:value] }.uniq
+            primary = emails.select do |x|
+              x[:verified] &&
+              x[:primary]
+            end.map { |x| x[:value] }
+            emails.select do |x|
+              x[:verified] &&
+              !x[:primary] &&
+              primary.exclude?(x[:value])
+            end.map { |x| x[:value] }.uniq
           else
             []
           end

spec/components/mozilla_iam/api/person_spec.rb

@@ -90,6 +90,19 @@ describe MozillaIAM::API::Person do
           expect(profile.secondary_emails).to contain_exactly("second@example.com", "third@example.com")
         end
       end
+
+      context "with a primary email in profile as secondary" do
+        let(:profile) { described_class.new({ emails: [
+          { verified: true, value: "first@example.com", primary: true },
+          { verified: true, value: "first@example.com", primary: false },
+          { verified: true, value: "second@example.com", primary: false },
+          { verified: true, value: "third@example.com", primary: false },
+        ] }) }
+
+        it "doesn't return primary email in secondary emails" do
+          expect(profile.secondary_emails).to contain_exactly("second@example.com", "third@example.com")
+        end
+      end
     end
   end
 end