From 53939ac2747753feaca0e4c2b5efc8cef7cdbbfc Mon Sep 17 00:00:00 2001
From: Ian Bicking <ianb@colorstudy.com>
Date: Wed, 18 Jul 2018 15:16:46 -0500
Subject: [PATCH] Fix lint errors

---
 addon/capture-data.js    | 4 +++-
 addon/emailTemplates.jsx | 8 ++++----
 addon/popup.jsx          | 4 ++--
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/addon/capture-data.js b/addon/capture-data.js
index 9ee6c3f..f193cb4 100644
--- a/addon/capture-data.js
+++ b/addon/capture-data.js
@@ -1,3 +1,5 @@
+/* globals captureText, Readability */
+
 (function () {
   const SCREENSHOT_WIDTH = 350;
 
@@ -37,7 +39,7 @@
   async function onMessage(message) {
     if (message.type !== "getData") {
       console.warn("Unexpected message type:", message.type);
-      return;
+      return undefined;
     }
     browser.runtime.onMessage.removeListener(onMessage);
     let data = {
diff --git a/addon/emailTemplates.jsx b/addon/emailTemplates.jsx
index 9b86f15..399e3c9 100644
--- a/addon/emailTemplates.jsx
+++ b/addon/emailTemplates.jsx
@@ -65,12 +65,12 @@ this.emailTemplates = (function () {
 
   class JustLinks extends React.Component {
     render() {
-      let tabList = this.props.tabs.map(tab => {
+      let tabList = this.props.tabs.map((tab, index) => {
         let selection =  null;
         if (tab.selection) {
           selection = <Fragment>{selectionDisplay(tab.selection)} <br /><br /></Fragment>;
         }
-        return <Fragment>
+        return <Fragment key={index}>
           <a href={tab.url}>{tab.title}</a> <br />
           { selection }
         </Fragment>;
@@ -90,10 +90,10 @@ this.emailTemplates = (function () {
         }
         let readability = "no readability";
         if (tab.readability && tab.readability.content) {
-          let hr = index === this.props.tabs.length -1 ? null : <hr />;
+          let hr = index === this.props.tabs.length - 1 ? null : <hr />;
           readability = <Fragment><div dangerouslySetInnerHTML={{__html: tab.readability.content}} /> { hr }</Fragment>;
         }
-        return <Fragment>
+        return <Fragment key={index}>
           <a href={tab.url}>{tab.title}</a> <br />
           { selection }
           { readability }
diff --git a/addon/popup.jsx b/addon/popup.jsx
index 98bb39d..2830e8e 100644
--- a/addon/popup.jsx
+++ b/addon/popup.jsx
@@ -185,8 +185,8 @@ class TemplateItem extends React.Component {
     if (this.props.selected) {
       className += " selected";
     }
-    return <li className={className} onClick={this.selectTemplate.bind(this)} role="button">
-      {this.props.title}
+    return <li className={className}>
+      <button onClick={this.selectTemplate.bind(this)}>{this.props.title}</button>
     </li>;
   }