Граф коммитов

2613 Коммитов

Автор SHA1 Сообщение Дата
Jared Lockhart 9ab249afe4
fix #5967 chore(project): set shell in makefile (#5968)
Because

* The makefile depends on /bin/bash to run correctly
* That is not the default on all environments

This commit

* Explicitly sets SHELL = /bin/bash in the Makefile
2021-07-15 10:47:16 -07:00
Lauren Zugai 4457d316c3
chore(deps): Security 'trim' (#5964)
Because:
* Dependabot found that 'trim' has a security vulnerability

This commit:
* Updates the trim package to the recommended remediation version
2021-07-15 12:45:30 -04:00
Jody Heavener 3f6d84f8c5
fixes #5943 chore(project): add make command to pull in latest kinto docker image (#5962) 2021-07-15 13:33:57 -03:00
Jared Lockhart 4c0df6b262
fix #5946 chore(project): cache docker layers in dockerhub (#5948)
Because

* It would save time if we push the docker build layers from circleci to dockerhub to reuse locally

This commit

* Uses the new buildkit --cache-from flag to pull in build layers from dockerhub when applicable
* Builds all stages and pushes them with their layers to dockerhub on every merge to main
* Configures local builds to pull those layers from dockerhub
* Removes the build circle stage since each circle task will now be able to pull from dockerhub rather than the local circle docker cache
2021-07-15 11:37:09 -04:00
Jared Lockhart 71d8081230
chore(project): update contributing docs for dependabot (#5953)
Because

* We need to manually address security warnings created by dependabot
* We need to perform dependabot duty on both mozilla/experimenter and mozilla/experimenter-docs
* We can now automatically approve dependabot PRs

This commit

* Adds instructions to contributing.md for
  * Addressing security warnings
  * Addressing dependabot prs in both mozilla/experimenter and mozilla/experimenter-docs
  * Approving dependabot PRs automatically
2021-07-14 16:23:15 -04:00
Jared Lockhart 5cc00614ad
fix #5949 chore(project): add makefile command to approve dependabot prs (#5950)
Because

* Rather than approving each dependabot pr by hand, it'd be handy to just do them all at once with the github cli

This commit

* Adds a makefile command to approve all dependabot prs
2021-07-14 16:09:33 -03:00
Lauren Zugai 96bdeed3f1
fixes #5542 fix(nimbus): Allow .0001 population_percent to be valid in ReadyForReview serializer (#5945)
Because:
* 0.0001 is a valid value that users can save, but the "Ready for review" validation errors show this to be an error

This commit:
* Adds a custom population_percent validation method to check for a min value rather than rely on min_value
2021-07-14 12:02:52 -03:00
Jody Heavener 0f50ef4bba
fixes #5921 fix(nimbus): allow refetching after end experiment, disable buttons while waiting (#5939) 2021-07-13 16:25:18 -05:00
Jody Heavener 42ed93d761
fixes #5804 feat(project): standardize on date over datetime in nimbus date properties (#5836) 2021-07-13 15:31:05 -04:00
Jared Lockhart 3f2a49af58
fix #5739 feat(nimbus): trigger kinto update from publish status (#5935)
Because

* We want updates to live experiments to be triggered by users manually
* This only current live update is pausing an experiment
* In the future we will support updating other fields for live experiments

This commit

* Removes the automatically triggered pause update logic
* Refactors the live update kinto logic to be triggered by publish status the same way launch/end are
* Refactors the V5 API to look at published_dto to determine if enrollment is ended
* Updates the NimbusExperimentFactory to update published_dto after each live update
* Updates the kinto diagrams to include setting is_paused from the UI to make frontend integration clearer for the current end enrollment flow
2021-07-13 11:49:25 -04:00
Lauren Zugai 3784d96b67
fixes #5783 feat(nimbus): Add duration tooltip to Audience & Summary (#5938)
Because:
* Users were not sure if total duration included the enrollment period

This commit:
* Adds a tooltip displaying the same copy for "Experiment duration" on the Audience page and "Total duration" in SummaryTimeline
2021-07-13 10:17:13 -05:00
Jody Heavener 0940915e9b
fixes #5924 fix(nimbus): remove usage of act in component test to address flakiness (#5937) 2021-07-12 14:19:00 -03:00
Jared Lockhart 47352d88fc
fix #5919 chore(nimbus): add isolation group/bucketrange readonly admin (#5920)
Because

* It will also be helpful to inspect all isolation groups and their assigned bucket ranges, not just per experiment
* They should be read only

This commit

* Adds isolation group directly to the admin as read only
2021-07-12 13:45:10 -03:00
Jared Lockhart 1718da251a
fix #5922 chore(nimbus): use cache instead of global for loading app version (#5923)
Because

* Using a global to store the version so we don't load the file twice can lead to non deterministic stateful behaviour such as state persisting across tests
* Manifests in the Django test runner but not the pytest runner, but I suspect that might be related to the thread scheduling and memory locality

This commit

* Uses the builtin python functools cache which explicitly allows clearing between tests
2021-07-12 11:43:56 -03:00
dependabot[bot] 3b5b9a40a5
chore(deps): bump @sentry/browser from 6.8.0 to 6.9.0 in /app (#5932) 2021-07-12 14:19:57 +00:00
dependabot[bot] 8a7185849a
chore(deps-dev): bump @storybook/addon-actions in /app (#5931) 2021-07-12 14:17:48 +00:00
Marina Samuel 537c3fc42f
Fix #5886: fix(visualization) - only load primary or secondary outcomes when overall results are available. (#5925) 2021-07-09 14:44:08 -04:00
Jody Heavener 4c4c4375a9
fixes #5744 feat(nimbus): update change approval message, add copy-able link (#5910) 2021-07-09 13:32:52 -03:00
Jared Lockhart de0259e549
fix #5917 chore(nimbus): display bucketing/isolation groups in admin as read only (#5918)
Because

* It will be helpful in some cases to inspect the assigned bucket ranges/isolation groups for an experiment
* They should never be edited by hand since they are always automatically assigned by the bucket allocator

This commit

* Displays the bucket and isolation groups assigned to an experiment in the nimbus experiment admin as read only
2021-07-09 06:25:01 -07:00
Tif Tran fe081b8fd4
fixes #5915 fix(reporting): Change event pair mapping to use event classes (#5916)
Because:

 * It was using strings before

This commit:

 * replaces event pairing from strings to event classes values
2021-07-08 14:23:45 -07:00
Jody Heavener c8e50164e4
fixes #5390 feat(legacy): add cta to encourage usage of nimbus (#5911) 2021-07-08 15:27:46 -03:00
Jared Lockhart 97934b9f74
fix #5912 chore(project): suppress errors from docker compose commands (#5913)
Because

* As Docker continues to update and change the semantics of its commands, we must update the Makefile to adapt
* Attempting to kill or remove already stopped/removed container entries can exit non-zero

This commit

* Suppresses non zero exit codes from kill/rm docker compose commands
2021-07-08 08:33:10 -07:00
dependabot[bot] ace92a7776
chore(deps-dev): bump @types/node from 14.14.41 to 14.17.5 in /app (#5909) 2021-07-07 21:08:27 +00:00
dependabot[bot] 5d12c12215
chore(deps-dev): bump eslint-plugin-flowtype from 5.7.2 to 5.8.0 in /app (#5908) 2021-07-07 21:05:53 +00:00
Jared Lockhart 90cad46ad1
Revert "fix #5894 chore(project): auto merge dependabot prs (#5906)" (#5907)
Because

* I wanted to try a github auto merge action
* It didn't work
* Mozilla org allows only github or mozilla authored actions so we'd have to write our own

This commit

* Reverts adding the auto merge action
2021-07-07 16:41:16 -04:00
Kate Hudson d46008c5ae
fixes #5451 feat(nimbus): All review_urls should link to simple-review (#5846)
Because

* The simple-review UI is now on prod

This commit

* Changes the review_url to always return simple-review RS URL
2021-07-07 16:38:30 -04:00
dependabot[bot] 852b46ebb0
chore(deps-dev): bump @storybook/react from 6.2.9 to 6.3.3 in /app (#5905) 2021-07-07 20:37:22 +00:00
dependabot[bot] da3a6b1218
chore(deps-dev): bump eslint-config-prettier from 7.0.0 to 7.2.0 in /app (#5904) 2021-07-07 20:37:13 +00:00
dependabot[bot] d78d444964
chore(deps-dev): bump prettier-plugin-organize-imports in /app (#5903) 2021-07-07 20:37:11 +00:00
dependabot[bot] 52cdf0d989
chore(deps): bump bootstrap from 4.5.2 to 4.6.0 in /app (#5900) 2021-07-07 20:36:58 +00:00
Jared Lockhart c147d6a89c
fix #5894 chore(project): auto merge dependabot prs (#5906)
Because

* It would be handy if dependabot prs that pass CI could be automatically merged

This commit

* Adds a github action that will automatically approve dependabot prs
2021-07-07 14:20:07 -06:00
dependabot[bot] b97cf1fc4d
chore(deps-dev): bump @storybook/preset-create-react-app in /app (#5902) 2021-07-07 19:54:58 +00:00
dependabot[bot] d1cdb87359
chore(deps-dev): bump @storybook/addon-links from 6.2.9 to 6.3.3 in /app (#5901) 2021-07-07 19:36:17 +00:00
dependabot[bot] 3ef8627aec
chore(deps): bump @sentry/browser from 6.7.2 to 6.8.0 in /app (#5899) 2021-07-07 19:36:06 +00:00
Jared Lockhart 44050876e9
fix #5797 chore(nimbus): switch dependabot to minor only (#5895)
Because

* We want to reduce the number of dependabot prs while staying as up to date as possible
* We want to reduce the number of dependabot prs that break and require manual intervention

This commit

* Ignores patch/major updates, allowing only minor updates
2021-07-07 15:51:33 -03:00
Jared Lockhart 7633ae178e
chore(project): silence new django model warning (#5891)
Because

* Django added a new warning about auto generated primary key fields
* It's noisy and unnecessary

This commit

* Silences the warning
2021-07-07 12:40:27 -04:00
dependabot[bot] 1f98d10d7a
chore(deps-dev): bump @typescript-eslint/eslint-plugin from 2.34.0 to 4.28.2 in /app (#5874)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jody Heavener <j.heavener@gmail.com>
2021-07-07 13:00:23 -03:00
Jared Lockhart 32b83147ec
chore(nimbus): decrease integration test celery timing (#5887)
Because

* We should be able to decrease the celery task timeouts so speed up the integration tests

This commit

* Turns them down to 5s to update and 10s to timeout
2021-07-06 15:57:34 -04:00
dependabot[bot] 669f5fc134
chore(deps): bump prettier from 2.3.1 to 2.3.2 in /app (#5884) 2021-07-06 19:05:38 +00:00
dependabot[bot] 5f5d071ad8
chore(deps): bump datadog from 0.41.0 to 0.42.0 in /app (#5882) 2021-07-06 18:54:17 +00:00
Tif Tran ff41840df6
fixes #5810 fix(legacy): Remove firefox version 100 (#5880)
This commit:

* removes firefox version 100

Because:

* Normandy isn't able to handle ff 100 using standard version filter object
2021-07-06 11:20:00 -07:00
dependabot[bot] 310d8cb2df
chore(deps): bump asgiref from 3.3.4 to 3.4.1 in /app (#5873) 2021-07-06 16:56:25 +00:00
dependabot[bot] 4233ac7230
chore(deps-dev): bump eslint from 7.28.0 to 7.30.0 in /app (#5885) 2021-07-06 16:41:21 +00:00
dependabot[bot] 809f6f211b
chore(deps): bump packaging from 20.9 to 21.0 in /app (#5883) 2021-07-06 16:32:04 +00:00
dependabot[bot] bdc0e313ba
chore(deps): bump django from 3.2.4 to 3.2.5 in /app (#5881) 2021-07-06 16:04:56 +00:00
dependabot[bot] 96df7f4f8f
chore(deps): bump @types/react-select from 4.0.15 to 4.0.16 in /app (#5841) 2021-07-06 16:04:48 +00:00
dependabot[bot] c73b5430d1
chore(deps): bump @testing-library/dom from 7.31.2 to 8.1.0 in /app (#5877) 2021-07-06 16:04:35 +00:00
dependabot[bot] 7902bc927b
chore(deps): bump packaging from 20.9 to 21.0 in /app/tests (#5869) 2021-07-06 16:04:06 +00:00
dependabot[bot] 91bdca7de4
chore(deps): bump celery from 5.1.1 to 5.1.2 in /app (#5856) 2021-07-06 15:23:55 +00:00
dependabot[bot] ed20192533
chore(deps): bump urllib3 from 1.26.5 to 1.26.6 in /app/tests (#5854) 2021-07-06 14:59:59 +00:00