* NETWORK_SITE_URL env var removal from files
* NETWORK_SITE_URL back for integration tests
* Testing if env vars in settings
* Tests on bg-main and main js files
* Replace network_site variable for heroku_app
* Get current domain
* Sync CSP up with FRU directives
* retain spacing in case that's needed
* CSP_SCRIPT_SRC got bumped a line
* stray comma
* Update default SECURE_CROSS_ORIGIN_OPENER_POLICY on settings.py
* Enforce https protocol in CSP directives
* Set default back to safest option, matching dev pattern for defaults
* set Cross-Origin-Opener-Policy to same-origin-allow-popups to resolve Paypal popup issue
* updated a bunch of configs
* linting
---------
Co-authored-by: Daniel Miranda <manieldiranda@gmail.com>
* Run npm audit fix
* Bump node to version 20
* Update package-lock to node 20
* Bump visual regression testing node version
---------
Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>
* Fix test base classes
* Fix copy product page test
* Fix test names
* Run python tests in parallel by default
* Run CI tests in parallel
* Remove dead code
* Rename test and lint
* New newsletter signup module work (part 1) (#11353)
* new newsletter signup module work (part 1: creating "atom" components, "molecule" components, and "blog-body-signup.jsx")
* Create a HOC component to handle form validation logic (#11373)
* Created a HOC component to handle form validation logic
* [Blog] Add newsletter signup snippet block (#11421)
* Add BlogSignup model
* BlogSignupFactory
* Add SnippetChooserBlockFactory
* Newsletter signup block factories
* Add newsletter signup block to blog page
* Streamfield provider for blog newsletter block
* Test newsletter signup blocks
* Add newsletter block to blog page
* Fix linting
* Adjust blog signup rich text description
* Newsletter submission logic (#11398)
* added form submission logic to HOC
* added inline note for error handling todo
* code cleanup
* connect frontend with backend
* add GA/GTM tracking
* Playwright tests for the new newsletter signup module (#11476)
* Add Playwright tests for the blog body newsletter module
* Set NETWORK_SITE_URL in front end test configs to localhost and BASKET_URL to basket-dev & revert some changes
* replaced signup button text
* Update heading.jsx so the default heading is h3 with h3 styling
---------
Co-authored-by: Jhonatan Lopes <jhonatan.dapontelopes@gmail.com>
* DonateHelpPage model, factory, and tests
* formatting
* html formatting
* template for notice section is done
* added "show_notice" flag
* Added newline at the end of help_page_notice.html
* feedback from PR
* formatting
* saving progress, page is now working with body but need to update scss still
* feedback from PR
* added height/width attributes to image for linter
* feedback from PR
* updated scss, factory, and template
* backend work done
* added new notice block instead so we can update template individually
* backend done, unless we want to make image optional
* updated help page to use new notice block instead of imagetextmini
* updated migrations
* linting
* formatting
* fixed typo
* updated to use StructBlockValidationError
* updated tests
* smal front end update
* linting notice-block.scss
* updated migrations, having trouble with NoticeBlockFactory
* block factories & tests, updating of factory file structure
* updated import
* updated some factory file paths to account for changes
* import formatting
* removed forgotten factory.py file
* first pass, have the form rendering with default styling
* formatting
* updated spacing
* updated linting file to ignore errors from FA code
* added donate and donate help page to visual regression tests
* removed donate pages from visual regression tests since they live on a different subdomain (donate.localhost)
* very first pass, borrowing existing file to get feedback from design
* fixed bug where submit button would not render for last two dropdown options
* fixed error where text box wouldnt show up for 2nd to last option
* feedback from pr (add comments, update env.default and other small changes)
* added newline at end of formassembly_body.html
* updated chevron in the select dropdown
* feedback from stakeholders (increased textarea height and implemented word wrapping on select element for chrome)
* fixed dropdown styling/wrap issue
* updated scss, ready for review
* Formatting of scss file
* updated app.json and continuous-integration.yml to include updated sp directives
* Feedback from PR (height to min-height)
* localized form and updated instructions
* updated formassembly JS
* formatting
* localized submit button value
* updated revision number
* feedback from PR (wrapping dropdown options in trans blocks)
None of those commands run any tests. They run linters. The changed name
of the command expresses that.
I am keeping the confusing `test` command as an alias for `lint`.
When ever we are making PRs between branches, it is still a good idea to
make sure that the code passes CI. Otherwise this can lead to bad merges
that break other branches.
This is particularly important when we work on longer projects with
integration branches (e.g. PNI).
The CI step is allowed to fail. This means you won't really be notified
if there is an issue in the type checking. You would need to check the
logs of the CI step manually to see it.
If we decide in the future that we want to make typing necessary, we
could remove the allowed failure. We would probably want to spend
sometime before to fix the existing 300+ issues. Maybe simply by
ignoring them.
Rob DiVincenzo
Diego López
Mavis Ou
Jhonatan Lopes
Daniel Miranda
Tyler Denton
Tibor Leupold
Simon Fessehaye
Tibor Leupold