Handle multiple RealPhone in delete_phone_data

phones/management/commands/delete_phone_data.py

@@ -60,7 +60,7 @@ class _PhoneData:
     """Helper class to hold phone data for a user."""
 
     fxa: SocialAccount
-    real_phone: RealPhone | None = None
+    real_phones: list[RealPhone] | None = None
     relay_phone: RelayNumber | None = None
     inbound_contact_count: int = 0
 
@@ -69,9 +69,8 @@ class _PhoneData:
         """Initialize from an FxA ID."""
         fxa = SocialAccount.objects.get(provider="fxa", uid=fxa_id)
 
-        try:
-            real_phone = RealPhone.objects.get(user=fxa.user)
-        except RealPhone.DoesNotExist:
+        real_phones = RealPhone.objects.filter(user=fxa.user)
+        if not real_phones.exists():
             return cls(fxa=fxa)
 
         try:
@@ -80,11 +79,11 @@ class _PhoneData:
                 relay_number=relay_phone
             ).count()
         except RelayNumber.DoesNotExist:
-            return cls(fxa=fxa, real_phone=real_phone)
+            return cls(fxa=fxa, real_phones=list(real_phones))
 
         return cls(
             fxa=fxa,
-            real_phone=real_phone,
+            real_phones=list(real_phones),
             relay_phone=relay_phone,
             inbound_contact_count=inbound_contact_count,
         )
@@ -92,13 +91,13 @@ class _PhoneData:
     @property
     def has_data(self) -> bool:
         """Return True if the user has phone data to reset."""
-        return self.real_phone is not None
+        return self.real_phones is not None and len(self.real_phones) > 0
 
     @property
-    def real_number(self) -> str | None:
+    def real_numbers(self) -> list[str] | None:
         """Get user's real phone number, if it exists."""
-        if self.real_phone:
-            return self.real_phone.number
+        if self.real_phones:
+            return [real_phone.number for real_phone in self.real_phones]
         return None
 
     @property
@@ -114,8 +113,13 @@ class _PhoneData:
             f"* FxA ID: {self.fxa.uid}\n"
             f"* User ID: {self.fxa.user_id}\n"
             f"* Email: {self.fxa.user.email}\n"
-            f"* Real Phone: {self.real_number or '<NO REAL PHONE>'}\n"
-            f"* Relay Phone: {self.relay_number or '<NO RELAY PHONE>'}\n"
+            f"* Real Phone: "
+            + (
+                "\n* Real Phone: ".join(number for number in self.real_numbers)
+                if self.real_numbers
+                else "<NO REAL PHONE>"
+            )
+            + f"\n* Relay Phone: {self.relay_number or '<NO RELAY PHONE>'}\n"
             f"* Inbound Contacts: {self.inbound_contact_count}\n"
         )
 
@@ -125,5 +129,5 @@ class _PhoneData:
             if self.inbound_contact_count:
                 InboundContact.objects.filter(relay_number=self.relay_phone).delete()
             self.relay_phone.delete()
-        if self.real_phone:
-            self.real_phone.delete()
+        for real_phone in self.real_phones or []:
+            real_phone.delete()

phones/tests/mgmt_delete_phone_data_tests.py

@@ -159,6 +159,55 @@ Deleted user's phone data.
     assert not RealPhone.objects.filter(user=phone_user).exists()
 
 
+@pytest.mark.django_db
+def test_two_real_phones() -> None:
+    # Add user
+    now = datetime.now(tz=UTC)
+    phone_user = make_phone_test_user()
+    phone_user.profile.date_subscribed = now - timedelta(days=15)
+    phone_user.profile.save()
+
+    # Add unconfirmed real phone
+    baker.make(
+        RealPhone,
+        user=phone_user,
+        number="+12005550122",
+        verified=False,
+    )
+
+    # Add confirmed real phone
+    baker.make(
+        RealPhone,
+        user=phone_user,
+        number="+12005550123",
+        verification_sent_date=now - timedelta(days=14),
+        verified=True,
+    )
+
+    stdout = StringIO()
+    assert (fxa := phone_user.profile.fxa)
+    call_command(THE_COMMAND, fxa.uid, "--force", stdout=stdout)
+
+    expected_stdout = f"""\
+Found a matching user:
+
+* FxA ID: {phone_user.profile.fxa.uid}
+* User ID: {phone_user.id}
+* Email: phone_user@example.com
+* Real Phone: +12005550122
+* Real Phone: +12005550123
+* Relay Phone: <NO RELAY PHONE>
+* Inbound Contacts: 0
+
+Deleted user's phone data.
+"""
+    assert stdout.getvalue() == expected_stdout
+
+    phone_user.refresh_from_db()
+    assert phone_user.profile.has_phone
+    assert not RealPhone.objects.filter(user=phone_user).exists()
+
+
 def test_no_real_phone(phone_user: User) -> None:
     """Nothing is done if a user doesn't have a real phone setup."""
     RelayNumber.objects.filter(user=phone_user).delete()