Added in 445cf30609, this code was a
fallback to handle a change in how the content server generates the
flow id. Now that the content server change has stuck in prod, we can
remove the fallback.
https://github.com/mozilla/fxa-auth-server/pull/2420
r=shane-tomlinson
The code in test/local/ip_profiling.js was pretty confusing. There was a
bunch of mocking code at the top level, which duplicated the mocking
code inside makeRoutes. Then some of the test bodies were mocking things
a third time.
This changeset attempts to tidy all that up a bit. In doing so, it also
replaces the home-baked mock log object that was being used with a prefab
from test/mocks.js. This fixes#2383.
https://github.com/mozilla/fxa-auth-server/pull/2398
r=vbudhram
Fixesmozilla/fxa-amplitude-send#60.
Amplitude's view of devices is skewed by the randomly-generated
device_id that we're using until cross-project device_ids are
implemented. And the sync_device_count property is skewed to a
lesser degree by apparent session-related problems that seem to
force some users to sign in repeatedly on a single device.
To mitigate those problems, this change adds three new properties
that indicate the number of devices that were active in a given
time period: sync_active_devices_day, sync_active_devices_week and
sync_active_devices_month. In this case, a "month" is 30 days.
https://github.com/mozilla/fxa-auth-server/pull/2372
r=vbudhram
Previously we could accept URLs with unescaped special characters
such as newlines or unicode, which means we were depending on other
layers of the code to handle them correctly. This change makes the
requestor responsible for properly escaping any special characters
in their URLs before passing them in to us.
Fixesmozilla/fxa-amplitude-send#58.
The user-agent parser was originally written with synthesized device
names in mind, so it didn't always return the full version string for
browsers and operating systems. Since then, we started using the same
code for our event data, meaning that we're getting an incomplete
picture of the browser/os that our users are on.
This change tweaks the user-agent code so that it returns full version
info, and tweaks the code for synthesizing device names so that it
remains consistent with its old behaviour.
Phil Booth
Shane Tomlinson
Ryan Kelly
Omkar Yadav
Vijay Budhram
Vlad Filippov
Deepti
Edouard Oger
Ryan Kelly
Jon Buckley