chore(lint): clean up eslint deprecated rules

Fixes #2599
Fixes #2600
Fixes #2602
Clean up deprecated rules in the .eslintrc files

.eslintrc

@@ -14,8 +14,9 @@
     "dot-notation": 0,
     "eol-last": 2,
     "eqeqeq": [2, "allow-null"],
-    "global-strict": [0, "never"],
+    "global-strict": 0,
     "handle-callback-err": 0,
+    "indent": [2, 2],
     "key-spacing": 0,
     "new-cap": 0,
     "no-cond-assign": [2, "except-parens"],
@@ -35,12 +36,12 @@
     "no-undef": 2,
     "no-underscore-dangle": 0,
     "no-unused-vars": [2, {"vars": "all", "args": "none"}],
-    "no-use-before-define": true,
+    "no-use-before-define": [2, "nofunc"],
     "no-with": 2,
     "quotes": [2, "single", "avoid-escape"],
     "semi": [2, "always"],
     "space-unary-ops": 0,
-    "strict": 2,
+    "strict": [2, "global"],
     "valid-typeof": 1,
     "wrap-iife": 0,
     "yoda": 0

app/.eslintrc

@@ -5,10 +5,10 @@
     "jquery": true,
     "node": false
   },
+  "globals": {
+    "router": false
+  },
   "rules": {
-    "globals": {
-      "router": false
-    },
     "no-bitwise": 2,
     "no-caller": 2,
     "no-console": 0,

app/scripts/require_config.js

@@ -1,6 +1,7 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+'use strict';
 
 require.config({
   baseUrl: '/scripts',

tests/server/helpers/init-logging.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var mozlog = require('mozlog');
 var config = require('../../../server/lib/configuration');