e55dc57275
fix(test): Disable SMS sending tests on production environments. ( #5185 ) r=@jbuck, @philbooth
...
Production environments send SMS. We can't have that happening.
2017-06-30 00:20:42 +01:00
8f1ddd1411
refactor(client): Fix "context" data setting w/ mixins ( #5174 ) r=@philbooth
...
What is the problem?
When rendering a template, or translating a string, a view's `context()` function returns an object.
This paradigm makes it almost impossible for `context` to be overridden easily in mixins.
How does this fix the problem?
First, rename `context` to `updateContext`. Instead of having `updateContext` return an object,
pass in a Backbone model that each `updateContext` method can update. Mixins can override
`updateContext` and set the data on the passed in model.
2017-06-29 22:34:23 +01:00
de067d3ad2
feat(node): upgrade to Node 6 ( #5173 ) r=@shane-tomlinson
...
This is awesome!
2017-06-29 00:56:46 +01:00
a0e0164257
Release v1.90.0
2017-06-28 09:26:36 -07:00
d12ce201ff
fix(sign-in): Put registration links on left/top ( #5123 ) r=@shane-tomlinson
...
Put registration links on left OR top (responsive) based on feedback that some
users struggle to find the registration links.
2017-06-22 13:04:11 +01:00
e91864a634
feat(sms): Re-add "Use a distinct phone number for every SMS test." ( #5150 )
...
This is mostly a revert of d342fab2e6fixes #5136
2017-06-22 11:40:52 +01:00
d6d416fc56
fix(cwts): Remove the leftover CWTS styles. ( #5166 ) r=vladikoff
...
.extra-links-choose-what-to-sync is no longer needed, removing.
2017-06-21 12:41:44 -04:00
33677076ea
fix(CWTS): removed desktop-only caveat ( #5165 ) r=vladikoff
...
Add-ons, preferences, and soon addresses and credit cards will not be in parity on Android. I don't think this point in the process is the right time to mention it. Few care, and those that do won't be noticing here.
2017-06-21 12:33:48 -04:00
ccbfa6c7b7
refactor(broker): Clean up the fx-sync-channel broker. ( #5163 ) r=vladikoff
...
This does nothing but shift bits around so that related
concepts (*_LOGIN_FIELDS) are placed together.
Extracted from #5158
2017-06-21 11:02:23 -04:00
f546f09da8
refactor(test): Update some sync_* functional tests to use selectors.js ( #5164 ) r=vladikoff
...
This is an extraction from #5158 with the aim of making
that PR simpler to review. Now that we have a common
selectors definition, it makes sense updates much simpler.
2017-06-21 11:01:59 -04:00
cd013d24e7
refactor(build): Replace babel-preset-2015-nostrict with babel-preset-2015 ( #5161 ) r=vladikoff
...
babel-preset-2015 is maintained by the babel team, the -nostrict variant
is not. I used the -nostrict variant because it doesn't try to wrap
all of our modules in an AMD wrapper, but I didn't know it is
possible to supply the "modules: false" option to the plugin
to have the same effect.
2017-06-20 13:23:09 -04:00
d7c576f701
feat(metrics): emit flow events for newsletter subscription
...
https://github.com/mozilla/fxa-content-server/pull/5160
r=shane-tomlinson
2017-06-20 12:04:17 +01:00
99534a18f0
chore(logging): add remote address chain to fxa content server ( #5155 ) r=vladikoff
2017-06-19 11:34:59 -04:00
645b49381b
feat(oauth): support PKCE oauth parameters ( #5126 ) r=shane-tomlinson
2017-06-18 20:52:19 -04:00
f0502acc25
fix(styles): add hover state to primary buttons ( #5157 ) r=vladikoff
2017-06-18 19:52:06 -04:00
1852bbfaad
chore(nvm): nvmrc file for easier nvm usage ( #5156 ) r=vladikoff
2017-06-18 19:47:09 -04:00
7c6ca0e729
chore(tests): add new server test dependency on morgan ( #5154 ) r=vladikoff
2017-06-16 06:59:58 -04:00
15b8e8264a
fix(config): remove non-existing config files before attempting to load ( #5153 ) r=vladikoff
2017-06-15 21:54:05 -04:00
6ab32e57f8
fix(tests): switch from bash to sh in teamcity tests ( #5152 ) r=vladikoff
2017-06-15 20:52:36 -04:00
a23d5eb9b9
fix(logging): fix request logging ( #5142 ) r=vladikoff
...
Fixes #5111
2017-06-15 17:54:42 -04:00
c9f4a944ae
refactor(experiments): remove old config file ( #5148 ) r=@shane-tomlinson
2017-06-15 21:53:21 +01:00
d3a5f4d15f
feat(experiments): Internalize experiment rules. ( #4902 ) r=vladikoff
...
Remove able. All grouping rules have been imported
to app/scripts/lib/experiments/grouping-rules.
Documentation has been added on how to create a new
grouping rule, look at
app/scripts/lib/experiments/grouping-rules/README.md
fixes #4893
2017-06-15 14:31:42 -04:00
0246dbd34c
fix(tests): add a script to be run to check resource deployment ( #5147 ) r=vladikoff
2017-06-15 14:27:27 -04:00
01a2aebe26
fix(tests): add a test to confirm that DNS hooking works ( #5145 ) r=vladikoff
2017-06-15 14:08:21 -04:00
058e1f1b94
feat(test): Store screencaps at https://screencap.co.uk . ( #5132 ) r=vladikoff
2017-06-15 12:31:23 -04:00
3cca54ebee
feat(brokers): Add brokers for `mob_android_v1` and `mob_ios_v1` ( #5084 ) r=@philbooth
...
When the user verifies their email, a `fxaccounts:verified` message is sent over the WebChannel.
fixes #5029
2017-06-15 13:47:43 +01:00
a3799be8ce
fix(tests): make npm-install-deps reusable ( #5146 ) r=vladikoff
2017-06-14 22:57:49 -04:00
5a9db37c75
fix(strings): update strings in confirm and unblock r=vladikoff
...
Rewrote copy to omit the term "better" as users interpreted it as an optional step.
2017-06-14 18:55:29 -04:00
aba3a1549d
refactor(broker): Extract `finishOAuthFlowIfOriginalTab` to share between methods. ( #5141 ) r=@philbooth
...
This is extracted from #5090 with the intent to make that easier to review.
2017-06-14 16:35:14 +01:00
d1ebbfbb7b
fix(tests): provide a way to pre-flight check entrained resources ( #5131 ) r=vladikoff
2017-06-13 17:04:23 -04:00
5be33ef091
feat(settings): Reorder settings so display name is below account picture ( #5139 ), r=@vbudhram
2017-06-13 14:02:25 -04:00
d8231ff88d
Merge pull request #5138 from mozilla/i5035
...
fix(strings): update "Why Sync multiple devices?"
2017-06-13 13:10:16 -04:00
366563be89
fix(deps): update some prod dependencies ( #5137 )
2017-06-13 13:05:05 -04:00
f4d138cc6e
fix(strings): update "Why Sync multiple devices?"
...
Fixes #5035
2017-06-13 12:21:54 -04:00
5735b07777
feat(emails): Update verification email sent string ( #5135 ) r=vladikoff,shane-tomlinson
2017-06-13 10:44:24 -04:00
28bef76aca
Release v1.89.0
2017-06-13 10:18:26 -04:00
d342fab2e6
revert(sms): Use a distinct phone number for every SMS test. ( #5133 )
...
This reverts commit 6ea77cd892
2017-06-12 17:48:13 +01:00
6ea77cd892
fix(sms): Use a distinct phone number for every SMS test. ( #5128 ) r=@philbooth
...
testPhoneNumber and testPhoneNumberCountry are no longer needed.
2017-06-12 13:55:48 +01:00
841e1cf692
feat(emails): add tests for unblock and sign in confirmation ( #5125 )
...
Fixes #5054
2017-06-08 22:54:49 -04:00
5b6bf66a3a
Merge pull request #5127 from mozilla/disable-sms-send-tests
...
fix(test): Remove the testPhoneNumber default to fix tests.
2017-06-07 16:03:51 -07:00
18721e763d
fix(test): Remove the testPhoneNumber default to fix tests.
...
Tests that send an SMS look for the existence
of testPhoneNumber before sending. Disable these
tests until we have a better plan.
2017-06-07 23:28:46 +01:00
b8d7e567e4
feat(metrics): Add a `flow.signup.link.signin` flow event. ( #5116 ) r=@philbooth
...
This required a larger change than I had hoped. The external-links-mixin
was capturing the click and then calling `event.stopImmediatePropagation()`
on the event, meaning the click handler in the flow-events-mixin was
never called. :/
fixes #4680
fixes #5115
2017-06-07 17:51:12 +01:00
25b4c302cb
feat(sms): Add support for the SMS signinCode ( #5092 ) r=@vbudhram, @philbooth
...
To enable signinCodes to be sent, add the `signinCode=true` query parameter.
fixes #5060
2017-06-07 15:00:18 +01:00
dd656b52c4
Merge branch 'train-88'
2017-06-01 22:11:59 +01:00
5af74d9834
Release v1.88.1
2017-06-01 22:10:43 +01:00
c20bc4c020
feat(CAD): Make it easier to find `.smsStatus` errors in the logs. ( #5121 ) r=@philbooth
...
Add an `.smsStatus` suffix to the error context, which is included
in messages sent to DataDog, e.g.,:
error.verify-email.smsStatus.auth.999
issue #5109
2017-06-01 22:07:47 +01:00
d4c0343c74
fix(WebChannel): Fix the startup hang if the UA errors fetching fxaccounts:fxa_status ( #5117 ) r=@philbooth, @vbudhram
...
If the browser responds to an fxaccounts:fxa_status message with a `No Such Webchannel`
error, that means the UA either does not support the channel name, or is not set up
to communicate with this FxA server. In either case, FxA and the UA cannot communicate
using WebChannels.
If this happens, log the error and set the `fxaStatus` broker capability to `false`.
This will cause the session to use state stored in localStorage rather than the
state stored by the browser.
fixes #5114
2017-06-01 21:50:43 +01:00
b639e0a028
revert(sms): Re-add the "Maybe later" link. ( #5119 ) r=@vbudhram
...
This reverts commit 1c71687b34fixes #5117
2017-06-01 15:54:05 +01:00
8c55d183b5
feat(CAD): Log clicks on app store links into flow metrics. ( #5113 ) r=@philbooth
...
New flow events:
* flow.sms.link.app-store.(android|ios)
* flow.sms.sent.link.app-store.(android|ios)
* flow.reset-password-confirmed.link.app-store.(android|ios)
* flow.reset-password-verified.link.app-store.(android|ios)
* flow.secondary-email-verified.link.app-store.(android|ios)
* flow.signin-confirmed.link.app-store.(android|ios)
* flow.signin-verified.link.app-store.(android|ios)
* flow.signup-confirmed.link.app-store.(android|ios)
* flow.signup-verified.link.app-store.(android|ios)
fixes #5112
2017-06-01 14:38:24 +01:00
a338756e8d
fix(sms): Handle errors to /sms/status ( #5110 ) r=@philbooth
...
Before this fix, if a call to /sms/status failed,
signup confirmation would appear to fail with an
"Unexpected error".
Instead of failing, log and drop errors to /sms/status.
fixes #5109
2017-06-01 10:57:06 +01:00
Shane Tomlinson
Sean McArthur
vladikoff
Ryan Feeley
Phil Booth
Udara Weerasinghege
John Morrison
Vijay Budhram