a68d872d7b
Merge pull request #505 from mozilla/set_client_language
...
update fxa-client and add accept-language header based on browser language
@zaach - I rebased and added a couple of tests using the sinon spy. Looks good to me!
r+
2014-02-12 11:23:58 +00:00
e4fc85a983
restrict access to templates
2014-02-12 02:43:12 -08:00
9aef25eb6f
Update the fxa-client tests to check for lang
2014-02-12 10:26:46 +00:00
1a7dbf40a8
update fxa-client and add accept-language header based on browser language
2014-02-12 10:17:08 +00:00
346a66e1da
Merge pull request #508 from mozilla/issue-507-graphic-touch-up
...
updated intro graphics
easiest review ever. r+
2014-02-12 10:13:00 +00:00
bda8e863c5
Move email templates into content server and create a route to serve them - fixes #475
2014-02-11 20:26:06 -08:00
50eef95853
Merge pull request #512 from chilts/small-dev-help-in-readme
...
Add dev note related to config
2014-02-11 18:23:01 -08:00
793cec0675
Merge pull request #506 from mozilla/issue-460-service
...
Ensure the `service` and `redirectTo` URL search parameters make it to the fxa-js-client.
2014-02-11 17:54:36 -08:00
e881ea0c91
Add dev note related to config
2014-02-12 10:41:12 +13:00
d0541bc867
retighten up the linting rules
2014-02-11 11:48:00 -08:00
823e596049
updated intro graphics
2014-02-11 13:33:06 -05:00
48a3006988
Ensure the `service` and `redirectTo` URL search parameters make it to the fxa-js-client.
...
* Pick `service` and `redirectTo` out of the URL search parameters on startup, add it to Session.
* Add sinon.js to ensure the fxa-js-client recieves the `service` parameter when expected.
* Update the views to get `service` from Session instead of the URL.
* Add two new test suites, complete_sign_up and reset_password_complete.
* Check whether service and redirectTo make it to the complete screens.
* Check whether the expected backend calls are made when expected.
* Hook up the real translator in the tests so string interpolation can be tested.
NOTE: I updated bower to use a specific version of sinon because the official sinon.js package in bower is not set up to correctly handle amd installs and does not give spy functionality.
2014-02-11 15:04:59 +00:00
66de7e2c4d
Merge pull request #503 from pdehaan/issue-500
...
rename image, delete unused image
Looks good to me, tested using a local python server and the images still show. I'm happy.
r+
2014-02-11 10:37:29 +00:00
7c4e5059d8
Merge pull request #504 from pdehaan/issue-474
...
adding /server/ to Grunt jshint task
@pdehaan - https://www.youtube.com/watch?v=PgpDN-bARwc
r+ - Aside frommy one comment about having subdir specific jshint files, looks great! tests all pass, I'm happy.
2014-02-11 10:30:02 +00:00
e4542cafbc
Merge pull request #479 from mozilla/issue-401-resend-all-the-time
...
Fix the confirmation emails being sent on every click in the confirmation form.
2014-02-10 18:08:50 -08:00
6aacc92757
adding /server/ to Grunt jshint task
2014-02-10 14:19:38 -08:00
a3331cbd7c
rename image, delete unused image
2014-02-10 14:08:59 -08:00
7c6c29bca3
Merge pull request #499 from mozilla/issue-495-intro-manage-ui
...
added fixes to intro and manage, legal pages, and responsive views
2014-02-10 11:56:53 -05:00
67be94417d
added fixes to intro and manage, legal pages, and responsive views
2014-02-10 11:36:05 -05:00
828a15dd33
Fix the confirmation emails being sent on every click in the confirmation form.
...
fixes #401
2014-02-10 15:22:35 +00:00
4b2b55fd1d
Merge pull request #464 from mozilla/issue-252-tooltips
...
tooltips and generic form validation
2014-02-07 13:43:58 -08:00
1274f8f7c5
Add helpers.js with requiresFocus, use that in form.js when checking for focus.
2014-02-07 21:19:06 +00:00
f3cf8a98e3
fix the show button border to handle the keyboard accessibility updates
2014-02-07 21:08:08 +00:00
62f45f8802
tweaked tooltip spacing to avoid overlap
2014-02-07 21:05:37 +00:00
322105e0e2
Add red outlines to form elements when invalid.
...
* Remove the outline as soon as the user changes the value of the field.
fixes #435
2014-02-07 21:03:48 +00:00
c165b1afb4
Generic form validation, support for tooltips above and below the input elemnts & cleanup.
...
* Add tooltip/tooltip-below classes to tooltip containers.
* Add generic form validation in form.js with the ability for descendent views to override using strategy methods.
* MOAR TESTS!
2014-02-07 21:02:44 +00:00
cede5ece0e
Let's get us some tooltips!
...
* Create a new "base" View - FormView - useful for doing form validation.
* A FormView must provide three functions - isFormValid, showValidationErrors and submitForm.
* When a form element is invalid, it's containing .form-row recieves a title which is displayed as a tooltip.
* Change all Views that use forms to be a FormView
* Add a ton of tests.
fixes #252
2014-02-07 20:56:06 +00:00
b4f62b5cb1
Merge pull request #480 from mozilla/issue-436-tos-pp-back
...
Only show the back button in the tos/pp agreements if the user can go ba...
2014-02-07 11:57:19 -08:00
a80d6658f6
Merge pull request #481 from mozilla/issue-437-scroll-tos-pp
...
Scroll to the top of the tos/pp pages after render
2014-02-07 11:10:56 -08:00
f68d33c0aa
Merge pull request #491 from mozilla/issue-489-failing-tests
...
Fix the failing tests.
2014-02-07 11:09:41 -08:00
1fb4c692e3
Simplify by moving the window.scrollTo into router.js->showView
2014-02-07 17:22:37 +00:00
5612b6f40b
Scroll to the top of the tos/pp pages after render
...
fixes #437
2014-02-07 17:14:06 +00:00
4becf7d4b7
Fix the failing tests.
...
* Focus can only be checked for if the window is currently in focus.
* .error is used by mocha to indicate errors. Namespace all checks for .error to the view.
* Up time timeout for mocha to 5seconds and the intern to 120seconds.
* Add a unit test for signing in with a non-existent user (see https://github.com/mozilla/fxa-js-client/issues/74 )
fixes #489
2014-02-07 17:05:04 +00:00
cf200283f5
Merge pull request #490 from mozilla/issue-489-update-js-client
...
use the newest fxa-js-client which fixes the problem with calling signIn with a non-existent user
2014-02-07 17:02:52 +00:00
b80f6aa4c8
use the newest fxa-js-client which fixes the problem with calling signIn with a non-existent user
2014-02-07 16:51:46 +00:00
fa2c93e1b5
Merge pull request #477 from mozilla/issue-459-ring-around-coppa
...
Remove the focus ring around the COPPA year.
2014-02-06 14:40:56 -08:00
c64d6d775b
Merge pull request #476 from mozilla/issues-382-414-457-password-smoothness
...
Make the password fields more usable.
2014-02-06 14:39:19 -08:00
5af1ef8bc7
Merge pull request #482 from pdehaan/readmetweak
...
Update readme, bring server back online
2014-02-06 10:59:07 -08:00
60cbb09aab
Update readme, bring server back online
2014-02-06 10:57:19 -08:00
b54c108d9c
Add the missing aria-controls target
...
* in change_password.mustache and delete_account.mustache
2014-02-06 17:49:26 +00:00
0b273034f6
Only show the back button in the tos/pp agreements if the user can go back.
...
fixes #436
2014-02-06 15:43:55 +00:00
f7e52f50ab
Remove the focus ring around the COPPA year.
...
fixes #459
2014-02-06 13:23:12 +00:00
1ee5e1c8f0
Keyboard accessible password show buttons!
...
fixes #414
2014-02-06 12:56:29 +00:00
f027164183
Only show the "must be at least 8 characters" text on the /signup page when the user focuses the password element.
...
The help text for change-password and complete-reset-password are always displayed because there are two password inputs.
fixes #382
2014-02-06 12:56:29 +00:00
f56793a679
Re-focus the password field after clicking the show button.
...
fixes #457
2014-02-06 12:56:29 +00:00
f24f5a33a2
Merge pull request #472 from pdehaan/issue-379
...
removing the password length notice on the sign_in page
r++! I did this in another PR, yours got here first.
Thanks @pdehaan!
2014-02-06 06:59:43 +00:00
a91eba3000
removing the password length notice on the sign_in page
2014-02-05 13:13:43 -08:00
9dcea38c09
Merge pull request #469 from vladikoff/jsclient-0.1.10
...
Updates fxa-js-client to 0.1.10
tests all passing, thanks @vladikoff!
r+
2014-02-05 10:17:26 +00:00
72ec5aa4bd
Merge pull request #470 from pdehaan/colormebadd
...
cleaning up the colors. Fixes #468
thanks for the colab effort @pdehaan and @johngruen!
r+
2014-02-05 10:15:09 +00:00
48b968f48e
Merge pull request #466 from pdehaan/button-cursor
...
Adding hand pointer cursor to the enabled button states. Fixes #465
works beautifully, thanks @pdehaan!
r+
2014-02-05 10:11:14 +00:00
Shane Tomlinson
Zachary Carter
Zach Carter
Andrew Chilton
Peter deHaan
johngruen
Nick Chapman
Peter deHaan